Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/curl/config.m4 ext/curl/config.w32 ext/curl/curl.dsp ext/curl/interface.c ext/curl/package.xml ext/curl/php_curl.h ext/curl/share.c
Doh ! For once it's not the ZTS which broke :p I reverted the commit until I come up with a clean solution for both ZTS and non-ZTS Thanks On 24 November 2011 01:45, Antony Dovgal t...@daylessday.org wrote: On 11/24/2011 02:20 AM, Pierrick Charron wrote: pierrick Wed, 23 Nov 2011 22:20:28 + Revision: http://svn.php.net/viewvc?view=revisionrevision=319729 Log: Implemented FR #55540, added functions curl_share_init(), curl_share_setopt() and curl_share_close(). This patch breaks non-ZTS build of trunk: /local/qa/HEAD_non-ZTS/ext/curl/php_curl.h:157:2: error: expected specifier-qualifier-list before ‘MUTEX_T’ /local/qa/HEAD_non-ZTS/ext/curl/interface.c: In function ‘_php_curl_setopt’: /local/qa/HEAD_non-ZTS/ext/curl/interface.c:2449:8: warning: ‘return’ with no value, in function returning non-void make: *** [ext/curl/interface.lo] Error 1 -- Wbr, Antony Dovgal --- http://pinba.org - realtime profiling for PHP -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/curl/config.m4 ext/curl/config.w32 ext/curl/curl.dsp ext/curl/interface.c ext/curl/package.xml ext/curl/php_curl.h ext/curl/share.c
hi Pierrick! Don't forget the UPGRADING guide :) Cheers, On Wed, Nov 23, 2011 at 11:20 PM, Pierrick Charron pierr...@php.net wrote: pierrick Wed, 23 Nov 2011 22:20:28 + Revision: http://svn.php.net/viewvc?view=revisionrevision=319729 Log: Implemented FR #55540, added functions curl_share_init(), curl_share_setopt() and curl_share_close(). Bug: https://bugs.php.net/55540 (Assigned) no curl_share? nice... Changed paths: U php/php-src/trunk/NEWS U php/php-src/trunk/ext/curl/config.m4 U php/php-src/trunk/ext/curl/config.w32 U php/php-src/trunk/ext/curl/curl.dsp U php/php-src/trunk/ext/curl/interface.c U php/php-src/trunk/ext/curl/package.xml U php/php-src/trunk/ext/curl/php_curl.h A php/php-src/trunk/ext/curl/share.c -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/curl/config.m4 ext/curl/config.w32 ext/curl/curl.dsp ext/curl/interface.c ext/curl/package.xml ext/curl/php_curl.h ext/curl/share.c
I will. I'm still working on few things on the curl ext and once it will be done i'll take some time to document everything :) Pierrick On 23 November 2011 18:30, Pierre Joye pierre@gmail.com wrote: hi Pierrick! Don't forget the UPGRADING guide :) Cheers, On Wed, Nov 23, 2011 at 11:20 PM, Pierrick Charron pierr...@php.net wrote: pierrick Wed, 23 Nov 2011 22:20:28 + Revision: http://svn.php.net/viewvc?view=revisionrevision=319729 Log: Implemented FR #55540, added functions curl_share_init(), curl_share_setopt() and curl_share_close(). Bug: https://bugs.php.net/55540 (Assigned) no curl_share? nice... Changed paths: U php/php-src/trunk/NEWS U php/php-src/trunk/ext/curl/config.m4 U php/php-src/trunk/ext/curl/config.w32 U php/php-src/trunk/ext/curl/curl.dsp U php/php-src/trunk/ext/curl/interface.c U php/php-src/trunk/ext/curl/package.xml U php/php-src/trunk/ext/curl/php_curl.h A php/php-src/trunk/ext/curl/share.c -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/curl/config.m4 ext/curl/config.w32 ext/curl/curl.dsp ext/curl/interface.c ext/curl/package.xml ext/curl/php_curl.h ext/curl/share.c
On 11/24/2011 02:20 AM, Pierrick Charron wrote: pierrick Wed, 23 Nov 2011 22:20:28 + Revision: http://svn.php.net/viewvc?view=revisionrevision=319729 Log: Implemented FR #55540, added functions curl_share_init(), curl_share_setopt() and curl_share_close(). This patch breaks non-ZTS build of trunk: /local/qa/HEAD_non-ZTS/ext/curl/php_curl.h:157:2: error: expected specifier-qualifier-list before ‘MUTEX_T’ /local/qa/HEAD_non-ZTS/ext/curl/interface.c: In function ‘_php_curl_setopt’: /local/qa/HEAD_non-ZTS/ext/curl/interface.c:2449:8: warning: ‘return’ with no value, in function returning non-void make: *** [ext/curl/interface.lo] Error 1 -- Wbr, Antony Dovgal --- http://pinba.org - realtime profiling for PHP -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS UPGRADING ext/xsl/php_xsl.c ext/xsl/php_xsl.h ext/xsl/xsl_fe.h ext/xsl/xsltprocessor.c
On Mon, Jul 11, 2011 at 13:16, Christian Stocker chr...@php.net wrote:
chregu Mon, 11 Jul 2011 11:16:22 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=313131
Log:
Added XsltProcessor::setSecurityPrefs($options) and getSecurityPrefs()
to define forbidden operations within XSLT stylesheets, default is not to
enable any write operations from XSLT anymore. Bug #54446
Any reason not to merge it to 5.4?
+ if (zend_parse_parameters_ex(ZEND_PARSE_PARAMS_QUIET,
ZEND_NUM_ARGS() TSRMLS_CC, l, securityPrefs) == SUCCESS) {
[..]
+ } else {
+ WRONG_PARAM_COUNT;
+ }
Thats a freaky way of doing if (zend_parse_parameter(...) == FAILURE)
{ return; } ...
and won't produce as good errormsg.
+ php_error_docref(NULL TSRMLS_CC, E_WARNING, Can't set
libxslt
security properties);
Can be printed out up to 5 times in a row.. shouldn't it say which
property it was trying to set? And if one of these calls fail, won't
they all fail?
-Hannes
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS UPGRADING ext/xsl/php_xsl.c ext/xsl/php_xsl.h ext/xsl/xsl_fe.h ext/xsl/xsltprocessor.c
On 11.07.11 13:29, Hannes Magnusson wrote:
On Mon, Jul 11, 2011 at 13:16, Christian Stocker chr...@php.net wrote:
chregu Mon, 11 Jul 2011 11:16:22 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=313131
Log:
Added XsltProcessor::setSecurityPrefs($options) and getSecurityPrefs()
to define forbidden operations within XSLT stylesheets, default is not to
enable any write operations from XSLT anymore. Bug #54446
Any reason not to merge it to 5.4?
Sure, didn't realise that it was already branched.
+ if (zend_parse_parameters_ex(ZEND_PARSE_PARAMS_QUIET,
ZEND_NUM_ARGS() TSRMLS_CC, l, securityPrefs) == SUCCESS) {
[..]
+ } else {
+ WRONG_PARAM_COUNT;
+ }
Thats a freaky way of doing if (zend_parse_parameter(...) == FAILURE)
{ return; } ...
and won't produce as good errormsg.
copypaste ;) I'll fix it.
+ php_error_docref(NULL TSRMLS_CC, E_WARNING, Can't set
libxslt
security properties);
Can be printed out up to 5 times in a row.. shouldn't it say which
property it was trying to set? And if one of these calls fail, won't
they all fail?
yes, not sure how it can fail at all, but again, I'll try to come up
with a better solution.
Thanks for the feedback, much appreciated
chregu
-Hannes
--
Liip AG // Feldstrasse 133 // CH-8004 Zurich
Tel +41 43 500 39 81 // Mobile +41 76 561 88 60
www.liip.ch // blog.liip.ch // GnuPG 0x0748D5FE
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS UPGRADING ext/xsl/php_xsl.c ext/xsl/php_xsl.h ext/xsl/xsl_fe.h ext/xsl/xsltprocessor.c
Hi
I fixed all the things mentioned by Hanned, but my C and PHP-src skills
are a little bit rusty, so could anyone have a quick look at my latest
patch and check if that's ok/better?
https://gist.github.com/7cc9a6263401cd87367f
(if you prefer the whole file, it's here
https://gist.github.com/55d957fc3265699b7d17 )
thanks
chregu
On 11.07.11 13:29, Hannes Magnusson wrote:
On Mon, Jul 11, 2011 at 13:16, Christian Stocker chr...@php.net wrote:
chregu Mon, 11 Jul 2011 11:16:22 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=313131
Log:
Added XsltProcessor::setSecurityPrefs($options) and getSecurityPrefs()
to define forbidden operations within XSLT stylesheets, default is not to
enable any write operations from XSLT anymore. Bug #54446
Any reason not to merge it to 5.4?
+ if (zend_parse_parameters_ex(ZEND_PARSE_PARAMS_QUIET,
ZEND_NUM_ARGS() TSRMLS_CC, l, securityPrefs) == SUCCESS) {
[..]
+ } else {
+ WRONG_PARAM_COUNT;
+ }
Thats a freaky way of doing if (zend_parse_parameter(...) == FAILURE)
{ return; } ...
and won't produce as good errormsg.
+ php_error_docref(NULL TSRMLS_CC, E_WARNING, Can't set
libxslt
security properties);
Can be printed out up to 5 times in a row.. shouldn't it say which
property it was trying to set? And if one of these calls fail, won't
they all fail?
-Hannes
--
Liip AG // Feldstrasse 133 // CH-8004 Zurich
Tel +41 43 500 39 81 // Mobile +41 76 561 88 60
www.liip.ch // blog.liip.ch // GnuPG 0x0748D5FE
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/standard/basic_functions.c ext/standard/head.c ext/standard/head.h
On Mon, Aug 9, 2010 at 15:10, Kalle Sommer Nielsen ka...@php.net wrote: kalle Mon, 09 Aug 2010 13:10:32 + Revision: http://svn.php.net/viewvc?view=revisionrevision=302033 Log: Implemented FR #52555 (Ability to get HTTP response code) - Patch by Paul Dragoonis Errr. You don't think this will create some confusion with $http_response_headers ? $http_response_headers are the headers PHP just retrieved but http_response_code() is what PHP is about to send out ? -Hannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/spl/spl_iterators.c ext/spl/spl_iterators.h ext/spl/tests/CallbackFilterIteratorTest-002.phpt ext/spl/tests/CallbackFilterIteratorTest.phpt ext/spl/test
hi Arnaud,
Please add a note in the UPGRADING guide.
Thanks,
On Sun, Mar 27, 2011 at 10:13 PM, Arnaud Le Blanc lbarn...@php.net wrote:
lbarnaud Sun, 27 Mar 2011 20:13:27 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=309749
Log:
Added CallbackFilterIterator and RecursiveCallbackFilterIterator classes
[DOC] This is a concrete FilterIterator which takes a callback as
constructor parameter, and uses this callback for filtering. This allows
to use FilterIterator without extending it.
CallbackFilterIterator Example:
$it = new ArrayIterator(range(1,100));
$it = new CallbackFilterIterator($it, function($value) {
return $value % 2;
});
foreach($it as $value) // ...
RecursiveCallbackFilterIterator Example:
$it = new RecursiveDirectoryIterator(/);
$it = new RecursiveCallbackFilterIterator($it, function($file, $k, $it) {
return $it-hasChildren() || $file-getSize() 1024;
});
foreach(new RecursiveIteratorIterator($it) as $file) // ...
The callback takes the current value, the current key and the inner
iterator as parameters.
Changed paths:
U php/php-src/trunk/NEWS
U php/php-src/trunk/ext/spl/spl_iterators.c
U php/php-src/trunk/ext/spl/spl_iterators.h
A php/php-src/trunk/ext/spl/tests/CallbackFilterIteratorTest-002.phpt
A php/php-src/trunk/ext/spl/tests/CallbackFilterIteratorTest.phpt
A
php/php-src/trunk/ext/spl/tests/RecursiveCallbackFilterIteratorTest.phpt
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
RE: [PHP-CVS] svn: /php/php-src/trunk/ NEWS
While you're about it, how about being a little less ppositive about the pposition of multibyte suppport? Cheers! Mike -- Mike Ford, Electronic Information Developer, Libraries and Learning Innovation, Leeds Metropolitan University, C507 City Campus, Woodhouse Lane, LEEDS, LS1 3HE, United Kingdom Email: m.f...@leedsmet.ac.uk Tel: +44 113 812 4730 -Original Message- From: Sebastian Bergmann [mailto:sebast...@php.net] Sent: 06 March 2011 21:48 To: php-cvs@lists.php.net Subject: [PHP-CVS] svn: /php/php-src/trunk/ NEWS sebastianSun, 06 Mar 2011 21:47:46 + Revision: http://svn.php.net/viewvc?view=revisionrevision=308980 Log: Fix speling. Changed paths: U php/php-src/trunk/NEWS Modified: php/php-src/trunk/NEWS === --- php/php-src/trunk/NEWS2011-03-06 19:31:23 UTC (rev 308979) +++ php/php-src/trunk/NEWS2011-03-06 21:47:46 UTC (rev 308980) @@ -31,7 +31,7 @@ a property into a warning. (Scott) - General improvements: - . Added multibyte suppport by default. Previosly php had to be compiled + . Added multibyte suppport by default. Previously php had to be compiled with --enable-zend-multibyte. Now it can be enabled or disabled throug zend.multibyte directive in php.ini (Dmitry) . Removed compile time dependency from ext/mbstring (Dmitry) To view the terms under which this email is distributed, please go to http://disclaimer.leedsmet.ac.uk/email.htm
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS UPGRADING ext/pdo_mysql/mysql_driver.c ext/pdo_mysql/php_pdo_mysql_int.h
On 01/07/2011 03:39 PM, Kalle Sommer Nielsen wrote:
kalleFri, 07 Jan 2011 14:39:56 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=307224
Log:
Implemented FR #47802, support for character sets in DSN strings for PDO_MYSQL
Bug: http://bugs.php.net/47802 (Open) PDO_MYSQL doesn't use the charset
parameter
Changed paths:
U php/php-src/trunk/NEWS
U php/php-src/trunk/UPGRADING
U php/php-src/trunk/ext/pdo_mysql/mysql_driver.c
U php/php-src/trunk/ext/pdo_mysql/php_pdo_mysql_int.h
Modified: php/php-src/trunk/NEWS
===
--- php/php-src/trunk/NEWS2011-01-07 14:22:30 UTC (rev 307223)
+++ php/php-src/trunk/NEWS2011-01-07 14:39:56 UTC (rev 307224)
@@ -170,6 +170,10 @@
. Added nextRowset support.
. Fixed bug #50755 (PDO DBLIB Fails with OOM).
+- Improved PDO MySQL:
+ . Implemented FR #47802 (Support for setting character sets in DSN
strings).
+(Kalle)
+
- Improved Reflection extension: (Johannes)
. Added ReflectionExtension::isTemporary() and
ReflectionExtension::isPersistent() methods.
Modified: php/php-src/trunk/UPGRADING
===
--- php/php-src/trunk/UPGRADING 2011-01-07 14:22:30 UTC (rev 307223)
+++ php/php-src/trunk/UPGRADING 2011-01-07 14:39:56 UTC (rev 307224)
@@ -161,6 +161,8 @@
strings. This breaks code that iterated the resulting stream array using a
numeric index, but makes easier to identify which of the passed streams are
present in the result.
+- pdo_mysql now supports setting character sets when connecting in the DSN
+ string.
===
Modified: php/php-src/trunk/ext/pdo_mysql/mysql_driver.c
===
--- php/php-src/trunk/ext/pdo_mysql/mysql_driver.c2011-01-07 14:22:30 UTC
(rev 307223)
+++ php/php-src/trunk/ext/pdo_mysql/mysql_driver.c2011-01-07 14:39:56 UTC
(rev 307224)
@@ -711,6 +711,13 @@
goto cleanup;
}
+#ifdef PDO_MYSQL_HAS_CHARSET
+ if (vars[0].optval mysql_set_character_set(H-server,
vars[0].optval)) {
+ pdo_mysql_error(dbh);
+ goto cleanup;
+ }
+#endif
+
if (!dbh-auto_commit) {
mysql_handle_autocommit(dbh TSRMLS_CC);
}
Modified: php/php-src/trunk/ext/pdo_mysql/php_pdo_mysql_int.h
===
--- php/php-src/trunk/ext/pdo_mysql/php_pdo_mysql_int.h 2011-01-07
14:22:30 UTC (rev 307223)
+++ php/php-src/trunk/ext/pdo_mysql/php_pdo_mysql_int.h 2011-01-07
14:39:56 UTC (rev 307224)
@@ -33,6 +33,10 @@
#define PDO_MYSQL_PARAM_BIND MYSQL_BIND
#endif
+#if (MYSQL_VERSION_ID = 40113 MYSQL_VERSION_ID 5) ||
MYSQL_VERSION_ID = 50007 || defined(MYSQL_USE_MYSQLND)
+# define PDO_MYSQL_HAS_CHARSET
+#endif
+
#if defined(PDO_USE_MYSQLND) PHP_DEBUG !defined(PHP_WIN32)
#define PDO_DBG_ENABLED 1
this fix is inefficient. Implies a query to the server. Much efficient
is using mysql_options() on a MYSQL handle after mysql_init() but before
mysql_real_connect() (which sets the charset during the handshake).
http://dev.mysql.com/doc/refman/5.5/en/mysql-options.html
MYSQL_SET_CHARSET_NAME (argument type: char *)
The name of the character set to use as the default character set.
Could you change it?
Thanks!
Andrey
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS UPGRADING ext/pdo_mysql/mysql_driver.c ext/pdo_mysql/php_pdo_mysql_int.h
Hi Andrey 2011/1/7 Andrey Hristov p...@hristov.com: On 01/07/2011 03:39 PM, Kalle Sommer Nielsen wrote: this fix is inefficient. Implies a query to the server. Much efficient is using mysql_options() on a MYSQL handle after mysql_init() but before mysql_real_connect() (which sets the charset during the handshake). http://dev.mysql.com/doc/refman/5.5/en/mysql-options.html MYSQL_SET_CHARSET_NAME (argument type: char *) The name of the character set to use as the default character set. Could you change it? I changed it to use mysql_options() prior to the connection as suggested. Should I merge it to the 5.3 branch? Thanks! Andrey -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/zend_compile.c Zend/zend_globals.h Zend/zend_multibyte.c Zend/zend_multibyte.h ext/exif/exif.c ext/mbstring/mbstring.c ext/standard/html.c main/rfc1867
Hi Moriyoshi, Ops, sorry. I didn't understand your disagreement, and I didn't see any other objections. So I committed the patch as it was planned. Could you prepare a patch on top of this one? I'm also going to look into your recommendation of moving mbstring.script_encoding into zend.script_encoding instead of zend.multibyte. Thanks. Dmitry. On 12/09/2010 09:02 AM, Moriyoshi Koizumi wrote: Please revert. On Thu, Dec 9, 2010 at 3:00 PM, Moriyoshi Koizumim...@mozo.jp wrote: Hey, I don't think there was agreement on this yet. I've actually been preparing a patch that minimizes the extra hook points in SAPI. Moriyoshi On Wed, Dec 8, 2010 at 8:27 PM, Dmitry Stogovdmi...@php.net wrote: dmitry Wed, 08 Dec 2010 11:27:34 + Revision: http://svn.php.net/viewvc?view=revisionrevision=306077 Log: Removed compile time dependency from ext/mbstring Changed paths: U php/php-src/trunk/NEWS U php/php-src/trunk/Zend/zend_compile.c U php/php-src/trunk/Zend/zend_globals.h U php/php-src/trunk/Zend/zend_multibyte.c U php/php-src/trunk/Zend/zend_multibyte.h U php/php-src/trunk/ext/exif/exif.c U php/php-src/trunk/ext/mbstring/mbstring.c U php/php-src/trunk/ext/standard/html.c U php/php-src/trunk/main/rfc1867.c U php/php-src/trunk/main/rfc1867.h A php/php-src/trunk/tests/basic/028.phpt A php/php-src/trunk/tests/basic/029.phpt -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/zend_compile.c Zend/zend_globals.h Zend/zend_multibyte.c Zend/zend_multibyte.h ext/exif/exif.c ext/mbstring/mbstring.c ext/standard/html.c main/rfc1867
I was thinking that this is rather a *big* change, so we'd better roll our patches into one and commit it altogether. I am fine if that works for anyone else. Regards, Moriyoshi On Thu, Dec 9, 2010 at 6:11 PM, Dmitry Stogov dmi...@zend.com wrote: Hi Moriyoshi, Ops, sorry. I didn't understand your disagreement, and I didn't see any other objections. So I committed the patch as it was planned. Could you prepare a patch on top of this one? I'm also going to look into your recommendation of moving mbstring.script_encoding into zend.script_encoding instead of zend.multibyte. Thanks. Dmitry. On 12/09/2010 09:02 AM, Moriyoshi Koizumi wrote: Please revert. On Thu, Dec 9, 2010 at 3:00 PM, Moriyoshi Koizumim...@mozo.jp wrote: Hey, I don't think there was agreement on this yet. I've actually been preparing a patch that minimizes the extra hook points in SAPI. Moriyoshi On Wed, Dec 8, 2010 at 8:27 PM, Dmitry Stogovdmi...@php.net wrote: dmitry Wed, 08 Dec 2010 11:27:34 + Revision: http://svn.php.net/viewvc?view=revisionrevision=306077 Log: Removed compile time dependency from ext/mbstring Changed paths: U php/php-src/trunk/NEWS U php/php-src/trunk/Zend/zend_compile.c U php/php-src/trunk/Zend/zend_globals.h U php/php-src/trunk/Zend/zend_multibyte.c U php/php-src/trunk/Zend/zend_multibyte.h U php/php-src/trunk/ext/exif/exif.c U php/php-src/trunk/ext/mbstring/mbstring.c U php/php-src/trunk/ext/standard/html.c U php/php-src/trunk/main/rfc1867.c U php/php-src/trunk/main/rfc1867.h A php/php-src/trunk/tests/basic/028.phpt A php/php-src/trunk/tests/basic/029.phpt -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/zend_compile.c Zend/zend_globals.h Zend/zend_multibyte.c Zend/zend_multibyte.h ext/exif/exif.c ext/mbstring/mbstring.c ext/standard/html.c main/rfc1867
On 12/09/2010 08:51 PM, Moriyoshi Koizumi wrote: I was thinking that this is rather a *big* change, so we'd better roll our patches into one and commit it altogether. Sorry, that time I didn't understand that you started to improve the patch. I am fine if that works for anyone else. The patch had few small issues, but they are already fixed. Thanks. Dmitry. Regards, Moriyoshi On Thu, Dec 9, 2010 at 6:11 PM, Dmitry Stogovdmi...@zend.com wrote: Hi Moriyoshi, Ops, sorry. I didn't understand your disagreement, and I didn't see any other objections. So I committed the patch as it was planned. Could you prepare a patch on top of this one? I'm also going to look into your recommendation of moving mbstring.script_encoding into zend.script_encoding instead of zend.multibyte. Thanks. Dmitry. On 12/09/2010 09:02 AM, Moriyoshi Koizumi wrote: Please revert. On Thu, Dec 9, 2010 at 3:00 PM, Moriyoshi Koizumim...@mozo.jpwrote: Hey, I don't think there was agreement on this yet. I've actually been preparing a patch that minimizes the extra hook points in SAPI. Moriyoshi On Wed, Dec 8, 2010 at 8:27 PM, Dmitry Stogovdmi...@php.netwrote: dmitry Wed, 08 Dec 2010 11:27:34 + Revision: http://svn.php.net/viewvc?view=revisionrevision=306077 Log: Removed compile time dependency from ext/mbstring Changed paths: U php/php-src/trunk/NEWS U php/php-src/trunk/Zend/zend_compile.c U php/php-src/trunk/Zend/zend_globals.h U php/php-src/trunk/Zend/zend_multibyte.c U php/php-src/trunk/Zend/zend_multibyte.h U php/php-src/trunk/ext/exif/exif.c U php/php-src/trunk/ext/mbstring/mbstring.c U php/php-src/trunk/ext/standard/html.c U php/php-src/trunk/main/rfc1867.c U php/php-src/trunk/main/rfc1867.h A php/php-src/trunk/tests/basic/028.phpt A php/php-src/trunk/tests/basic/029.phpt -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/zend_compile.c Zend/zend_globals.h Zend/zend_multibyte.c Zend/zend_multibyte.h ext/exif/exif.c ext/mbstring/mbstring.c ext/standard/html.c main/rfc1867
Hello Dmitry. After this update ext/exif always produces these warnings: # php -v PHP Warning: PHP Startup: Illegal encoding ignored: 'ISO-8859-15' in Unknown on line 0 PHP Warning: PHP Startup: Illegal encoding ignored: 'UCS-2BE' in Unknown on line 0 PHP Warning: PHP Startup: Illegal encoding ignored: 'UCS-2LE' in Unknown on line 0 PHP Warning: PHP Startup: Illegal encoding ignored: 'JIS' in Unknown on line 0 PHP Warning: PHP Startup: Illegal encoding ignored: 'JIS' in Unknown on line 0 PHP 5.3.99-dev (cli) (built: Dec 8 2010 14:37:43) (DEBUG) Copyright (c) 1997-2010 The PHP Group Zend Engine v2.4.0, Copyright (c) 1998-2010 Zend Technologies On 12/08/2010 02:27 PM, Dmitry Stogov wrote: dmitry Wed, 08 Dec 2010 11:27:34 + Revision: http://svn.php.net/viewvc?view=revisionrevision=306077 Log: Removed compile time dependency from ext/mbstring Changed paths: U php/php-src/trunk/NEWS U php/php-src/trunk/Zend/zend_compile.c U php/php-src/trunk/Zend/zend_globals.h U php/php-src/trunk/Zend/zend_multibyte.c U php/php-src/trunk/Zend/zend_multibyte.h U php/php-src/trunk/ext/exif/exif.c U php/php-src/trunk/ext/mbstring/mbstring.c U php/php-src/trunk/ext/standard/html.c U php/php-src/trunk/main/rfc1867.c U php/php-src/trunk/main/rfc1867.h A php/php-src/trunk/tests/basic/028.phpt A php/php-src/trunk/tests/basic/029.phpt -- Wbr, Antony Dovgal --- http://pinba.org - realtime statistics for PHP -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/zend_compile.c Zend/zend_globals.h Zend/zend_multibyte.c Zend/zend_multibyte.h ext/exif/exif.c ext/mbstring/mbstring.c ext/standard/html.c main/rfc1867
Hey, I don't think there was agreement on this yet. I've actually been preparing a patch that minimizes the extra hook points in SAPI. Moriyoshi On Wed, Dec 8, 2010 at 8:27 PM, Dmitry Stogov dmi...@php.net wrote: dmitry Wed, 08 Dec 2010 11:27:34 + Revision: http://svn.php.net/viewvc?view=revisionrevision=306077 Log: Removed compile time dependency from ext/mbstring Changed paths: U php/php-src/trunk/NEWS U php/php-src/trunk/Zend/zend_compile.c U php/php-src/trunk/Zend/zend_globals.h U php/php-src/trunk/Zend/zend_multibyte.c U php/php-src/trunk/Zend/zend_multibyte.h U php/php-src/trunk/ext/exif/exif.c U php/php-src/trunk/ext/mbstring/mbstring.c U php/php-src/trunk/ext/standard/html.c U php/php-src/trunk/main/rfc1867.c U php/php-src/trunk/main/rfc1867.h A php/php-src/trunk/tests/basic/028.phpt A php/php-src/trunk/tests/basic/029.phpt -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/zend_compile.c Zend/zend_globals.h Zend/zend_multibyte.c Zend/zend_multibyte.h ext/exif/exif.c ext/mbstring/mbstring.c ext/standard/html.c main/rfc1867
Please revert. On Thu, Dec 9, 2010 at 3:00 PM, Moriyoshi Koizumi m...@mozo.jp wrote: Hey, I don't think there was agreement on this yet. I've actually been preparing a patch that minimizes the extra hook points in SAPI. Moriyoshi On Wed, Dec 8, 2010 at 8:27 PM, Dmitry Stogov dmi...@php.net wrote: dmitry Wed, 08 Dec 2010 11:27:34 + Revision: http://svn.php.net/viewvc?view=revisionrevision=306077 Log: Removed compile time dependency from ext/mbstring Changed paths: U php/php-src/trunk/NEWS U php/php-src/trunk/Zend/zend_compile.c U php/php-src/trunk/Zend/zend_globals.h U php/php-src/trunk/Zend/zend_multibyte.c U php/php-src/trunk/Zend/zend_multibyte.h U php/php-src/trunk/ext/exif/exif.c U php/php-src/trunk/ext/mbstring/mbstring.c U php/php-src/trunk/ext/standard/html.c U php/php-src/trunk/main/rfc1867.c U php/php-src/trunk/main/rfc1867.h A php/php-src/trunk/tests/basic/028.phpt A php/php-src/trunk/tests/basic/029.phpt -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS main/SAPI.c main/SAPI.h main/php_variables.c sapi/apache/mod_php5.c sapi/apache2filter/sapi_apache2.c sapi/apache2handler/sapi_apache2.c sapi/nsapi/nsapi.c
Done, thanks for the reminder.
On Sat, Nov 6, 2010 at 6:49 PM, Pierre Joye pierre@gmail.com wrote:
hi Ilia,
Please add a note to the UPGRADING file.
Thanks!
On Sat, Nov 6, 2010 at 6:14 PM, Ilia Alshanetsky il...@php.net wrote:
iliaa Sat, 06 Nov 2010 17:14:21 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=305129
Log:
Updated _SERVER['REQUEST_TIME'] to include microsecond precision.
Changed paths:
U php/php-src/trunk/NEWS
U php/php-src/trunk/main/SAPI.c
U php/php-src/trunk/main/SAPI.h
U php/php-src/trunk/main/php_variables.c
U php/php-src/trunk/sapi/apache/mod_php5.c
U php/php-src/trunk/sapi/apache2filter/sapi_apache2.c
U php/php-src/trunk/sapi/apache2handler/sapi_apache2.c
U php/php-src/trunk/sapi/nsapi/nsapi.c
Modified: php/php-src/trunk/NEWS
===
--- php/php-src/trunk/NEWS 2010-11-06 16:24:58 UTC (rev 305128)
+++ php/php-src/trunk/NEWS 2010-11-06 17:14:21 UTC (rev 305129)
@@ -4,6 +4,7 @@
- Upgraded bundled sqlite to version 3.7.3. (Ilia)
- Upgraded bundled PCRE to version 8.10. (Ilia)
+- Updated _SERVER['REQUEST_TIME'] to include microsecond precision. (Ilia)
- Added apache compatible functions (apache_child_terminate, getallheaders,
apache_request_headers, apache_response_headers) to FastCGI SAPI (Dmitry)
- Added caches to eliminate repeatable run-time bindings of functions,
classes,
Modified: php/php-src/trunk/main/SAPI.c
===
--- php/php-src/trunk/main/SAPI.c 2010-11-06 16:24:58 UTC (rev 305128)
+++ php/php-src/trunk/main/SAPI.c 2010-11-06 17:14:21 UTC (rev 305129)
@@ -961,14 +961,19 @@
}
}
-SAPI_API time_t sapi_get_request_time(TSRMLS_D)
+SAPI_API double sapi_get_request_time(TSRMLS_D)
{
if(SG(global_request_time)) return SG(global_request_time);
if (sapi_module.get_request_time SG(server_context)) {
SG(global_request_time) =
sapi_module.get_request_time(TSRMLS_C);
} else {
- SG(global_request_time) = time(0);
+ struct timeval tp = {0};
+ if (!gettimeofday(tp, NULL)) {
+ SG(global_request_time) = (double)(tp.tv_sec +
tp.tv_usec / 100.00);
+ } else {
+ SG(global_request_time) = (double)time(0);
+ }
}
return SG(global_request_time);
}
Modified: php/php-src/trunk/main/SAPI.h
===
--- php/php-src/trunk/main/SAPI.h 2010-11-06 16:24:58 UTC (rev 305128)
+++ php/php-src/trunk/main/SAPI.h 2010-11-06 17:14:21 UTC (rev 305129)
@@ -129,7 +129,7 @@
long post_max_size;
int options;
zend_bool sapi_started;
- time_t global_request_time;
+ double global_request_time;
HashTable known_post_content_types;
} sapi_globals_struct;
@@ -208,7 +208,7 @@
SAPI_API int sapi_get_target_uid(uid_t * TSRMLS_DC);
SAPI_API int sapi_get_target_gid(gid_t * TSRMLS_DC);
-SAPI_API time_t sapi_get_request_time(TSRMLS_D);
+SAPI_API double sapi_get_request_time(TSRMLS_D);
SAPI_API void sapi_terminate_process(TSRMLS_D);
END_EXTERN_C()
Modified: php/php-src/trunk/main/php_variables.c
===
--- php/php-src/trunk/main/php_variables.c 2010-11-06 16:24:58 UTC (rev
305128)
+++ php/php-src/trunk/main/php_variables.c 2010-11-06 17:14:21 UTC (rev
305129)
@@ -590,8 +590,8 @@
/* store request init time */
{
zval new_entry;
- Z_TYPE(new_entry) = IS_LONG;
- Z_LVAL(new_entry) = sapi_get_request_time(TSRMLS_C);
+ Z_TYPE(new_entry) = IS_DOUBLE;
+ Z_DVAL(new_entry) = sapi_get_request_time(TSRMLS_C);
php_register_variable_ex(REQUEST_TIME, new_entry,
array_ptr TSRMLS_CC);
}
Modified: php/php-src/trunk/sapi/apache/mod_php5.c
===
--- php/php-src/trunk/sapi/apache/mod_php5.c 2010-11-06 16:24:58 UTC (rev
305128)
+++ php/php-src/trunk/sapi/apache/mod_php5.c 2010-11-06 17:14:21 UTC (rev
305129)
@@ -438,9 +438,9 @@
/* {{{ php_apache_get_request_time
*/
-static time_t php_apache_get_request_time(TSRMLS_D)
+static double php_apache_get_request_time(TSRMLS_D)
{
- return ((request_rec *)SG(server_context))-request_time;
+ return (double) ((request_rec *)SG(server_context))-request_time;
}
/* }}} */
Modified: php/php-src/trunk/sapi/apache2filter/sapi_apache2.c
===
--- php/php-src/trunk/sapi/apache2filter/sapi_apache2.c 2010-11-06 16:24:58
UTC (rev 305128)
+++
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS main/SAPI.c main/SAPI.h main/php_variables.c sapi/apache/mod_php5.c sapi/apache2filter/sapi_apache2.c sapi/apache2handler/sapi_apache2.c sapi/nsapi/nsapi.c
hi Ilia,
Please add a note to the UPGRADING file.
Thanks!
On Sat, Nov 6, 2010 at 6:14 PM, Ilia Alshanetsky il...@php.net wrote:
iliaa Sat, 06 Nov 2010 17:14:21 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=305129
Log:
Updated _SERVER['REQUEST_TIME'] to include microsecond precision.
Changed paths:
U php/php-src/trunk/NEWS
U php/php-src/trunk/main/SAPI.c
U php/php-src/trunk/main/SAPI.h
U php/php-src/trunk/main/php_variables.c
U php/php-src/trunk/sapi/apache/mod_php5.c
U php/php-src/trunk/sapi/apache2filter/sapi_apache2.c
U php/php-src/trunk/sapi/apache2handler/sapi_apache2.c
U php/php-src/trunk/sapi/nsapi/nsapi.c
Modified: php/php-src/trunk/NEWS
===
--- php/php-src/trunk/NEWS 2010-11-06 16:24:58 UTC (rev 305128)
+++ php/php-src/trunk/NEWS 2010-11-06 17:14:21 UTC (rev 305129)
@@ -4,6 +4,7 @@
- Upgraded bundled sqlite to version 3.7.3. (Ilia)
- Upgraded bundled PCRE to version 8.10. (Ilia)
+- Updated _SERVER['REQUEST_TIME'] to include microsecond precision. (Ilia)
- Added apache compatible functions (apache_child_terminate, getallheaders,
apache_request_headers, apache_response_headers) to FastCGI SAPI (Dmitry)
- Added caches to eliminate repeatable run-time bindings of functions,
classes,
Modified: php/php-src/trunk/main/SAPI.c
===
--- php/php-src/trunk/main/SAPI.c 2010-11-06 16:24:58 UTC (rev 305128)
+++ php/php-src/trunk/main/SAPI.c 2010-11-06 17:14:21 UTC (rev 305129)
@@ -961,14 +961,19 @@
}
}
-SAPI_API time_t sapi_get_request_time(TSRMLS_D)
+SAPI_API double sapi_get_request_time(TSRMLS_D)
{
if(SG(global_request_time)) return SG(global_request_time);
if (sapi_module.get_request_time SG(server_context)) {
SG(global_request_time) =
sapi_module.get_request_time(TSRMLS_C);
} else {
- SG(global_request_time) = time(0);
+ struct timeval tp = {0};
+ if (!gettimeofday(tp, NULL)) {
+ SG(global_request_time) = (double)(tp.tv_sec +
tp.tv_usec / 100.00);
+ } else {
+ SG(global_request_time) = (double)time(0);
+ }
}
return SG(global_request_time);
}
Modified: php/php-src/trunk/main/SAPI.h
===
--- php/php-src/trunk/main/SAPI.h 2010-11-06 16:24:58 UTC (rev 305128)
+++ php/php-src/trunk/main/SAPI.h 2010-11-06 17:14:21 UTC (rev 305129)
@@ -129,7 +129,7 @@
long post_max_size;
int options;
zend_bool sapi_started;
- time_t global_request_time;
+ double global_request_time;
HashTable known_post_content_types;
} sapi_globals_struct;
@@ -208,7 +208,7 @@
SAPI_API int sapi_get_target_uid(uid_t * TSRMLS_DC);
SAPI_API int sapi_get_target_gid(gid_t * TSRMLS_DC);
-SAPI_API time_t sapi_get_request_time(TSRMLS_D);
+SAPI_API double sapi_get_request_time(TSRMLS_D);
SAPI_API void sapi_terminate_process(TSRMLS_D);
END_EXTERN_C()
Modified: php/php-src/trunk/main/php_variables.c
===
--- php/php-src/trunk/main/php_variables.c 2010-11-06 16:24:58 UTC (rev
305128)
+++ php/php-src/trunk/main/php_variables.c 2010-11-06 17:14:21 UTC (rev
305129)
@@ -590,8 +590,8 @@
/* store request init time */
{
zval new_entry;
- Z_TYPE(new_entry) = IS_LONG;
- Z_LVAL(new_entry) = sapi_get_request_time(TSRMLS_C);
+ Z_TYPE(new_entry) = IS_DOUBLE;
+ Z_DVAL(new_entry) = sapi_get_request_time(TSRMLS_C);
php_register_variable_ex(REQUEST_TIME, new_entry, array_ptr
TSRMLS_CC);
}
Modified: php/php-src/trunk/sapi/apache/mod_php5.c
===
--- php/php-src/trunk/sapi/apache/mod_php5.c 2010-11-06 16:24:58 UTC (rev
305128)
+++ php/php-src/trunk/sapi/apache/mod_php5.c 2010-11-06 17:14:21 UTC (rev
305129)
@@ -438,9 +438,9 @@
/* {{{ php_apache_get_request_time
*/
-static time_t php_apache_get_request_time(TSRMLS_D)
+static double php_apache_get_request_time(TSRMLS_D)
{
- return ((request_rec *)SG(server_context))-request_time;
+ return (double) ((request_rec *)SG(server_context))-request_time;
}
/* }}} */
Modified: php/php-src/trunk/sapi/apache2filter/sapi_apache2.c
===
--- php/php-src/trunk/sapi/apache2filter/sapi_apache2.c 2010-11-06 16:24:58
UTC (rev 305128)
+++ php/php-src/trunk/sapi/apache2filter/sapi_apache2.c 2010-11-06 17:14:21
UTC (rev 305129)
@@ -308,10 +308,10 @@
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS UPGRADING ext/standard/basic_functions.c
On 1 October 2010 10:18, Kalle Sommer Nielsen ka...@php.net wrote: - PHP_FE(getrandmax, arginfo_getrandmax) - PHP_FE(mt_rand, arginfo_mt_rand) + PHP_DEP_FE(getrandmax, arginfo_getrandmax) + PHP_DEP_FE(mt_rand, arginfo_mt_rand) Looks like you deprecated mt_rand(), oopsie. (Tips hat in mgdm's direction) PHP_FE(mt_srand, arginfo_mt_srand) PHP_FE(mt_getrandmax, arginfo_mt_getrandmax)
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS UPGRADING ext/standard/basic_functions.c
On Fri, Oct 1, 2010 at 11:18 AM, Kalle Sommer Nielsen ka...@php.net wrote: kalle Fri, 01 Oct 2010 09:18:44 + Revision: http://svn.php.net/viewvc?view=revisionrevision=303912 Log: * Added PHP_RAND_MAX and PHP_MT_RAND_MAX constants * Deprecated getrandmax() and mt_getrandmax() in favour of the new constants What is the reasoning behind that? It could be possible that the max/min has to be defined at runtime at some point. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS UPGRADING ext/standard/basic_functions.c
What is the reasoning behind that? It could be possible that the max/min has to be defined at runtime at some point. Define at runtime? The values those functions expose are from compile time constants. I do not see why we need a function call to get a statically defined value. Also, there is no min value -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS UPGRADING ext/standard/basic_functions.c
On Fri, Oct 1, 2010 at 12:08 PM, Kalle Sommer Nielsen ka...@php.net wrote: What is the reasoning behind that? It could be possible that the max/min has to be defined at runtime at some point. Define at runtime? 'possible', 'at some point' (new RNG implementation). In any case, I don't see any gain to deprecate them for the sake of adding constants. Please revert the deprecation, I'm sure about the constant additions as they could be useless later (same reason). Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/tests/array_type_hint_001.phpt Zend/tests/hint/param_type_hint_001.phpt Zend/tests/hint/param_type_hint_002.phpt Zend/tests/hint/param_type_hint_003.
Felipe,
Wouldn't the simpler change be to allow use of no spaces between scalar hint
and a variable? Basically change + to a *?
On Fri, May 21, 2010 at 9:07 PM, Felipe Pena felipe...@gmail.com wrote:
Hi,
2010/5/20 Derick Rethans der...@php.net
derick Thu, 20 May 2010 19:18:35 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=299534
Log:
- Added scalar typehinting.
Changed paths:
changed paths exceeded maximum size
Any reason to not do the same as array is treated nowadays? e.g.
ST_IN_SCRIPTINGobject {
return T_OBJECT;
}
I'm asking because the type names are surely intended to be reserved words
from now.
Using: ST_IN_SCRIPTING(string|binary){TABS_AND_SPACES}[ \t]+$ { is
confusing because we might to create the String/binary class in PHP and
when
trying to use it as type-hint it will ask for the php type, not the
class...
obviously. Which represent a BC independentely of 'string' not being a
reserved word. (If was this the reason for the token rules just to match
arguments)
And just to informe, the source as is, we have the following issues:
foo(string$var) - expect an string class instance
foo(string $var) - expect a php string type
It need be like: (string|binary){WHITESPACE}*({WHITESPACE}*)?$,
but
I think it shouldn't be a argument specific rule, but the same as T_ARRAY
is.
Patch to make string, real, binary, etc... reserved words:
http://dpaste.org/00Le/raw/
If no objections, I'll commit it, alright? :)
--
Regards,
Felipe Pena
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/tests/array_type_hint_001.phpt Zend/tests/hint/param_type_hint_001.phpt Zend/tests/hint/param_type_hint_002.phpt Zend/tests/hint/param_type_hint_003.
2010/5/22 Ilia Alshanetsky i...@prohost.org
Felipe,
Wouldn't the simpler change be to allow use of no spaces between scalar
hint and a variable? Basically change + to a *?
But it is not just about 0 or more tab/spaces, there is also \r, \n... which
are inclued in the {WHITESPACE}.
And I consider simpler to match just the type name, thus not needing the
yyless() logic. Hence I also suggested in the patch to remove the _HINT
suffix.
--
Regards,
Felipe Pena
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/tests/array_type_hint_001.phpt Zend/tests/hint/param_type_hint_001.phpt Zend/tests/hint/param_type_hint_002.phpt Zend/tests/hint/param_type_hint_003.
Felipe,
The idea behind the more complex logic was to allow people to have
Int/String/etc... class names, which if we make the types reserved keywords
will no longer be possible and break existing code.
On Sat, May 22, 2010 at 11:03 AM, Felipe Pena felipe...@gmail.com wrote:
2010/5/22 Ilia Alshanetsky i...@prohost.org
Felipe,
Wouldn't the simpler change be to allow use of no spaces between scalar
hint and a variable? Basically change + to a *?
But it is not just about 0 or more tab/spaces, there is also \r, \n...
which are inclued in the {WHITESPACE}.
And I consider simpler to match just the type name, thus not needing the
yyless() logic. Hence I also suggested in the patch to remove the _HINT
suffix.
--
Regards,
Felipe Pena
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/tests/array_type_hint_001.phpt Zend/tests/hint/param_type_hint_001.phpt Zend/tests/hint/param_type_hint_002.phpt Zend/tests/hint/param_type_hint_003.
could you discuss that on internals please?
On Sat, May 22, 2010 at 5:15 PM, Ilia Alshanetsky i...@prohost.org wrote:
Felipe,
The idea behind the more complex logic was to allow people to have
Int/String/etc... class names, which if we make the types reserved keywords
will no longer be possible and break existing code.
On Sat, May 22, 2010 at 11:03 AM, Felipe Pena felipe...@gmail.com wrote:
2010/5/22 Ilia Alshanetsky i...@prohost.org
Felipe,
Wouldn't the simpler change be to allow use of no spaces between scalar
hint and a variable? Basically change + to a *?
But it is not just about 0 or more tab/spaces, there is also \r, \n...
which are inclued in the {WHITESPACE}.
And I consider simpler to match just the type name, thus not needing the
yyless() logic. Hence I also suggested in the patch to remove the _HINT
suffix.
--
Regards,
Felipe Pena
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/tests/array_type_hint_001.phpt Zend/tests/hint/param_type_hint_001.phpt Zend/tests/hint/param_type_hint_002.phpt Zend/tests/hint/param_type_hint_003.
Ilia,
2010/5/22 Ilia Alshanetsky i...@prohost.org
Felipe,
The idea behind the more complex logic was to allow people to have
Int/String/etc... class names, which if we make the types reserved keywords
will no longer be possible and break existing code.
I didn't knew that plan. Anyway, it can be done by matching the type name in
the case-sensitive way.
-ST_IN_SCRIPTING(string|binary){TABS_AND_SPACES}[ \t]+$ {
- yyless(6);
+ST_IN_SCRIPTING('string'|'binary') {
?php
class String { }
function f(string $a){}
f('foo');
f(new String); // Catchable fatal error: Argument 1 passed to f() must be of
the type string, object given ...
--
Regards,
Felipe Pena
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/tests/array_type_hint_001.phpt Zend/tests/hint/param_type_hint_001.phpt Zend/tests/hint/param_type_hint_002.phpt Zend/tests/hint/param_type_hint_003.
Hi,
2010/5/20 Derick Rethans der...@php.net
derick Thu, 20 May 2010 19:18:35 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=299534
Log:
- Added scalar typehinting.
Changed paths:
changed paths exceeded maximum size
Any reason to not do the same as array is treated nowadays? e.g.
ST_IN_SCRIPTINGobject {
return T_OBJECT;
}
I'm asking because the type names are surely intended to be reserved words
from now.
Using: ST_IN_SCRIPTING(string|binary){TABS_AND_SPACES}[ \t]+$ { is
confusing because we might to create the String/binary class in PHP and when
trying to use it as type-hint it will ask for the php type, not the class...
obviously. Which represent a BC independentely of 'string' not being a
reserved word. (If was this the reason for the token rules just to match
arguments)
And just to informe, the source as is, we have the following issues:
foo(string$var) - expect an string class instance
foo(string $var) - expect a php string type
It need be like: (string|binary){WHITESPACE}*({WHITESPACE}*)?$, but
I think it shouldn't be a argument specific rule, but the same as T_ARRAY
is.
Patch to make string, real, binary, etc... reserved words:
http://dpaste.org/00Le/raw/
If no objections, I'll commit it, alright? :)
--
Regards,
Felipe Pena
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt
On Thu, May 6, 2010 at 00:48, Sara Golemon poll...@php.net wrote: pollita Wed, 05 May 2010 22:48:14 + Revision: http://svn.php.net/viewvc?view=revisionrevision=299037 Log: Add JSON_Serializable interface Slight bikeshedding.. but we don't use underscore for interface/classnames... -Hannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt
On Thu, May 6, 2010 at 12:59 PM, Hannes Magnusson hannes.magnus...@gmail.com wrote: On Thu, May 6, 2010 at 00:48, Sara Golemon poll...@php.net wrote: pollita Wed, 05 May 2010 22:48:14 + Revision: http://svn.php.net/viewvc?view=revisionrevision=299037 Log: Add JSON_Serializable interface Slight bikeshedding.. but we don't use underscore for interface/classnames... And I would go with JsonSerializable. However, where does it come from? Does it have to be an interface or why not using __toJson? I must have lived under a rock as I don't see any proposal either, be RFC or internals. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/tests/unset_cv05.phpt ext/filter/filter.c ext/session/session.c ext/session/tests/007.phpt ext/session/tests/008-php4.2.3.phpt ext/session/tests/009.
On Thu, Apr 15, 2010 at 18:36, Kalle Sommer Nielsen ka...@php.net wrote: kalle Thu, 15 Apr 2010 16:36:08 + Revision: http://svn.php.net/viewvc?view=revisionrevision=298048 Log: Removed register_long_arrays ini option (and $HTTP_SESSION_VARS from ext/session) Make sure you mention this in the upgrade guide please. -Hannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/tests/closure_005.phpt Zend/tests/closure_007.phpt Zend/tests/closure_020.phpt Zend/tests/closure_024.phpt Zend/tests/closure_026.phpt Zend/tests/clo
On Mon, Apr 19, 2010 at 21:45, Stanislav Malyshev s...@php.net wrote: stas Mon, 19 Apr 2010 19:45:03 + Revision: http://svn.php.net/viewvc?view=revisionrevision=298187 Log: restore $this support for closures to its former glory Remember the upgrade guide.. -Hannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS Zend/tests/unset_cv07.phpt ext/standard/basic_functions.c ext/standard/basic_functions.h ext/standard/tests/general_functions/import_request.phpt ext/standa
On 22.04.2010 02:23, Kalle Sommer Nielsen wrote:
+--SKIPIF--
+?php if(PHP_VERSION_ID 503099){ die('Not needed anymore without
register_globals'); } ?
First 4 letters of this message must be 'skip', otherwise the test is not
skipped.
--
Wbr,
Antony Dovgal
---
http://pinba.org - realtime statistics for PHP
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/standard/datetime.c main/main.c main/php_globals.h php.ini-development php.ini-production
On Mon, 12 Apr 2010, Kalle Sommer Nielsen wrote: Modified: php/php-src/trunk/main/php_globals.h === --- php/php-src/trunk/main/php_globals.h 2010-04-12 07:01:46 UTC (rev 297863) +++ php/php-src/trunk/main/php_globals.h 2010-04-12 07:34:30 UTC (rev 297864) @@ -127,8 +127,6 @@ zend_bool register_argc_argv; zend_bool auto_globals_jit; - zend_bool y2k_compliance; - char *docref_root; char *docref_ext; This breaks the ABIs, so please update the API numbers as well! regards, Derick -- http://derickrethans.nl | http://xdebug.org Like Xdebug? Consider a donation: http://xdebug.org/donate.php twitter: @derickr and @xdebug -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/standard/datetime.c main/main.c main/php_globals.h php.ini-development php.ini-production
On Thu, 2010-04-15 at 12:04 +0100, Derick Rethans wrote: On Mon, 12 Apr 2010, Kalle Sommer Nielsen wrote: Modified: php/php-src/trunk/main/php_globals.h === --- php/php-src/trunk/main/php_globals.h2010-04-12 07:01:46 UTC (rev 297863) +++ php/php-src/trunk/main/php_globals.h2010-04-12 07:34:30 UTC (rev 297864) @@ -127,8 +127,6 @@ zend_bool register_argc_argv; zend_bool auto_globals_jit; - zend_bool y2k_compliance; - char *docref_root; char *docref_ext; This breaks the ABIs, so please update the API numbers as well! Shouldn't we then also update the middle version number, so PHP_VERSION_ID can be used for readable #ifdefs? (I suggested that before ...) johannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/reflection/php_reflection.c ext/reflection/tests/ReflectionExtension_isPersistant.phpt ext/reflection/tests/ReflectionExtension_isTemporary.phpt
2010/3/30 Johannes Schlüter johan...@php.net: johannes Tue, 30 Mar 2010 20:50:42 + Revision: http://svn.php.net/viewvc?view=revisionrevision=297202 Log: Add ReflectionExtension::isTemporary() and ReflectionExtension::isPersistent(). Whattaheck is a temporary extension? dl()ed? -Hannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/reflection/php_reflection.c ext/reflection/tests/ReflectionExtension_isPersistant.phpt ext/reflection/tests/ReflectionExtension_isTemporary.phpt
2010/4/3 Hannes Magnusson hannes.magnus...@gmail.com: 2010/3/30 Johannes Schlüter johan...@php.net: johannes Tue, 30 Mar 2010 20:50:42 + Revision: http://svn.php.net/viewvc?view=revisionrevision=297202 Log: Add ReflectionExtension::isTemporary() and ReflectionExtension::isPersistent(). Whattaheck is a temporary extension? dl()ed? -Hannes Indeed, a persistent extension is an extension loaded via php.ini, temporary is via dl() =) -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/reflection/php_reflection.c ext/reflection/tests/ReflectionExtension_isPersistant.phpt ext/reflection/tests/ReflectionExtension_isTemporary.phpt
On Sat, 2010-04-03 at 14:53 +, Hannes Magnusson wrote: 2010/3/30 Johannes Schlüter johan...@php.net: johannes Tue, 30 Mar 2010 20:50:42 + Revision: http://svn.php.net/viewvc?view=revisionrevision=297202 Log: Add ReflectionExtension::isTemporary() and ReflectionExtension::isPersistent(). Whattaheck is a temporary extension? dl()ed? dl()ed or loaded using the extension directive in php.ini, persistent is statically compiled-in. Documentation is almost ready, will be committed once I convinced PhD to render it. johannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/reflection/php_reflection.c ext/reflection/tests/ReflectionExtension_isPersistant.phpt ext/reflection/tests/ReflectionExtension_isTemporary.phpt
On Sat, 2010-04-03 at 18:21 +0200, Johannes Schlüter wrote: dl()ed or loaded using the extension directive in php.ini, persistent is statically compiled-in. eh I meant to write dl()ed is temporary, persistent is statically compiled-in or loaded using the extension directive in php.ini Documentation is almost ready, will be committed once I convinced PhD to render it. There I have it correct. johannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/standard/html.c ext/standard/tests/strings/bug44703.phpt ext/standard/tests/strings/get_html_translation_table_basic1.phpt ext/standard/tests/strings/ge
On Tue, 2010-03-23 at 18:08 +, Rasmus Lerdorf wrote: rasmus Tue, 23 Mar 2010 18:08:06 + Revision: http://svn.php.net/viewvc?view=revisionrevision=296685 Log: Switch default_charset, if not specified, from ISO-8859-1 to UTF-8 I have been wanting to make this change for years, but there is a small chance of BC issues, so it shouldn't go into a minor release. I in my world this isn't just a small chance of a break. Over here every application has to deal with non-ASCII characters (äöüßÄÖÜ). Many average applications don't set the encoding, most don't care. With the environments using more and more Utf-8 (operating system environments, editor defaults, ...) the change is good but it is no small thing but will cause trouble for many users having iso-8859-1 texts in their database and getting broken pages after the upgrade and we should advise users to mind their encodings! Fixing applications is easy, getting the knowledge to our users is hard. johannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/standard/html.c ext/standard/tests/strings/bug44703.phpt ext/standard/tests/strings/get_html_translation_table_basic1.phpt ext/standard/tests/strings/ge
On 26.03.2010, at 13:39, Johannes Schlüter wrote: On Tue, 2010-03-23 at 18:08 +, Rasmus Lerdorf wrote: rasmus Tue, 23 Mar 2010 18:08:06 + Revision: http://svn.php.net/viewvc?view=revisionrevision=296685 Log: Switch default_charset, if not specified, from ISO-8859-1 to UTF-8 I have been wanting to make this change for years, but there is a small chance of BC issues, so it shouldn't go into a minor release. I in my world this isn't just a small chance of a break. Over here every application has to deal with non-ASCII characters (äöüßÄÖÜ). Many average applications don't set the encoding, most don't care. With the environments using more and more Utf-8 (operating system environments, editor defaults, ...) the change is good but it is no small thing but will cause trouble for many users having iso-8859-1 texts in their database and getting broken pages after the upgrade and we should advise users to mind their encodings! Fixing applications is easy, getting the knowledge to our users is hard. I had the same feeling when Rasmus mentioned his change. I think its a good chance, but I am not sure if we should include it in a 5.4 if that is the version name for the next release. regards, Lukas Kahwe Smith m...@pooteeweet.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/standard/html.c ext/standard/tests/strings/bug44703.phpt ext/standard/tests/strings/get_html_translation_table_basic1.phpt ext/standard/tests/strings/
2010/3/26 Johannes Schlüter johan...@php.net: On Tue, 2010-03-23 at 18:08 +, Rasmus Lerdorf wrote: With the environments using more and more Utf-8 (operating system environments, editor defaults, ...) the change is good but it is no small thing but will cause trouble for many users having iso-8859-1 texts in their database and getting broken pages after the upgrade and we should advise users to mind their encodings! It is clearly noted in the upgrade guide... If you have a pre-existing app on the server then update your INI file. For new apps, use the default.. As long as we list it in the upgrade guide, and potentionally in the Backwards compatibility breakages listing.. Its an simple and easy one-time-fix to php.ini. If it was about swapping parameter order to function, or completely different return value or anything that a developer needs to really scan his code for, then thats a different story - but a default ini value? -Hannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/standard/html.c ext/standard/tests/strings/bug44703.phpt ext/standard/tests/strings/get_html_translation_table_basic1.phpt ext/standard/tests/strings/ge
On 03/26/2010 05:39 AM, Johannes Schlüter wrote: On Tue, 2010-03-23 at 18:08 +, Rasmus Lerdorf wrote: rasmus Tue, 23 Mar 2010 18:08:06 + Revision: http://svn.php.net/viewvc?view=revisionrevision=296685 Log: Switch default_charset, if not specified, from ISO-8859-1 to UTF-8 I have been wanting to make this change for years, but there is a small chance of BC issues, so it shouldn't go into a minor release. I in my world this isn't just a small chance of a break. Over here every application has to deal with non-ASCII characters (äöüßÄÖÜ). Many average applications don't set the encoding, most don't care. With the environments using more and more Utf-8 (operating system environments, editor defaults, ...) the change is good but it is no small thing but will cause trouble for many users having iso-8859-1 texts in their database and getting broken pages after the upgrade and we should advise users to mind their encodings! Fixing applications is easy, getting the knowledge to our users is hard. Well, they don't necessarily have to fix their application. They can just put: default_charset=iso-8859-1 in their php.ini. But, I also consider it a security fix. There are a lot of apps out there that assume utf-8, but don't explicitly set it in PHP. They will send an http-equiv meta header specifying utf-8, but since they haven't told PHP they are in utf-8, functions like htmlspecialchars and htmlentities will not strip out invalid utf-8 characters which causes XSS problems. -Rasmus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/standard/html.c ext/standard/tests/strings/bug44703.phpt ext/standard/tests/strings/get_html_translation_table_basic1.phpt ext/standard/tests/strings/ge
On Fri, 2010-03-26 at 08:04 -0700, Rasmus Lerdorf wrote: On 03/26/2010 05:39 AM, Johannes Schlüter wrote: On Tue, 2010-03-23 at 18:08 +, Rasmus Lerdorf wrote: rasmus Tue, 23 Mar 2010 18:08:06 + Revision: http://svn.php.net/viewvc?view=revisionrevision=296685 Log: Switch default_charset, if not specified, from ISO-8859-1 to UTF-8 I have been wanting to make this change for years, but there is a small chance of BC issues, so it shouldn't go into a minor release. I in my world this isn't just a small chance of a break. Over here every application has to deal with non-ASCII characters (äöüßÄÖÜ). Many average applications don't set the encoding, most don't care. With the environments using more and more Utf-8 (operating system environments, editor defaults, ...) the change is good but it is no small thing but will cause trouble for many users having iso-8859-1 texts in their database and getting broken pages after the upgrade and we should advise users to mind their encodings! Fixing applications is easy, getting the knowledge to our users is hard. Well, they don't necessarily have to fix their application. They can just put: default_charset=iso-8859-1 in their php.ini. If they have access to the file, which many users don't have. And I don't object to the change, just want to get some more awareness about the impact. johannes p.s. sorry for CC'ing internals-win, not internals, my completion went wrong. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/standard/html.c ext/standard/tests/strings/bug44703.phpt ext/standard/tests/strings/get_html_translation_table_basic1.phpt ext/standard/tests/strings/ge
Hi! Well, they don't necessarily have to fix their application. They can just put: default_charset=iso-8859-1 in their php.ini. If they have access to the file, which many users don't have. And I Can't they just do ini_set? It's INI_ALL. -- Stanislav Malyshev, Zend Software Architect s...@zend.com http://www.zend.com/ (408)253-8829 MSN: s...@zend.com -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/standard/html.c ext/standard/tests/strings/bug44703.phpt ext/standard/tests/strings/get_html_translation_table_basic1.phpt ext/standard/tests/strings/ge
On Fri, 2010-03-26 at 11:03 -0700, Stanislav Malyshev wrote: Hi! Well, they don't necessarily have to fix their application. They can just put: default_charset=iso-8859-1 in their php.ini. If they have access to the file, which many users don't have. And I Can't they just do ini_set? It's INI_ALL. Yes, they can also just call header() or whatever. As I wrote in my initial mail Fixing applications is easy the point is getting the knowledge to our users is hard. Which means we need clear language in announcements and other documentation. johannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/hash/config.m4 ext/hash/hash.c ext/hash/hash_joaat.c ext/hash/php_hash.h ext/hash/php_hash_joaat.h ext/hash/tests/hash_algos.phpt ext/hash/tests/joaat
hi Martin, What's about config.w32? Cheers, On Wed, Mar 24, 2010 at 4:47 PM, Martin Jansen m...@php.net wrote: mj Wed, 24 Mar 2010 15:47:40 + Revision: http://svn.php.net/viewvc?view=revisionrevision=296728 Log: Added Jenkins's one-at-a-time hash support to ext/hash. Changed paths: U php/php-src/trunk/NEWS U php/php-src/trunk/ext/hash/config.m4 U php/php-src/trunk/ext/hash/hash.c A php/php-src/trunk/ext/hash/hash_joaat.c U php/php-src/trunk/ext/hash/php_hash.h A php/php-src/trunk/ext/hash/php_hash_joaat.h U php/php-src/trunk/ext/hash/tests/hash_algos.phpt A php/php-src/trunk/ext/hash/tests/joaat.phpt -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/hash/config.m4 ext/hash/hash.c ext/hash/hash_joaat.c ext/hash/php_hash.h ext/hash/php_hash_joaat.h ext/hash/tests/hash_algos.phpt ext/hash/tests/joaat
On 24.03.10 17:03, Pierre Joye wrote: What's about config.w32? Fixed. I also added FNV support which was missing, too. Martin -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/hash/config.m4 ext/hash/hash.c ext/hash/hash_joaat.c ext/hash/php_hash.h ext/hash/php_hash_joaat.h ext/hash/tests/hash_algos.phpt ext/hash/tests/joaat
thanks! On Wed, Mar 24, 2010 at 5:31 PM, Martin Jansen mar...@divbyzero.net wrote: On 24.03.10 17:03, Pierre Joye wrote: What's about config.w32? Fixed. I also added FNV support which was missing, too. Martin -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS main/php_version.h
On Tue, 2010-03-23 at 16:04 +, Derick Rethans wrote: derick Tue, 23 Mar 2010 16:04:53 + Revision: http://svn.php.net/viewvc?view=revisionrevision=296680 Log: - Set trunk version. Changed paths: U php/php-src/trunk/NEWS U php/php-src/trunk/main/php_version.h configure.in needs to be changed, too, else php_version.h will be overwritten. johannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: php/php-src/trunk/ NEWS Zend/zend.c Zend/zend_dtrace.c
Hi!
+ char dtrace_error_buffer[1024];
TSRMLS_FETCH();
/* Obtain relevant filename and lineno */
@@ -1581,6 +1591,12 @@
va_start(args, format);
+ if(DTRACE_ERROR_ENABLED()) {
+ vsprintf(dtrace_error_buffer, format, args);
+ }
This doesn't look good. I don't see a check anywhere that format doesn't
run over 1024 chars.
--
Stanislav Malyshev, Zend Software Architect
s...@zend.com http://www.zend.com/
(408)253-8829 MSN: s...@zend.com
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
