Re: [PHP-CVS] Re: cvs: php4(PHP_4_3) /ext/mbstring mbstring.c

2002-11-24 Thread Yasuo Ohgaki 
Moriyoshi Koizumi wrote:

I suppose the problem was caused by wrong length passed to 
php_url_decode() and whether var has been altered doesn't have much to do 
with it.

Ah. I see. It's obvious bug.
I mixed up php_mbstr_encoding_handler :)

--
Yasuo Ohgaki




Moriyoshi

Yasuo Ohgaki [EMAIL PROTECTED] wrote:



var pointer will never be changed before/after
php_url_decode()

How this could be a bug?

--
Yasuo Ohgaki

Moriyoshi Koizumi wrote:


moriyoshi		Thu Nov 21 09:51:27 2002 EDT

 Modified files:  (Branch: PHP_4_3)
   /php4/ext/mbstring	mbstring.c 
 Log:
 Fixed yet another mb_parse_str() bug
 # This is reported by Ilia. Thanks!
 
 
 
Index: php4/ext/mbstring/mbstring.c
diff -u php4/ext/mbstring/mbstring.c:1.142.2.2 php4/ext/mbstring/mbstring.c:1.142.2.3
--- php4/ext/mbstring/mbstring.c:1.142.2.2	Thu Nov 14 16:35:18 2002
+++ php4/ext/mbstring/mbstring.c	Thu Nov 21 09:51:26 2002
@@ -17,7 +17,7 @@
   +--+
 */

-/* $Id: mbstring.c,v 1.142.2.2 2002/11/14 21:35:18 moriyoshi Exp $ */
+/* $Id: mbstring.c,v 1.142.2.3 2002/11/21 14:51:26 moriyoshi Exp $ */

/*
 * PHP4 Multibyte String module mbstring (currently only for Japanese)
@@ -1719,16 +1719,16 @@
	while (var  n  num) {
		val = strchr(var, '=');
		if (val) { /* have a value */
+			len_list[n] = php_url_decode(var, val-var);
			str_list[n] = var;
-			len_list[n] = php_url_decode(var, strlen(var));
			n++;

			*val++ = '\0';
			str_list[n] = val;
			len_list[n] = php_url_decode(val, strlen(val));
		} else {
-			str_list[n] = var;
			len_list[n] = php_url_decode(var, strlen(var));
+			str_list[n] = var;
			n++;

			str_list[n] = ;





--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php










--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] Re: cvs: php4(PHP_4_3) /ext/mbstring mbstring.c

2002-11-23 Thread Moriyoshi Koizumi 
I suppose the problem was caused by wrong length passed to 
php_url_decode() and whether var has been altered doesn't have much to do 
with it.

Moriyoshi

Yasuo Ohgaki [EMAIL PROTECTED] wrote:

 var pointer will never be changed before/after
 php_url_decode()
 
 How this could be a bug?
 
 --
 Yasuo Ohgaki
 
 Moriyoshi Koizumi wrote:
  moriyoshi   Thu Nov 21 09:51:27 2002 EDT
  
Modified files:  (Branch: PHP_4_3)
  /php4/ext/mbstring  mbstring.c 
Log:
Fixed yet another mb_parse_str() bug
# This is reported by Ilia. Thanks!



  Index: php4/ext/mbstring/mbstring.c
  diff -u php4/ext/mbstring/mbstring.c:1.142.2.2 
php4/ext/mbstring/mbstring.c:1.142.2.3
  --- php4/ext/mbstring/mbstring.c:1.142.2.2  Thu Nov 14 16:35:18 2002
  +++ php4/ext/mbstring/mbstring.cThu Nov 21 09:51:26 2002
  @@ -17,7 +17,7 @@
  +--+
*/
   
  -/* $Id: mbstring.c,v 1.142.2.2 2002/11/14 21:35:18 moriyoshi Exp $ */
  +/* $Id: mbstring.c,v 1.142.2.3 2002/11/21 14:51:26 moriyoshi Exp $ */
   
   /*
* PHP4 Multibyte String module mbstring (currently only for Japanese)
  @@ -1719,16 +1719,16 @@
  while (var  n  num) {
  val = strchr(var, '=');
  if (val) { /* have a value */
  +   len_list[n] = php_url_decode(var, val-var);
  str_list[n] = var;
  -   len_list[n] = php_url_decode(var, strlen(var));
  n++;
   
  *val++ = '\0';
  str_list[n] = val;
  len_list[n] = php_url_decode(val, strlen(val));
  } else {
  -   str_list[n] = var;
  len_list[n] = php_url_decode(var, strlen(var));
  +   str_list[n] = var;
  n++;
   
  str_list[n] = ;
  
  
 
 
 
 -- 
 PHP CVS Mailing List (http://www.php.net/)
 To unsubscribe, visit: http://www.php.net/unsub.php
 


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php