Re: [PHP-CVS] com karma: - Request automatic bug report closing when refering to bug as "Fix(ed)? (bug)? #NNN": hooks/commit-bugs.php

2012-09-08 Thread Ferenc Kovacs 
On Sat, Sep 8, 2012 at 8:37 PM, Felipe Pena  wrote:

> 2012/9/8 Pierre Joye :
> > are you sure about that? I always (or very often) ask for feedback first
> :)
> >
>
> Well, since this is a typical feature of a bugtracker with a VCS
> integration. I suppose that nobody will complains about. Not worthy
> for tedious discussions (procrastination).
>
> If it is not okay, I can just revert it.
>
>
maybe we can look for a more specific commit comment, so it only triggered
when the committer explicitly ask for it.
maybe "closes #$bug['number']" ?

-- 
Ferenc Kovács
@Tyr43l - http://tyrael.hu

Re: [PHP-CVS] com karma: - Request automatic bug report closing when refering to bug as "Fix(ed)? (bug)? #NNN": hooks/commit-bugs.php

2012-09-08 Thread Felipe Pena 
2012/9/8 Pierre Joye :
> are you sure about that? I always (or very often) ask for feedback first :)
>

Well, since this is a typical feature of a bugtracker with a VCS
integration. I suppose that nobody will complains about. Not worthy
for tedious discussions (procrastination).

If it is not okay, I can just revert it.

> On Sat, Sep 8, 2012 at 7:50 PM, Felipe Pena  wrote:
>> Commit:8aae7e02344616d162d44aa6e8829a374f0ed3e4
>> Author:Felipe Pena  Sat, 8 Sep 2012 
>> 14:50:19 -0300
>> Parents:   3f9aeb02ef1bde0d2f3c25c3a297bb872964c99a
>> Branches:  master
>>
>> Link:   
>> http://git.php.net/?p=karma.git;a=commitdiff;h=8aae7e02344616d162d44aa6e8829a374f0ed3e4
>>
>> Log:
>> - Request automatic bug report closing when refering to bug as "Fix(ed)? 
>> (bug)? #NNN"
>>
>> Changed paths:
>>   M  hooks/commit-bugs.php
>>
>>
>> Diff:
>> diff --git a/hooks/commit-bugs.php b/hooks/commit-bugs.php
>> index 0995822..6b6366c 100644
>> --- a/hooks/commit-bugs.php
>> +++ b/hooks/commit-bugs.php
>> @@ -69,6 +69,12 @@ foreach ($bug_list as $k => $bug) {
>>  'ncomment' => $comment,
>>  'MAGIC_COOKIE' => $SVN_MAGIC_COOKIE,
>>  );
>> +
>> +if (preg_match('/Fix(?:ed)?\s*(?:bug\s*)?#'. $bug['number'] .'\b/i', 
>> $commit_info['log_message'])) {
>> +/* Request the automatic closing of the bug report */
>> +$postdata['status'] = 'Closed';
>> +}
>> +
>>  if ($is_DEBUG) {
>>  unset($postdata['ncomment']);
>>  $postdata['getbug'] = 1;
>>
>>
>> --
>> PHP CVS Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>
>
>
> --
> Pierre
>
> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org



-- 
Regards,
Felipe Pena

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] com karma: - Request automatic bug report closing when refering to bug as "Fix(ed)? (bug)? #NNN": hooks/commit-bugs.php

2012-09-08 Thread Pierre Joye 
are you sure about that? I always (or very often) ask for feedback first :)

On Sat, Sep 8, 2012 at 7:50 PM, Felipe Pena  wrote:
> Commit:8aae7e02344616d162d44aa6e8829a374f0ed3e4
> Author:Felipe Pena  Sat, 8 Sep 2012 14:50:19 
> -0300
> Parents:   3f9aeb02ef1bde0d2f3c25c3a297bb872964c99a
> Branches:  master
>
> Link:   
> http://git.php.net/?p=karma.git;a=commitdiff;h=8aae7e02344616d162d44aa6e8829a374f0ed3e4
>
> Log:
> - Request automatic bug report closing when refering to bug as "Fix(ed)? 
> (bug)? #NNN"
>
> Changed paths:
>   M  hooks/commit-bugs.php
>
>
> Diff:
> diff --git a/hooks/commit-bugs.php b/hooks/commit-bugs.php
> index 0995822..6b6366c 100644
> --- a/hooks/commit-bugs.php
> +++ b/hooks/commit-bugs.php
> @@ -69,6 +69,12 @@ foreach ($bug_list as $k => $bug) {
>  'ncomment' => $comment,
>  'MAGIC_COOKIE' => $SVN_MAGIC_COOKIE,
>  );
> +
> +if (preg_match('/Fix(?:ed)?\s*(?:bug\s*)?#'. $bug['number'] .'\b/i', 
> $commit_info['log_message'])) {
> +/* Request the automatic closing of the bug report */
> +$postdata['status'] = 'Closed';
> +}
> +
>  if ($is_DEBUG) {
>  unset($postdata['ncomment']);
>  $postdata['getbug'] = 1;
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php