Re: [PHP-CVS] com karma: Use author/email format that can be copied and pasted for use in e-mail clients.: lib/Git/PostReceiveHook.php

2012-03-20 Thread Stefan Marr
Hi:

On 20 Mar 2012, at 10:05, Derick Rethans wrote:

 Commit: f05ac19fc6481815958655f483ef8d0d4fbc3bbe
 Author: Derick Rethans(git...@derickrethans.nl) Tue, 20 Mar 2012 
 08:57:53 +
 Committer: Derick Rethans(git...@derickrethans.nl)  Tue, 20 Mar 2012 
 09:05:42 +
 Parents: 20a4cccd338af8b1e20ceae4339e563907b4195c
 
 Link: 
 http://git.php.net/?p=karma.git;a=commitdiff;h=f05ac19fc6481815958655f483ef8d0d4fbc3bbe
 
 Log:
 Use author/email format that can be copied and pasted for use in e-mail 
 clients.


While you guys are doing all these nice little improvements, would it be 
possible to fold the author and committer line if the authors match? (to be 
less verbose)

And, in the push emails, could the line with the short log go first in every 
block?
That seems to be the most important information in there to me.

Here I was also wondering whether the commit hash could be left out to reduce 
verbosity even more. It is still included in the link.

Thanks
Stefan


-- 
Stefan Marr
Software Languages Lab
Vrije Universiteit Brussel
Pleinlaan 2 / B-1050 Brussels / Belgium
http://soft.vub.ac.be/~smarr
Phone: +32 2 629 2974
Fax:   +32 2 629 3525


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] com karma: Use author/email format that can be copied and pasted for use in e-mail clients.: lib/Git/PostReceiveHook.php

2012-03-20 Thread Derick Rethans
On Tue, 20 Mar 2012, Stefan Marr wrote:

 Hi:
 
 On 20 Mar 2012, at 10:05, Derick Rethans wrote:
 
  Commit: f05ac19fc6481815958655f483ef8d0d4fbc3bbe
  Author: Derick Rethans(git...@derickrethans.nl) Tue, 20 Mar 2012 
  08:57:53 +
  Committer: Derick Rethans(git...@derickrethans.nl)  Tue, 20 Mar 2012 
  09:05:42 +
  Parents: 20a4cccd338af8b1e20ceae4339e563907b4195c
  
  Link: 
  http://git.php.net/?p=karma.git;a=commitdiff;h=f05ac19fc6481815958655f483ef8d0d4fbc3bbe
  
  Log:
  Use author/email format that can be copied and pasted for use in e-mail 
  clients.
 
 
 While you guys are doing all these nice little improvements, would it 
 be possible to fold the author and committer line if the authors 
 match? (to be less verbose)

Sure, will fix.

 And, in the push emails, could the line with the short log go first in 
 every block? That seems to be the most important information in there 
 to me.

Can do, but it's the emails subject now. Is that not good enough?

 Here I was also wondering whether the commit hash could be left out to 
 reduce verbosity even more. It is still included in the link.

I think it should be retained.

cheers,
Derick

-- 
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] com karma: Use author/email format that can be copied and pasted for use in e-mail clients.: lib/Git/PostReceiveHook.php

2012-03-20 Thread Christopher Jones



On 03/20/2012 02:34 AM, Derick Rethans wrote:

On Tue, 20 Mar 2012, Stefan Marr wrote:



And, in the push emails, could the line with the short log go first in
every block? That seems to be the most important information in there
to me.


Can do, but it's the emails subject now. Is that not good enough?


I'm with Stefan on this.

Chris

--
Email: christopher.jo...@oracle.com
Tel:  +1 650 506 8630
Blog:  http://blogs.oracle.com/opal/

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] com karma: Use author/email format that can be copied and pasted for use in e-mail clients.: lib/Git/PostReceiveHook.php

2012-03-20 Thread Stas Malyshev
Hi!

 Hi:
 
 On 20 Mar 2012, at 10:05, Derick Rethans wrote:
 
 Commit: f05ac19fc6481815958655f483ef8d0d4fbc3bbe Author: Derick
 Rethans(git...@derickrethans.nl) Tue, 20 Mar 2012 08:57:53
 + Committer: Derick Rethans(git...@derickrethans.nl)  Tue,
 20 Mar 2012 09:05:42 + Parents:
 20a4cccd338af8b1e20ceae4339e563907b4195c
 
 Link:
 http://git.php.net/?p=karma.git;a=commitdiff;h=f05ac19fc6481815958655f483ef8d0d4fbc3bbe


 
Log:
 Use author/email format that can be copied and pasted for use in
 e-mail clients.
 
 
 While you guys are doing all these nice little improvements, would it
 be possible to fold the author and committer line if the authors
 match? (to be less verbose)

It would also be nice to change times - + is obviously not needed as
it's always UTC and we don't really need the seconds probably. We could
drop the day of week too maybe. That would remove visual clutter.
Commit hash should be there, but we show it 3 times - as Commit, as part
of the Link and as part of the Diff. I think 1 time should be enough.

-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] com karma: Use author/email format that can be copied and pasted for use in e-mail clients.: lib/Git/PostReceiveHook.php

2012-03-20 Thread Stas Malyshev
Hi!

 It would also be nice to change times - + is obviously not needed as
 it's always UTC and we don't really need the seconds probably. We could

Wait, I was wrong on that - it's not always the same, my sample was too
small :) Maybe we should convert it to always UTC?

Also, maybe we can get rid of Trivial merge mails? In general, it
feels like we have too many mails here. I make one update to 3 branches
and before I got just one email out of it, now I get six. That quickly
becomes unmanageable and I can't review actual commits.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php