Re: [PHP-CVS] com php-src: Bug 61504 updated libmagic.patch: ext/fileinfo/libmagic.patch

2012-05-04 Thread Christopher Jones
On 03/28/2012 03:06 AM, Anatoliy Belsky wrote: Commit:11f04c3524cc86a5c4cdf748a107801116604184 Author:Anatoliy Belskya...@php.net Wed, 28 Mar 2012 12:06:09 +0200 Parents: e7fa402c7ccbff8a6ff8af776192416747db0d77 Branches: PHP-5.3 PHP-5.4 master Link:

Re: [PHP-CVS] com php-src: Bug 61504 updated libmagic.patch: ext/fileinfo/libmagic.patch

2012-05-04 Thread Anatoliy Belsky
Hi Chris, please see my comment in the #61940. Regards Anatoliy Am Fr, 4.05.2012, 19:16 schrieb Christopher Jones: On 03/28/2012 03:06 AM, Anatoliy Belsky wrote: Commit:11f04c3524cc86a5c4cdf748a107801116604184 Author:Anatoliy Belskya...@php.net Wed, 28 Mar 2012 12:06:09

Re: [PHP-CVS] com php-src: Bug 61504 updated libmagic.patch: ext/fileinfo/libmagic.patch

2012-05-04 Thread Christopher Jones
On 05/04/2012 11:16 AM, Anatoliy Belsky wrote: Hi Chris, please see my comment in the #61940. Regards Anatoliy Hi Anatoliy, Is this documented on php.net? I agree with Sean that the error messages are useless. Is there anyway PHP can improve on them? Thanks for looking at it, Chris

Re: [PHP-CVS] com php-src: Bug 61504 updated libmagic.patch: ext/fileinfo/libmagic.patch

2012-05-04 Thread Hannes Magnusson
On Fri, May 4, 2012 at 9:38 PM, Christopher Jones christopher.jo...@oracle.com wrote: On 05/04/2012 11:16 AM, Anatoliy Belsky wrote: Hi Chris, please see my comment in the #61940. Regards Anatoliy Hi Anatoliy, Is this documented on php.net? I agree with Sean that the error

Re: [PHP-CVS] com php-src: Bug 61504 updated libmagic.patch: ext/fileinfo/libmagic.patch

2012-05-04 Thread Christopher Jones
On 05/04/2012 02:22 PM, Anatoliy Belsky wrote: Hi Chris, that's not documented on the php.net yet. I think shortening that notice is a good idea. Probably it should just stop on the first fail and warn about the incompatibility. Cheers Anatoliy Hi Anatoliy, What are the options for

Re: [PHP-CVS] com php-src: Bug 61504 updated libmagic.patch: ext/fileinfo/libmagic.patch

2012-05-04 Thread Sean Coates
What are the options for reverting this fix (while keeping security)? Thanks for the help on this, Anatoliy and Chris. In my opinion, it is too late to revert the new behaviour. I currently have this in my codebase: if (version_compare(PHP_VERSION, '5.3.11') = 0) {

Re: [PHP-CVS] com php-src: Bug 61504 updated libmagic.patch: ext/fileinfo/libmagic.patch

2012-05-04 Thread Christopher Jones
On 05/04/2012 03:10 PM, Sean Coates wrote: What are the options for reverting this fix (while keeping security)? Thanks for the help on this, Anatoliy and Chris. In my opinion, it is too late to revert the new behaviour. This really should never have gone into .11 in the first place. The

Re: [PHP-CVS] com php-src: Bug 61504 updated libmagic.patch: ext/fileinfo/libmagic.patch

2012-05-04 Thread Anatoliy Belsky
Sean, thanks for reporting that :) Chris, theoretically there were a possibility to apply the patch for 5.04 which was made first (it's attached in #61504) ... but I wouldn't call that quite rational. As Sean mentioned, it's already done. For the current patch 5.11 tests was fixed, some fixes

Re: [PHP-CVS] com php-src: Bug 61504 updated libmagic.patch: ext/fileinfo/libmagic.patch

2012-05-04 Thread Anatoliy Belsky
Chris, it's already in the news http://git.php.net/?p=php-src.git;a=blob;f=NEWS;h=d26ffea8ab357a44e37044193c8b316dfaa61662;hb=704bbb3263d0ec9a6b4a767bbc516e55388f4b0e Regards Anatoliy On Fri, 04 May 2012 15:19:31 -0700 Christopher Jones christopher.jo...@oracle.com wrote: On 05/04/2012

Re: [PHP-CVS] com php-src: Bug 61504 updated libmagic.patch: ext/fileinfo/libmagic.patch

2012-05-04 Thread Christopher Jones
Hi Anatoliy, I can't see the NEWS entry in the PHP-5.4 or PHP-5.3 heads: http://git.php.net/?p=php-src.git;a=blob_plain;f=NEWS;hb=refs/heads/PHP-5.4 http://git.php.net/?p=php-src.git;a=blob_plain;f=NEWS;hb=refs/heads/PHP-5.3 I can see it in NEWS from the 5.3.12.tar.bz2 bundle. This all

Re: [PHP-CVS] com php-src: Bug 61504 updated libmagic.patch: ext/fileinfo/libmagic.patch

2012-05-04 Thread Christopher Jones
On 05/04/2012 03:53 PM, Anatoliy Belsky wrote: Sean, thanks for reporting that :) Chris, theoretically there were a possibility to apply the patch for 5.04 which was made first (it's attached in #61504) ... but I wouldn't call that quite rational. As Sean mentioned, it's already done. For