Re: [PHP-CVS] com php-src: Fixed bug #61922 (ZTS build doesn't accept zend.script_encoding config): NEWS Zend/zend.c

2012-05-10 Thread Dmitry Stogov
On 05/05/2012 06:57 PM, Laruence wrote: Hi Dmitry: On Sat, May 5, 2012 at 6:38 PM, Laruencelarue...@php.net wrote: On Sat, May 5, 2012 at 2:36 PM, Dmitry Stogovdmi...@zend.com wrote: Hi Laruence, Thank you for sending this. I'm not sure if the patch is completely correct. With the patch

Re: [PHP-CVS] com php-src: Fixed bug #61922 (ZTS build doesn't accept zend.script_encoding config): NEWS Zend/zend.c

2012-05-05 Thread Dmitry Stogov
Hi Laruence, Thank you for sending this. I'm not sure if the patch is completely correct. With the patch all the threads share the single copy of script_encoding_list and when one thread terminates it calls compiler_globals_dtor() and frees the script_encoding_list. But other threads still

Re: [PHP-CVS] com php-src: Fixed bug #61922 (ZTS build doesn't accept zend.script_encoding config): NEWS Zend/zend.c

2012-05-05 Thread Laruence
On Sat, May 5, 2012 at 2:36 PM, Dmitry Stogov dmi...@zend.com wrote: Hi Laruence, Thank you for sending this. I'm not sure if the patch is completely correct. With the patch all the threads share the single copy of script_encoding_list and when one thread terminates it calls

Re: [PHP-CVS] com php-src: Fixed bug #61922 (ZTS build doesn't accept zend.script_encoding config): NEWS Zend/zend.c

2012-05-05 Thread Laruence
Hi Dmitry: On Sat, May 5, 2012 at 6:38 PM, Laruence larue...@php.net wrote: On Sat, May 5, 2012 at 2:36 PM, Dmitry Stogov dmi...@zend.com wrote: Hi Laruence, Thank you for sending this. I'm not sure if the patch is completely correct. With the patch all the threads share the single copy of

Re: [PHP-CVS] com php-src: Fixed bug #61922 (ZTS build doesn't accept zend.script_encoding config): NEWS Zend/zend.c

2012-05-03 Thread Laruence
Hi, Dmitry: you may want to review this, :) thanks On Thu, May 3, 2012 at 10:39 PM, Xinchen Hui larue...@php.net wrote: Commit:    72f19e9a8bcf5712b24fa333a26616eff19ac1ce Author:    Xinchen Hui larue...@php.net         Thu, 3 May 2012 22:39:53 +0800 Parents: