Re: [PHP-CVS] com php-src: Remove a useless memory write in zend_llist_del_element: Zend/zend_llist.c
On 12/26/2012 07:09 AM, Pierrick Charron wrote: Sorry about that. I thought it was a small change safe enough to be committed without asking to the list but apparently I was wrong. I'm going to revert it right now on 5.3 and 5.4, but just for my personnel knowledge, could you tell me what kind of problem this change can introduce ? Thanks Pierrick Stable branches need to be kept stable, so only high priority issues should be fixed. The problem with any change is that modifying any code can have unintended and unforeseeable consequences. More extreme examples from other projects have involved white space differences throwing off build tools; optimizer bugs/features changing expected program behavior; the sudden exposure of latent memory issues due to structure changes. Chris -- christopher.jo...@oracle.com http://twitter.com/ghrd -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] com php-src: Remove a useless memory write in zend_llist_del_element: Zend/zend_llist.c
Sorry about that. I thought it was a small change safe enough to be committed without asking to the list but apparently I was wrong. I'm going to revert it right now on 5.3 and 5.4, but just for my personnel knowledge, could you tell me what kind of problem this change can introduce ? Thanks Pierrick On 26 December 2012 01:31, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! On 12/25/2012 05:45 PM, Pierrick Charron wrote: Commit:fad960a4045da86cdbd8308a165ffc47892f05b9 Author:Pierrick Charron pierr...@php.net Tue, 25 Dec 2012 20:45:24 -0500 Parents: a2b6d9c1047a4e5f3419ebc3489a66d62aa12d07 Branches: PHP-5.3 PHP-5.4 PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=fad960a4045da86cdbd8308a165ffc47892f05b9 Log: Remove a useless memory write in zend_llist_del_element The zend_llist_element *next pointer is not necessary and removing it will also remove a write on memory Was this really worth potentially destabilizing 5.3 to change? Or even 5.4? I don't think so. And BTW, why no asking maintainers about this? It's not even a bug fix as far as I can see. Could you please do it in 5.5+? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] com php-src: Remove a useless memory write in zend_llist_del_element: Zend/zend_llist.c
On 12/25/2012 05:45 PM, Pierrick Charron wrote: Commit:fad960a4045da86cdbd8308a165ffc47892f05b9 Author:Pierrick Charron pierr...@php.net Tue, 25 Dec 2012 20:45:24 -0500 Parents: a2b6d9c1047a4e5f3419ebc3489a66d62aa12d07 Branches: PHP-5.3 PHP-5.4 PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=fad960a4045da86cdbd8308a165ffc47892f05b9 Log: Remove a useless memory write in zend_llist_del_element The zend_llist_element *next pointer is not necessary and removing it will also remove a write on memory Was this really worth potentially destabilizing 5.3 to change? Or even 5.4? Chris -- christopher.jo...@oracle.com http://twitter.com/ghrd -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] com php-src: Remove a useless memory write in zend_llist_del_element: Zend/zend_llist.c
Hi! On 12/25/2012 05:45 PM, Pierrick Charron wrote: Commit:fad960a4045da86cdbd8308a165ffc47892f05b9 Author:Pierrick Charron pierr...@php.net Tue, 25 Dec 2012 20:45:24 -0500 Parents: a2b6d9c1047a4e5f3419ebc3489a66d62aa12d07 Branches: PHP-5.3 PHP-5.4 PHP-5.5 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=fad960a4045da86cdbd8308a165ffc47892f05b9 Log: Remove a useless memory write in zend_llist_del_element The zend_llist_element *next pointer is not necessary and removing it will also remove a write on memory Was this really worth potentially destabilizing 5.3 to change? Or even 5.4? I don't think so. And BTW, why no asking maintainers about this? It's not even a bug fix as far as I can see. Could you please do it in 5.5+? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
