Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2009-07-07 Thread Jani Taskinen
Always add the news on fixing bugs also in PHP_5_3 NEWS file. --Jani Pierre-Alain Joye wrote: pajoye Tue Jul 7 11:07:57 2009 UTC Modified files: (Branch: PHP_5_2) /php-src NEWS Log: - #45905

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2009-07-07 Thread Pierre Joye
On Tue, Jul 7, 2009 at 2:17 PM, Jani Taskinenjani.taski...@sci.fi wrote: Always add the news on fixing bugs also in PHP_5_3 NEWS file. Ah? That is new. I will do it. -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe,

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2009-07-07 Thread Jani Taskinen
Pierre Joye wrote: On Tue, Jul 7, 2009 at 2:17 PM, Jani Taskinenjani.taski...@sci.fi wrote: Always add the news on fixing bugs also in PHP_5_3 NEWS file. Ah? That is new. I will do it. Well, it's kinda logical: 5.3 got released. Now we have parallel releases of 5.2 and 5.3 branches so

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/pcntl pcntl.c /ext/pcntl/tests 001.phpt bug47566.phpt

2009-05-26 Thread Antony Dovgal
On 26.05.2009 18:02, Arnaud Le Blanc wrote: - /* WEXITSTATUS only returns 8 bits so we *MUST* cast this to signed char -if you want to have valid negative exit codes */ - RETURN_LONG((signed char) WEXITSTATUS(status_word)); + RETURN_LONG(WEXITSTATUS(status_word)); Okay,

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/pcntl pcntl.c /ext/pcntl/tests 001.phpt bug47566.phpt

2009-05-26 Thread Arnaud Le Blanc
Hi, On Tue, 2009-05-26 at 19:09 +0400, Antony Dovgal wrote: On 26.05.2009 18:02, Arnaud Le Blanc wrote: - /* WEXITSTATUS only returns 8 bits so we *MUST* cast this to signed char - if you want to have valid negative exit codes */ - RETURN_LONG((signed char)

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/curl interface.c php_curl.h

2009-05-26 Thread Ilia Alshanetsky
On 26-May-09, at 11:50 AM, Jani Taskinen wrote: janiTue May 26 15:50:44 2009 UTC Modified files: (Branch: PHP_5_2) /php-src NEWS /php-src/ext/curlinterface.c php_curl.h Log: MFH:- Fixed bug #48203 (Crash when CURLOPT_STDERR is set to regular file)

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard file.c

2009-05-19 Thread Antony Dovgal
On 18.05.2009 22:46, Ilia Alshanetsky wrote: iliaa Mon May 18 18:46:07 2009 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard file.c /php-src NEWS Log: MFB: Fixed bug #48313 (fgetcsv() does not return null for empty rows) All these

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2009-05-15 Thread Moriyoshi Koizumi
Just to let you guys know no intention to offend here. I just used it in the sense Jani had corrected it to be. Moriyoshi Jani Taskinen wrote: jani Fri May 15 17:18:18 2009 UTC Modified files: (Branch: PHP_5_2) /php-src NEWS Log: - Reverted is such a

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main network.c

2009-05-04 Thread Antony Dovgal
The build is broken: /local/qa/5_2/main/network.c: In function 'php_network_bind_socket_to_local_addr': /local/qa/5_2/main/network.c:426: error: 'bindto' undeclared (first use in this function) /local/qa/5_2/main/network.c:426: error: (Each undeclared identifier is reported only once

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard basic_functions.c /ext/standard/tests/network ip2long_variation1.phpt

2009-04-29 Thread Kalle Sommer Nielsen
Hi Ilia 2009/4/29 Ilia Alshanetsky il...@php.net: iliaa           Tue Apr 28 22:31:26 2009 UTC  Modified files:              (Branch: PHP_5_2)    /php-src/ext/standard       basic_functions.c    /php-src/ext/standard/tests/network ip2long_variation1.phpt    /php-src    NEWS  Log:  MFB:

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2009-04-07 Thread Jani Taskinen
Updated what to what now? --Jani Ilia Alshanetsky kirjoitti: iliaa Tue Apr 7 14:08:40 2009 UTC Modified files: (Branch: PHP_5_2) /php-src NEWS Log: News

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2009-04-07 Thread Johannes Schlüter
On Tue, 2009-04-07 at 14:08 +, Ilia Alshanetsky wrote: ?? ??? 2009, PHP 5.2.10 +- Updated to version 2009.5 (2009e) (Derick) + Shouldn't that read something like Update the timezone database to ... or similar? (Not sure what name usually is used, but the current form isn't clear at all)

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2009-04-07 Thread Ilia Alshanetsky
I'll adjust ;-) Ilia Alshanetsky On 7-Apr-09, at 12:59 PM, Jani Taskinen wrote: Updated what to what now? --Jani Ilia Alshanetsky kirjoitti: iliaa Tue Apr 7 14:08:40 2009 UTC Modified files: (Branch: PHP_5_2) /php-src NEWS Log: News

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mbstring/oniguruma regint.h /ext/sysvshm sysvshm.c

2009-03-25 Thread Ilia Alshanetsky
Moriyoshi, The change relates to alignment issues on platforms that are strict in that regard. If you use instead of longs, you could end up with crashes where sizeof(int) != sizeof(long) Ilia Alshanetsky On 24-Mar-09, at 10:05 PM, Moriyoshi Koizumi wrote: Hey, we need to be more

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mbstring/oniguruma regint.h /ext/sysvshm sysvshm.c

2009-03-24 Thread Moriyoshi Koizumi
Hey, we need to be more specific on what was the problem and what this patch actually fixes; oniguruma is a third-party library and I really don't think we'll be good at keeping up to upstream-updates with such a site specific change. Moriyoshi 2009/3/20 Ilia Alshanetsky il...@php.net: iliaa    

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard string.c /ext/standard/tests/strings bug47546.phpt

2009-03-05 Thread Antony Dovgal
On 03.03.2009 14:50, Kalle Sommer Nielsen wrote: kalle Tue Mar 3 11:50:33 2009 UTC Added files: (Branch: PHP_5_2) /php-src/ext/standard/tests/strings bug47546.phpt Modified files: /php-src NEWS /php-src/ext/standard

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard string.c /ext/standard/tests/strings bug47546.phpt

2009-03-03 Thread Antony Dovgal
On 03.03.2009 14:50, Kalle Sommer Nielsen wrote: kalle Tue Mar 3 11:50:33 2009 UTC Added files: (Branch: PHP_5_2) /php-src/ext/standard/tests/strings bug47546.phpt Modified files: /php-src NEWS /php-src/ext/standard

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS configure.in /main php_version.h

2009-02-26 Thread Ilia Alshanetsky
Moriyoshi, Well, the only thing we could do at this point is to re-tag the release with the change delaying the release by a week. You know where I stand on the matter of the code default value, but if there is a consensus on internal that this change needs to happen, then this can

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS configure.in /main php_version.h

2009-02-26 Thread Kalle Sommer Nielsen
2009/2/26 Ilia Alshanetsky i...@prohost.org: Let's reach a conclusion by end of day (EST time) so release can either be made or delayed. +0 aswell, lets just release it -- Kalle Sommer Nielsen ka...@php.net -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit:

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS configure.in /main php_version.h

2009-02-25 Thread Moriyoshi Koizumi
Ilia, We didn't resolve the array_unique() issue yet. Please take this into account. Moriyoshi 2009/2/25 Ilia Alshanetsky il...@php.net: iliaa           Wed Feb 25 14:56:51 2009 UTC  Modified files:              (Branch: PHP_5_2)    /php-src    configure.in NEWS    /php-src/main      

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS configure.in /main php_version.h

2009-02-25 Thread Ilia Alshanetsky
Moriyoshi, My opinion is that the current implementation is valid, which is why Andrei's patch was accepted in the first place. On 25-Feb-09, at 9:34 PM, Moriyoshi Koizumi wrote: Ilia, We didn't resolve the array_unique() issue yet. Please take this into account. Moriyoshi 2009/2/25

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS configure.in /main php_version.h

2009-02-25 Thread Moriyoshi Koizumi
The issue is not whether it is valid or not. Andrei's patch broke the backwards compatibility that affects real-world applications and thus cannot be regarded as an improvement. Moriyoshi On Thu, Feb 26, 2009 at 11:51 AM, Ilia Alshanetsky i...@prohost.org wrote: Moriyoshi, My opinion is that

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS configure.in /main php_version.h

2009-02-25 Thread Moriyoshi Koizumi
In addition, I didn't insist that the whole thing should be reverted. I just argue about the default value. Moriyoshi On Thu, Feb 26, 2009 at 1:27 PM, Moriyoshi Koizumi m...@mozo.jp wrote: The issue is not whether it is valid or not. Andrei's patch broke the backwards compatibility that

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2009-02-16 Thread Johannes Schlüter
On Sun, 2009-02-15 at 14:31 +, Ilia Alshanetsky wrote: iliaa Sun Feb 15 14:31:55 2009 UTC Modified files: (Branch: PHP_5_2) /php-src NEWS Log: reverted fix Is this fix in 5.3? Then it should be added to NEWS there. Thanks, johannes

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mbstring mbstring.c /ext/mbstring/libmbfl/mbfl mbfilter.c /ext/mbstring/tests bug45923.phpt

2009-02-14 Thread Antony Dovgal
On 14.02.2009 10:35, Moriyoshi Koizumi wrote: moriyoshi Sat Feb 14 07:35:01 2009 UTC Added files: (Branch: PHP_5_2) /php-src/ext/mbstring/tests bug45923.phpt Modified files: /php-src NEWS /php-src/ext/mbstring

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mbstring mbstring.c /ext/mbstring/libmbfl/mbfl mbfilter.c /ext/mbstring/tests bug45923.phpt

2009-02-14 Thread Moriyoshi Koizumi
I'm going to fix this shortly. Thank you for the heads-up. Moriyoshi On 2/14/09, Antony Dovgal t...@daylessday.org wrote: On 14.02.2009 10:35, Moriyoshi Koizumi wrote: moriyoshiSat Feb 14 07:35:01 2009 UTC Added files: (Branch: PHP_5_2)

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/soap php_http.c

2009-01-19 Thread Hannes Magnusson
On Mon, Jan 19, 2009 at 22:57, Ilia Alshanetsky il...@php.net wrote: iliaa Mon Jan 19 21:57:47 2009 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/soap php_http.c /php-srcNEWS Log: Fixed bug #47131 (SOAP Extension ignores user_agent ini setting).

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2008-12-13 Thread Pierre Joye
hi, Add the reported too please. Cheers, On Sat, Dec 13, 2008 at 2:37 PM, Scott MacVicar scott...@php.net wrote: scottmacSat Dec 13 13:37:59 2008 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS Log: Add CVE

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2008-12-13 Thread Pierre Joye
On Sat, Dec 13, 2008 at 3:11 PM, Pierre Joye pierre@gmail.com wrote: hi, Add the reported too please. *reporter -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard math.c

2008-10-30 Thread Jani Taskinen
Hannes Magnusson wrote: On Wed, Oct 29, 2008 at 21:52, Hannes Magnusson [EMAIL PROTECTED] wrote: On Wed, Oct 29, 2008 at 21:17, Ilia Alshanetsky [EMAIL PROTECTED] wrote: iliaa Wed Oct 29 20:17:33 2008 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard math.c

2008-10-29 Thread Hannes Magnusson
On Wed, Oct 29, 2008 at 21:17, Ilia Alshanetsky [EMAIL PROTECTED] wrote: iliaa Wed Oct 29 20:17:33 2008 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS /php-src/ext/standard math.c Log: MFB: Fixed bug #42294 (Unified solution for round() based

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard math.c

2008-10-29 Thread Hannes Magnusson
On Wed, Oct 29, 2008 at 21:52, Hannes Magnusson [EMAIL PROTECTED] wrote: On Wed, Oct 29, 2008 at 21:17, Ilia Alshanetsky [EMAIL PROTECTED] wrote: iliaa Wed Oct 29 20:17:33 2008 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS /php-src/ext/standard

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard math.c

2008-10-29 Thread Ilia Alshanetsky
All of the existing tests appear to pass on my system without any changes. As far as I can tell the only difference with the patch is that the rounding behavior of 32bit *nux, Windows machines and 64 bit *nixes will now be consistent. But, we may need one more RC to confirm all is well...

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mbstring/libmbfl/filters mbfilter_htmlent.c

2008-10-15 Thread Moriyoshi Koizumi
Looks like I forgot to add the test for those branches. I'm going to add them when I'm home. Moriyoshi On Thu, Oct 16, 2008 at 10:02 AM, Moriyoshi Koizumi [EMAIL PROTECTED] wrote: moriyoshi Thu Oct 16 01:02:39 2008 UTC Modified files: (Branch: PHP_5_2)

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main output.c /tests/lang bug45392.phpt

2008-08-18 Thread Dmitry Stogov
Hi Arnaud, I think this fix is wrong. CG(unclean_shutdown) may be set by any error (not only memory overflow) and in case of this patch error messages never go to stdout. The patch also breaks 20 ext/soap tests. It is definitely must be reverted for PHP_5_2 as it changes behavior and I

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2008-08-06 Thread Marcus Boerger
Hello Stanislav, we should not mention the reported, unless they provided a patch, in which case they go into the braces part anyway. marcus Tuesday, August 5, 2008, 11:40:49 PM, you wrote: stasTue Aug 5 21:40:49 2008 UTC Modified files: (Branch: PHP_5_2)

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2008-08-06 Thread Pierre Joye
hi Marcus, On Wed, Aug 6, 2008 at 1:07 PM, Marcus Boerger [EMAIL PROTECTED] wrote: Hello Stanislav, we should not mention the reported, unless they provided a patch, Except for security issue Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2008-08-06 Thread Hannes Magnusson
On Wed, Aug 6, 2008 at 13:30, Pierre Joye [EMAIL PROTECTED] wrote: hi Marcus, On Wed, Aug 6, 2008 at 1:07 PM, Marcus Boerger [EMAIL PROTECTED] wrote: Hello Stanislav, we should not mention the reported, unless they provided a patch, Except for security issue In which case, it should be

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2008-08-06 Thread Derick Rethans
On Wed, 6 Aug 2008, Hannes Magnusson wrote: On Wed, Aug 6, 2008 at 13:30, Pierre Joye [EMAIL PROTECTED] wrote: hi Marcus, On Wed, Aug 6, 2008 at 1:07 PM, Marcus Boerger [EMAIL PROTECTED] wrote: Hello Stanislav, we should not mention the reported, unless they provided a patch,

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2008-08-06 Thread Hannes Magnusson
On Wed, Aug 6, 2008 at 14:01, Derick Rethans [EMAIL PROTECTED] wrote: On Wed, 6 Aug 2008, Hannes Magnusson wrote: On Wed, Aug 6, 2008 at 13:30, Pierre Joye [EMAIL PROTECTED] wrote: hi Marcus, On Wed, Aug 6, 2008 at 1:07 PM, Marcus Boerger [EMAIL PROTECTED] wrote: Hello Stanislav,

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2008-08-06 Thread Derick Rethans
On Wed, 6 Aug 2008, Hannes Magnusson wrote: On Wed, Aug 6, 2008 at 14:01, Derick Rethans [EMAIL PROTECTED] wrote: On Wed, 6 Aug 2008, Hannes Magnusson wrote: On Wed, Aug 6, 2008 at 13:30, Pierre Joye [EMAIL PROTECTED] wrote: hi Marcus, On Wed, Aug 6, 2008 at 1:07 PM, Marcus

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2008-08-06 Thread Jani Taskinen
Hannes Magnusson kirjoitti: On Wed, Aug 6, 2008 at 14:01, Derick Rethans [EMAIL PROTECTED] wrote: On Wed, 6 Aug 2008, Hannes Magnusson wrote: On Wed, Aug 6, 2008 at 13:30, Pierre Joye [EMAIL PROTECTED] wrote: hi Marcus, On Wed, Aug 6, 2008 at 1:07 PM, Marcus Boerger [EMAIL PROTECTED] wrote:

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2008-08-06 Thread Stanislav Malyshev
Hi! No, we don't usually do that. There is no need to wake sleeping dogs. Actually, there's a number of reported by in NEWS. Don't know why this one is so different. -- Stanislav Malyshev, Zend Software Architect [EMAIL PROTECTED] http://www.zend.com/ (408)253-8829 MSN: [EMAIL

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2008-07-23 Thread Antony Dovgal
On 23.07.2008 16:05, Felipe Pena wrote: - (Dmitry, Felipe) + (Dmitry, Tony) It should have been (Dmitry, Felipe, Tony) =) -- Wbr, Antony Dovgal -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard html.c /ext/standard/tests/strings bug44703.phpt

2008-04-14 Thread Felipe Pena
Ooops, Ilia, should this be reverted? Sorry. 2008/4/11, Felipe Pena [EMAIL PROTECTED]: felipe Fri Apr 11 19:01:25 2008 UTC Added files: (Branch: PHP_5_2) /php-src/ext/standard/tests/strings bug44703.phpt Modified files: /php-srcNEWS

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS configure.in /main php_version.h

2008-04-04 Thread Hannes Magnusson
On Fri, Apr 4, 2008 at 2:16 AM, Ilia Alshanetsky [EMAIL PROTECTED] wrote: iliaa Fri Apr 4 00:16:53 2008 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS configure.in /php-src/main php_version.h Log: Back to dev

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS configure.in /main php_version.h

2008-02-28 Thread Hannes Magnusson
On Thu, Feb 28, 2008 at 1:35 AM, Ilia Alshanetsky [EMAIL PROTECTED] wrote: iliaa Thu Feb 28 00:35:26 2008 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS configure.in /php-src/main php_version.h Log: Back to dev

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard metaphone.c /ext/standard/tests/strings bug44242.phpt

2008-02-25 Thread Nuno Lopes
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/metaphone.c?r1=1.28.2.1.2.5r2=1.28.2.1.2.6diff_format=u Index: php-src/ext/standard/metaphone.c diff -u php-src/ext/standard/metaphone.c:1.28.2.1.2.5 php-src/ext/standard/metaphone.c:1.28.2.1.2.6 ---

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gmp gmp.c

2008-02-02 Thread Dmitry Stogov
I talk about PHP_5_2 (I thought it was clear from the email subject). PHP_5_3 works fine on the same system. Thanks. Dmitry. Ilia Alshanetsky wrote: Ok, i'll take a peak at the code, I am really surprised certain tests pass here and fail for you... Are you testing on a 32bit platform in 5.3

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gmp gmp.c

2008-02-02 Thread Antony Dovgal
On 02.02.2008 13:49, Dmitry Stogov wrote: I talk about PHP_5_2 (I thought it was clear from the email subject). PHP_5_3 works fine on the same system. These two tests fail for ages, AFAIK the reason is that GMP produces different results on different architectures. 5_2/ext/gmp/tests/021.phpt

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gmp gmp.c

2008-02-01 Thread Dmitry Stogov
It's very strange, because I still have the test failed. ext/gmp/tests/021.php The exactly broken thing is gmp_gcd(-1,0) that now returns -1 instead of 1. However you can see that return value of gmp_gcd(-2,2) now is not equal to gmp_gcd(2,-2). :( Thanks. Dmitry. Ilia Alshanetsky wrote:

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gmp gmp.c

2008-02-01 Thread Ilia Alshanetsky
Ok, i'll take a peak at the code, I am really surprised certain tests pass here and fail for you... Are you testing on a 32bit platform in 5.3 branch? On 1-Feb-08, at 4:19 AM, Dmitry Stogov wrote: It's very strange, because I still have the test failed. ext/gmp/tests/021.php The exactly

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gmp gmp.c

2008-02-01 Thread Antony Dovgal
On 01.02.2008 18:36, Rasmus Lerdorf wrote: All the gmp tests pass for me as well here with gmp-4.2.2 on an ancient FreeBSD 4.10 box. Same here on Linux 64bit (gmp-4.2.1, 5_3-CVS). -- Wbr, Antony Dovgal -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit:

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gmp gmp.c

2008-02-01 Thread Rasmus Lerdorf
All the gmp tests pass for me as well here with gmp-4.2.2 on an ancient FreeBSD 4.10 box. -Rasmus Ilia Alshanetsky wrote: Ok, i'll take a peak at the code, I am really surprised certain tests pass here and fail for you... Are you testing on a 32bit platform in 5.3 branch? On

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gmp gmp.c

2008-01-31 Thread Dmitry Stogov
Hi Ilia, Probably your fix is not accurate, because it breaks ext/gmp/tests/021.phpt, however it shouldn't from my point of view. BTW my math knowledge is not excellent. Could you please take a look. May be the fix should be done only for gmp_div_r() and shouldn't affect other functions.

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gmp gmp.c

2008-01-31 Thread Ilia Alshanetsky
When I ran the tests on my machine here all the tests had passed. I'll take a look again. On 31-Jan-08, at 3:50 AM, Dmitry Stogov wrote: Hi Ilia, Probably your fix is not accurate, because it breaks ext/gmp/tests/ 021.phpt, however it shouldn't from my point of view. BTW my math

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gmp gmp.c

2008-01-31 Thread Ilia Alshanetsky
Dmitry, I've just tried to run the test on a patched 5.3 system and the test passes without any problems. Why is the test failing on your machine? On 31-Jan-08, at 3:50 AM, Dmitry Stogov wrote: Hi Ilia, Probably your fix is not accurate, because it breaks ext/gmp/tests/ 021.phpt,

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard/tests/file bug43248.phpt TSRM tsrm_virtual_cwd.c

2007-11-13 Thread Jani Taskinen
What about PHP_5_3 branch?? --Jani On Tue, 2007-11-13 at 09:46 +, Dmitry Stogov wrote: dmitryTue Nov 13 09:46:39 2007 UTC Added files: (Branch: PHP_5_2) /php-src/ext/standard/tests/file bug43248.phpt Modified files:

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard array.c /ext/standard/tests/array array_intersect_assoc_variation1.phpt array_intersect_assoc_variation2.phpt

2007-11-06 Thread Ilia Alshanetsky
Is this a critical fix? On 6-Nov-07, at 8:28 AM, Jani Taskinen wrote: janiTue Nov 6 13:28:22 2007 UTC Modified files: (Branch: PHP_5_2) /php-src NEWS /php-src/ext/standardarray.c /php-src/ext/standard/tests/array

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard array.c

2007-11-06 Thread Antony Dovgal
On 06.11.2007 16:55, Ilia Alshanetsky wrote: Is this a critical fix? I believe a crash is critical enough to be merged into 5_2. -- Wbr, Antony Dovgal -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard array.c /ext/standard/tests/array array_intersect_assoc_variation1.phpt array_intersect_assoc_variation2.phpt

2007-11-06 Thread Jani Taskinen
Depends what you think is critical? Passing anything but an array to this function makes it go boom.. --Jani On Tue, 2007-11-06 at 08:55 -0500, Ilia Alshanetsky wrote: Is this a critical fix? On 6-Nov-07, at 8:28 AM, Jani Taskinen wrote: janiTue Nov 6 13:28:22 2007

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mssql php_mssql.c

2007-10-23 Thread Jani Taskinen
I'm pretty sure #4294 is not the correct bug number.. --Jani On Mon, 2007-10-22 at 22:43 +, Ilia Alshanetsky wrote: iliaa Mon Oct 22 22:43:44 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/mssqlphp_mssql.c /php-src NEWS Log:

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mysqli mysqli_api.c /ext/mysqli/tests bug38710.phpt

2007-09-06 Thread Andrey Hristov
Hi Tony, Antony Dovgal wrote: The machine is Linux x86-64. On 06.09.2007 02:43, Antony Dovgal wrote: The test fails in 5_2 branch (didn't check HEAD yet). # cat ext/mysqli/tests/bug38710.diff 001+ int(8193) 002+ string(32) b7652d9bca37038c342cc0c492dd70f9 001- int(10) 002-

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mysqli mysqli_api.c /ext/mysqli/tests bug38710.phpt

2007-09-06 Thread Antony Dovgal
On 06.09.2007 11:27, Andrey Hristov wrote: interesting. What server do you use? I am with 5.1.21.. Could be some recent fix in the 5.1 tree. # mysql --version mysql Ver 14.12 Distrib 5.0.26, for suse-linux-gnu (x86_64) using readline 5.1 -- Wbr, Antony Dovgal -- PHP CVS Mailing List

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mysqli mysqli_api.c /ext/mysqli/tests bug38710.phpt

2007-09-06 Thread Andrey Hristov
Hi Tony, Antony Dovgal wrote: On 06.09.2007 11:27, Andrey Hristov wrote: interesting. What server do you use? I am with 5.1.21.. Could be some recent fix in the 5.1 tree. # mysql --version mysql Ver 14.12 Distrib 5.0.26, for suse-linux-gnu (x86_64) using readline 5.1 yeah, just tried

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard dir.c file.c

2007-09-05 Thread Jani Taskinen
This is against the proper procedure. You're supposed to commit first to HEAD then MFH to the appropriate branch. We don't have the luxury of having some divas around here who think they can do whatever they like.. Can someone please revoke Ilia's CVS account? Only committing to a branch and

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard dir.c file.c

2007-09-05 Thread Andrei Zmievski
Calm down, Jani. I'm sure it was just an oversight. -Andrei http://10fathoms.org/vu - daily photoblog On Sep 5, 2007, at 2:06 AM, Jani Taskinen wrote: This is against the proper procedure. You're supposed to commit first to HEAD then MFH to the appropriate branch. We don't have the luxury

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mysqli mysqli_api.c /ext/mysqli/tests bug38710.phpt

2007-09-05 Thread Antony Dovgal
The test fails in 5_2 branch (didn't check HEAD yet). # cat ext/mysqli/tests/bug38710.diff 001+ int(8193) 002+ string(32) b7652d9bca37038c342cc0c492dd70f9 001- int(10) 002- string(32) 1af6d6f2f682f76f80e606aeaaee1680 On 05.09.2007 16:36, Andrey Hristov wrote: andreyWed Sep

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mysqli mysqli_api.c /ext/mysqli/tests bug38710.phpt

2007-09-05 Thread Antony Dovgal
The machine is Linux x86-64. On 06.09.2007 02:43, Antony Dovgal wrote: The test fails in 5_2 branch (didn't check HEAD yet). # cat ext/mysqli/tests/bug38710.diff 001+ int(8193) 002+ string(32) b7652d9bca37038c342cc0c492dd70f9 001- int(10) 002- string(32)

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard array.c

2007-08-10 Thread Jani Taskinen
Yes, and I'm not gonna fix that broken test that was broken to begin with. Whoever added it should fix it. --Jani On Fri, 2007-08-10 at 02:16 +0400, Antony Dovgal wrote: ext/standard/tests/array/extract.phpt is broken after this commit. On 08.08.2007 11:41, Jani Taskinen wrote: jani

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard array.c

2007-08-09 Thread Antony Dovgal
ext/standard/tests/array/extract.phpt is broken after this commit. On 08.08.2007 11:41, Jani Taskinen wrote: janiWed Aug 8 07:41:09 2007 UTC Modified files: (Branch: PHP_5_2) /php-src NEWS /php-src/ext/standard array.c Log: - Fixed bug #42233

RE: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /tests/lang 041.phpt 042.phpt 043.phpt 044.phpt ZendEngine2 zend_language_parser.y

2007-08-06 Thread Dmitry Stogov
Hi, I think this feature shouldn't go into 5.2, especially after 5.2.4RC1 release. May be into 5.3 Thanks. Dmitry. -Original Message- From: Johannes Schlьter [mailto:[EMAIL PROTECTED] Sent: Friday, August 03, 2007 1:55 AM To: php-cvs@lists.php.net Subject: [PHP-CVS] cvs:

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/pdo_sqlite sqlite_statement.c

2007-08-02 Thread Marcus Boerger
Hello Ilia, MFH? Thursday, August 2, 2007, 12:45:32 AM, you wrote: iliaa Wed Aug 1 22:45:32 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/pdo_sqlite sqlite_statement.c /php-srcNEWS Log: Fixed bug #41831 (pdo_sqlite prepared

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/pdo_sqlite sqlite_statement.c

2007-08-02 Thread Antony Dovgal
On 02.08.2007 15:39, Marcus Boerger wrote: Hello Ilia, MFH? No point, PDO in HEAD is completely out of sync. -- Wbr, Antony Dovgal -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/json JSON_parser.c json.c /ext/json/tests pass001.1.phpt

2007-06-13 Thread Stanislav Malyshev
+ double d = zend_strtod(buf-c, NULL); + if (d LONG_MAX) { Shouldn't it be d LONG_MAX || d -LONG_MAX? -int(4) +%s(4) If it's 32-bit it's always float, no chance to get int(4) from PHP, so why %s? -- Stanislav Malyshev, Zend

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/json JSON_parser.c json.c /ext/json/tests pass001.1.phpt

2007-06-13 Thread Ilia Alshanetsky
The test is universal, on 64 bit machines you will get int because PHP int is actually a long. The -LONG_MAX is a good point though. On 13-Jun-07, at 1:11 PM, Stanislav Malyshev wrote: + double d = zend_strtod(buf-c, NULL); + if (d LONG_MAX) { Shouldn't it be d LONG_MAX ||

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/json JSON_parser.c json.c /ext/json/tests pass001.1.phpt

2007-06-13 Thread Stanislav Malyshev
The test is universal That's why it has this: if (PHP_INT_SIZE != 4) die(skip this test is for 32bit platform only); at the beginning, I guess? ;) -- Stanislav Malyshev, Zend Products Engineer [EMAIL PROTECTED] http://www.zend.com/ -- PHP CVS Mailing List (http://www.php.net/) To

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/json JSON_parser.c json.c /ext/json/tests pass001.1.phpt

2007-06-13 Thread Ilia Alshanetsky
There is no reason for it to be such, I will probably merge with the separate 64bit test. On 13-Jun-07, at 1:57 PM, Stanislav Malyshev wrote: The test is universal That's why it has this: if (PHP_INT_SIZE != 4) die(skip this test is for 32bit platform only); at the beginning, I

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/wddx wddx.c /ext/wddx/tests bug41527.phpt

2007-06-12 Thread Matt Wilmas
Hi Ilia, Could you, or anyone, just put Matt instead of the e-mail addy in the NEWS files? :-) Thanks, Matt - Original Message - From: Ilia Alshanetsky Sent: Monday, June 11, 2007 iliaa Mon Jun 11 15:08:43 2007 UTC Added files: (Branch: PHP_5_2)

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gd gd.c /ext/gd/libgd gd.c

2007-06-06 Thread Pierre
On 6/6/07, Antony Dovgal [EMAIL PROTECTED] wrote: tony2001Wed Jun 6 09:45:43 2007 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS /php-src/ext/gd/libgd gd.c /php-src/ext/gd gd.c Log: MFH: fix several integer overflows in GD Can

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gd gd.c /ext/gd/libgd gd.c

2007-06-06 Thread Antony Dovgal
On 06.06.2007 14:00, Pierre wrote: On 6/6/07, Antony Dovgal [EMAIL PROTECTED] wrote: tony2001Wed Jun 6 09:45:43 2007 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS /php-src/ext/gd/libgd gd.c /php-src/ext/gd gd.c Log: MFH: fix

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gd gd.c /ext/gd/libgd gd.c

2007-06-06 Thread Pierre
On 6/6/07, Antony Dovgal [EMAIL PROTECTED] wrote: On 06.06.2007 14:00, Pierre wrote: On 6/6/07, Antony Dovgal [EMAIL PROTECTED] wrote: tony2001Wed Jun 6 09:45:43 2007 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS /php-src/ext/gd/libgd

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gd gd.c /ext/gd/libgd gd.h

2007-06-04 Thread Marcus Boerger
Hello Pierre-Alain, it is [DOC] - we all seem to make that mistake and get it wrong somehow. Should we simply allow more than just [DOC] ? Sunday, June 3, 2007, 7:46:18 PM, you wrote: pajoye Sun Jun 3 17:46:18 2007 UTC Modified files: (Branch: PHP_5_2)

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/zip php_zip.c /ext/zip/tests bug11216.phpt

2007-06-03 Thread Hannes Magnusson
On 6/3/07, Pierre-Alain Joye [EMAIL PROTECTED] wrote: - if (zip_add_dir(intern, (const char *)s) == -1) { - RETURN_FALSE; + if (zip_add_dir(intern, (const char *)s) == -1) { + RETVAL_FALSE; + } + RETVAL_TRUE; I

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/openssl xp_ssl.c

2007-05-27 Thread Marcus Boerger
Hello Ilia, is HEAD so bad or are a few keystrokes hurting you so much? Sunday, May 27, 2007, 7:05:51 PM, you wrote: iliaa Sun May 27 17:05:51 2007 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS /php-src/ext/opensslxp_ssl.c Log:

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/openssl xp_ssl.c

2007-05-27 Thread Edin Kadribasic
It seems that Ilia's time is more precious that anybody elses. This thing needs fixing. Edin Marcus Boerger wrote: Hello Ilia, is HEAD so bad or are a few keystrokes hurting you so much? Sunday, May 27, 2007, 7:05:51 PM, you wrote: iliaa Sun May 27 17:05:51 2007 UTC

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard html.c html.h /ext/standard/tests/strings htmlentities18.phpt

2007-05-25 Thread Ilia Alshanetsky
On 25-May-07, at 10:11 AM, Hannes Magnusson wrote: On 5/22/07, Ilia Alshanetsky [EMAIL PROTECTED] wrote: iliaa Tue May 22 12:37:01 2007 UTC Added files: (Branch: PHP_5_2) /php-src/ext/standard/tests/strings htmlentities18.phpt Modified files: /php-src

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard html.c html.h /ext/standard/tests/strings htmlentities18.phpt

2007-05-25 Thread Hannes Magnusson
On 5/22/07, Ilia Alshanetsky [EMAIL PROTECTED] wrote: iliaa Tue May 22 12:37:01 2007 UTC Added files: (Branch: PHP_5_2) /php-src/ext/standard/tests/strings htmlentities18.phpt Modified files: /php-srcNEWS /php-src/ext/standard html.c html.h

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mysql php_mysql.c php_mysql.h

2007-05-14 Thread Antony Dovgal
On 05/14/2007 09:10 PM, Scott MacVicar wrote: scottmacMon May 14 17:10:47 2007 UTC Modified files: (Branch: PHP_5_2) /php-src NEWS /php-src/ext/mysql php_mysql.c php_mysql.h Log: Add mysql_set_charset() so that the connection encoding can be changed.

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mysql php_mysql.c php_mysql.h

2007-05-14 Thread Scott MacVicar
Was discussed last summer and again in January this year, I forgot about it for 5.2.2 until recently. http://news.php.net/php.internals/27634 http://news.php.net/php.internals/27638 Spoke to ilia on IRC on Friday and his only comment was to use the new param parsing API. Scott Antony Dovgal

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mysql php_mysql.c php_mysql.h

2007-05-14 Thread Ilia Alshanetsky
Tony, it was also discussed on internals back in 5.2.1 days, but it was too late to include due to the state of the release cycle at the time. On 14-May-07, at 1:21 PM, Antony Dovgal wrote: On 05/14/2007 09:10 PM, Scott MacVicar wrote: scottmacMon May 14 17:10:47 2007 UTC

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/mysql php_mysql.c

2007-05-14 Thread Nuno Lopes
Index: php-src/NEWS diff -u php-src/NEWS:1.2027.2.547.2.701 php-src/NEWS:1.2027.2.547.2.702 --- php-src/NEWS:1.2027.2.547.2.701 Mon May 14 17:10:46 2007 +++ php-src/NEWS Mon May 14 18:09:19 2007 @@ -1,7 +1,7 @@ PHP NEWS

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/wddx wddx.c /ext/wddx/tests bug41283.phpt

2007-05-08 Thread Matt Wilmas
Hi Ilia, all, I've attached patches for what I think is a better fix here, and it simplifies the code. Looking at the CVS log, the is_numeric_string() usage was added in version 1.120 to fix the first numeric key bug. The simple, better thing would've been to just change zend_hash... to

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard image.c

2007-05-08 Thread Derick Rethans
On Tue, 8 May 2007, Ilia Alshanetsky wrote: iliaa Tue May 8 18:38:21 2007 UTC Modified files: (Branch: PHP_5_2) /php-src NEWS /php-src/ext/standard image.c Log: Fixed bug #41321 (downgrade read errors in getimagesize() to E_NOTICE). I don't

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard image.c

2007-05-08 Thread Ilia Alshanetsky
It is better because it won't show up on most systems. As far as taking out the error message entirely, that is not a good idea because that takes away your ability to determine what went wrong in parsing of the file. On 8-May-07, at 3:18 PM, Derick Rethans wrote: On Tue, 8 May 2007,

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard image.c

2007-05-08 Thread Derick Rethans
On Tue, 8 May 2007, Ilia Alshanetsky wrote: It is better because it won't show up on most systems. As far as taking out the error message entirely, that is not a good idea because that takes away your ability to determine what went wrong in parsing of the file. But the only way of figuring it

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/xmlwriter php_xmlwriter.c /ext/xmlwriter/tests bug41287.phpt bug41326.phpt

2007-05-08 Thread Antony Dovgal
CCing phpdocs. On 05/09/2007 01:41 AM, Pierre-Alain Joye wrote: pajoye Tue May 8 21:41:36 2007 UTC Added files: (Branch: PHP_5_2) /php-src/ext/xmlwriter/tests bug41326.phpt Modified files: /php-src NEWS /php-src/ext/xmlwriter

RE: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/soap soap.c

2007-05-07 Thread Dmitry Stogov
Hi Ilia, Why do you completely break ext/soap (all tests are failed)? Why do you do it in PHP_5_2 branch? (we have HEAD for experiments) Your patch doesn't allow me to fix other ext/soap issues, because it completely breaks test suite. Please finish your fix ASAP (also for HEAD) or revert it.

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/soap soap.c

2007-05-07 Thread Ilia Alshanetsky
On 7-May-07, at 4:19 AM, Dmitry Stogov wrote: Hi Ilia, Why do you completely break ext/soap (all tests are failed)? The soap is hardly broken, what the patch changed was allow SoapServer's handle() method to work without any parameters even when always_populate_raw_post_data is off.

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/soap soap.c

2007-05-07 Thread Ilia Alshanetsky
Dmitry, All of the tests have been fixed and now pass. I've had to convert the gzip/deflate tests to use CGI and added an additional test to check basic POST retrieval from a request (server029). On 7-May-07, at 4:19 AM, Dmitry Stogov wrote: Hi Ilia, Why do you completely break

  1   2   >