Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/json json.c utf8_to_utf16.c /ext/json/tests bug43941.phpt

2008-08-22 Thread Ilia Alshanetsky
Why do we need this check here, wouldn't it already be executed by the  
internal error handler?



On 21-Aug-08, at 2:10 PM, Stanislav Malyshev wrote:


if(!PG(display_errors)) {


Ilia Alshanetsky





--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/json json.c utf8_to_utf16.c /ext/json/tests bug43941.phpt

2008-08-22 Thread Stanislav Malyshev

Hi!

Why do we need this check here, wouldn't it already be executed by the 
internal error handler?


IIRC, it plays kind of opposite to what happens to the error handler - 
if display_errors is on, nothing is printed, in order not to put that 
error message into wrong context. I'm not sure it's that useful, but I 
remember somebody asking for it. My personal opinion is that running 
production server with display_errors=on means one already have shot 
oneself in the foot, but you know. IIRC there are some other places 
which do the same.

--
Stanislav Malyshev, Zend Software Architect
[EMAIL PROTECTED]   http://www.zend.com/
(408)253-8829   MSN: [EMAIL PROTECTED]

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php