Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-07-08 Thread Pierre Joye
pls add it to 5.2 NEWS too.

Cheers,

On Thu, Jul 9, 2009 at 2:27 AM, Stanislav Malyshevs...@php.net wrote:
 stas            Thu Jul  9 00:27:29 2009 UTC

  Modified files:              (Branch: PHP_5_3)
    /php-src    NEWS
  Log:
  report fix


 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.672r2=1.2027.2.547.2.965.2.673diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.672 
 php-src/NEWS:1.2027.2.547.2.965.2.673
 --- php-src/NEWS:1.2027.2.547.2.965.2.672       Wed Jul  8 18:23:08 2009
 +++ php-src/NEWS        Thu Jul  9 00:27:28 2009
 @@ -3,6 +3,8 @@
  ?? ??? 2009, PHP 5.3.1
  - Fixed spl_autoload_unregister/spl_autoad_functions wrt. Closures and
   Functors. (Christian Seiler)
 +- Fixed open_basedir circumvention for mail.log. (Maksymilian Arciemowicz,
 +  Stas)

  - Fixed bug #48854 (array_merge_recursive modifies arrays after first one).
   (Felipe)



 --
 PHP CVS Mailing List (http://www.php.net/)
 To unsubscribe, visit: http://www.php.net/unsub.php





-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-07-08 Thread Pierre Joye
err, forget that :)

On Thu, Jul 9, 2009 at 2:28 AM, Pierre Joyepierre@gmail.com wrote:
 pls add it to 5.2 NEWS too.

 Cheers,

 On Thu, Jul 9, 2009 at 2:27 AM, Stanislav Malyshevs...@php.net wrote:
 stas            Thu Jul  9 00:27:29 2009 UTC

  Modified files:              (Branch: PHP_5_3)
    /php-src    NEWS
  Log:
  report fix


 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.672r2=1.2027.2.547.2.965.2.673diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.672 
 php-src/NEWS:1.2027.2.547.2.965.2.673
 --- php-src/NEWS:1.2027.2.547.2.965.2.672       Wed Jul  8 18:23:08 2009
 +++ php-src/NEWS        Thu Jul  9 00:27:28 2009
 @@ -3,6 +3,8 @@
  ?? ??? 2009, PHP 5.3.1
  - Fixed spl_autoload_unregister/spl_autoad_functions wrt. Closures and
   Functors. (Christian Seiler)
 +- Fixed open_basedir circumvention for mail.log. (Maksymilian Arciemowicz,
 +  Stas)

  - Fixed bug #48854 (array_merge_recursive modifies arrays after first one).
   (Felipe)



 --
 PHP CVS Mailing List (http://www.php.net/)
 To unsubscribe, visit: http://www.php.net/unsub.php





 --
 Pierre

 http://blog.thepimp.net | http://www.libgd.org




-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/phar/phar pharcommand.inc

2009-06-25 Thread Lukas Kahwe Smith


On 25.06.2009, at 00:12, Greg Beaver wrote:


cellog  Wed Jun 24 22:12:47 2009 UTC

 Modified files:  (Branch: PHP_5_3)
   /php-src NEWS
   /php-src/ext/phar/phar   pharcommand.inc
 Log:
 fix slightly unclear error message in generation of phar.phar



This doesnt need to be merged to HEAD?

regards,
Lukas Kahwe Smith
m...@pooteeweet.org




--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/phar/phar pharcommand.inc

2009-06-25 Thread Greg Beaver
Lukas Kahwe Smith wrote:
 
 On 25.06.2009, at 00:12, Greg Beaver wrote:
 
 cellogWed Jun 24 22:12:47 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-srcNEWS
/php-src/ext/phar/pharpharcommand.inc
  Log:
  fix slightly unclear error message in generation of phar.phar
 
 
 This doesnt need to be merged to HEAD?

Hi,

It was merged to HEAD here http://news.php.net/php.cvs/58971

Thanks,
Greg

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-06-17 Thread Pierre Joye
On Thu, Jun 18, 2009 at 12:51 AM, Jani Taskinenj...@php.net wrote:
 jani            Wed Jun 17 22:51:06 2009 UTC

  Modified files:              (Branch: PHP_5_3)
    /php-src    NEWS
  Log:
  Pierre, this can not be so hard

I followed what was in RC3, Felipe fixed and etc. etc.

-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php




Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard php_string.h string.c /ext/standard/tests/strings bug47546.phpt

2009-06-12 Thread Michael Wallner
Matt Wilmas wrote:
 Hi Dmitry, Antony,
 
 Fixed, thanks.
 

 Matt Wilmas wrote:
 mattwil Wed Apr  1 17:05:37 2009 UTC

   Removed files:   (Branch: PHP_5_3)
 /php-src/ext/standard/tests/strings bug47546.phpt
   Modified files:  /php-src NEWS /php-src/ext/standard
 php_string.h string.c Log:
   MFH: explode() stuff:
   - Fixed bug #47560 (explode()'s limit parameter odd behaviour) by
 reverting change for bug #47546 
 

In what state is this now?

php_explode() does not work as expected with limit=-1 and
php_explode_negative_limit() is not exported in php_string.h

Mike

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard php_string.h string.c /ext/standard/tests/strings bug47546.phpt

2009-06-12 Thread Richard Quadling
2009/6/12 Michael Wallner m...@php.net:
 Matt Wilmas wrote:
 Hi Dmitry, Antony,

 Fixed, thanks.


 Matt Wilmas wrote:
 mattwil Wed Apr  1 17:05:37 2009 UTC

   Removed files:               (Branch: PHP_5_3)
     /php-src/ext/standard/tests/strings bug47546.phpt
   Modified files:              /php-src NEWS /php-src/ext/standard
 php_string.h string.c Log:
   MFH: explode() stuff:
   - Fixed bug #47560 (explode()'s limit parameter odd behaviour) by
 reverting change for bug #47546


 In what state is this now?

 php_explode() does not work as expected with limit=-1 and
 php_explode_negative_limit() is not exported in php_string.h

 Mike

 --
 PHP Internals - PHP Runtime Development Mailing List
 To unsubscribe, visit: http://www.php.net/unsub.php



From a user's perspective, I would say that explode() now works as I
would expect.

When a valid delimiter is supplied with no limit, then the result is
the same as if the limit was the count of items after the split.

For negative limits (with a valid delimiter), the result is chopped by
the abs($limit).

?php
$string = 'one.two.three.four';
$results = array();

foreach(array('Valid' = '.', 'Invalid' = '_') as $valid = $delimiter) {
$results[$valid]['No Limit'] = explode($delimiter, $string);

foreach(range(-4, 4) as $limit) {
$results[$valid][$limit] = explode($delimiter, $string, $limit);
}
}

print_r($results);
?

outputs what I think is correct.

Array
(
[Valid] = Array
(
[No Limit] = Array
(
[0] = one
[1] = two
[2] = three
[3] = four
)
[-4] = Array
(
)
[-3] = Array
(
[0] = one
)
[-2] = Array
(
[0] = one
[1] = two
)
[-1] = Array
(
[0] = one
[1] = two
[2] = three
)
[0] = Array
(
[0] = one.two.three.four
)
[1] = Array
(
[0] = one.two.three.four
)
[2] = Array
(
[0] = one
[1] = two.three.four
)
[3] = Array
(
[0] = one
[1] = two
[2] = three.four
)
[4] = Array
(
[0] = one
[1] = two
[2] = three
[3] = four
)
)
[Invalid] = Array
(
[No Limit] = Array
(
[0] = one.two.three.four
)
[-4] = Array
(
)
[-3] = Array
(
)
[-2] = Array
(
)
[-1] = Array
(
)
[0] = Array
(
[0] = one.two.three.four
)
[1] = Array
(
[0] = one.two.three.four
)
[2] = Array
(
[0] = one.two.three.four
)
[3] = Array
(
[0] = one.two.three.four
)
[4] = Array
(
[0] = one.two.three.four
)
)
)

-- 
-
Richard Quadling
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498r=213474731
Standing on the shoulders of some very clever giants!

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/xmlwriter php_xmlwriter.c

2009-05-11 Thread Pierre Joye
Did you notice the assigned field in the bug report? I had the patch
already as well (wrote it on my way back home from the NL test fest,
these bugs were found there while writing tests for xmlwriter :)

Can you MFB it to 5.2 as well then? Small enough.

Cheers,
--
Pierre

On Mon, May 11, 2009 at 2:21 PM, Ilia Alshanetsky il...@php.net wrote:
 iliaa           Mon May 11 12:21:26 2009 UTC

  Modified files:              (Branch: PHP_5_3)
    /php-src/ext/xmlwriter      php_xmlwriter.c
    /php-src    NEWS
  Log:

  Fixed bug #48204 (xmlwriter_open_uri() does not emit warnings on invalid
  paths)

 http://cvs.php.net/viewvc.cgi/php-src/ext/xmlwriter/php_xmlwriter.c?r1=1.20.2.12.2.15.2.11r2=1.20.2.12.2.15.2.12diff_format=u
 Index: php-src/ext/xmlwriter/php_xmlwriter.c
 diff -u php-src/ext/xmlwriter/php_xmlwriter.c:1.20.2.12.2.15.2.11 
 php-src/ext/xmlwriter/php_xmlwriter.c:1.20.2.12.2.15.2.12
 --- php-src/ext/xmlwriter/php_xmlwriter.c:1.20.2.12.2.15.2.11   Wed Dec 31 
 11:15:47 2008
 +++ php-src/ext/xmlwriter/php_xmlwriter.c       Mon May 11 12:21:26 2009
 @@ -17,7 +17,7 @@
   +--+
  */

 -/* $Id: php_xmlwriter.c,v 1.20.2.12.2.15.2.11 2008/12/31 11:15:47 sebastian 
 Exp $ */
 +/* $Id: php_xmlwriter.c,v 1.20.2.12.2.15.2.12 2009/05/11 12:21:26 iliaa Exp 
 $ */

  #ifdef HAVE_CONFIG_H
  #include config.h
 @@ -1755,6 +1755,7 @@

        valid_file = _xmlwriter_get_valid_file_path(source, resolved_path, 
 MAXPATHLEN TSRMLS_CC);
        if (!valid_file) {
 +               php_error_docref(NULL TSRMLS_CC, E_WARNING, Unable to 
 resolve file path);
                RETURN_FALSE;
        }

 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.596r2=1.2027.2.547.2.965.2.597diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.596 
 php-src/NEWS:1.2027.2.547.2.965.2.597
 --- php-src/NEWS:1.2027.2.547.2.965.2.596       Sun May 10 21:06:35 2009
 +++ php-src/NEWS        Mon May 11 12:21:26 2009
 @@ -39,6 +39,8 @@
  - Added ability to throw exceptions from SQLite3 instead of warnings. (Scott)
  - Added startup notices for deprecated ini settings. (Kalle)

 +- Fixed bug #48204 (xmlwriter_open_uri() does not emit warnings on invalid
 +  paths). (Ilia)
  - Fixed bug #48185 (warning: value computed is not used in
   pdo_sqlite_stmt_get_col line 271). (Matteo)
  - Fixed bug #48087 (call_user_method() invalid free of arguments). (Felipe)



 --
 PHP CVS Mailing List (http://www.php.net/)
 To unsubscribe, visit: http://www.php.net/unsub.php





-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pdo_sqlite sqlite_statement.c

2009-05-08 Thread Antony Dovgal
On 08.05.2009 03:29, Matteo Beccati wrote:
  #ifdef HAVE_CONFIG_H
  #include config.h
 @@ -265,11 +265,6 @@
   case SQLITE3_TEXT:
   *ptr = (char*)sqlite3_column_text(S-stmt, colno);
   *len = sqlite3_column_bytes(S-stmt, colno);
 - if (*len) {
 - /* sqlite3.h says the NUL terminator is 
 included in the byte count
 -  * for TEXT values */
 - *len--;
 - }
   return 1;

It doesn't look like no-op to me, but it's not clear what's being decremented.
I'd say it should do (*len)-- if the comment in sqlite3.h is correct.

-- 
Wbr, 
Antony Dovgal

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pdo_sqlite sqlite_statement.c

2009-05-08 Thread Matteo Beccati
Antony Dovgal ha scritto:
 On 08.05.2009 03:29, Matteo Beccati wrote:
  #ifdef HAVE_CONFIG_H
  #include config.h
 @@ -265,11 +265,6 @@
  case SQLITE3_TEXT:
  *ptr = (char*)sqlite3_column_text(S-stmt, colno);
  *len = sqlite3_column_bytes(S-stmt, colno);
 -if (*len) {
 -/* sqlite3.h says the NUL terminator is 
 included in the byte count
 - * for TEXT values */
 -*len--;
 -}
  return 1;
 
 It doesn't look like no-op to me, but it's not clear what's being decremented.
 I'd say it should do (*len)-- if the comment in sqlite3.h is correct.

By no-op I meant that it's not doing anything in a broader context,
i.e. it's not decreasing the length integer used by the caller function.

I've been pointed to the compiler warning (see bug topic of
http://bugs.php.net/bug.php?id=48185) and propery fixed it. When I ran
the test suite lots of test cases were failing because the output was
truncated.

I think that this by itself is the proof that sqlite3_column_bytes() is
not including the NULL terminator. To be sure I've also checked
sqlite3.h and couldn't find any reference to that behaviour.

The comment is wrong and the code is not doing what the comment tells,
so I thought that a clean up was required, both for consistency and to
fix the compiler warning.


Cheers
--
M.

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS configure.in /main php_version.h

2009-05-06 Thread Johannes Schlüter
On Wed, 2009-05-06 at 18:51 +, Johannes Schlüter wrote:
 johannes  Wed May  6 18:51:29 2009 UTC
 
   Modified files:  (Branch: PHP_5_3)
 /php-src/main php_version.h 
 /php-src  configure.in NEWS 
   Log:
   5.3.0RC2-dev

no -dev of course ;-)
  
 http://cvs.php.net/viewvc.cgi/php-src/main/php_version.h?r1=1.112.2.37.2.50.2.11r2=1.112.2.37.2.50.2.12diff_format=u
 Index: php-src/main/php_version.h
 diff -u php-src/main/php_version.h:1.112.2.37.2.50.2.11 
 php-src/main/php_version.h:1.112.2.37.2.50.2.12
 --- php-src/main/php_version.h:1.112.2.37.2.50.2.11   Mon Mar 23 20:40:36 2009
 +++ php-src/main/php_version.hWed May  6 18:51:29 2009
 @@ -3,6 +3,6 @@
  #define PHP_MAJOR_VERSION 5
  #define PHP_MINOR_VERSION 3
  #define PHP_RELEASE_VERSION 0
 -#define PHP_EXTRA_VERSION RC2-dev
 -#define PHP_VERSION 5.3.0RC2-dev
 +#define PHP_EXTRA_VERSION RC2
 +#define PHP_VERSION 5.3.0RC2
  #define PHP_VERSION_ID 50300
 http://cvs.php.net/viewvc.cgi/php-src/configure.in?r1=1.579.2.52.2.77.2.49r2=1.579.2.52.2.77.2.50diff_format=u
 Index: php-src/configure.in
 diff -u php-src/configure.in:1.579.2.52.2.77.2.49 
 php-src/configure.in:1.579.2.52.2.77.2.50
 --- php-src/configure.in:1.579.2.52.2.77.2.49 Wed May  6 14:04:46 2009
 +++ php-src/configure.in  Wed May  6 18:51:29 2009
 @@ -1,4 +1,4 @@
 -## $Id: configure.in,v 1.579.2.52.2.77.2.49 2009/05/06 14:04:46 iliaa Exp $ 
 -*- autoconf -*-
 +## $Id: configure.in,v 1.579.2.52.2.77.2.50 2009/05/06 18:51:29 johannes Exp 
 $ -*- autoconf -*-
  dnl ## Process this file with autoconf to produce a configure script.
  
  divert(1)
 @@ -42,7 +42,7 @@
  PHP_MAJOR_VERSION=5
  PHP_MINOR_VERSION=3
  PHP_RELEASE_VERSION=0
 -PHP_EXTRA_VERSION=RC2-dev
 +PHP_EXTRA_VERSION=RC2
  
 PHP_VERSION=$PHP_MAJOR_VERSION.$PHP_MINOR_VERSION.$PHP_RELEASE_VERSION$PHP_EXTRA_VERSION
  PHP_VERSION_ID=`expr [$]PHP_MAJOR_VERSION \* 1 + [$]PHP_MINOR_VERSION \* 
 100 + [$]PHP_RELEASE_VERSION`
  
 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.586r2=1.2027.2.547.2.965.2.587diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.586 
 php-src/NEWS:1.2027.2.547.2.965.2.587
 --- php-src/NEWS:1.2027.2.547.2.965.2.586 Tue May  5 01:35:43 2009
 +++ php-src/NEWS  Wed May  6 18:51:29 2009
 @@ -1,6 +1,6 @@
  PHP
 NEWS
  
 |||
 -?? ??? 200?, PHP 5.3.0 RC 2
 +07 May 2009, PHP 5.3.0 RC 2
  - Upgraded bundled sqlite to version 3.6.13. (Ilia)
  - Upgraded bundled PCRE to version 7.9. (Nuno)
  - Upgraded bundled libmagic to 5.02 in the fileinfo extension. (Scott)
 @@ -69,7 +69,8 @@
  - Fixed bug #42362 (HTTP status codes 204 and 304 should not be gzipped).
(Scott, Edward Z. Yang)
  - Fixed PECL bug #16338 (phar extension uses php_stream_copy_to_stream). 
 (Greg)
 -- Fixed PECL bug #14646 (phar error message unclear with php stream 
 wrappers). (Greg)
 +- Fixed PECL bug #14646 (phar error message unclear with php stream 
 wrappers).
 +  (Greg)
  - Fixed an issue with ReflectionProperty::setAccessible().
(Sebastian, Roman Borschel)
  
 
 
 


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/filter/tests bug39763.phpt bug42718-2.phpt /ext/pcre/tests bug33200.phpt /ext/session/tests 001.phpt 003.phpt 004.phpt 005.phpt 006.phpt 007.phpt 008

2009-05-05 Thread Antony Dovgal
On 05.05.2009 01:18, Kalle Sommer Nielsen wrote:
 kalle Mon May  4 21:18:22 2009 UTC
 
   Modified files:  (Branch: PHP_5_3)
 /php-src  NEWS 
 /php-src/ext/filter/tests bug39763.phpt bug42718-2.phpt 
 /php-src/ext/pcre/tests   bug33200.phpt 
 /php-src/ext/session/tests001.phpt 003.phpt 004.phpt 005.phpt 
   006.phpt 007.phpt 008-php4.2.3.phpt 
   009.phpt 012.phpt 013.phpt 014.phpt 
   019.phpt 
 /php-src/ext/standard/tests/general_functions putenv_error1.phpt 
   putenv_error2.phpt 
 /php-src/ext/standard/tests/misc  syslog_vars_variation1.phpt 
 /php-src/ext/standard/tests/network   
   
 define_syslog_variables_variation-win32.phpt 
 /php-src/main main.c 
 /php-src/tests/basic  bug46313-win.phpt 
 /php-src/tests/security   magic_quotes_gpc.phpt 
   Log:
   Added E_DEPRECATED startup notice (5.3 only)

+25 test failures.

# cat /local/qa/5_3/ext/session/tests/007.diff
001+ PHP Warning:  Directive 'register_globals' is deprecated in PHP 5.3 and 
greater in Unknown on line 0
002+ PHP Warning:  Directive 'register_long_arrays' is deprecated in PHP 5.3 
and greater in Unknown on line 0
003+
012- PHP Warning:  Directive 'register_globals' is deprecated in PHP 5.3 and 
greater in Unknown on line 0
013- PHP Warning:  Directive 'register_long_arrays' is deprecated in PHP 5.3 
and greater in Unknown on line 0

-- 
Wbr, 
Antony Dovgal

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-05-04 Thread Jani Taskinen

Matt Wilmas kirjoitti:

mattwil Tue May  5 00:55:27 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src	NEWS 
  Log:

  Changed wording
  
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.584r2=1.2027.2.547.2.965.2.585diff_format=u

Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.584 
php-src/NEWS:1.2027.2.547.2.965.2.585
--- php-src/NEWS:1.2027.2.547.2.965.2.584   Tue May  5 00:39:33 2009
+++ php-src/NEWSTue May  5 00:55:27 2009
@@ -22,7 +22,7 @@
   open(2) system call. (Mikko)
 - Added dechunk filter which can decode HTTP responses with chunked
   transfer-encoding. HTTP streams use this filter automatically in case
-  Transfer-Encoding: chunked header presents in response. It's possible to
+  Transfer-Encoding: chunked header is present in response. It's possible to
   disable this behaviour using http=array(auto_decode=0) in stream
   context. (Dmitry)
 - Added ability to throw exceptions from SQLite3 instead of warnings. (Scott)



The NEWS file is not the right place to document stuff..

--Jani

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /main main.c

2009-04-28 Thread Dmitry Stogov

Hi,

This patch should be removed when re2c EOF handling issue will be resolved.

Thanks. Dmitry.

Dmitry Stogov wrote:

dmitry  Tue Apr 28 07:13:31 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src	NEWS 
/php-src/main	main.c 
  Log:

  Fixed bug #48034 (PHP crashes when script is 8192 (8KB) bytes long)
  
  
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.570r2=1.2027.2.547.2.965.2.571diff_format=u

Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.570 
php-src/NEWS:1.2027.2.547.2.965.2.571
--- php-src/NEWS:1.2027.2.547.2.965.2.570   Mon Apr 27 18:45:12 2009
+++ php-src/NEWSTue Apr 28 07:13:30 2009
@@ -17,6 +17,7 @@
 
 - Fixed bug #48087 (call_user_method() invalid free of arguments). (Felipe)

 - Fixed bug #48060 (pdo_pgsql - large objects are returned as empty). (Matteo)
+- Fixed bug #48034 (PHP crashes when script is 8192 (8KB) bytes long). (Dmitry)
 - Fixed bug #48023 (spl_autoload_register didn't store closures). (Etienne)
 - Fixed bug #48004 (Error handler prevents creation of default object).
   (Dmitry)
http://cvs.php.net/viewvc.cgi/php-src/main/main.c?r1=1.640.2.23.2.57.2.47r2=1.640.2.23.2.57.2.48diff_format=u
Index: php-src/main/main.c
diff -u php-src/main/main.c:1.640.2.23.2.57.2.47 
php-src/main/main.c:1.640.2.23.2.57.2.48
--- php-src/main/main.c:1.640.2.23.2.57.2.47Fri Mar 27 02:34:06 2009
+++ php-src/main/main.c Tue Apr 28 07:13:30 2009
@@ -18,7 +18,7 @@
+--+
 */
 
-/* $Id: main.c,v 1.640.2.23.2.57.2.47 2009/03/27 02:34:06 lbarnaud Exp $ */

+/* $Id: main.c,v 1.640.2.23.2.57.2.48 2009/04/28 07:13:30 dmitry Exp $ */
 
 /* {{{ includes

  */
@@ -89,6 +89,13 @@
 
 #include SAPI.h

 #include rfc1867.h
+
+#if HAVE_SYS_MMAN_H
+# include sys/mman.h
+# ifndef PAGE_SIZE
+#  define PAGE_SIZE 4096
+# endif
+#endif
 /* }}} */
 
 PHPAPI int (*php_register_internal_extensions_func)(TSRMLS_D) = php_register_internal_extensions;

@@ -1134,8 +1141,10 @@
handle-handle.stream.isatty  = 0;
/* can we mmap immeadiately? */
memset(handle-handle.stream.mmap, 0, 
sizeof(handle-handle.stream.mmap));
-   len = php_zend_stream_fsizer(stream TSRMLS_CC) + 
ZEND_MMAP_AHEAD;
-   if (php_stream_mmap_possible(stream)
+   len = php_zend_stream_fsizer(stream TSRMLS_CC);
+   if (len != 0
+((len - 1) % PAGE_SIZE) = PAGE_SIZE - ZEND_MMAP_AHEAD
+php_stream_mmap_possible(stream)
 (p = php_stream_mmap_range(stream, 0, len, 
PHP_STREAM_MAP_MODE_SHARED_READONLY, mapped_len)) != NULL) {
handle-handle.stream.closer   = 
php_zend_stream_mmap_closer;
handle-handle.stream.mmap.buf = p;





--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /main main.c

2009-04-28 Thread Jani Taskinen


In that bug report the user said PHP 5.2.9 is also affected. So can you please 
MFH there too? :)


--Jani



Dmitry Stogov kirjoitti:

dmitry  Tue Apr 28 07:13:31 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src	NEWS 
/php-src/main	main.c 
  Log:

  Fixed bug #48034 (PHP crashes when script is 8192 (8KB) bytes long)
  
  
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.570r2=1.2027.2.547.2.965.2.571diff_format=u

Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.570 
php-src/NEWS:1.2027.2.547.2.965.2.571
--- php-src/NEWS:1.2027.2.547.2.965.2.570   Mon Apr 27 18:45:12 2009
+++ php-src/NEWSTue Apr 28 07:13:30 2009
@@ -17,6 +17,7 @@
 
 - Fixed bug #48087 (call_user_method() invalid free of arguments). (Felipe)

 - Fixed bug #48060 (pdo_pgsql - large objects are returned as empty). (Matteo)
+- Fixed bug #48034 (PHP crashes when script is 8192 (8KB) bytes long). (Dmitry)
 - Fixed bug #48023 (spl_autoload_register didn't store closures). (Etienne)
 - Fixed bug #48004 (Error handler prevents creation of default object).
   (Dmitry)
http://cvs.php.net/viewvc.cgi/php-src/main/main.c?r1=1.640.2.23.2.57.2.47r2=1.640.2.23.2.57.2.48diff_format=u
Index: php-src/main/main.c
diff -u php-src/main/main.c:1.640.2.23.2.57.2.47 
php-src/main/main.c:1.640.2.23.2.57.2.48
--- php-src/main/main.c:1.640.2.23.2.57.2.47Fri Mar 27 02:34:06 2009
+++ php-src/main/main.c Tue Apr 28 07:13:30 2009
@@ -18,7 +18,7 @@
+--+
 */
 
-/* $Id: main.c,v 1.640.2.23.2.57.2.47 2009/03/27 02:34:06 lbarnaud Exp $ */

+/* $Id: main.c,v 1.640.2.23.2.57.2.48 2009/04/28 07:13:30 dmitry Exp $ */
 
 /* {{{ includes

  */
@@ -89,6 +89,13 @@
 
 #include SAPI.h

 #include rfc1867.h
+
+#if HAVE_SYS_MMAN_H
+# include sys/mman.h
+# ifndef PAGE_SIZE
+#  define PAGE_SIZE 4096
+# endif
+#endif
 /* }}} */
 
 PHPAPI int (*php_register_internal_extensions_func)(TSRMLS_D) = php_register_internal_extensions;

@@ -1134,8 +1141,10 @@
handle-handle.stream.isatty  = 0;
/* can we mmap immeadiately? */
memset(handle-handle.stream.mmap, 0, 
sizeof(handle-handle.stream.mmap));
-   len = php_zend_stream_fsizer(stream TSRMLS_CC) + 
ZEND_MMAP_AHEAD;
-   if (php_stream_mmap_possible(stream)
+   len = php_zend_stream_fsizer(stream TSRMLS_CC);
+   if (len != 0
+((len - 1) % PAGE_SIZE) = PAGE_SIZE - ZEND_MMAP_AHEAD
+php_stream_mmap_possible(stream)
 (p = php_stream_mmap_range(stream, 0, len, 
PHP_STREAM_MAP_MODE_SHARED_READONLY, mapped_len)) != NULL) {
handle-handle.stream.closer   = 
php_zend_stream_mmap_closer;
handle-handle.stream.mmap.buf = p;






--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-04-27 Thread Jani Taskinen

Scott MacVicar kirjoitti:

scottmacMon Apr 27 18:20:19 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src	NEWS 
  Log:

  BFN

[snip]

   crashes). (Dmitry)
 - Fixed bug #47699 (autoload and late static binding). (Dmitry)
+- Fixed bug #47695 (build error when xmlrpc and iconv are compiled
+  against different iconv versions). (Scott)



Why aren't you fixing this in the bugfix branch? It's getting quite boring to 
ask this same question from EVERYONE all the fucking time. Did some somewhere 
say that the only active branch is PHP_5_3 suddenly?!


--Jani


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-04-27 Thread Scott MacVicar

On 27 Apr 2009, at 19:35, Jani Taskinen wrote:


Scott MacVicar kirjoitti:

scottmacMon Apr 27 18:20:19 2009 UTC
 Modified files:  (Branch: PHP_5_3)
   /php-src NEWS   Log:
 BFN

[snip]

  crashes). (Dmitry)
- Fixed bug #47699 (autoload and late static binding). (Dmitry)
+- Fixed bug #47695 (build error when xmlrpc and iconv are compiled
+  against different iconv versions). (Scott)



Why aren't you fixing this in the bugfix branch? It's getting quite  
boring to ask this same question from EVERYONE all the fucking time.  
Did some somewhere say that the only active branch is PHP_5_3  
suddenly?!




For me it was an accident, fixed in 5.2 now.

Scott

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/mysqlnd mysqlnd_portability.h

2009-04-20 Thread Johannes Schlüter
On Mon, 2009-04-20 at 12:23 +0300, Jani Taskinen wrote:
 Does that fix it also on MacOSX? :)

The MacOS issue was reported using a different bug, didn't see that one
was bogussed in favor of this one.

But I'll run it through our build farm to verify/fix on a few more
systems ...

johannes

 --Jani
 
 
 Johannes Schlüter wrote:
  johannesMon Apr 20 09:16:52 2009 UTC
  
Modified files:  (Branch: PHP_5_3)
  /php-src/ext/mysqlndmysqlnd_portability.h 
  /php-srcNEWS 
Log:
Fix #47535 Compilation failure in ps_fetch_from_1_to_8_bytes()

  http://cvs.php.net/viewvc.cgi/php-src/ext/mysqlnd/mysqlnd_portability.h?r1=1.4.2.12r2=1.4.2.13diff_format=u
  Index: php-src/ext/mysqlnd/mysqlnd_portability.h
  diff -u php-src/ext/mysqlnd/mysqlnd_portability.h:1.4.2.12 
  php-src/ext/mysqlnd/mysqlnd_portability.h:1.4.2.13
  --- php-src/ext/mysqlnd/mysqlnd_portability.h:1.4.2.12  Tue Nov 18 
  17:02:18 2008
  +++ php-src/ext/mysqlnd/mysqlnd_portability.h   Mon Apr 20 09:16:51 2009
  @@ -199,6 +199,11 @@
   #define MYSQLND_LLU_SPEC %llu
   #endif
   
  +#ifdef _AIX
  +#define MYSQLND_LL_SPEC %lli
  +#define MYSQLND_LLU_SPEC %llu
  +#endif
  +
   #define MYSQLND_SZ_T_SPEC %zd
   #ifndef L64
   #define L64(x) x##LL
  http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.562r2=1.2027.2.547.2.965.2.563diff_format=u
  Index: php-src/NEWS
  diff -u php-src/NEWS:1.2027.2.547.2.965.2.562 
  php-src/NEWS:1.2027.2.547.2.965.2.563
  --- php-src/NEWS:1.2027.2.547.2.965.2.562   Sun Apr 19 14:44:43 2009
  +++ php-src/NEWSMon Apr 20 09:16:51 2009
  @@ -30,6 +30,8 @@
   - Fixed bug #47662 (Support more than 127 subpatterns in preg_match). 
  (Nuno)
   - Fixed bug #47596 (Bus error on parsing file). (Dmitry)
   - Fixed bug #47560 (explode()'s limit parameter odd behaviour). (Matt)
  +- Fixed bug #47535 (Compilation failure in ps_fetch_from_1_to_8_bytes()).
  +  (Johannes)
   - Fixed bug #47516 (nowdoc can not be embed in heredoc but can be embed in
 double quote). (Dmitry)
   - Fixed bug #47038 (Memory leak in include). (Dmitry)
  
  
  
 
 
 


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/mysqlnd mysqlnd_portability.h

2009-04-20 Thread Jani Taskinen

Does that fix it also on MacOSX? :)

--Jani


Johannes Schlüter wrote:

johannesMon Apr 20 09:16:52 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src/ext/mysqlnd	mysqlnd_portability.h 
/php-src	NEWS 
  Log:

  Fix #47535 Compilation failure in ps_fetch_from_1_to_8_bytes()
  
http://cvs.php.net/viewvc.cgi/php-src/ext/mysqlnd/mysqlnd_portability.h?r1=1.4.2.12r2=1.4.2.13diff_format=u

Index: php-src/ext/mysqlnd/mysqlnd_portability.h
diff -u php-src/ext/mysqlnd/mysqlnd_portability.h:1.4.2.12 
php-src/ext/mysqlnd/mysqlnd_portability.h:1.4.2.13
--- php-src/ext/mysqlnd/mysqlnd_portability.h:1.4.2.12  Tue Nov 18 17:02:18 2008
+++ php-src/ext/mysqlnd/mysqlnd_portability.h   Mon Apr 20 09:16:51 2009
@@ -199,6 +199,11 @@
 #define MYSQLND_LLU_SPEC %llu
 #endif
 
+#ifdef _AIX

+#define MYSQLND_LL_SPEC %lli
+#define MYSQLND_LLU_SPEC %llu
+#endif
+
 #define MYSQLND_SZ_T_SPEC %zd
 #ifndef L64
 #define L64(x) x##LL
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.562r2=1.2027.2.547.2.965.2.563diff_format=u
Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.562 
php-src/NEWS:1.2027.2.547.2.965.2.563
--- php-src/NEWS:1.2027.2.547.2.965.2.562   Sun Apr 19 14:44:43 2009
+++ php-src/NEWSMon Apr 20 09:16:51 2009
@@ -30,6 +30,8 @@
 - Fixed bug #47662 (Support more than 127 subpatterns in preg_match). (Nuno)
 - Fixed bug #47596 (Bus error on parsing file). (Dmitry)
 - Fixed bug #47560 (explode()'s limit parameter odd behaviour). (Matt)
+- Fixed bug #47535 (Compilation failure in ps_fetch_from_1_to_8_bytes()).
+  (Johannes)
 - Fixed bug #47516 (nowdoc can not be embed in heredoc but can be embed in
   double quote). (Dmitry)
 - Fixed bug #47038 (Memory leak in include). (Dmitry)







--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard file.c streamsfuncs.c /main php_streams.h /main/streams cast.c streams.c

2009-04-19 Thread Jani Taskinen

Arnaud Le Blanc kirjoitti:

lbarnaudSun Apr 19 13:46:47 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src	NEWS 
/php-src/ext/standard	file.c streamsfuncs.c 
/php-src/main	php_streams.h 
/php-src/main/streams	cast.c streams.c 
  Log:

  Fixed bug #47997 (stream_copy_to_stream returns 1 on empty streams)
  


Why didn't you MFH to PHP_5_2 ?!
That's the stable branch still and open for bug fixes like this..

--Jani

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard filters.c http_fopen_wrapper.c /ext/standard/tests/filters chunked_001.phpt

2009-04-16 Thread Hannes Magnusson
On Thu, Apr 16, 2009 at 12:16, Dmitry Stogov dmi...@php.net wrote:
 dmitry          Thu Apr 16 10:16:27 2009 UTC

  Added files:                 (Branch: PHP_5_3)
    /php-src/ext/standard/tests/filters chunked_001.phpt

  Modified files:
    /php-src    NEWS
    /php-src/ext/standard       filters.c http_fopen_wrapper.c
  Log:
  - Added dechunk filter which can decode HTTP responces with chunked 
 transfer-encoding. HTTP streams use this filter automatically in case 
 Transfer-Encoding: chunked header presents in responce. It's possible to 
 disable this behaviour using http=array(auto_decode=0) in stream context
  - Fixed bug #47021 (SoapClient stumbles over WSDL delivered with 
 Transfer-Encoding: chunked)

Although its great that this is implemented as a filter I'm a bit
sceptical on removing the header from the response, and enabling this
by default is quite a big change considering PHP has never supported
chunked encoding and bunch of userland implementations exist for it.

-Hannes

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard filters.c http_fopen_wrapper.c /ext/standard/tests/filters chunked_001.phpt

2009-04-16 Thread Rob Richards

Hannes Magnusson wrote:

On Thu, Apr 16, 2009 at 12:16, Dmitry Stogov dmi...@php.net wrote:
  

dmitry  Thu Apr 16 10:16:27 2009 UTC

 Added files: (Branch: PHP_5_3)
   /php-src/ext/standard/tests/filters chunked_001.phpt

 Modified files:
   /php-srcNEWS
   /php-src/ext/standard   filters.c http_fopen_wrapper.c
 Log:
 - Added dechunk filter which can decode HTTP responces with chunked transfer-encoding. HTTP streams use this 
filter automatically in case Transfer-Encoding: chunked header presents in responce. It's possible to disable 
this behaviour using http=array(auto_decode=0) in stream context
 - Fixed bug #47021 (SoapClient stumbles over WSDL delivered with 
Transfer-Encoding: chunked)



Although its great that this is implemented as a filter I'm a bit
sceptical on removing the header from the response, and enabling this
by default is quite a big change considering PHP has never supported
chunked encoding and bunch of userland implementations exist for it.

-Hannes

  
The header needs to be taken out so the caller knows that the content is 
no longer chunked. It would however be nice if some header was added 
indicating that the data had been chunked. Similar to how ext/http does 
it where it changes the Transfer-Encoding header to 
X-Original-Transfer-Encoding.


Rob


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pcre/pcrelib AUTHORS ChangeLog LICENCE NEWS NON-UNIX-USE README config.h dftables.c pcre.h pcre_compile.c pcre_config.c pcre_exec.c pcre_fullinfo.c pcr

2009-04-14 Thread Ilia Alshanetsky

We should upgrade the lib for 5.2 as well.

Ilia Alshanetsky

On 11-Apr-09, at 2:57 PM, Nuno Lopes wrote:


nlopess Sat Apr 11 18:57:29 2009 UTC7
 Log:
 upgrade PCRE to version 7.9




--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pcre/pcrelib AUTHORS ChangeLog LICENCE NEWS NON-UNIX-USE README config.h dftables.c pcre.h pcre_compile.c pcre_config.c pcre_exec.c pcre_fullinfo.c pcr

2009-04-14 Thread Nuno Lopes

Ok, done.
Nuno


We should upgrade the lib for 5.2 as well.

Ilia Alshanetsky

On 11-Apr-09, at 2:57 PM, Nuno Lopes wrote:


nlopess Sat Apr 11 18:57:29 2009 UTC7
 Log:
 upgrade PCRE to version 7.9


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pcre/pcrelib AUTHORS ChangeLog LICENCE NEWS NON-UNIX-USE README config.h dftables.c pcre.h pcre_compile.c pcre_config.c pcre_exec.c pcre_fullinfo.c pcr

2009-04-14 Thread Ilia Alshanetsky

Thanks.

Ilia Alshanetsky




On 14-Apr-09, at 4:57 PM, Nuno Lopes wrote:


Ok, done.
Nuno


We should upgrade the lib for 5.2 as well.
Ilia Alshanetsky
On 11-Apr-09, at 2:57 PM, Nuno Lopes wrote:

nlopess Sat Apr 11 18:57:29 2009 UTC7
Log:
upgrade PCRE to version 7.9



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard php_string.h string.c /ext/standard/tests/strings bug47546.phpt

2009-04-02 Thread Dmitry Stogov

Hi Matt,

I suppose the following tests start fail after this patch

explode() function [ext/standard/tests/strings/explode.phpt]
Test explode() function [ext/standard/tests/strings/explode1.phpt]
Test explode() function : usage variations - positive and negative 
limits [ext/standard/tests/strings/explode_variation5.phpt]
Test explode() function : usage variations - misc tests 
[ext/standard/tests/strings/explode_variation6.phpt]


Could you please check them.

Thanks. Dmitry.

Matt Wilmas wrote:

mattwil Wed Apr  1 17:05:37 2009 UTC

  Removed files:   (Branch: PHP_5_3)
/php-src/ext/standard/tests/strings	bug47546.phpt 

  Modified files:  
/php-src	NEWS 
/php-src/ext/standard	php_string.h string.c 
  Log:

  MFH: explode() stuff:
  - Fixed bug #47560 (explode()'s limit parameter odd behaviour) by reverting 
change for bug #47546
  - Changed int to long where needed (should fix memory errors from overflow 
seen in bug #47854)
  - Simplified logic a bit with limit and its default value
  - php_explode_negative_limit(): removed safe_emalloc (not needed; plain 
erealloc is used later)
   - Moved declarations/allocation to optimize if the delimiter isn't found
   - Changed ALLOC_STEP size for less realloc's (and maybe better memory block 
alignment?)
  
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.548r2=1.2027.2.547.2.965.2.549diff_format=u

Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.548 
php-src/NEWS:1.2027.2.547.2.965.2.549
--- php-src/NEWS:1.2027.2.547.2.965.2.548   Wed Apr  1 14:00:35 2009
+++ php-src/NEWSWed Apr  1 17:05:34 2009
@@ -18,6 +18,7 @@
   crashes). (Dmitry)
 - Fixed bug #47699 (autoload and late static binding). (Dmitry)
 - Fixed bug #47596 (Bus error on parsing file). (Dmitry)
+- Fixed bug #47560 (explode()'s limit parameter odd behaviour). (Matt)
 - Fixed bug #47516 (nowdoc can not be embed in heredoc but can be embed in
   double quote). (Dmitry)
 - Fixed bug #47038 (Memory leak in include). (Dmitry)
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/php_string.h?r1=1.87.2.2.2.3.2.4r2=1.87.2.2.2.3.2.5diff_format=u
Index: php-src/ext/standard/php_string.h
diff -u php-src/ext/standard/php_string.h:1.87.2.2.2.3.2.4 
php-src/ext/standard/php_string.h:1.87.2.2.2.3.2.5
--- php-src/ext/standard/php_string.h:1.87.2.2.2.3.2.4  Wed Dec 31 11:15:45 2008
+++ php-src/ext/standard/php_string.h   Wed Apr  1 17:05:35 2009
@@ -17,7 +17,7 @@
+--+
 */
 
-/* $Id: php_string.h,v 1.87.2.2.2.3.2.4 2008/12/31 11:15:45 sebastian Exp $ */

+/* $Id: php_string.h,v 1.87.2.2.2.3.2.5 2009/04/01 17:05:35 mattwil Exp $ */
 
 /* Synced with php 3.0 revision 1.43 1999-06-16 [ssb] */
 
@@ -138,7 +138,7 @@

 PHPAPI int php_char_to_str_ex(char *str, uint len, char from, char *to, int 
to_len, zval *result, int case_sensitivity, int *replace_count);
 PHPAPI int php_char_to_str(char *str, uint len, char from, char *to, int 
to_len, zval *result);
 PHPAPI void php_implode(zval *delim, zval *arr, zval *return_value TSRMLS_DC);
-PHPAPI void php_explode(zval *delim, zval *str, zval *return_value, int limit);
+PHPAPI void php_explode(zval *delim, zval *str, zval *return_value, long 
limit);
 
 PHPAPI size_t php_strspn(char *s1, char *s2, char *s1_end, char *s2_end); 
 PHPAPI size_t php_strcspn(char *s1, char *s2, char *s1_end, char *s2_end); 
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.69.2.45r2=1.445.2.14.2.69.2.46diff_format=u

Index: php-src/ext/standard/string.c
diff -u php-src/ext/standard/string.c:1.445.2.14.2.69.2.45 
php-src/ext/standard/string.c:1.445.2.14.2.69.2.46
--- php-src/ext/standard/string.c:1.445.2.14.2.69.2.45  Wed Apr  1 14:00:38 2009
+++ php-src/ext/standard/string.c   Wed Apr  1 17:05:35 2009
@@ -18,7 +18,7 @@
+--+
  */
 
-/* $Id: string.c,v 1.445.2.14.2.69.2.45 2009/04/01 14:00:38 iliaa Exp $ */

+/* $Id: string.c,v 1.445.2.14.2.69.2.46 2009/04/01 17:05:35 mattwil Exp $ */
 
 /* Synced with php 3.0 revision 1.193 1999-06-16 [ssb] */
 
@@ -928,7 +928,7 @@
 
 /* {{{ php_explode

  */
-PHPAPI void php_explode(zval *delim, zval *str, zval *return_value, int limit) 
+PHPAPI void php_explode(zval *delim, zval *str, zval *return_value, long limit) 
 {

char *p1, *p2, *endp;
 
@@ -944,7 +944,7 @@

add_next_index_stringl(return_value, p1, p2 - p1, 1);
p1 = p2 + Z_STRLEN_P(delim);
} while ((p2 = php_memnstr(p1, Z_STRVAL_P(delim), Z_STRLEN_P(delim), 
endp)) != NULL 
-(limit == -1 || --limit  1));
+--limit  1);
 
 		if (p1 = endp)

add_next_index_stringl(return_value, p1, endp-p1, 1);
@@ -954,12 +954,10 @@
 
 /* {{{ php_explode_negative_limit

  */
-PHPAPI void 

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard php_string.h string.c /ext/standard/tests/strings bug47546.phpt

2009-04-02 Thread Matt Wilmas

Hi Dmitry, Antony,

- Original Message -
From: Dmitry Stogov
Sent: Thursday, April 02, 2009


Hi Matt,

I suppose the following tests start fail after this patch

explode() function [ext/standard/tests/strings/explode.phpt]
Test explode() function [ext/standard/tests/strings/explode1.phpt]
Test explode() function : usage variations - positive and negative limits 
[ext/standard/tests/strings/explode_variation5.phpt]
Test explode() function : usage variations - misc tests 
[ext/standard/tests/strings/explode_variation6.phpt]


Could you please check them.


Fixed, thanks.


Thanks. Dmitry.


- Matt


Matt Wilmas wrote:

mattwil Wed Apr  1 17:05:37 2009 UTC

  Removed files:   (Branch: PHP_5_3)
/php-src/ext/standard/tests/strings bug47546.phpt
  Modified files:  /php-src NEWS /php-src/ext/standard 
php_string.h string.c Log:

  MFH: explode() stuff:
  - Fixed bug #47560 (explode()'s limit parameter odd behaviour) by 
reverting change for bug #47546 



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pcntl pcntl.c

2009-03-28 Thread Hannes Magnusson
2009/3/28 Matteo Beccati mbecc...@php.net:
 mbeccati                Sat Mar 28 03:21:04 2009 UTC

  Modified files:              (Branch: PHP_5_3)
    /php-src    NEWS
    /php-src/ext/pcntl  pcntl.c
  Log:
  MFH:
  - Fixed bug #47816 (pcntl tests failing on NetBSD)

Remember to close the bug report...

-Hannes

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pdo pdo_dbh.c /ext/pdo/tests bug47769.phpt

2009-03-27 Thread Ilia Alshanetsky

MFB52?


Ilia Alshanetsky




On 26-Mar-09, at 8:53 AM, Felipe Pena wrote:


felipe  Thu Mar 26 12:53:39 2009 UTC

 Added files: (Branch: PHP_5_3)
   /php-src/ext/pdo/tests   bug47769.phpt

 Modified files:
   /php-src NEWS
   /php-src/ext/pdo pdo_dbh.c
 Log:
 MFH: - Fixed bug #47769 (Strange extends PDO)


http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.537r2=1.2027.2.547.2.965.2.538diff_format=u
Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.537 
php-src/NEWS:1.2027.2.547.2.965.2.538
--- php-src/NEWS:1.2027.2.547.2.965.2.537   Thu Mar 26 12:37:52 2009
+++ php-src/NEWSThu Mar 26 12:53:39 2009
@@ -5,6 +5,7 @@
  (Matteo)
- Fixed bug #47771 (Exception during object construction from arg  
call calls

  object's destructor). (Dmitry)
+- Fixed bug #47769 (Strange extends PDO). (Felipe)
- Fixed bug #47714 (autoloading classes inside exception_handler  
leads to

  crashes). (Dmitry)
- Fixed bug #47699 (autoload and late static binding). (Dmitry)
http://cvs.php.net/viewvc.cgi/php-src/ext/pdo/pdo_dbh.c?r1=1.82.2.31.2.17.2.22r2=1.82.2.31.2.17.2.23diff_format=u
Index: php-src/ext/pdo/pdo_dbh.c
diff -u php-src/ext/pdo/pdo_dbh.c:1.82.2.31.2.17.2.22 php-src/ext/ 
pdo/pdo_dbh.c:1.82.2.31.2.17.2.23
--- php-src/ext/pdo/pdo_dbh.c:1.82.2.31.2.17.2.22	Tue Feb 17  
14:42:26 2009

+++ php-src/ext/pdo/pdo_dbh.c   Thu Mar 26 12:53:39 2009
@@ -18,7 +18,7 @@
   
+ 
--+

*/

-/* $Id: pdo_dbh.c,v 1.82.2.31.2.17.2.22 2009/02/17 14:42:26  
johannes Exp $ */
+/* $Id: pdo_dbh.c,v 1.82.2.31.2.17.2.23 2009/03/26 12:53:39 felipe  
Exp $ */


/* The PDO Database Handle Class */

@@ -1333,7 +1333,7 @@
lc_method_name = emalloc(method_len + 1);
zend_str_tolower_copy(lc_method_name, method_name, method_len);

-	if (zend_hash_find(dbh-ce-function_table, lc_method_name,  
method_len+1, (void**)fbc) == FAILURE) {
+	if ((fbc = std_object_handlers.get_method(object_pp, method_name,  
method_len TSRMLS_CC)) == NULL) {

/* not a pre-defined method, nor a user-defined method; check
 * the driver specific methods */
if (!dbh-cls_methods[PDO_DBH_DRIVER_METHOD_KIND_DBH]) {
@@ -1346,23 +1346,13 @@

if 
(zend_hash_find(dbh-cls_methods[PDO_DBH_DRIVER_METHOD_KIND_DBH],
lc_method_name, method_len+1, (void**)fbc) == 
FAILURE) {
-
if (!fbc) {
fbc = NULL;
}
-
-   goto out;
}
-   /* got it */
}

out:
-   if (!fbc) {
-   if (std_object_handlers.get_method) {
-			fbc = std_object_handlers.get_method(object_pp, method_name,  
method_len TSRMLS_CC);

-   }
-   }
-
efree(lc_method_name);
return fbc;
}

http://cvs.php.net/viewvc.cgi/php-src/ext/pdo/tests/bug47769.phpt?view=markuprev=1.1
Index: php-src/ext/pdo/tests/bug47769.phpt
+++ php-src/ext/pdo/tests/bug47769.phpt
--TEST--
Bug #47769 (Strange extends PDO)
--FILE--
?php

class test extends PDO
{
protected function isProtected() {
echo this is a protected method.\n;
}
private function isPrivate() {
echo this is a private method.\n;
}

   public function quote($str, $paramtype = NULL) {
$this-isProtected();
$this-isPrivate();
print $str .\n;
}
}

$test = new test('sqlite:memory');
$test-quote('foo');
$test-isProtected();

?
--EXPECTF--
this is a protected method.
this is a private method.
foo

Fatal error: Call to protected method test::isProtected() from  
context '' in %s on line %d




--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php




--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pdo pdo_dbh.c /ext/pdo/tests bug47769.phpt

2009-03-27 Thread Felipe Pena
Em Sex, 2009-03-27 às 12:25 -0400, Ilia Alshanetsky escreveu:
 MFB52?
 

Done!


 
 
 
 On 26-Mar-09, at 8:53 AM, Felipe Pena wrote:
 
  felipe  Thu Mar 26 12:53:39 2009 UTC
 
   Added files: (Branch: PHP_5_3)
 /php-src/ext/pdo/tests   bug47769.phpt
 
   Modified files:
 /php-src NEWS
 /php-src/ext/pdo pdo_dbh.c
   Log:
   MFH: - Fixed bug #47769 (Strange extends PDO)
 
 
  http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.537r2=1.2027.2.547.2.965.2.538diff_format=u
  Index: php-src/NEWS
  diff -u php-src/NEWS:1.2027.2.547.2.965.2.537 
  php-src/NEWS:1.2027.2.547.2.965.2.538
  --- php-src/NEWS:1.2027.2.547.2.965.2.537   Thu Mar 26 12:37:52 2009
  +++ php-src/NEWSThu Mar 26 12:53:39 2009
  @@ -5,6 +5,7 @@
(Matteo)
  - Fixed bug #47771 (Exception during object construction from arg  
  call calls
object's destructor). (Dmitry)
  +- Fixed bug #47769 (Strange extends PDO). (Felipe)
  - Fixed bug #47714 (autoloading classes inside exception_handler  
  leads to
crashes). (Dmitry)
  - Fixed bug #47699 (autoload and late static binding). (Dmitry)
  http://cvs.php.net/viewvc.cgi/php-src/ext/pdo/pdo_dbh.c?r1=1.82.2.31.2.17.2.22r2=1.82.2.31.2.17.2.23diff_format=u
  Index: php-src/ext/pdo/pdo_dbh.c
  diff -u php-src/ext/pdo/pdo_dbh.c:1.82.2.31.2.17.2.22 php-src/ext/ 
  pdo/pdo_dbh.c:1.82.2.31.2.17.2.23
  --- php-src/ext/pdo/pdo_dbh.c:1.82.2.31.2.17.2.22   Tue Feb 17  
  14:42:26 2009
  +++ php-src/ext/pdo/pdo_dbh.c   Thu Mar 26 12:53:39 2009
  @@ -18,7 +18,7 @@
 
  + 
  --+
  */
 
  -/* $Id: pdo_dbh.c,v 1.82.2.31.2.17.2.22 2009/02/17 14:42:26  
  johannes Exp $ */
  +/* $Id: pdo_dbh.c,v 1.82.2.31.2.17.2.23 2009/03/26 12:53:39 felipe  
  Exp $ */
 
  /* The PDO Database Handle Class */
 
  @@ -1333,7 +1333,7 @@
  lc_method_name = emalloc(method_len + 1);
  zend_str_tolower_copy(lc_method_name, method_name, method_len);
 
  -   if (zend_hash_find(dbh-ce-function_table, lc_method_name,  
  method_len+1, (void**)fbc) == FAILURE) {
  +   if ((fbc = std_object_handlers.get_method(object_pp, method_name,  
  method_len TSRMLS_CC)) == NULL) {
  /* not a pre-defined method, nor a user-defined method; check
   * the driver specific methods */
  if (!dbh-cls_methods[PDO_DBH_DRIVER_METHOD_KIND_DBH]) {
  @@ -1346,23 +1346,13 @@
 
  if 
  (zend_hash_find(dbh-cls_methods[PDO_DBH_DRIVER_METHOD_KIND_DBH],
  lc_method_name, method_len+1, (void**)fbc) == 
  FAILURE) {
  -
  if (!fbc) {
  fbc = NULL;
  }
  -
  -   goto out;
  }
  -   /* got it */
  }
 
  out:
  -   if (!fbc) {
  -   if (std_object_handlers.get_method) {
  -   fbc = std_object_handlers.get_method(object_pp, 
  method_name,  
  method_len TSRMLS_CC);
  -   }
  -   }
  -
  efree(lc_method_name);
  return fbc;
  }
 
  http://cvs.php.net/viewvc.cgi/php-src/ext/pdo/tests/bug47769.phpt?view=markuprev=1.1
  Index: php-src/ext/pdo/tests/bug47769.phpt
  +++ php-src/ext/pdo/tests/bug47769.phpt
  --TEST--
  Bug #47769 (Strange extends PDO)
  --FILE--
  ?php
 
  class test extends PDO
  {
  protected function isProtected() {
  echo this is a protected method.\n;
  }
  private function isPrivate() {
  echo this is a private method.\n;
  }
 
 public function quote($str, $paramtype = NULL) {
  $this-isProtected();
  $this-isPrivate();
  print $str .\n;
  }
  }
 
  $test = new test('sqlite:memory');
  $test-quote('foo');
  $test-isProtected();
 
  ?
  --EXPECTF--
  this is a protected method.
  this is a private method.
  foo
 
  Fatal error: Call to protected method test::isProtected() from  
  context '' in %s on line %d
 
 
 
  -- 
  PHP CVS Mailing List (http://www.php.net/)
  To unsubscribe, visit: http://www.php.net/unsub.php
 
 
-- 
Regards,
Felipe Pena


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/mbstring config.m4 mbstring.dsp /ext/mbstring/libmbfl/filters Makefile.am Makefile.bcc32 mbfilter_cp850.c mbfilter_cp850.h unicode_table_cp850.h /ext/

2009-03-20 Thread Pierre Joye
hi,

what's about HEAD?

2009/3/18 Moriyoshi Koizumi moriyo...@php.net:
 moriyoshi               Wed Mar 18 17:43:55 2009 UTC

  Added files:                 (Branch: PHP_5_3)
    /php-src/ext/mbstring/libmbfl/filters       mbfilter_cp850.c
                                                mbfilter_cp850.h
                                                unicode_table_cp850.h

  Modified files:
    /php-src    NEWS
    /php-src/ext/mbstring       config.m4 mbstring.dsp
    /php-src/ext/mbstring/libmbfl/filters       Makefile.am Makefile.bcc32
    /php-src/ext/mbstring/libmbfl/mbfl  mbfl_consts.h mbfl_convert.c
                                        mbfl_encoding.c mbfl_encoding.h
                                        mbfl_ident.c
  Log:
  - Add support for CP850 encoding (patch by Denis Giffeler)


 --
 PHP CVS Mailing List (http://www.php.net/)
 To unsubscribe, visit: http://www.php.net/unsub.php




-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/bz2 bz2_filter.c

2009-02-05 Thread Jani Taskinen

Greg Beaver wrote:

cellog  Tue Feb  3 18:56:26 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src	NEWS 
/php-src/ext/bz2	bz2_filter.c 
  Log:

  Re-Fixed bug #46026 (bz2.decompress/zlib.inflate filter tries to decompress 
after end of stream)
  
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.484r2=1.2027.2.547.2.965.2.485diff_format=u

Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.484 
php-src/NEWS:1.2027.2.547.2.965.2.485
--- php-src/NEWS:1.2027.2.547.2.965.2.484   Tue Feb  3 18:29:25 2009
+++ php-src/NEWSTue Feb  3 18:56:25 2009
@@ -6,7 +6,8 @@
 - Fixed bug #47085 (rename() returns true even if the file in PHAR does not 
exist). (Greg)
 - Fixed bug #47031 (Fix constants in DualIterator example). (Etienne)
 - Fixed bug #46347 (parse_ini_file() doesn't support * in keys). (Nuno)
-
+- Re-Fixed bug #46026 (bz2.decompress/zlib.inflate filter tries to decompress 
after
+  end of stream). (Greg)


Re-Fixed ? Please don't invent stuff like this into NEWS. It's either 
Fixed or not.


Also, why isn't this fix MFH'd to PHP_5_2?

--Jani



 29 Jan 2009, PHP 5.3.0 Beta 1
 - Upgraded bundled sqlite to version 3.6.10. (Scott, Ilia)
http://cvs.php.net/viewvc.cgi/php-src/ext/bz2/bz2_filter.c?r1=1.3.2.2.2.5.2.6r2=1.3.2.2.2.5.2.7diff_format=u
Index: php-src/ext/bz2/bz2_filter.c
diff -u php-src/ext/bz2/bz2_filter.c:1.3.2.2.2.5.2.6 
php-src/ext/bz2/bz2_filter.c:1.3.2.2.2.5.2.7
--- php-src/ext/bz2/bz2_filter.c:1.3.2.2.2.5.2.6Wed Dec 31 11:15:35 2008
+++ php-src/ext/bz2/bz2_filter.cTue Feb  3 18:56:26 2009
@@ -16,7 +16,7 @@
+--+
 */
 
-/* $Id: bz2_filter.c,v 1.3.2.2.2.5.2.6 2008/12/31 11:15:35 sebastian Exp $ */

+/* $Id: bz2_filter.c,v 1.3.2.2.2.5.2.7 2009/02/03 18:56:26 cellog Exp $ */
 
 #ifdef HAVE_CONFIG_H

 #include config.h
@@ -353,11 +353,14 @@
if (Z_TYPE_P(filterparams) == IS_ARRAY || 
Z_TYPE_P(filterparams) == IS_OBJECT) {
 
 if (SUCCESS == zend_hash_find(HASH_OF(filterparams), concatenated, sizeof(concatenated), (void **) tmpzval) ) {

-   SEPARATE_ZVAL(tmpzval);
-   convert_to_boolean_ex(tmpzval);
-   data-expect_concatenated = 
Z_LVAL_PP(tmpzval);
-   zval_ptr_dtor(tmpzval);
-   tmpzval = NULL;
+   zval tmp, *tmp2;
+
+   tmp = **tmpzval;
+   zval_copy_ctor(tmp);
+   tmp2 = tmp;
+   convert_to_boolean_ex(tmp2);
+   data-expect_concatenated = Z_LVAL(tmp);
+   tmpzval = NULL;
}
 
 zend_hash_find(HASH_OF(filterparams), small, sizeof(small), (void **) tmpzval);

@@ -366,10 +369,13 @@
}
 
 			if (tmpzval) {

-   SEPARATE_ZVAL(tmpzval);
-   convert_to_boolean_ex(tmpzval);
-   data-small_footprint = Z_LVAL_PP(tmpzval);
-   zval_ptr_dtor(tmpzval);
+   zval tmp, *tmp2;
+
+   tmp = **tmpzval;
+   zval_copy_ctor(tmp);
+   tmp2 = tmp;
+   convert_to_boolean_ex(tmp2);
+   data-small_footprint = Z_LVAL(tmp);
}
}
 
@@ -385,26 +391,31 @@

if (Z_TYPE_P(filterparams) == IS_ARRAY || 
Z_TYPE_P(filterparams) == IS_OBJECT) {
if (zend_hash_find(HASH_OF(filterparams), blocks, 
sizeof(blocks), (void**) tmpzval) == SUCCESS) {
/* How much memory to allocate (1 - 9) 
x 100kb */
-   SEPARATE_ZVAL(tmpzval);
-   convert_to_long_ex(tmpzval);
-   if (Z_LVAL_PP(tmpzval)  1 || 
Z_LVAL_PP(tmpzval)  9) {
+   zval tmp;
+   
+   tmp = **tmpzval;
+   zval_copy_ctor(tmp);
+   convert_to_long(tmp);
+   if (Z_LVAL(tmp)  1 || Z_LVAL(tmp)  9) 
{
php_error_docref(NULL TSRMLS_CC, 
E_WARNING, Invalid parameter given for number of blocks to allocate. (%ld), 
Z_LVAL_PP(tmpzval));
} else {
-   blockSize100k = 

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/bz2 bz2_filter.c

2009-02-05 Thread Greg Beaver
Jani Taskinen wrote:
 Greg Beaver wrote:
 cellogTue Feb  3 18:56:26 2009 UTC

   Modified files:  (Branch: PHP_5_3)
 /php-srcNEWS /php-src/ext/bz2bz2_filter.c   Log:
   Re-Fixed bug #46026 (bz2.decompress/zlib.inflate filter tries to
 decompress after end of stream)
  
 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.484r2=1.2027.2.547.2.965.2.485diff_format=u

 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.484
 php-src/NEWS:1.2027.2.547.2.965.2.485
 --- php-src/NEWS:1.2027.2.547.2.965.2.484Tue Feb  3 18:29:25 2009
 +++ php-src/NEWSTue Feb  3 18:56:25 2009
 @@ -6,7 +6,8 @@
  - Fixed bug #47085 (rename() returns true even if the file in PHAR
 does not exist). (Greg)
  - Fixed bug #47031 (Fix constants in DualIterator example). (Etienne)
  - Fixed bug #46347 (parse_ini_file() doesn't support * in keys). (Nuno)
 -
 +- Re-Fixed bug #46026 (bz2.decompress/zlib.inflate filter tries to
 decompress after
 +  end of stream). (Greg)

 Re-Fixed ? Please don't invent stuff like this into NEWS. It's
 either Fixed or not.
sorry for offending your delicate sensibilities.  Feel free to Re-Commit
with the corrected name for Fixed.
 Also, why isn't this fix MFH'd to PHP_5_2? 
The original fix was merged, minus the feature addition, but 5.2 went RC
yesterday, so I didn't think it wise to randomly commit.

Any other questions?

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/bz2 bz2_filter.c

2009-02-05 Thread Jani Taskinen

Greg Beaver kirjoitti:

Jani Taskinen wrote:

Greg Beaver wrote:

cellogTue Feb  3 18:56:26 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-srcNEWS /php-src/ext/bz2bz2_filter.c   Log:
  Re-Fixed bug #46026 (bz2.decompress/zlib.inflate filter tries to
decompress after end of stream)
 
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.484r2=1.2027.2.547.2.965.2.485diff_format=u


Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.484
php-src/NEWS:1.2027.2.547.2.965.2.485
--- php-src/NEWS:1.2027.2.547.2.965.2.484Tue Feb  3 18:29:25 2009
+++ php-src/NEWSTue Feb  3 18:56:25 2009
@@ -6,7 +6,8 @@
 - Fixed bug #47085 (rename() returns true even if the file in PHAR
does not exist). (Greg)
 - Fixed bug #47031 (Fix constants in DualIterator example). (Etienne)
 - Fixed bug #46347 (parse_ini_file() doesn't support * in keys). (Nuno)
-
+- Re-Fixed bug #46026 (bz2.decompress/zlib.inflate filter tries to
decompress after
+  end of stream). (Greg)

Re-Fixed ? Please don't invent stuff like this into NEWS. It's
either Fixed or not.

sorry for offending your delicate sensibilities.  Feel free to Re-Commit
with the corrected name for Fixed.
Also, why isn't this fix MFH'd to PHP_5_2? 

The original fix was merged, minus the feature addition, but 5.2 went RC
yesterday, so I didn't think it wise to randomly commit.

Any other questions?


Yes, did your gerbil die or what's with the attitude?

--Jani



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/bz2 bz2_filter.c

2009-02-05 Thread Greg Beaver
Jani Taskinen wrote:
 Greg Beaver kirjoitti:
 Jani Taskinen wrote:
 Greg Beaver wrote:
 cellogTue Feb  3 18:56:26 2009 UTC

   Modified files:  (Branch: PHP_5_3)
 /php-srcNEWS /php-src/ext/bz2bz2_filter.c   Log:
   Re-Fixed bug #46026 (bz2.decompress/zlib.inflate filter tries to
 decompress after end of stream)
  
 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.484r2=1.2027.2.547.2.965.2.485diff_format=u


 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.484
 php-src/NEWS:1.2027.2.547.2.965.2.485
 --- php-src/NEWS:1.2027.2.547.2.965.2.484Tue Feb  3 18:29:25 2009
 +++ php-src/NEWSTue Feb  3 18:56:25 2009
 @@ -6,7 +6,8 @@
  - Fixed bug #47085 (rename() returns true even if the file in PHAR
 does not exist). (Greg)
  - Fixed bug #47031 (Fix constants in DualIterator example). (Etienne)
  - Fixed bug #46347 (parse_ini_file() doesn't support * in keys).
 (Nuno)
 -
 +- Re-Fixed bug #46026 (bz2.decompress/zlib.inflate filter tries to
 decompress after
 +  end of stream). (Greg)
 Re-Fixed ? Please don't invent stuff like this into NEWS. It's
 either Fixed or not.
 sorry for offending your delicate sensibilities.  Feel free to Re-Commit
 with the corrected name for Fixed.
 Also, why isn't this fix MFH'd to PHP_5_2? 
 The original fix was merged, minus the feature addition, but 5.2 went RC
 yesterday, so I didn't think it wise to randomly commit.

 Any other questions?
 
 Yes, did your gerbil die or what's with the attitude?

:) perhaps it's the barrage of nit-picking messages from 3 different
people over insignificant details (and then the yeah replies) when the
fix itself was a bit of work in the first place?  It's all right though,
I know that none of us can help being smug when others mess up, I do the
same thing in my own special way.

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-01-21 Thread Felipe Pena
Hello,

Em Qua, 2009-01-21 às 08:21 +0100, Kalle Sommer Nielsen escreveu:
 Hi Felipe
 
 2009/1/20 Felipe Pena fel...@php.net:
  felipe  Tue Jan 20 20:28:05 2009 UTC
 
   Modified files:  (Branch: PHP_5_3)
 /php-srcNEWS
   Log:
   BFN #47087
 
  http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.470r2=1.2027.2.547.2.965.2.471diff_format=u
  Index: php-src/NEWS
  diff -u php-src/NEWS:1.2027.2.547.2.965.2.470 
  php-src/NEWS:1.2027.2.547.2.965.2.471
  --- php-src/NEWS:1.2027.2.547.2.965.2.470   Tue Jan 20 11:22:43 2009
  +++ php-src/NEWSTue Jan 20 20:28:04 2009
  @@ -53,6 +53,7 @@
   - Fixed bug #47145 + #47159 (Always free failed SQLite statements). (Scott)
   - Fixed bug #47141 (Unable to fetch error messages from SQLite
when the database can't be opened). (Scott)
  +- Fixed bug #47087 (Second parameter of mssql_fetch_array()). (Felipe)
   - Fixed bug #47050 (mysqli_poll() modifies improper variables). (Johannes)
   - Fixed bug #47045 (SplObjectStorage instances compared with ==). (Etienne)
   - Fixed bug #46979 (use with non-compound name *has* effect). (Dmitry)
 
 Should this have a NEWS entry if it was introduced in one of the alpha's?
 

I think so. If not, all entry related to namespace, sqlite3, mysqlnd
stuff, etc. need be removed too?

-- 
Regards,
Felipe Pena


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-01-20 Thread Kalle Sommer Nielsen
Hi Felipe

2009/1/20 Felipe Pena fel...@php.net:
 felipe  Tue Jan 20 20:28:05 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-srcNEWS
  Log:
  BFN #47087

 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.470r2=1.2027.2.547.2.965.2.471diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.470 
 php-src/NEWS:1.2027.2.547.2.965.2.471
 --- php-src/NEWS:1.2027.2.547.2.965.2.470   Tue Jan 20 11:22:43 2009
 +++ php-src/NEWSTue Jan 20 20:28:04 2009
 @@ -53,6 +53,7 @@
  - Fixed bug #47145 + #47159 (Always free failed SQLite statements). (Scott)
  - Fixed bug #47141 (Unable to fetch error messages from SQLite
   when the database can't be opened). (Scott)
 +- Fixed bug #47087 (Second parameter of mssql_fetch_array()). (Felipe)
  - Fixed bug #47050 (mysqli_poll() modifies improper variables). (Johannes)
  - Fixed bug #47045 (SplObjectStorage instances compared with ==). (Etienne)
  - Fixed bug #46979 (use with non-compound name *has* effect). (Dmitry)

Should this have a NEWS entry if it was introduced in one of the alpha's?


-- 
Kalle Sommer Nielsen

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-01-12 Thread Marcus Boerger
Hello Stanislav,

Monday, January 12, 2009, 10:56:37 PM, you wrote:

 stasMon Jan 12 21:56:37 2009 UTC

   Modified files:  (Branch: PHP_5_3)
 /php-srcNEWS 
   Log:
   report fix 46304
   
   
 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.447r2=1.2027.2.547.2.965.2.448diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.447
 php-src/NEWS:1.2027.2.547.2.965.2.448
 --- php-src/NEWS:1.2027.2.547.2.965.2.447   Mon Jan 12 19:08:25 2009
 +++ php-src/NEWSMon Jan 12 21:56:36 2009
 @@ -46,6 +46,8 @@
  - Fixed bug #46653 (can't extend mysqli). (Johannes)
  - Fixed bug #46646 (Restrict serialization on some internal classes like
Closure and SplFileInfo using exceptions). (Etienne)
 +- Fixed bug #46304 (Defining namespaced constant using define() defines 
 +  CASE SENSITIVE namespace). (Stas)

This was a never released feature, so you do not need a NEWS entry. Please
drop.

  - Fixed bug #46268 (DateTime::modify() does not reset relative time values).
(Derick)
  - Fixed bug #46044 (Mysqli - wrong error message). (Johannes)






Best regards,
 Marcus


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-01-12 Thread Pierre Joye
On Mon, Jan 12, 2009 at 11:05 PM, Marcus Boerger he...@php.net wrote:
 Hello Stanislav,

 Monday, January 12, 2009, 10:56:37 PM, you wrote:

 stasMon Jan 12 21:56:37 2009 UTC

   Modified files:  (Branch: PHP_5_3)
 /php-srcNEWS
   Log:
   report fix 46304


 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.447r2=1.2027.2.547.2.965.2.448diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.447
 php-src/NEWS:1.2027.2.547.2.965.2.448
 --- php-src/NEWS:1.2027.2.547.2.965.2.447   Mon Jan 12 19:08:25 2009
 +++ php-src/NEWSMon Jan 12 21:56:36 2009
 @@ -46,6 +46,8 @@
  - Fixed bug #46653 (can't extend mysqli). (Johannes)
  - Fixed bug #46646 (Restrict serialization on some internal classes like
Closure and SplFileInfo using exceptions). (Etienne)
 +- Fixed bug #46304 (Defining namespaced constant using define() defines
 +  CASE SENSITIVE namespace). (Stas)

 This was a never released feature, so you do not need a NEWS entry. Please
 drop.


It was since the last 5.3 release. The RM will have to merge them, take #23. :)

Cheers,
-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-01-12 Thread Stanislav Malyshev

Hi!


This was a never released feature, so you do not need a NEWS entry. Please
drop.


Do you mean no namespace bugfixes should be in NEWS until 5.3 is released?
--
Stanislav Malyshev, Zend Software Architect
s...@zend.com   http://www.zend.com/
(408)253-8829   MSN: s...@zend.com

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-01-12 Thread Pierre Joye
hi,

As it is nice to listen to Marcus, in this case it is wrong.

How do we know what has been fixed between two test releases? Reading
the commits?

On Mon, Jan 12, 2009 at 11:24 PM, Stanislav Malyshev s...@php.net wrote:
 stasMon Jan 12 22:24:31 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-srcNEWS
  Log:
  ns bugfix out


 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.448r2=1.2027.2.547.2.965.2.449diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.448 
 php-src/NEWS:1.2027.2.547.2.965.2.449
 --- php-src/NEWS:1.2027.2.547.2.965.2.448   Mon Jan 12 21:56:36 2009
 +++ php-src/NEWSMon Jan 12 22:24:31 2009
 @@ -46,8 +46,6 @@
  - Fixed bug #46653 (can't extend mysqli). (Johannes)
  - Fixed bug #46646 (Restrict serialization on some internal classes like
   Closure and SplFileInfo using exceptions). (Etienne)
 -- Fixed bug #46304 (Defining namespaced constant using define() defines
 -  CASE SENSITIVE namespace). (Stas)
  - Fixed bug #46268 (DateTime::modify() does not reset relative time values).
   (Derick)
  - Fixed bug #46044 (Mysqli - wrong error message). (Johannes)



 --
 PHP CVS Mailing List (http://www.php.net/)
 To unsubscribe, visit: http://www.php.net/unsub.php





-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-01-12 Thread Marcus Boerger
Hello Pierre,

Monday, January 12, 2009, 11:21:32 PM, you wrote:

 On Mon, Jan 12, 2009 at 11:05 PM, Marcus Boerger he...@php.net wrote:
 Hello Stanislav,

 Monday, January 12, 2009, 10:56:37 PM, you wrote:

 stasMon Jan 12 21:56:37 2009 UTC

   Modified files:  (Branch: PHP_5_3)
 /php-srcNEWS
   Log:
   report fix 46304


 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.447r2=1.2027.2.547.2.965.2.448diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.447
 php-src/NEWS:1.2027.2.547.2.965.2.448
 --- php-src/NEWS:1.2027.2.547.2.965.2.447   Mon Jan 12 19:08:25 2009
 +++ php-src/NEWSMon Jan 12 21:56:36 2009
 @@ -46,6 +46,8 @@
  - Fixed bug #46653 (can't extend mysqli). (Johannes)
  - Fixed bug #46646 (Restrict serialization on some internal classes like
Closure and SplFileInfo using exceptions). (Etienne)
 +- Fixed bug #46304 (Defining namespaced constant using define() defines
 +  CASE SENSITIVE namespace). (Stas)

 This was a never released feature, so you do not need a NEWS entry. Please
 drop.


 It was since the last 5.3 release. The RM will have to merge them, take #23. 
 :)

There is no merging here. It can only be dropping because there is only one
entry necessary. And that is the one announcing namespaces in the first
place.


Best regards,
 Marcus


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-01-12 Thread Pierre Joye
Hi Marcus,

On Mon, Jan 12, 2009 at 11:33 PM, Marcus Boerger he...@php.net wrote:

 It was since the last 5.3 release. The RM will have to merge them, take #23. 
 :)

 There is no merging here. It can only be dropping because there is only one
 entry necessary. And that is the one announcing namespaces in the first
 place.

In the final 5.3, yes, in the meantime no. How do you trace the
changes between two 5.3 releases (as an enduser)? It is not the 1st
time we discussed that, do we really to do it on each NEWS addition
(well, some only, as other seems to be fine ;)?

Cheers,
-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-01-12 Thread Ilia Alshanetsky

Pierre,

I think it would be a rather a big pain for the RM to have to cull not- 
needed entries from a massive change list before the release. Its way  
simpler to avoid putting them in there all together.



On 12-Jan-09, at 5:44 PM, Pierre Joye wrote:


Hi Marcus,

On Mon, Jan 12, 2009 at 11:33 PM, Marcus Boerger he...@php.net  
wrote:


It was since the last 5.3 release. The RM will have to merge them,  
take #23. :)


There is no merging here. It can only be dropping because there is  
only one
entry necessary. And that is the one announcing namespaces in the  
first

place.


In the final 5.3, yes, in the meantime no. How do you trace the
changes between two 5.3 releases (as an enduser)? It is not the 1st
time we discussed that, do we really to do it on each NEWS addition
(well, some only, as other seems to be fine ;)?

Cheers,
--
Pierre

http://blog.thepimp.net | http://www.libgd.org

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Ilia Alshanetsky





--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-01-10 Thread Marcus Boerger
Hello Antony,

Friday, January 9, 2009, 8:17:08 PM, you wrote:

 tony2001Fri Jan  9 19:17:08 2009 UTC

   Modified files:  (Branch: PHP_5_3)
 /php-srcNEWS 
   Log:
   news
   
   
 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.440r2=1.2027.2.547.2.965.2.441diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.440
 php-src/NEWS:1.2027.2.547.2.965.2.441
 --- php-src/NEWS:1.2027.2.547.2.965.2.440   Fri Jan  9 14:59:30 2009
 +++ php-src/NEWSFri Jan  9 19:17:08 2009
 @@ -24,6 +24,7 @@
  - Added depth parameter to json_decode() to lower the nesting depth from the
maximum if required. (Scott)
  - Added ICU support to SQLite3 when using the bundled version. (Scott)
 +- Added zend_ts_hash_copy_to_hash(). (Tony)

Since when do we mention internal C level changes?

  - Enabled the salsa hashing functions. (Scott)
  
  - Fixed bug #46957 (The tokenizer returns deprecated values). (Felipe)






Best regards,
 Marcus


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-01-09 Thread Hannes Magnusson
On Fri, Jan 9, 2009 at 20:17, Antony Dovgal tony2...@php.net wrote:
 tony2001Fri Jan  9 19:17:08 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-srcNEWS
  Log:
  news


 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.440r2=1.2027.2.547.2.965.2.441diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.440 
 php-src/NEWS:1.2027.2.547.2.965.2.441
 --- php-src/NEWS:1.2027.2.547.2.965.2.440   Fri Jan  9 14:59:30 2009
 +++ php-src/NEWSFri Jan  9 19:17:08 2009
 @@ -24,6 +24,7 @@
  - Added depth parameter to json_decode() to lower the nesting depth from the
   maximum if required. (Scott)
  - Added ICU support to SQLite3 when using the bundled version. (Scott)
 +- Added zend_ts_hash_copy_to_hash(). (Tony)

That really looks like its a userspace function.. maybe reword it to
Added internal function zend_ts_hash_copy_to_hash() for PHP
extensions?

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli php_cli.c /sapi/embed php_embed.c

2009-01-04 Thread Stanislav Malyshev

Hi!


Why?
I'm not aware of any dl()-related problems in FastCGI.


FastCGI is like all other long-running SAPIs, so can't it have the same 
problems httpd has?

--
Stanislav Malyshev, Zend Software Architect
s...@zend.com   http://www.zend.com/
(408)253-8829   MSN: s...@zend.com

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli php_cli.c /sapi/embed php_embed.c

2009-01-04 Thread Steph Fox

Why?
I'm not aware of any dl()-related problems in FastCGI.


FastCGI is like all other long-running SAPIs, so can't it have the same 
problems httpd has?


OK that's confused me... I thought the problem with dl() was purely in 
threaded SAPIs? - otherwise surely it should've been dropped for CLI forever 
ago?


What did I miss?

- Steph

ps Happy new year Stas ;)



--
Stanislav Malyshev, Zend Software Architect
s...@zend.com   http://www.zend.com/
(408)253-8829   MSN: s...@zend.com

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php




--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli php_cli.c /sapi/embed php_embed.c

2009-01-03 Thread Antony Dovgal
On 02.01.2009 07:47, Andi Gutmans wrote:
 Hi Marcus,
 
 I think dl() should also be disabled for FastCGI.

Why?
I'm not aware of any dl()-related problems in FastCGI.

-- 
Wbr, 
Antony Dovgal

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli php_cli.c /sapi/embed php_embed.c

2009-01-02 Thread Marcus Boerger
Hello Andi,

  my main goal was to get rid of dl() for apache and alike modules and get
the c level API changes in. For FastCGI I guess you are right, but I would
appreciate if Dmitry could look into it. As far as I understand the only
thing we have to do is to pass the function table containing the dl() only
if we are not in FastCGI mode. So basically if ther is no -b command line
flag.

marcus

Friday, January 2, 2009, 5:47:09 AM, you wrote:

 Hi Marcus,

 I think dl() should also be disabled for FastCGI.
 It may require a bit of reordering of the code to make this work but I
 think it's the right thing.

 If you bump into any problems then maybe Dmitry could help out but he's
 on vacation for the next couple of weeks.

 Thanks!
 Andi

 -Original Message-
 From: Marcus Boerger [mailto:he...@php.net] 
 Sent: Wednesday, December 31, 2008 6:27 AM
 To: php-cvs@lists.php.net; php...@lists.php.net
 Subject: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard
 basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli
 php_cli.c /sapi/embed php_embed.c 

 helly   Wed Dec 31 14:27:10 2008 UTC

   Modified files:  (Branch: PHP_5_3)
 /php-srcNEWS 
 /php-src/ext/standard   basic_functions.c 
 /php-src/main   SAPI.h main.c 
 /php-src/sapi/cgi   cgi_main.c 
 /php-src/sapi/cli   php_cli.c 
 /php-src/sapi/embed   php_embed.c 
   Log:
   MFH
   - Changed dl() to be disabled by default. Enabled only when explicitly
 registered by the SAPI layer. Enabled only with CLI, CGI and EMBED.
 (Dmitry)
   [DOC]
   
   
 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.428r
 2=1.2027.2.547.2.965.2.429diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.428
 php-src/NEWS:1.2027.2.547.2.965.2.429
 --- php-src/NEWS:1.2027.2.547.2.965.2.428   Tue Dec 30 23:34:29 2008
 +++ php-src/NEWSWed Dec 31 14:27:08 2008
 @@ -6,6 +6,8 @@
  - Deprecated session_register(), session_unregister() and
session_is_registered(). (Hannes)
  
 +- Changed dl() to be disabled by default. Enabled only when explicitly
 +  registered by the SAPI layer. Enabled only with CLI, CGI and EMBED.
 (Dmitry)
  - Changed opendir(), dir() and scandir() to use default context when no
 context
argument is passed. (Sara)
  - Changed open_basedir to allow tightening in runtime contexts. (Sara)
 http://cvs.php.net/viewvc.cgi/php-src/ext/standard/basic_functions.c?r1=
 1.725.2.31.2.64.2.79r2=1.725.2.31.2.64.2.80diff_format=u
 Index: php-src/ext/standard/basic_functions.c
 diff -u php-src/ext/standard/basic_functions.c:1.725.2.31.2.64.2.79
 php-src/ext/standard/basic_functions.c:1.725.2.31.2.64.2.80
 --- php-src/ext/standard/basic_functions.c:1.725.2.31.2.64.2.79   Wed Dec
 31 11:15:44 2008
 +++ php-src/ext/standard/basic_functions.c  Wed Dec 31 14:27:09 2008
 @@ -18,7 +18,7 @@
  
 +--+
   */
  
 -/* $Id: basic_functions.c,v 1.725.2.31.2.64.2.79 2008/12/31 11:15:44
 sebastian Exp $ */
 +/* $Id: basic_functions.c,v 1.725.2.31.2.64.2.80 2008/12/31 14:27:09
 helly Exp $ */
  
  #include php.h
  #include php_streams.h
 @@ -3025,9 +3025,6 @@
 PHP_FE(is_scalar,
 arginfo_is_scalar)
 PHP_FE(is_callable,
 arginfo_is_callable)
  
 -   /* functions from dl.c */
 -   PHP_FE(dl,
 arginfo_dl)
 -
 /* functions from file.c */
 PHP_FE(pclose,
 arginfo_pclose)
 PHP_FE(popen,
 arginfo_popen)
 http://cvs.php.net/viewvc.cgi/php-src/main/SAPI.h?r1=1.114.2.1.2.3.2.5r
 2=1.114.2.1.2.3.2.6diff_format=u
 Index: php-src/main/SAPI.h
 diff -u php-src/main/SAPI.h:1.114.2.1.2.3.2.5
 php-src/main/SAPI.h:1.114.2.1.2.3.2.6
 --- php-src/main/SAPI.h:1.114.2.1.2.3.2.5   Wed Dec 31 11:15:47 2008
 +++ php-src/main/SAPI.h   Wed Dec 31 14:27:09 2008
 @@ -16,7 +16,7 @@
  
 +--+
  */
  
 -/* $Id: SAPI.h,v 1.114.2.1.2.3.2.5 2008/12/31 11:15:47 sebastian Exp $
 */
 +/* $Id: SAPI.h,v 1.114.2.1.2.3.2.6 2008/12/31 14:27:09 helly Exp $ */
  
  #ifndef SAPI_H
  #define SAPI_H
 @@ -264,6 +264,7 @@
 int phpinfo_as_text;
  
 char *ini_entries;
 +   const zend_function_entry *additional_functions;
  };
  
  
 http://cvs.php.net/viewvc.cgi/php-src/main/main.c?r1=1.640.2.23.2.57.2.4
 0r2=1.640.2.23.2.57.2.41diff_format=u
 Index: php-src/main/main.c
 diff -u php-src/main/main.c:1.640.2.23.2.57.2.40
 php-src/main/main.c:1.640.2.23.2.57.2.41
 --- php-src/main/main.c:1.640.2.23.2.57.2.40Wed Dec 31 14:05:22 2008
 +++ php-src/main/main.c   Wed Dec 31 14:27:09 2008
 @@ -18,7 +18,7 @@
  
 +--+
  */
  
 -/* $Id: main.c,v 1.640.2.23.2.57.2.40 2008/12/31 14:05:22 helly Exp $
 */
 +/* $Id: main.c,v 1.640.2.23.2.57.2.41 2008/12/31 14:27:09 helly Exp $
 */
  
  /* {{{ includes
   */
 @@ -1910,6 +1910,15 @@
 

RE: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli php_cli.c /sapi/embed php_embed.c

2009-01-02 Thread Andi Gutmans
Ok will ask him to take a look when he's back.

Cheers,
Andi

 -Original Message-
 From: Marcus Boerger [mailto:he...@php.net]
 Sent: Friday, January 02, 2009 4:04 AM
 To: Andi Gutmans
 Cc: Marcus Boerger; php-cvs@lists.php.net
 Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard
 basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli
php_cli.c
 /sapi/embed php_embed.c
 
 Hello Andi,
 
   my main goal was to get rid of dl() for apache and alike modules and
get
 the c level API changes in. For FastCGI I guess you are right, but I
would
 appreciate if Dmitry could look into it. As far as I understand the
only
 thing we have to do is to pass the function table containing the dl()
only
 if we are not in FastCGI mode. So basically if ther is no -b command
line
 flag.
 
 marcus
 
 Friday, January 2, 2009, 5:47:09 AM, you wrote:
 
  Hi Marcus,
 
  I think dl() should also be disabled for FastCGI.
  It may require a bit of reordering of the code to make this work but
I
  think it's the right thing.
 
  If you bump into any problems then maybe Dmitry could help out but
he's
  on vacation for the next couple of weeks.
 
  Thanks!
  Andi
 
  -Original Message-
  From: Marcus Boerger [mailto:he...@php.net]
  Sent: Wednesday, December 31, 2008 6:27 AM
  To: php-cvs@lists.php.net; php...@lists.php.net
  Subject: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard
  basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli
  php_cli.c /sapi/embed php_embed.c
 
  helly   Wed Dec 31 14:27:10 2008 UTC
 
Modified files:  (Branch: PHP_5_3)
  /php-srcNEWS
  /php-src/ext/standard   basic_functions.c
  /php-src/main   SAPI.h main.c
  /php-src/sapi/cgi   cgi_main.c
  /php-src/sapi/cli   php_cli.c
  /php-src/sapi/embed   php_embed.c
Log:
MFH
- Changed dl() to be disabled by default. Enabled only when
explicitly
  registered by the SAPI layer. Enabled only with CLI, CGI and
EMBED.
  (Dmitry)
[DOC]
 
 
 
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.428r
  2=1.2027.2.547.2.965.2.429diff_format=u
  Index: php-src/NEWS
  diff -u php-src/NEWS:1.2027.2.547.2.965.2.428
  php-src/NEWS:1.2027.2.547.2.965.2.429
  --- php-src/NEWS:1.2027.2.547.2.965.2.428   Tue Dec 30 23:34:29
2008
  +++ php-src/NEWSWed Dec 31 14:27:08 2008
  @@ -6,6 +6,8 @@
   - Deprecated session_register(), session_unregister() and
 session_is_registered(). (Hannes)
 
  +- Changed dl() to be disabled by default. Enabled only when
explicitly
  +  registered by the SAPI layer. Enabled only with CLI, CGI and
EMBED.
  (Dmitry)
   - Changed opendir(), dir() and scandir() to use default context
when no
  context
 argument is passed. (Sara)
   - Changed open_basedir to allow tightening in runtime contexts.
(Sara)
 
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/basic_functions.c?r1=
  1.725.2.31.2.64.2.79r2=1.725.2.31.2.64.2.80diff_format=u
  Index: php-src/ext/standard/basic_functions.c
  diff -u php-src/ext/standard/basic_functions.c:1.725.2.31.2.64.2.79
  php-src/ext/standard/basic_functions.c:1.725.2.31.2.64.2.80
  --- php-src/ext/standard/basic_functions.c:1.725.2.31.2.64.2.79
Wed
 Dec
  31 11:15:44 2008
  +++ php-src/ext/standard/basic_functions.c  Wed Dec 31 14:27:09
2008
  @@ -18,7 +18,7 @@
 
 
+--+
*/
 
  -/* $Id: basic_functions.c,v 1.725.2.31.2.64.2.79 2008/12/31
11:15:44
  sebastian Exp $ */
  +/* $Id: basic_functions.c,v 1.725.2.31.2.64.2.80 2008/12/31
14:27:09
  helly Exp $ */
 
   #include php.h
   #include php_streams.h
  @@ -3025,9 +3025,6 @@
  PHP_FE(is_scalar,
  arginfo_is_scalar)
  PHP_FE(is_callable,
  arginfo_is_callable)
 
  -   /* functions from dl.c */
  -   PHP_FE(dl,
  arginfo_dl)
  -
  /* functions from file.c */
  PHP_FE(pclose,
  arginfo_pclose)
  PHP_FE(popen,
  arginfo_popen)
 
http://cvs.php.net/viewvc.cgi/php-src/main/SAPI.h?r1=1.114.2.1.2.3.2.5r
  2=1.114.2.1.2.3.2.6diff_format=u
  Index: php-src/main/SAPI.h
  diff -u php-src/main/SAPI.h:1.114.2.1.2.3.2.5
  php-src/main/SAPI.h:1.114.2.1.2.3.2.6
  --- php-src/main/SAPI.h:1.114.2.1.2.3.2.5   Wed Dec 31 11:15:47
2008
  +++ php-src/main/SAPI.h   Wed Dec 31 14:27:09 2008
  @@ -16,7 +16,7 @@
 
 
+--+
   */
 
  -/* $Id: SAPI.h,v 1.114.2.1.2.3.2.5 2008/12/31 11:15:47 sebastian
Exp $
  */
  +/* $Id: SAPI.h,v 1.114.2.1.2.3.2.6 2008/12/31 14:27:09 helly Exp $
*/
 
   #ifndef SAPI_H
   #define SAPI_H
  @@ -264,6 +264,7 @@
  int phpinfo_as_text;
 
  char *ini_entries;
  +   const zend_function_entry *additional_functions;
   };
 
 
 
http://cvs.php.net/viewvc.cgi/php-src/main/main.c?r1=1.640.2.23.2.57.2.4
  0r2=1.640.2.23.2.57.2.41diff_format=u
  Index: php-src/main/main.c
  diff -u php-src/main/main.c

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/sockets php_sockets.h sockets.c

2009-01-01 Thread Hannes Magnusson
On Thu, Jan 1, 2009 at 06:24, Kalle Sommer Nielsen ka...@php.net wrote:
 kalle   Thu Jan  1 05:24:30 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-srcNEWS
/php-src/ext/socketsphp_sockets.h sockets.c
  Log:
  MFH:
  [DOC] Renable socket_create_pair() on Windows

  # ext/sockets have its own implementation of socketpair(), perhaps we should 
 move it
  # to the core. This will make stream_socket_pair() available on Windows 
 aswell

 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.431r2=1.2027.2.547.2.965.2.432diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.431 
 php-src/NEWS:1.2027.2.547.2.965.2.432
 --- php-src/NEWS:1.2027.2.547.2.965.2.431   Wed Dec 31 15:45:59 2008
 +++ php-src/NEWSThu Jan  1 05:24:29 2009
 @@ -11,6 +11,7 @@
  - Changed opendir(), dir() and scandir() to use default context when no 
 context
   argument is passed. (Sara)
  - Changed open_basedir to allow tightening in runtime contexts. (Sara)
 +- Re-enabled socket_create_pair() on Windows (Kalle)

  - Added json_last_error() to return any error information from json_decode().
   (Scott)
 http://cvs.php.net/viewvc.cgi/php-src/ext/sockets/php_sockets.h?r1=1.36.2.1.2.4.2.3r2=1.36.2.1.2.4.2.4diff_format=u
 Index: php-src/ext/sockets/php_sockets.h
 diff -u php-src/ext/sockets/php_sockets.h:1.36.2.1.2.4.2.3 
 php-src/ext/sockets/php_sockets.h:1.36.2.1.2.4.2.4
 --- php-src/ext/sockets/php_sockets.h:1.36.2.1.2.4.2.3  Wed Dec 31 11:15:43 
 2008
 +++ php-src/ext/sockets/php_sockets.h   Thu Jan  1 05:24:29 2009
 @@ -22,7 +22,7 @@
  #ifndef PHP_SOCKETS_H
  #define PHP_SOCKETS_H

 -/* $Id: php_sockets.h,v 1.36.2.1.2.4.2.3 2008/12/31 11:15:43 sebastian Exp $ 
 */
 +/* $Id: php_sockets.h,v 1.36.2.1.2.4.2.4 2009/01/01 05:24:29 kalle Exp $ */

  #if HAVE_SOCKETS

 @@ -43,7 +43,7 @@

  PHP_FUNCTION(socket_select);
  PHP_FUNCTION(socket_create_listen);
 -#ifdef HAVE_SOCKETPAIR
 +#if defined(HAVE_SOCKETPAIR) || defined(PHP_WIN32)

Why don't you define HAVE_SOCKETPAIR in config.w32 rather then messing
around with these kind of workarounds?

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/sockets php_sockets.h sockets.c

2009-01-01 Thread Kalle Sommer Nielsen
2009/1/1 Hannes Magnusson hannes.magnus...@gmail.com:
 On Thu, Jan 1, 2009 at 06:24, Kalle Sommer Nielsen ka...@php.net wrote:
 kalle   Thu Jan  1 05:24:30 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-srcNEWS
/php-src/ext/socketsphp_sockets.h sockets.c
  Log:
  MFH:
  [DOC] Renable socket_create_pair() on Windows

  # ext/sockets have its own implementation of socketpair(), perhaps we 
 should move it
  # to the core. This will make stream_socket_pair() available on Windows 
 aswell

 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.431r2=1.2027.2.547.2.965.2.432diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.431 
 php-src/NEWS:1.2027.2.547.2.965.2.432
 --- php-src/NEWS:1.2027.2.547.2.965.2.431   Wed Dec 31 15:45:59 2008
 +++ php-src/NEWSThu Jan  1 05:24:29 2009
 @@ -11,6 +11,7 @@
  - Changed opendir(), dir() and scandir() to use default context when no 
 context
   argument is passed. (Sara)
  - Changed open_basedir to allow tightening in runtime contexts. (Sara)
 +- Re-enabled socket_create_pair() on Windows (Kalle)

  - Added json_last_error() to return any error information from 
 json_decode().
   (Scott)
 http://cvs.php.net/viewvc.cgi/php-src/ext/sockets/php_sockets.h?r1=1.36.2.1.2.4.2.3r2=1.36.2.1.2.4.2.4diff_format=u
 Index: php-src/ext/sockets/php_sockets.h
 diff -u php-src/ext/sockets/php_sockets.h:1.36.2.1.2.4.2.3 
 php-src/ext/sockets/php_sockets.h:1.36.2.1.2.4.2.4
 --- php-src/ext/sockets/php_sockets.h:1.36.2.1.2.4.2.3  Wed Dec 31 11:15:43 
 2008
 +++ php-src/ext/sockets/php_sockets.h   Thu Jan  1 05:24:29 2009
 @@ -22,7 +22,7 @@
  #ifndef PHP_SOCKETS_H
  #define PHP_SOCKETS_H

 -/* $Id: php_sockets.h,v 1.36.2.1.2.4.2.3 2008/12/31 11:15:43 sebastian Exp 
 $ */
 +/* $Id: php_sockets.h,v 1.36.2.1.2.4.2.4 2009/01/01 05:24:29 kalle Exp $ */

  #if HAVE_SOCKETS

 @@ -43,7 +43,7 @@

  PHP_FUNCTION(socket_select);
  PHP_FUNCTION(socket_create_listen);
 -#ifdef HAVE_SOCKETPAIR
 +#if defined(HAVE_SOCKETPAIR) || defined(PHP_WIN32)

 Why don't you define HAVE_SOCKETPAIR in config.w32 rather then messing
 around with these kind of workarounds?


Because of stream_socket_pair(), and then it would only work if
ext/sockets was built too, so unless we move it into the core and
export it then it should be like that.

 -Hannes




-- 
Kalle Sommer Nielsen

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/sockets php_sockets.h sockets.c

2009-01-01 Thread Pierre Joye
hi!

On Thu, Jan 1, 2009 at 7:31 PM, Kalle Sommer Nielsen ka...@php.net wrote:

 Because of stream_socket_pair(), and then it would only work if
 ext/sockets was built too, so unless we move it into the core and
 export it then it should be like that.

Does it even work? I would not enable again this function without
first having tests for it. There is certainly reasons why it was
disabled (well, ext/socket is a reason already...).

Cheers,
-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/sockets php_sockets.h sockets.c

2009-01-01 Thread Kalle Sommer Nielsen
Hi

2009/1/1 Pierre Joye pierre@gmail.com:
 hi!

 On Thu, Jan 1, 2009 at 7:31 PM, Kalle Sommer Nielsen ka...@php.net wrote:

 Because of stream_socket_pair(), and then it would only work if
 ext/sockets was built too, so unless we move it into the core and
 export it then it should be like that.

 Does it even work? I would not enable again this function without
 first having tests for it. There is certainly reasons why it was
 disabled (well, ext/socket is a reason already...).

Like I just said on IRC, it was Jani that added a magic define back
around the time 5.1 was released, which Windows didn't have and it was
disabled:
http://cvs.php.net/viewvc.cgi/php-src/ext/sockets/sockets.c?r1=1.190r2=1.191


 Cheers,
 --
 Pierre

 http://blog.thepimp.net | http://www.libgd.org




-- 
Kalle Sommer Nielsen

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



RE: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli php_cli.c /sapi/embed php_embed.c

2009-01-01 Thread Andi Gutmans
Hi Marcus,

I think dl() should also be disabled for FastCGI.
It may require a bit of reordering of the code to make this work but I
think it's the right thing.

If you bump into any problems then maybe Dmitry could help out but he's
on vacation for the next couple of weeks.

Thanks!
Andi

-Original Message-
From: Marcus Boerger [mailto:he...@php.net] 
Sent: Wednesday, December 31, 2008 6:27 AM
To: php-cvs@lists.php.net; php...@lists.php.net
Subject: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard
basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli
php_cli.c /sapi/embed php_embed.c 

helly   Wed Dec 31 14:27:10 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-srcNEWS 
/php-src/ext/standard   basic_functions.c 
/php-src/main   SAPI.h main.c 
/php-src/sapi/cgi   cgi_main.c 
/php-src/sapi/cli   php_cli.c 
/php-src/sapi/embed php_embed.c 
  Log:
  MFH
  - Changed dl() to be disabled by default. Enabled only when explicitly
registered by the SAPI layer. Enabled only with CLI, CGI and EMBED.
(Dmitry)
  [DOC]
  
  
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.428r
2=1.2027.2.547.2.965.2.429diff_format=u
Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.428
php-src/NEWS:1.2027.2.547.2.965.2.429
--- php-src/NEWS:1.2027.2.547.2.965.2.428   Tue Dec 30 23:34:29 2008
+++ php-src/NEWSWed Dec 31 14:27:08 2008
@@ -6,6 +6,8 @@
 - Deprecated session_register(), session_unregister() and
   session_is_registered(). (Hannes)
 
+- Changed dl() to be disabled by default. Enabled only when explicitly
+  registered by the SAPI layer. Enabled only with CLI, CGI and EMBED.
(Dmitry)
 - Changed opendir(), dir() and scandir() to use default context when no
context
   argument is passed. (Sara)
 - Changed open_basedir to allow tightening in runtime contexts. (Sara)
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/basic_functions.c?r1=
1.725.2.31.2.64.2.79r2=1.725.2.31.2.64.2.80diff_format=u
Index: php-src/ext/standard/basic_functions.c
diff -u php-src/ext/standard/basic_functions.c:1.725.2.31.2.64.2.79
php-src/ext/standard/basic_functions.c:1.725.2.31.2.64.2.80
--- php-src/ext/standard/basic_functions.c:1.725.2.31.2.64.2.79 Wed Dec
31 11:15:44 2008
+++ php-src/ext/standard/basic_functions.c  Wed Dec 31 14:27:09 2008
@@ -18,7 +18,7 @@
 
+--+
  */
 
-/* $Id: basic_functions.c,v 1.725.2.31.2.64.2.79 2008/12/31 11:15:44
sebastian Exp $ */
+/* $Id: basic_functions.c,v 1.725.2.31.2.64.2.80 2008/12/31 14:27:09
helly Exp $ */
 
 #include php.h
 #include php_streams.h
@@ -3025,9 +3025,6 @@
PHP_FE(is_scalar,
arginfo_is_scalar)
PHP_FE(is_callable,
arginfo_is_callable)
 
-   /* functions from dl.c */
-   PHP_FE(dl,
arginfo_dl)
-
/* functions from file.c */
PHP_FE(pclose,
arginfo_pclose)
PHP_FE(popen,
arginfo_popen)
http://cvs.php.net/viewvc.cgi/php-src/main/SAPI.h?r1=1.114.2.1.2.3.2.5r
2=1.114.2.1.2.3.2.6diff_format=u
Index: php-src/main/SAPI.h
diff -u php-src/main/SAPI.h:1.114.2.1.2.3.2.5
php-src/main/SAPI.h:1.114.2.1.2.3.2.6
--- php-src/main/SAPI.h:1.114.2.1.2.3.2.5   Wed Dec 31 11:15:47 2008
+++ php-src/main/SAPI.h Wed Dec 31 14:27:09 2008
@@ -16,7 +16,7 @@
 
+--+
 */
 
-/* $Id: SAPI.h,v 1.114.2.1.2.3.2.5 2008/12/31 11:15:47 sebastian Exp $
*/
+/* $Id: SAPI.h,v 1.114.2.1.2.3.2.6 2008/12/31 14:27:09 helly Exp $ */
 
 #ifndef SAPI_H
 #define SAPI_H
@@ -264,6 +264,7 @@
int phpinfo_as_text;
 
char *ini_entries;
+   const zend_function_entry *additional_functions;
 };
 
 
http://cvs.php.net/viewvc.cgi/php-src/main/main.c?r1=1.640.2.23.2.57.2.4
0r2=1.640.2.23.2.57.2.41diff_format=u
Index: php-src/main/main.c
diff -u php-src/main/main.c:1.640.2.23.2.57.2.40
php-src/main/main.c:1.640.2.23.2.57.2.41
--- php-src/main/main.c:1.640.2.23.2.57.2.40Wed Dec 31 14:05:22 2008
+++ php-src/main/main.c Wed Dec 31 14:27:09 2008
@@ -18,7 +18,7 @@
 
+--+
 */
 
-/* $Id: main.c,v 1.640.2.23.2.57.2.40 2008/12/31 14:05:22 helly Exp $
*/
+/* $Id: main.c,v 1.640.2.23.2.57.2.41 2008/12/31 14:27:09 helly Exp $
*/
 
 /* {{{ includes
  */
@@ -1910,6 +1910,15 @@
/* start Zend extensions */
zend_startup_extensions();
 
+   /* register additional functions */
+   if (sapi_module.additional_functions) {
+   if (zend_hash_find(module_registry, standard,
sizeof(standard), (void**)module)==SUCCESS) {
+   EG(current_module) = module;
+   zend_register_functions(NULL,
sapi_module.additional_functions, NULL, MODULE_PERSISTENT TSRMLS_CC);
+   EG(current_module) = NULL;
+   }
+   }
+   
/* make core report what it should */
if 

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS configure.in /ext/standard basic_functions.c dns.c dns.h /win32/build config.w32.h.in

2008-12-31 Thread Hannes Magnusson
On Wed, Dec 31, 2008 at 15:30, Ilia Alshanetsky il...@php.net wrote:
 iliaa   Wed Dec 31 14:30:38 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src/ext/standard   dns.c dns.h basic_functions.c
/php-srcconfigure.in NEWS
/php-src/win32/buildconfig.w32.h.in
  Log:

  [DOC]
  Added gethostname() to return the current system host name.

 http://cvs.php.net/viewvc.cgi/php-src/ext/standard/dns.c?r1=1.70.2.7.2.5.2.9r2=1.70.2.7.2.5.2.10diff_format=u
 Index: php-src/ext/standard/dns.c
 diff -u php-src/ext/standard/dns.c:1.70.2.7.2.5.2.9 
 php-src/ext/standard/dns.c:1.70.2.7.2.5.2.10
 --- php-src/ext/standard/dns.c:1.70.2.7.2.5.2.9 Wed Dec 31 11:15:44 2008
 +++ php-src/ext/standard/dns.c  Wed Dec 31 14:30:37 2008
 @@ -18,7 +18,7 @@
+--+
  */

 -/* $Id: dns.c,v 1.70.2.7.2.5.2.9 2008/12/31 11:15:44 sebastian Exp $ */
 +/* $Id: dns.c,v 1.70.2.7.2.5.2.10 2008/12/31 14:30:37 iliaa Exp $ */

  /* {{{ includes */
  #include php.h
 @@ -107,6 +107,27 @@
  static char *php_gethostbyaddr(char *ip);
  static char *php_gethostbyname(char *name);

 +#ifdef HAVE_GETHOSTNAME
 +/* {{{ proto string gethostname()
 +   Get the host name of the current machine */
 +PHP_FUNCTION(gethostname)
 +{
 +   char buf[4096];
 +
 +   if (zend_parse_parameters_none() == FAILURE) {
 +   WRONG_PARAM_COUNT;

This will throw one extra wrong parameter count warning.
Just use return; like with zend_parse_parameters().

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli php_cli.c /sapi/embed php_embed.c

2008-12-31 Thread Pierre Joye
hi Marcus,

On Wed, Dec 31, 2008 at 3:27 PM, Marcus Boerger he...@php.net wrote:


   arginfo_popen)
 http://cvs.php.net/viewvc.cgi/php-src/main/SAPI.h?r1=1.114.2.1.2.3.2.5r2=1.114.2.1.2.3.2.6diff_format=u
 Index: php-src/main/SAPI.h
 diff -u php-src/main/SAPI.h:1.114.2.1.2.3.2.5 
 php-src/main/SAPI.h:1.114.2.1.2.3.2.6
 --- php-src/main/SAPI.h:1.114.2.1.2.3.2.5   Wed Dec 31 11:15:47 2008
 +++ php-src/main/SAPI.h Wed Dec 31 14:27:09 2008
 @@ -16,7 +16,7 @@
+--+
  */

 -/* $Id: SAPI.h,v 1.114.2.1.2.3.2.5 2008/12/31 11:15:47 sebastian Exp $ */
 +/* $Id: SAPI.h,v 1.114.2.1.2.3.2.6 2008/12/31 14:27:09 helly Exp $ */

  #ifndef SAPI_H
  #define SAPI_H
 @@ -264,6 +264,7 @@
int phpinfo_as_text;

char *ini_entries;
 +   const zend_function_entry *additional_functions;
  };

This addition breaks the builds, zend_function_entry is not defined at
this point and breaks as long as one includes SAPI.h (like
ext/filter). Should zend_API.h not included in zend.h? or do you want
to manually include it in mainco?

Cheers,
--
Pierre

http://blog.thepimp.net | http://www.libgd.org

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-12-18 Thread Jani Taskinen

AFAIK, PHP_5_2 is still open for bug fixes. Why not commit there too?

--Jani


Stanislav Malyshev wrote:

stasWed Dec 17 11:36:34 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src	NEWS 
  Log:

  report fix
  
  
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.416r2=1.2027.2.547.2.965.2.417diff_format=u

Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.416 
php-src/NEWS:1.2027.2.547.2.965.2.417
--- php-src/NEWS:1.2027.2.547.2.965.2.416   Tue Dec 16 12:54:05 2008
+++ php-src/NEWSWed Dec 17 11:36:34 2008
@@ -14,6 +14,8 @@
   given bad data). (Ilia)
 - Fixed bug #46738 (Segfault when mb_detect_encoding() fails). (Scott)
 - Fixed bug #46681 (mkdir() fails silently on PHP 5.3). (Hannes)
+- Fixed bug #46005 (User not consistently logged under Apache2). 
+  (admorten at umich dot edu, Stas)

 - Fixed bug #45989 (json_decode() doesn't return NULL on certain
   invalid strings). (magicaltux, Scott)
 







--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-12-18 Thread Hannes Magnusson
It's not: http://news.php.net/php.internals/42202

-Hannes

On Thu, Dec 18, 2008 at 12:20, Jani Taskinen jani.taski...@sci.fi wrote:
 AFAIK, PHP_5_2 is still open for bug fixes. Why not commit there too?

 --Jani


 Stanislav Malyshev wrote:

 stasWed Dec 17 11:36:34 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-srcNEWS  Log:
  report fix

  
 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.416r2=1.2027.2.547.2.965.2.417diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.416
 php-src/NEWS:1.2027.2.547.2.965.2.417
 --- php-src/NEWS:1.2027.2.547.2.965.2.416   Tue Dec 16 12:54:05 2008
 +++ php-src/NEWSWed Dec 17 11:36:34 2008
 @@ -14,6 +14,8 @@
   given bad data). (Ilia)
  - Fixed bug #46738 (Segfault when mb_detect_encoding() fails). (Scott)
  - Fixed bug #46681 (mkdir() fails silently on PHP 5.3). (Hannes)
 +- Fixed bug #46005 (User not consistently logged under Apache2). +
  (admorten at umich dot edu, Stas)
  - Fixed bug #45989 (json_decode() doesn't return NULL on certain
   invalid strings). (magicaltux, Scott)





 --
 PHP CVS Mailing List (http://www.php.net/)
 To unsubscribe, visit: http://www.php.net/unsub.php



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-12-18 Thread Jani Taskinen
This is rather critical bug. And preferring something is something 
else than enforcing it..


--Jani


Hannes Magnusson wrote:

It's not: http://news.php.net/php.internals/42202

-Hannes

On Thu, Dec 18, 2008 at 12:20, Jani Taskinen jani.taski...@sci.fi wrote:

AFAIK, PHP_5_2 is still open for bug fixes. Why not commit there too?

--Jani


Stanislav Malyshev wrote:

stasWed Dec 17 11:36:34 2008 UTC

 Modified files:  (Branch: PHP_5_3)
   /php-srcNEWS  Log:
 report fix

 
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.416r2=1.2027.2.547.2.965.2.417diff_format=u
Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.416
php-src/NEWS:1.2027.2.547.2.965.2.417
--- php-src/NEWS:1.2027.2.547.2.965.2.416   Tue Dec 16 12:54:05 2008
+++ php-src/NEWSWed Dec 17 11:36:34 2008
@@ -14,6 +14,8 @@
  given bad data). (Ilia)
 - Fixed bug #46738 (Segfault when mb_detect_encoding() fails). (Scott)
 - Fixed bug #46681 (mkdir() fails silently on PHP 5.3). (Hannes)
+- Fixed bug #46005 (User not consistently logged under Apache2). +
 (admorten at umich dot edu, Stas)
 - Fixed bug #45989 (json_decode() doesn't return NULL on certain
  invalid strings). (magicaltux, Scott)





--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php





--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-12-18 Thread Stanislav Malyshev

Hi!

This is rather critical bug. And preferring something is something 
else than enforcing it..


If Ilia OKs it, I'll merge it.
--
Stanislav Malyshev, Zend Software Architect
s...@zend.com   http://www.zend.com/
(408)253-8829   MSN: s...@zend.com

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-12-18 Thread Ilia Alshanetsky

This is a pretty important bug fix IMO,  please MFH it to 5.2


On 18-Dec-08, at 7:18 AM, Stanislav Malyshev wrote:


Hi!

This is rather critical bug. And preferring something is  
something else than enforcing it..


If Ilia OKs it, I'll merge it.
--
Stanislav Malyshev, Zend Software Architect
s...@zend.com   http://www.zend.com/
(408)253-8829   MSN: s...@zend.com

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Ilia Alshanetsky





--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-12-18 Thread Stanislav Malyshev

Hi!


This is a pretty important bug fix IMO,  please MFH it to 5.2


done
--
Stanislav Malyshev, Zend Software Architect
s...@zend.com   http://www.zend.com/
(408)253-8829   MSN: s...@zend.com

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard/tests/directory open_basedir_001.phpt /main fopen_wrappers.c fopen_wrappers.h

2008-12-09 Thread Hannes Magnusson
Fail.

open_basedir can as of 5.3.0 be set at run time to tighten the path.
I.e. if open_basedir=/usr/local in php.ini you can
ini_set(open_basedir, /usr/local/bin) at runtime.
trying to remove stuff from open_basedir (i.e. ini_set(open_basedir,
/usr);) fails.

-Hannes

On Tue, Dec 9, 2008 at 11:20, Hannes Magnusson [EMAIL PROTECTED] wrote:
 bjori   Tue Dec  9 10:20:11 2008 UTC

  Added files: (Branch: PHP_5_3)
/php-src/ext/standard/tests/directory   open_basedir_001.phpt

  Modified files:
/php-srcNEWS
/php-src/main   fopen_wrappers.c fopen_wrappers.h
  Log:
  MFH: - Changed open_basedir to allow tightening in runtime contexts. (Sara)
  - Add test



 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.405r2=1.2027.2.547.2.965.2.406diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.405 
 php-src/NEWS:1.2027.2.547.2.965.2.406
 --- php-src/NEWS:1.2027.2.547.2.965.2.405   Tue Dec  9 10:12:21 2008
 +++ php-src/NEWSTue Dec  9 10:20:11 2008
 @@ -3,6 +3,7 @@
  ?? ??? 200?, PHP 5.3.0 Alpha 4
  - Changed opendir/dir/scandir to use default context
   when no context argument is passed. (Sara)
 +- Changed open_basedir to allow tightening in runtime contexts. (Sara)

  - Fixed bug #46811 ini_set() doesn't return false on failure. (Hannes)

 http://cvs.php.net/viewvc.cgi/php-src/main/fopen_wrappers.c?r1=1.175.2.3.2.13.2.13r2=1.175.2.3.2.13.2.14diff_format=u
 Index: php-src/main/fopen_wrappers.c
 diff -u php-src/main/fopen_wrappers.c:1.175.2.3.2.13.2.13 
 php-src/main/fopen_wrappers.c:1.175.2.3.2.13.2.14
 --- php-src/main/fopen_wrappers.c:1.175.2.3.2.13.2.13   Mon Aug 11 15:33:02 
 2008
 +++ php-src/main/fopen_wrappers.c   Tue Dec  9 10:20:11 2008
 @@ -17,7 +17,7 @@
+--+
  */

 -/* $Id: fopen_wrappers.c,v 1.175.2.3.2.13.2.13 2008/08/11 15:33:02 lbarnaud 
 Exp $ */
 +/* $Id: fopen_wrappers.c,v 1.175.2.3.2.13.2.14 2008/12/09 10:20:11 bjori Exp 
 $ */

  /* {{{ includes
  */
 @@ -79,6 +79,62 @@
  #endif
  /* }}} */

 +/* {{{ OnUpdateBaseDir
 +Allows any change to open_basedir setting in during Startup and Shutdown 
 events,
 +or a tightening during activation/runtime/deactivation */
 +PHPAPI ZEND_INI_MH(OnUpdateBaseDir)
 +{
 +   char **p, *pathbuf, *ptr, *end;
 +#ifndef ZTS
 +   char *base = (char *) mh_arg2;
 +#else
 +   char *base = (char *) ts_resource(*((int *) mh_arg2));
 +#endif
 +
 +   p = (char **) (base + (size_t) mh_arg1);
 +
 +   if (stage == PHP_INI_STAGE_STARTUP || stage == 
 PHP_INI_STAGE_SHUTDOWN) {
 +   /* We're in a PHP_INI_SYSTEM context, no restrictions */
 +   *p = new_value;
 +   return SUCCESS;
 +   }
 +
 +   /* Otherwise we're in runtime */
 +   if (!*p || !**p) {
 +   /* open_basedir not set yet, go ahead and give it a value */
 +   *p = new_value;
 +   return SUCCESS;
 +   }
 +
 +   /* Shortcut: When we have a open_basedir and someone tries to unset, 
 we know it'll fail */
 +   if (!new_value || !*new_value) {
 +   return FAILURE;
 +   }
 +
 +   /* Is the proposed open_basedir at least as restrictive as the 
 current setting? */
 +   ptr = pathbuf = estrdup(new_value);
 +   while (ptr  *ptr) {
 +   end = strchr(ptr, DEFAULT_DIR_SEPARATOR);
 +   if (end != NULL) {
 +   *end = '\0';
 +   end++;
 +   }
 +   if (php_check_open_basedir_ex(ptr, 0 TSRMLS_CC) != 0) {
 +   /* At least one portion of this open_basedir is less 
 restrictive than the prior one, FAIL */
 +   efree(pathbuf);
 +   return FAILURE;
 +   }
 +   ptr = end;
 +   }
 +   efree(pathbuf);
 +
 +   /* Everything checks out, set it */
 +   *p = new_value;
 +
 +   return SUCCESS;
 +}
 +/* }}} */
 +
  /* {{{ php_check_specific_open_basedir
When open_basedir is not NULL, check if the given filename is located 
 in
open_basedir. Returns -1 if error or not in the open_basedir, else 0.
 http://cvs.php.net/viewvc.cgi/php-src/main/fopen_wrappers.h?r1=1.44.2.1.2.2.2.4r2=1.44.2.1.2.2.2.5diff_format=u
 Index: php-src/main/fopen_wrappers.h
 diff -u php-src/main/fopen_wrappers.h:1.44.2.1.2.2.2.4 
 php-src/main/fopen_wrappers.h:1.44.2.1.2.2.2.5
 --- php-src/main/fopen_wrappers.h:1.44.2.1.2.2.2.4  Mon Aug 11 15:33:02 
 2008
 +++ php-src/main/fopen_wrappers.h   Tue Dec  9 10:20:11 2008
 @@ -16,13 +16,14 @@
+--+
  */

 -/* $Id: fopen_wrappers.h,v 1.44.2.1.2.2.2.4 2008/08/11 15:33:02 lbarnaud Exp 
 $ */
 +/* $Id: fopen_wrappers.h,v 1.44.2.1.2.2.2.5 2008/12/09 10:20:11 bjori Exp $ 
 */

  #ifndef FOPEN_WRAPPERS_H
  #define FOPEN_WRAPPERS_H

  BEGIN_EXTERN_C()

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/reflection php_reflection.c /ext/reflection/tests ReflectionFunction_getNamespaceName.phpt reflectionClass_getNamespaceName.phpt /ext/standard credits.c

2008-11-10 Thread Hannes Magnusson
2008/11/4 Marcus Boerger [EMAIL PROTECTED]:
 helly   Tue Nov  4 15:59:00 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-srcNEWS
/ZendEngine2zend_API.c zend_API.h zend_compile.c zend_compile.h
zend_constants.c zend_execute_API.c
zend_language_parser.y zend_language_scanner.c
zend_language_scanner.l zend_language_scanner_defs.h
zend_vm_def.h zend_vm_execute.h
/ZendEngine2/tests  bug42802.phpt bug42819.phpt bug42820.phpt
bug42859.phpt bug43183.phpt bug43332_1.phpt
bug43332_2.phpt bug43343.phpt bug43344_10.phpt
bug43344_11.phpt bug43344_12.phpt
bug43344_13.phpt bug43344_2.phpt bug43344_3.phpt
bug43344_4.phpt bug43344_5.phpt bug43344_6.phpt
bug43344_7.phpt bug43344_8.phpt bug43344_9.phpt
bug43651.phpt bug44653.phpt class_alias_012.phpt
class_alias_013.phpt class_alias_015.phpt
class_alias_016.phpt class_alias_019.phpt
class_alias_020.phpt class_alias_021.phpt
class_constants_004.phpt class_exists_001.phpt
constants_003.phpt constants_004.phpt
constants_006.phpt constants_009.phpt
inter_02.phpt interface_exists_002.phpt
lsb_014.phpt ns_001.phpt ns_002.phpt ns_003.phpt
ns_004.phpt ns_005.phpt ns_006.phpt ns_007.phpt
ns_008.phpt ns_009.phpt ns_010.phpt ns_011.phpt
ns_012.phpt ns_013.phpt ns_014.phpt ns_015.phpt
ns_016.phpt ns_017.phpt ns_018.phpt ns_019.phpt
ns_020.phpt ns_021.phpt ns_022.phpt ns_023.phpt
ns_025.phpt ns_026.phpt ns_027.inc ns_027.phpt
ns_028.phpt ns_029.phpt ns_030.phpt ns_031.phpt
ns_032.phpt ns_034.phpt ns_035.phpt ns_036.phpt
ns_037.phpt ns_038.phpt ns_040.phpt ns_041.phpt
ns_042.phpt ns_043.phpt ns_044.phpt ns_045.phpt
ns_046.phpt ns_047.phpt ns_048.phpt ns_049.phpt
ns_050.phpt ns_051.phpt ns_052.phpt ns_053.phpt
ns_054.phpt ns_055.phpt ns_056.phpt ns_057.phpt
ns_058.phpt ns_060.phpt ns_061.phpt ns_062.phpt
ns_064.phpt ns_065.inc ns_065.phpt ns_066.phpt
ns_067.inc ns_067.phpt
/php-src/ext/reflection php_reflection.c
/php-src/ext/reflection/tests

 ReflectionFunction_getNamespaceName.phpt
reflectionClass_getNamespaceName.phpt
/php-src/ext/standard   credits.c var_unserializer.c
var_unserializer.re
  Log:
  - Next step in namespaces, using / as namespace separator.

Ironic commit message, but shouldn't this be MFBed? :)

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-11-10 Thread Kalle Sommer Nielsen
2008/11/10 David Coallier [EMAIL PROTECTED]:
 davidc  Mon Nov 10 18:54:30 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-srcNEWS
  Log:
  - Added resolution of bug #44153, #44154


 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.373r2=1.2027.2.547.2.965.2.374diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.373 
 php-src/NEWS:1.2027.2.547.2.965.2.374
 --- php-src/NEWS:1.2027.2.547.2.965.2.373   Mon Nov 10 14:45:30 2008
 +++ php-src/NEWSMon Nov 10 18:54:30 2008
 @@ -3575,3 +3575,7 @@
  - Fixed bug #28694 (ReflectionExtension::getFunctions() crashes PHP). 
 (Marcus)
  - Fixed bug #28512 (Allocate enough space to store MSSQL data). (Frank)
  - Fixed strip_tags() to correctly handle '\0' characters. (Stefan)
 +- Fixed bug #44153 (pdo-errorCode() returns NULL when there are no errors).
 +  (David C.)
 +- Fixed bug #44154 (pdo-errorInfo() always have three elements in the
 +  returned array). (David C.)


That a wrong order :), Bugs should be sorted by id decreasing:
#44154
#44153
...
#28694
#28512


Also aren't these in HEAD or did I miss the commits? If not then
please remember HEAD first or Jani will kill some bunnies :)



 --
 PHP CVS Mailing List (http://www.php.net/)
 To unsubscribe, visit: http://www.php.net/unsub.php





-- 
Kalle Sommer Nielsen

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-11-10 Thread David Coallier

 Also aren't these in HEAD or did I miss the commits? If not then
 please remember HEAD first or Jani will kill some bunnies :)


Those aren't commited but were made on HEAD first. I have a few
compiling issues right now so as soon as HEAD is back on track. But no
no didn't forget, head before branch :)


-- 
Slan,
David

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-11-10 Thread Kalle Sommer Nielsen
2008/11/10 David Coallier [EMAIL PROTECTED]:

 Also aren't these in HEAD or did I miss the commits? If not then
 please remember HEAD first or Jani will kill some bunnies :)


 Those aren't commited but were made on HEAD first. I have a few
 compiling issues right now so as soon as HEAD is back on track. But no
 no didn't forget, head before branch :)

Hmm, HEAD compiles for for me (latest checkout, 5 minutes old) on
Windows Vista with VC++ 9 with a normal configure without any
parameters.



 --
 Slan,
 David




-- 
Kalle Sommer Nielsen

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-11-10 Thread David Coallier
 Hmm, HEAD compiles for for me (latest checkout, 5 minutes old) on
 Windows Vista with VC++ 9 with a normal configure without any
 parameters.


I know it's not related to PHP. I have been playing with some system
headers and now I have to revert back. It's not related to PHP but to
personal tests.

-- 
Slan,
David

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS acinclude.m4 configure.in

2008-11-06 Thread Hannes Magnusson
On Thu, Nov 6, 2008 at 21:42, David Soria Parra [EMAIL PROTECTED] wrote:
 dsp Thu Nov  6 20:42:12 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-srcacinclude.m4 configure.in NEWS
  Log:
  MFH: Detect Sun C compiler and set default flags if it is used
[...]
 +- Added default flags for suncc compiler. (David Soria Parra)

Thats great.. what are those default flags and why should I care?

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS acinclude.m4 configure.in

2008-11-06 Thread David Soria Parra

Hannes Magnusson wrote:

On Thu, Nov 6, 2008 at 21:42, David Soria Parra [EMAIL PROTECTED] wrote:

dsp Thu Nov  6 20:42:12 2008 UTC

 Modified files:  (Branch: PHP_5_3)
   /php-srcacinclude.m4 configure.in NEWS
 Log:
 MFH: Detect Sun C compiler and set default flags if it is used

[...]

+- Added default flags for suncc compiler. (David Soria Parra)


Thats great.. what are those default flags and why should I care?

Hi Hannes,

so the complete list is at 
http://docs.sun.com/app/docs/doc/819-5265/bjapp?a=view but let me get 
through the most important parts of the list:


xtarget=native
Causes to generate processor specific code.

xalias_level=basic
does optimization based on basic assumptions about the c types e.g. 
float* will not point to int*.


fsimple=2
will simplify floating point arithmetic

xipo=1
will do an analysis of all object files and try to optimize across all 
object files.


xlibmopt
optimize math routines, according to the documentation this might result 
in slight differences to the std math lib. But I asked some sun 
engineers and it was considered safe.


So actually I picked options that usually are set by the -fast option, 
but removed the onces that might cause problems. That's why the list is 
that long and that's even why I don't use -xO5 but -xO4 to not run in 
errors (this was recommand by some webstack guy).


The only sad thing is that you still need to set the compiler using the 
CC env variable as by default we are looking for gcc and ignoring other 
compilers even though they are the default cc compiler on those 
machines. I acutally think that this is not desirable.


David

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS acinclude.m4 configure.in

2008-11-06 Thread Hannes Magnusson
On Thu, Nov 6, 2008 at 22:14, David Soria Parra [EMAIL PROTECTED] wrote:
 Hannes Magnusson wrote:

 On Thu, Nov 6, 2008 at 21:42, David Soria Parra [EMAIL PROTECTED] wrote:

 dsp Thu Nov  6 20:42:12 2008 UTC

  Modified files:  (Branch: PHP_5_3)
   /php-srcacinclude.m4 configure.in NEWS
  Log:
  MFH: Detect Sun C compiler and set default flags if it is used

 [...]

 +- Added default flags for suncc compiler. (David Soria Parra)

 Thats great.. what are those default flags and why should I care?

 Hi Hannes,

 so the complete list is at
 http://docs.sun.com/app/docs/doc/819-5265/bjapp?a=view but let me get

Sorry for not being literal enough: How should the end-user know what
this news entry means, and should he pay special attentions to it?
Should he search our docs for which flags does PHP set by default for
suncc?

Being slightly more verbose in the NEWS isn't a bad thing - and if
this is something important then you should document it too.

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/reflection php_reflection.c /ext/reflection/tests ReflectionFunction_getNamespaceName.phpt reflectionClass_getNamespaceName.phpt /ext/standard credit

2008-11-04 Thread Marcus Boerger
Hello all,

  thanks Greg, I only found one important issue prior to submitting this.

marcus

Tuesday, November 4, 2008, 4:59:00 PM, you wrote:

 helly   Tue Nov  4 15:59:00 2008 UTC

   Modified files:  (Branch: PHP_5_3)
 /php-srcNEWS 
 /ZendEngine2zend_API.c zend_API.h zend_compile.c zend_compile.h
 zend_constants.c zend_execute_API.c 
 zend_language_parser.y zend_language_scanner.c 
 zend_language_scanner.l zend_language_scanner_defs.h
 zend_vm_def.h zend_vm_execute.h 
 /ZendEngine2/tests  bug42802.phpt bug42819.phpt bug42820.phpt 
 bug42859.phpt bug43183.phpt bug43332_1.phpt 
 bug43332_2.phpt bug43343.phpt bug43344_10.phpt 
 bug43344_11.phpt bug43344_12.phpt 
 bug43344_13.phpt bug43344_2.phpt bug43344_3.phpt 
 bug43344_4.phpt bug43344_5.phpt bug43344_6.phpt 
 bug43344_7.phpt bug43344_8.phpt bug43344_9.phpt 
 bug43651.phpt bug44653.phpt class_alias_012.phpt 
 class_alias_013.phpt class_alias_015.phpt 
 class_alias_016.phpt class_alias_019.phpt 
 class_alias_020.phpt class_alias_021.phpt 
 class_constants_004.phpt class_exists_001.phpt 
 constants_003.phpt constants_004.phpt 
 constants_006.phpt constants_009.phpt 
 inter_02.phpt interface_exists_002.phpt 
 lsb_014.phpt ns_001.phpt ns_002.phpt ns_003.phpt 
 ns_004.phpt ns_005.phpt ns_006.phpt ns_007.phpt 
 ns_008.phpt ns_009.phpt ns_010.phpt ns_011.phpt 
 ns_012.phpt ns_013.phpt ns_014.phpt ns_015.phpt 
 ns_016.phpt ns_017.phpt ns_018.phpt ns_019.phpt 
 ns_020.phpt ns_021.phpt ns_022.phpt ns_023.phpt 
 ns_025.phpt ns_026.phpt ns_027.inc ns_027.phpt 
 ns_028.phpt ns_029.phpt ns_030.phpt ns_031.phpt 
 ns_032.phpt ns_034.phpt ns_035.phpt ns_036.phpt 
 ns_037.phpt ns_038.phpt ns_040.phpt ns_041.phpt 
 ns_042.phpt ns_043.phpt ns_044.phpt ns_045.phpt 
 ns_046.phpt ns_047.phpt ns_048.phpt ns_049.phpt 
 ns_050.phpt ns_051.phpt ns_052.phpt ns_053.phpt 
 ns_054.phpt ns_055.phpt ns_056.phpt ns_057.phpt 
 ns_058.phpt ns_060.phpt ns_061.phpt ns_062.phpt 
 ns_064.phpt ns_065.inc ns_065.phpt ns_066.phpt 
 ns_067.inc ns_067.phpt 
 /php-src/ext/reflection php_reflection.c 
 /php-src/ext/reflection/tests   

 ReflectionFunction_getNamespaceName.phpt 

 reflectionClass_getNamespaceName.phpt 
 /php-src/ext/standard   credits.c var_unserializer.c 
 var_unserializer.re 
   Log:
   - Next step in namespaces, using / as namespace separator.
   
   



Best regards,
 Marcus


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /sapi/cgi cgi_main.c fastcgi.c fastcgi.h

2008-10-21 Thread Jani Taskinen

Isn't this a bug fix? Where's the MFH to PHP_5_2 ?

--Jani


Arnaud Le Blanc wrote:

lbarnaudTue Oct 21 03:19:28 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src	NEWS 
/php-src/sapi/cgi	cgi_main.c fastcgi.c fastcgi.h 
  Log:

  MFH: Fixed FCGI_GET_VALUES requests (fixes #45522)
  
  
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.345r2=1.2027.2.547.2.965.2.346diff_format=u

Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.345 
php-src/NEWS:1.2027.2.547.2.965.2.346
--- php-src/NEWS:1.2027.2.547.2.965.2.345   Wed Oct 15 18:41:57 2008
+++ php-src/NEWSTue Oct 21 03:19:28 2008
@@ -48,6 +48,8 @@
   (Christian Schneider, Arnaud)
 - Fixed bug #45911 (Cannot disable ext/hash). (Arnaud)
 - Fixed bug #45907 (undefined reference to 'PHP_SHA512Init'). (Greg)
+- Fixed buf #45522 (FCGI_GET_VALUES request does not return supplied values).
+  (Arnaud)
 - Fixed bug #45392 (ob_start()/ob_end_clean() and memory_limit). (Ilia)
 - Fixed bug #45382 (timeout bug in stream_socket_enable_crypto).
   (vnegrier at optilian dot com, Ilia)
http://cvs.php.net/viewvc.cgi/php-src/sapi/cgi/cgi_main.c?r1=1.267.2.15.2.50.2.29r2=1.267.2.15.2.50.2.30diff_format=u
Index: php-src/sapi/cgi/cgi_main.c
diff -u php-src/sapi/cgi/cgi_main.c:1.267.2.15.2.50.2.29 
php-src/sapi/cgi/cgi_main.c:1.267.2.15.2.50.2.30
--- php-src/sapi/cgi/cgi_main.c:1.267.2.15.2.50.2.29Fri Oct 17 01:31:12 2008
+++ php-src/sapi/cgi/cgi_main.c Tue Oct 21 03:19:28 2008
@@ -21,7 +21,7 @@
+--+
 */
 
-/* $Id: cgi_main.c,v 1.267.2.15.2.50.2.29 2008/10/17 01:31:12 iliaa Exp $ */

+/* $Id: cgi_main.c,v 1.267.2.15.2.50.2.30 2008/10/21 03:19:28 lbarnaud Exp $ */
 
 #include php.h

 #include php_globals.h
@@ -1608,11 +1608,18 @@
 #ifndef PHP_WIN32
/* Pre-fork, if required */
if (getenv(PHP_FCGI_CHILDREN)) {
-   children = atoi(getenv(PHP_FCGI_CHILDREN));
+   char * children_str = getenv(PHP_FCGI_CHILDREN);
+   children = atoi(children_str);
if (children  0) {
fprintf(stderr, PHP_FCGI_CHILDREN is not valid\n);
return FAILURE;
}
+   fcgi_set_mgmt_var(FCGI_MAX_CONNS, sizeof(FCGI_MAX_CONNS)-1, 
children_str, strlen(children_str));
+   /* This is the number of concurrent requests, equals 
FCGI_MAX_CONNS */
+   fcgi_set_mgmt_var(FCGI_MAX_REQS,  sizeof(FCGI_MAX_REQS)-1,  
children_str, strlen(children_str));
+   } else {
+   fcgi_set_mgmt_var(FCGI_MAX_CONNS, sizeof(FCGI_MAX_CONNS)-1, 1, 
sizeof(1)-1);
+   fcgi_set_mgmt_var(FCGI_MAX_REQS,  sizeof(FCGI_MAX_REQS)-1,  1, 
sizeof(1)-1);
}
 
 	if (children) {

http://cvs.php.net/viewvc.cgi/php-src/sapi/cgi/fastcgi.c?r1=1.4.2.13.2.28.2.6r2=1.4.2.13.2.28.2.7diff_format=u
Index: php-src/sapi/cgi/fastcgi.c
diff -u php-src/sapi/cgi/fastcgi.c:1.4.2.13.2.28.2.6 
php-src/sapi/cgi/fastcgi.c:1.4.2.13.2.28.2.7
--- php-src/sapi/cgi/fastcgi.c:1.4.2.13.2.28.2.6Tue Aug 26 09:56:08 2008
+++ php-src/sapi/cgi/fastcgi.c  Tue Oct 21 03:19:28 2008
@@ -16,7 +16,7 @@
+--+
 */
 
-/* $Id: fastcgi.c,v 1.4.2.13.2.28.2.6 2008/08/26 09:56:08 dmitry Exp $ */

+/* $Id: fastcgi.c,v 1.4.2.13.2.28.2.7 2008/10/21 03:19:28 lbarnaud Exp $ */
 
 #include php.h

 #include fastcgi.h
@@ -133,18 +133,7 @@
struct sockaddr_in  sa_inet;
 } sa_t;
 
-typedef struct _fcgi_mgmt_rec {

-   char*  name;
-   char   name_len;
-   char   val;
-} fcgi_mgmt_rec;
-
-static const fcgi_mgmt_rec fcgi_mgmt_vars[] = {
-   {FCGI_MAX_CONNS,  sizeof(FCGI_MAX_CONNS)-1,  1},
-   {FCGI_MAX_REQS,   sizeof(FCGI_MAX_REQS)-1,   1},
-   {FCGI_MPXS_CONNS, sizeof(FCGI_MPXS_CONNS)-1, 0}
-};
-
+static HashTable fcgi_mgmt_vars;
 
 static int is_initialized = 0;

 static int is_fastcgi = 0;
@@ -194,6 +183,8 @@
 int fcgi_init(void)
 {
if (!is_initialized) {
+   zend_hash_init(fcgi_mgmt_vars, 0, NULL, fcgi_free_mgmt_var_cb, 
1);
+   fcgi_set_mgmt_var(FCGI_MPXS_CONNS, sizeof(FCGI_MPXS_CONNS)-1, 0, 
sizeof(0)-1);
 #ifdef _WIN32
 # if 0
/* TODO: Support for TCP sockets */
@@ -260,6 +251,9 @@
 
 void fcgi_shutdown(void)

 {
+   if (is_initialized) {
+   zend_hash_destroy(fcgi_mgmt_vars);
+   }
is_fastcgi = 0;
 }
 
@@ -750,8 +744,13 @@

padding = hdr.paddingLength;
}
} else if (hdr.type == FCGI_GET_VALUES) {
-   int j;
unsigned char *p = buf + sizeof(fcgi_header);
+   HashPosition pos;
+   char * str_index;
+   uint str_length;
+   ulong num_index;
+   int key_type;
+   zval ** value;
 
 		if (safe_read(req, buf, len+padding) != len+padding) 

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard syslog.c /win32/build registersyslog.php

2008-10-16 Thread Hannes Magnusson
On Wed, Oct 15, 2008 at 20:41, Kalle Sommer Nielsen [EMAIL PROTECTED] wrote:
 kalle   Wed Oct 15 18:41:58 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-srcNEWS
/php-src/ext/standard   syslog.c
/php-src/win32/buildregistersyslog.php
  Log:
  [DOC] Deprecate define_syslog_variables() in 5.3

 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.344r2=1.2027.2.547.2.965.2.345diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.344 
 php-src/NEWS:1.2027.2.547.2.965.2.345
 --- php-src/NEWS:1.2027.2.547.2.965.2.344   Tue Oct 14 19:03:36 2008
 +++ php-src/NEWSWed Oct 15 18:41:57 2008
 @@ -14,6 +14,8 @@
   (Keisial at gmail dot com, Greg)
  - Added support for using compressed connections with PDO_mysql. (Johannes)

 +- Deprecated define_syslog_variables(). (Kalle)
 +
  - Fixed bug causing the algorithm parameter of mhash() to be modified. 
 (Scott)

  - Fixed bug #46238 (Segmentation fault on static call with empty string 
 method).
 http://cvs.php.net/viewvc.cgi/php-src/ext/standard/syslog.c?r1=1.49.2.3.2.2.2.3r2=1.49.2.3.2.2.2.4diff_format=u
 Index: php-src/ext/standard/syslog.c
 diff -u php-src/ext/standard/syslog.c:1.49.2.3.2.2.2.3 
 php-src/ext/standard/syslog.c:1.49.2.3.2.2.2.4
 --- php-src/ext/standard/syslog.c:1.49.2.3.2.2.2.3  Mon Mar 10 22:12:36 
 2008
 +++ php-src/ext/standard/syslog.c   Wed Oct 15 18:41:57 2008
 @@ -16,7 +16,7 @@
+--+
  */

 -/* $Id: syslog.c,v 1.49.2.3.2.2.2.3 2008/03/10 22:12:36 felipe Exp $ */
 +/* $Id: syslog.c,v 1.49.2.3.2.2.2.4 2008/10/15 18:41:57 kalle Exp $ */

  #include php.h

 @@ -207,6 +207,8 @@
return;
}

 +   php_error_docref(NULL TSRMLS_CC, E_DEPRECATED, 
 define_syslog_variables is deprecated, please use the syslog constants 
 instead);
 +

Why not use PHP_DEP_FE() ?

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pgsql pgsql.c

2008-10-02 Thread Ilia Alshanetsky
No, its for security or critical fixes only. I'd say that a crash  
inside a key area of the code is critical...



On 1-Oct-08, at 5:01 PM, Hannes Magnusson wrote:


On Wed, Oct 1, 2008 at 22:30, Ilia Alshanetsky [EMAIL PROTECTED] wrote:

iliaa   Wed Oct  1 20:30:24 2008 UTC

Modified files:  (Branch: PHP_5_3)
  /php-src/ext/pgsql  pgsql.c
  /php-srcNEWS
Log:

Fixed bug #46206 (pg_query_params/pg_execute convert passed values to
strings).




Hmmh.. Does this mean that 5.2 is dead and all the unreleased 5.2 NEWS
entries should be moved to 5_3?

-Hannes


Ilia Alshanetsky





--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pgsql pgsql.c

2008-10-01 Thread Hannes Magnusson
On Wed, Oct 1, 2008 at 22:30, Ilia Alshanetsky [EMAIL PROTECTED] wrote:
 iliaa   Wed Oct  1 20:30:24 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src/ext/pgsql  pgsql.c
/php-srcNEWS
  Log:

  Fixed bug #46206 (pg_query_params/pg_execute convert passed values to
  strings).



Hmmh.. Does this mean that 5.2 is dead and all the unreleased 5.2 NEWS
entries should be moved to 5_3?

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pgsql pgsql.c

2008-10-01 Thread Jani Taskinen

Ilia Alshanetsky wrote:
[cut]

http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.337r2=1.2027.2.547.2.965.2.338diff_format=u
Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.337 
php-src/NEWS:1.2027.2.547.2.965.2.338
--- php-src/NEWS:1.2027.2.547.2.965.2.337   Wed Oct  1 13:13:34 2008
+++ php-src/NEWSWed Oct  1 20:30:23 2008
@@ -13,6 +13,8 @@
 
 - Fixed bug causing the algorithm parameter of mhash() to be modified. (Scott)
 
+- Fixed bug #46206 (pg_query_params/pg_execute convert passed values to
+  strings). (Ilia) 
 - Fixed bug #46205 (Closure - Memory leaks when ReflectionException is thrown).

   (Dmitry)
 - Fixed bug #46194 (SIGSEGV when requested file is not found). (Greg)



Ehem. PHP_5_2 is still there, you're the RM of it, aren't you? You're supposed 
to commit _bug_ fixes there too.


--Jani

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-09-24 Thread Felipe Pena
Em Qua, 2008-09-24 às 23:43 +, Ilia Alshanetsky escreveu:
 iliaa Wed Sep 24 23:43:30 2008 UTC
 
   Modified files:  (Branch: PHP_5_3)
 /php-src  NEWS 
   Log:
   
   Fixed typo
   

Opss, thanks Ilia!

-- 
Regards,
Felipe Pena.


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /main/streams filter.c streams.c

2008-09-23 Thread Hannes Magnusson
On Mon, Sep 22, 2008 at 03:26, Greg Beaver [EMAIL PROTECTED] wrote:
 cellog  Mon Sep 22 01:26:14 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-srcNEWS
/php-src/main/streams   filter.c streams.c
  Log:
  MF52 fix Bug #46147: after stream seek, appending stream filter reads 
 incorrect data

 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.328r2=1.2027.2.547.2.965.2.329diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.328 
 php-src/NEWS:1.2027.2.547.2.965.2.329
 --- php-src/NEWS:1.2027.2.547.2.965.2.328   Sun Sep 21 18:13:45 2008
 +++ php-src/NEWSMon Sep 22 01:26:13 2008
 @@ -10,6 +10,8 @@

  - Fixed bug causing the algorithm parameter of mhash() to be modified. 
 (Scott)

 +- Fixed Bug #46147 (after stream seek, appending stream filter reads 
 incorrect data).
 +  (Greg)


If the fix is already in 5.2 then this news entry is useless.

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/fileinfo fileinfo.c

2008-09-20 Thread Marcus Boerger
Hello Scott,

Tuesday, September 16, 2008, 12:13:25 AM, you wrote:

 scottmacMon Sep 15 22:13:25 2008 UTC

   Modified files:  (Branch: PHP_5_3)
 /php-srcNEWS 
 /php-src/ext/fileinfo   fileinfo.c 
   Log:
   Fixed bug #46086 (Segfault when accessing fileinfo class property)
   
 http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.317r2=1.2027.2.547.2.965.2.318diff_format=u
 Index: php-src/NEWS
 diff -u php-src/NEWS:1.2027.2.547.2.965.2.317
 php-src/NEWS:1.2027.2.547.2.965.2.318
 --- php-src/NEWS:1.2027.2.547.2.965.2.317   Sun Sep 14 06:47:08 2008
 +++ php-src/NEWSMon Sep 15 22:13:25 2008
 @@ -2,9 +2,12 @@
 
 |||
  ?? ??? 200?, PHP 5.3.0 Alpha 3
  - Upgraded bundled PCRE to version 7.8. (Nuno)
 +- Upgraded bundled sqlite to version 3.6.2. (Scott)
  - Changed error level E_ERROR into E_WARNING in Soap extension methods 
parameter validation. (Felipe)
  
 +- Fixed bug #46086 (Segfault when accessing fileinfo class properties).
 +  (Scott)
  - Fixed bug #46072 (Compile failure under IRIX 6.5.30 building util.c) (Greg)
  - Fixed bug #46060 (Phar::addEmptyDir() breaks) (Greg)
  - Fixed bug #46042 (memory leaks with reflection of mb_convert_encoding()).
 http://cvs.php.net/viewvc.cgi/php-src/ext/fileinfo/fileinfo.c?r1=1.20.2.13r2=1.20.2.14diff_format=u
 Index: php-src/ext/fileinfo/fileinfo.c
 diff -u php-src/ext/fileinfo/fileinfo.c:1.20.2.13
 php-src/ext/fileinfo/fileinfo.c:1.20.2.14
 --- php-src/ext/fileinfo/fileinfo.c:1.20.2.13   Sat Sep 13 21:32:21 2008
 +++ php-src/ext/fileinfo/fileinfo.c Mon Sep 15 22:13:25 2008
 @@ -16,7 +16,7 @@
+--+
  */
  
 -/* $Id: fileinfo.c,v 1.20.2.13 2008/09/13 21:32:21 tony2001 Exp $ */
 +/* $Id: fileinfo.c,v 1.20.2.14 2008/09/15 22:13:25 scottmac Exp $ */
  
  #ifdef HAVE_CONFIG_H
  #include config.h
 @@ -100,15 +100,11 @@
 zend_object_value retval;
 struct finfo_object *intern;
  
 -   intern = ecalloc(1, sizeof(struct finfo_object));
 -   intern-zo.ce = class_type;
 -   intern-zo.properties = NULL;
 -#if ZEND_MODULE_API_NO = 20050922
 -   intern-zo.guards = NULL;
 -#else
 -   intern-zo.in_get = 0;
 -   intern-zo.in_set = 0;
 -#endif
 +   intern = emalloc(sizeof(struct finfo_object));
The ecallow actually seemed to be correct as it made sure that both the
inherited stad zend object struct gets initialized as well as anything
beyon that. Now calling zend_object_std_init() obviously prevents a
maintenance nightmare and in this case fixes an error. Still the rest of
the struct needs to be initialized as well.
 +
 +   zend_object_std_init(intern-zo, class_type TSRMLS_CC);
 +   zend_hash_copy(intern-zo.properties,
 class_type-default_properties, (copy_ctor_func_t) zval_add_ref,(void *) 
 tmp, sizeof(zval *));
 +
 intern-ptr = NULL;
  
 retval.handle = zend_objects_store_put(intern,
 finfo_objects_dtor, NULL, NULL TSRMLS_CC);






Best regards,
 Marcus


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-09-08 Thread Jani Taskinen

Felipe Pena wrote:

felipe  Sun Sep  7 23:08:21 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src	NEWS 
  Log:

  - New entry
  
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.309r2=1.2027.2.547.2.965.2.310diff_format=u

Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.309 
php-src/NEWS:1.2027.2.547.2.965.2.310
--- php-src/NEWS:1.2027.2.547.2.965.2.309   Sun Sep  7 13:15:59 2008
+++ php-src/NEWSSun Sep  7 23:08:20 2008
@@ -1,6 +1,8 @@
 PHPNEWS
 |||
 ?? ??? 200?, PHP 5.3.0 Alpha 3
+- Changed Soap methods error level, now it is no longer E_ERROR. (Felipe)


Wha? In english please? And I checked soap.c and it has quite a few 
E_ERROR errors in it..so this NEWS entry is quite misleading.


--Jani



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-09-08 Thread Markus Fischer
Hi,

Jani Taskinen wrote:
 Felipe Pena wrote:
 felipeSun Sep  7 23:08:21 2008 UTC

   Modified files:  (Branch: PHP_5_3)
 /php-srcNEWS   Log:
   - New entry

  ?? ??? 200?, PHP 5.3.0 Alpha 3
 +- Changed Soap methods error level, now it is no longer E_ERROR.
 (Felipe)
 
 Wha? In english please? And I checked soap.c and it has quite a few
 E_ERROR errors in it..so this NEWS entry is quite misleading.

I'm too having trouble, based on this entry, understanding what has really
changed (unfortunately I didn't understand the commit either).

What errors have been changed to what exactly would be nice to know, and is it
something which needs documented?

thanks :)

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-09-01 Thread Jani Taskinen

Derick Rethans wrote:

On Mon, 1 Sep 2008, Jani Taskinen wrote:


+- Fixed bug #43668) (Added odbc.default_cursortype to control the ODBC
+  cursormodel). (Patrick)
+- Fixed bug #43666) (Fixed code to use ODBC 3.52 datatypes for 64bit systems). 
+  (Patrick)


Now you messed up - extra ) ;-)


No, I didn't notice those. They were there already..

--Jani


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-09-01 Thread Derick Rethans
On Mon, 1 Sep 2008, Jani Taskinen wrote:

 Derick Rethans wrote:
  On Mon, 1 Sep 2008, Jani Taskinen wrote:
  
   +- Fixed bug #43668) (Added odbc.default_cursortype to control the ODBC
   +  cursormodel). (Patrick)
   +- Fixed bug #43666) (Fixed code to use ODBC 3.52 datatypes for 64bit
   systems). +  (Patrick)
  
  Now you messed up - extra ) ;-)
 
 No, I didn't notice those. They were there already..

Still your fault! :) Anyway, perhaps we should add all those little 
rules regarding NEWS to README.CVS-RULES - so that new people like 
Patrick don't have to wait for your wrath to occur.

regards,
Derick

-- 
HEAD before 5_3!: http://tinyurl.com/6d2esb
http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-09-01 Thread Jani Taskinen

Derick Rethans wrote:

On Mon, 1 Sep 2008, Jani Taskinen wrote:


Derick Rethans wrote:

On Mon, 1 Sep 2008, Jani Taskinen wrote:


+- Fixed bug #43668) (Added odbc.default_cursortype to control the ODBC
+  cursormodel). (Patrick)
+- Fixed bug #43666) (Fixed code to use ODBC 3.52 datatypes for 64bit
systems). +  (Patrick)

Now you messed up - extra ) ;-)

No, I didn't notice those. They were there already..


Still your fault! :) Anyway, perhaps we should add all those little 
rules regarding NEWS to README.CVS-RULES - so that new people like 
Patrick don't have to wait for your wrath to occur.


Nobody reads that file it seems. Not even the old devs. So it's 
pointless. Besides, when I release the wrath upon someone, they'll 
remember it for sure.. ;)


--Jani

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-09-01 Thread Derick Rethans
On Mon, 1 Sep 2008, Jani Taskinen wrote:

 +- Fixed bug #43668) (Added odbc.default_cursortype to control the ODBC
 +  cursormodel). (Patrick)
 +- Fixed bug #43666) (Fixed code to use ODBC 3.52 datatypes for 64bit 
 systems). 
 +  (Patrick)

Now you messed up - extra ) ;-)

regards,
Derick

-- 
HEAD before 5_3!: http://tinyurl.com/6d2esb
http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-08-31 Thread Lukas Kahwe Smith


On 31.08.2008, at 16:56, Alexey Zakhlestin wrote:


indeyetsSun Aug 31 14:56:15 2008 UTC

 Modified files:  (Branch: PHP_5_3)
   /php-src NEWS
 Log:
 added entry about change in ext/session

http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.297r2=1.2027.2.547.2.965.2.298diff_format=u
Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.297 
php-src/NEWS:1.2027.2.547.2.965.2.298
--- php-src/NEWS:1.2027.2.547.2.965.2.297   Sun Aug 31 10:20:57 2008
+++ php-src/NEWSSun Aug 31 14:56:14 2008
@@ -1,6 +1,8 @@
PHP
NEWS
|
|
|
|
|
|
|
|
|
||
?? ??? 200?, PHP 5.3.0 Alpha 2
+- Removed special treatment of /tmp path for sessions in  
open_basedir

+  context. (Alexey)
- Changed bundled libmagic to use PHP memory allocation routines.  
(Ilia)
- Changed bundled libmagic to use pcre instead of ereg. (Derick,  
Scott, Mikko)

- Updated mime_content_type to use fileinfo. (Derick)



might make sense to mention that it was introduced in 5.2.2 (or  
whatever version you recently mentioned).


regards,
Lukas Kahwe Smith
[EMAIL PROTECTED]




--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-08-31 Thread Jani Taskinen
Quite pointless entries, this thing was never in any release, who cares what 
happened during development of it? Think f.e. if all changes done for the 
namespace crap was added in the NEWS..


Short version: Please remove these pointless entries.

--Jani

Mikko Koppanen kirjoitti:

mkoppanen   Sun Aug 31 10:06:47 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src	NEWS 
  Log:

  Added news entries about changes in ext/fileinfo
  
  
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.295r2=1.2027.2.547.2.965.2.296diff_format=u

Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.295 
php-src/NEWS:1.2027.2.547.2.965.2.296
--- php-src/NEWS:1.2027.2.547.2.965.2.295   Fri Aug 29 14:59:19 2008
+++ php-src/NEWSSun Aug 31 10:06:46 2008
@@ -1,6 +1,10 @@
 PHPNEWS
 |||
 ?? ??? 200?, PHP 5.3.0 Alpha 2
+- Changed bundled libmagic to use PHP memory allocation routines. (Ilia)
+- Changed bundled libmagic to use pcre instead of ereg. (Derick,Scott,Mikko)
+- Updated mime_content_type to use fileinfo. (Derick)
+
 - Removed shebang line check from CGI sapi (it is checked by scanner). (Dmitry)
 
 - Changed session_start() to return false when session startup fails. (Jani)







--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-08-31 Thread Mikko Koppanen
On Sun, Aug 31, 2008 at 5:53 PM, Jani Taskinen [EMAIL PROTECTED] wrote:
 Quite pointless entries, this thing was never in any release, who cares what
 happened during development of it? Think f.e. if all changes done for the
 namespace crap was added in the NEWS..

 Short version: Please remove these pointless entries.

These changes happened after alpha1 and before upcoming alpha2. I
thought those changes were to be logged into NEWS. Removed the
entries, sorry for the noise!



-- 
Mikko Koppanen

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-08-31 Thread Pierre Joye
hi,

On Sun, Aug 31, 2008 at 6:53 PM, Jani Taskinen [EMAIL PROTECTED] wrote:
 Quite pointless entries, this thing was never in any release, who cares what
 happened during development of it? Think f.e. if all changes done for the
 namespace crap was added in the NEWS..

 Short version: Please remove these pointless entries.

That's not correct. There was a release (alpha1) and changes happened
between it and the next alpha/RC releases. Theses changes have to be
present in the NEWS file. It is the RM to merge them before the first
stable release (5.3.0-final).

I may be mistaken but it is what is described in the release process
doc and what other (Derick or Johannes) said as well.

Cheers,
-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-08-31 Thread Jani Taskinen

Pierre Joye kirjoitti:

hi,

On Sun, Aug 31, 2008 at 6:53 PM, Jani Taskinen [EMAIL PROTECTED] wrote:

Quite pointless entries, this thing was never in any release, who cares what
happened during development of it? Think f.e. if all changes done for the
namespace crap was added in the NEWS..

Short version: Please remove these pointless entries.


That's not correct. There was a release (alpha1) and changes happened
between it and the next alpha/RC releases. Theses changes have to be
present in the NEWS file. It is the RM to merge them before the first
stable release (5.3.0-final).


I don't count alpha/beta/etc. as releases. Release is a stable release.
One that people actually download and use in production..

Also those entries didn't really give any useful information to PHP _users_ as 
the changes were pretty much internal things.


Please don't spam NEWS..:)

--Jani




--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pcre php_pcre.c /ext/pcre/tests preg_filter.phpt

2008-08-30 Thread Marcus Boerger
Hello Antony,

Friday, August 29, 2008, 11:15:29 PM, you wrote:

 On 29.08.2008 16:13, Marcus Boerger wrote:
 helly Fri Aug 29 12:13:55 2008 UTC
 
   Added files: (Branch: PHP_5_3)
 /php-src/ext/pcre/tests   preg_filter.phpt 

 Don't forget to fix sapi/cli/tests/006.phpt

Fixed - thanks for reminding! :-)

Best regards,
 Marcus


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pcre php_pcre.c /ext/pcre/tests preg_filter.phpt

2008-08-29 Thread Hannes Magnusson
On Fri, Aug 29, 2008 at 14:13, Marcus Boerger [EMAIL PROTECTED] wrote:
[...]
 @@ -1879,6 +1894,7 @@
PHP_FE(preg_match_all,  arginfo_preg_match_all)
PHP_FE(preg_replace,arginfo_preg_replace)
PHP_FE(preg_replace_callback,   arginfo_preg_replace_callback)
 +   PHP_FE(preg_filter, arginfo_preg_replace)

The second argument of arginfo_preg_replace is called `callback`...

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-CVS] Re: [PHP-DOC] Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pcre php_pcre.c /ext/pcre/tests preg_filter.phpt

2008-08-29 Thread Felipe Pena
Em Sex, 2008-08-29 às 21:07 +0200, Hannes Magnusson escreveu:
 On Fri, Aug 29, 2008 at 14:13, Marcus Boerger [EMAIL PROTECTED] wrote:
 [...]
  @@ -1879,6 +1894,7 @@
 PHP_FE(preg_match_all,  arginfo_preg_match_all)
 PHP_FE(preg_replace,arginfo_preg_replace)
 PHP_FE(preg_replace_callback,   arginfo_preg_replace_callback)
  +   PHP_FE(preg_filter, 
  arginfo_preg_replace)
 
 The second argument of arginfo_preg_replace is called `callback`...
 
No, 'callback' is the second argument of arginfo_preg_replace_callback.

 -Hannes
-- 
Regards,
Felipe Pena.


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-CVS] Re: [PHP-DOC] Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pcre php_pcre.c /ext/pcre/tests preg_filter.phpt

2008-08-29 Thread Hannes Magnusson
On Fri, Aug 29, 2008 at 21:16, Felipe Pena [EMAIL PROTECTED] wrote:
 Em Sex, 2008-08-29 às 21:07 +0200, Hannes Magnusson escreveu:
 On Fri, Aug 29, 2008 at 14:13, Marcus Boerger [EMAIL PROTECTED] wrote:
 [...]
  @@ -1879,6 +1894,7 @@
 PHP_FE(preg_match_all,  arginfo_preg_match_all)
 PHP_FE(preg_replace,arginfo_preg_replace)
 PHP_FE(preg_replace_callback,   arginfo_preg_replace_callback)
  +   PHP_FE(preg_filter, 
  arginfo_preg_replace)

 The second argument of arginfo_preg_replace is called `callback`...

 No, 'callback' is the second argument of arginfo_preg_replace_callback.

Hah! Indeed.
Don't know how I manage to misread that one :D

-Hannes

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/pcre php_pcre.c /ext/pcre/tests preg_filter.phpt

2008-08-29 Thread Antony Dovgal

On 29.08.2008 16:13, Marcus Boerger wrote:

helly   Fri Aug 29 12:13:55 2008 UTC

  Added files: (Branch: PHP_5_3)
/php-src/ext/pcre/tests	preg_filter.phpt 


Don't forget to fix sapi/cli/tests/006.phpt

--
Wbr, 
Antony Dovgal


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /sapi/cgi cgi_main.c fastcgi.c fastcgi.h

2008-08-26 Thread Jani Taskinen

Sounds like something that should go to PHP_5_2 branch also?

--Jani



Dmitry Stogov wrote:

dmitry  Tue Aug 26 09:56:09 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src	NEWS 
/php-src/sapi/cgi	cgi_main.c fastcgi.c fastcgi.h 
  Log:

  Fixed bug #45786 (FastCGI process exited unexpectedly)
  
  
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.286r2=1.2027.2.547.2.965.2.287diff_format=u

Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.286 
php-src/NEWS:1.2027.2.547.2.965.2.287
--- php-src/NEWS:1.2027.2.547.2.965.2.286   Mon Aug 25 18:40:44 2008
+++ php-src/NEWSTue Aug 26 09:56:08 2008
@@ -27,6 +27,7 @@
   relative time string. (Derick)
 
 - Fixed bug #45798 (sqlite3 doesn't notice if variable was bound). (Felipe)

+- Fixed bug #45786 (FastCGI process exited unexpectedly). (Dmitry)
 - Fixed bug #45763 (mysqli::multi_query does not work with mysqlnd). (Johannes)
 - Fixed bug #45757 (FreeBSD4.11 build failure: failed include; stdint.h).
   (Hannes)
http://cvs.php.net/viewvc.cgi/php-src/sapi/cgi/cgi_main.c?r1=1.267.2.15.2.50.2.25r2=1.267.2.15.2.50.2.26diff_format=u
Index: php-src/sapi/cgi/cgi_main.c
diff -u php-src/sapi/cgi/cgi_main.c:1.267.2.15.2.50.2.25 
php-src/sapi/cgi/cgi_main.c:1.267.2.15.2.50.2.26
--- php-src/sapi/cgi/cgi_main.c:1.267.2.15.2.50.2.25Mon Aug 18 10:49:35 2008
+++ php-src/sapi/cgi/cgi_main.c Tue Aug 26 09:56:08 2008
@@ -21,7 +21,7 @@
+--+
 */
 
-/* $Id: cgi_main.c,v 1.267.2.15.2.50.2.25 2008/08/18 10:49:35 dmitry Exp $ */

+/* $Id: cgi_main.c,v 1.267.2.15.2.50.2.26 2008/08/26 09:56:08 dmitry Exp $ */
 
 #include php.h

 #include php_globals.h
@@ -776,7 +776,7 @@
 #ifndef PHP_WIN32
!parent 
 #endif
-   
!fcgi_finish_request((fcgi_request*)SG(server_context))) {
+   
!fcgi_finish_request((fcgi_request*)SG(server_context), 0)) {
php_handle_aborted_connection();
}
} else {
@@ -1914,7 +1914,7 @@
   get path_translated */
if (php_request_startup(TSRMLS_C) == FAILURE) {
if (fastcgi) {
-   fcgi_finish_request(request);
+   fcgi_finish_request(request, 1);
}
SG(server_context) = NULL;
php_module_shutdown(TSRMLS_C);
@@ -2056,7 +2056,7 @@
/* only fastcgi will get here */
requests++;
if (max_requests  (requests == max_requests)) {
-   fcgi_finish_request(request);
+   fcgi_finish_request(request, 1);
if (bindpath) {
free(bindpath);
}
http://cvs.php.net/viewvc.cgi/php-src/sapi/cgi/fastcgi.c?r1=1.4.2.13.2.28.2.5r2=1.4.2.13.2.28.2.6diff_format=u
Index: php-src/sapi/cgi/fastcgi.c
diff -u php-src/sapi/cgi/fastcgi.c:1.4.2.13.2.28.2.5 
php-src/sapi/cgi/fastcgi.c:1.4.2.13.2.28.2.6
--- php-src/sapi/cgi/fastcgi.c:1.4.2.13.2.28.2.5Mon Aug 18 10:49:35 2008
+++ php-src/sapi/cgi/fastcgi.c  Tue Aug 26 09:56:08 2008
@@ -16,7 +16,7 @@
+--+
 */
 
-/* $Id: fastcgi.c,v 1.4.2.13.2.28.2.5 2008/08/18 10:49:35 dmitry Exp $ */

+/* $Id: fastcgi.c,v 1.4.2.13.2.28.2.6 2008/08/26 09:56:08 dmitry Exp $ */
 
 #include php.h

 #include fastcgi.h
@@ -662,6 +662,7 @@
unsigned char buf[FCGI_MAX_LENGTH+8];
 
 	req-keep = 0;

+   req-closed = 0;
req-in_len = 0;
req-out_hdr = NULL;
req-out_pos = req-out_buf;
@@ -886,7 +887,6 @@
HANDLE pipe;
OVERLAPPED ov;
 #endif
-   fcgi_finish_request(req);
 
 	while (1) {

if (req-fd  0) {
@@ -1177,13 +1177,16 @@
return len;
 }
 
-int fcgi_finish_request(fcgi_request *req)

+int fcgi_finish_request(fcgi_request *req, int force_close)
 {
int ret = 1;
 
 	if (req-fd = 0) {

-   ret = fcgi_flush(req, 1);
-   fcgi_close(req, 0, 1);
+   if (!req-closed) {
+   ret = fcgi_flush(req, 1);
+   req-closed = 1;
+   }
+   fcgi_close(req, force_close, 1);
}
return ret;
 }
http://cvs.php.net/viewvc.cgi/php-src/sapi/cgi/fastcgi.h?r1=1.2.2.4.2.5.2.2r2=1.2.2.4.2.5.2.3diff_format=u
Index: php-src/sapi/cgi/fastcgi.h
diff -u php-src/sapi/cgi/fastcgi.h:1.2.2.4.2.5.2.2 
php-src/sapi/cgi/fastcgi.h:1.2.2.4.2.5.2.3
--- php-src/sapi/cgi/fastcgi.h:1.2.2.4.2.5.2.2  Mon Aug 18 10:49:35 2008
+++ php-src/sapi/cgi/fastcgi.h  Tue Aug 26 09:56:08 2008
@@ -16,7 +16,7 @@

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /sapi/cgi cgi_main.c fastcgi.c fastcgi.h

2008-08-26 Thread Ilia Alshanetsky

Yeah, Dmitry could you please MFH.


On 26-Aug-08, at 7:00 AM, Jani Taskinen wrote:


Sounds like something that should go to PHP_5_2 branch also?

--Jani



Dmitry Stogov wrote:

dmitry  Tue Aug 26 09:56:09 2008 UTC
 Modified files:  (Branch: PHP_5_3)
   /php-src	NEWS /php-src/sapi/cgi	cgi_main.c fastcgi.c  
fastcgi.h   Log:

 Fixed bug #45786 (FastCGI process exited unexpectedly)
   
http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.286r2=1.2027.2.547.2.965.2.287diff_format=u
Index: php-src/NEWS
diff -u php-src/NEWS:1.2027.2.547.2.965.2.286 
php-src/NEWS:1.2027.2.547.2.965.2.287
--- php-src/NEWS:1.2027.2.547.2.965.2.286   Mon Aug 25 18:40:44 2008
+++ php-src/NEWSTue Aug 26 09:56:08 2008
@@ -27,6 +27,7 @@
  relative time string. (Derick)
 - Fixed bug #45798 (sqlite3 doesn't notice if variable was bound).  
(Felipe)

+- Fixed bug #45786 (FastCGI process exited unexpectedly). (Dmitry)
- Fixed bug #45763 (mysqli::multi_query does not work with  
mysqlnd). (Johannes)
- Fixed bug #45757 (FreeBSD4.11 build failure: failed include;  
stdint.h).

  (Hannes)
http://cvs.php.net/viewvc.cgi/php-src/sapi/cgi/cgi_main.c?r1=1.267.2.15.2.50.2.25r2=1.267.2.15.2.50.2.26diff_format=u
Index: php-src/sapi/cgi/cgi_main.c
diff -u php-src/sapi/cgi/cgi_main.c:1.267.2.15.2.50.2.25 php-src/ 
sapi/cgi/cgi_main.c:1.267.2.15.2.50.2.26
--- php-src/sapi/cgi/cgi_main.c:1.267.2.15.2.50.2.25	Mon Aug 18  
10:49:35 2008

+++ php-src/sapi/cgi/cgi_main.c Tue Aug 26 09:56:08 2008
@@ -21,7 +21,7 @@

+ 
--+

*/
-/* $Id: cgi_main.c,v 1.267.2.15.2.50.2.25 2008/08/18 10:49:35  
dmitry Exp $ */
+/* $Id: cgi_main.c,v 1.267.2.15.2.50.2.26 2008/08/26 09:56:08  
dmitry Exp $ */

 #include php.h
#include php_globals.h
@@ -776,7 +776,7 @@
#ifndef PHP_WIN32
!parent 
#endif
-   
!fcgi_finish_request((fcgi_request*)SG(server_context))) {
+   
!fcgi_finish_request((fcgi_request*)SG(server_context), 0)) {
php_handle_aborted_connection();
}
} else {
@@ -1914,7 +1914,7 @@
   get path_translated */
if (php_request_startup(TSRMLS_C) == FAILURE) {
if (fastcgi) {
-   fcgi_finish_request(request);
+   fcgi_finish_request(request, 1);
}
SG(server_context) = NULL;
php_module_shutdown(TSRMLS_C);
@@ -2056,7 +2056,7 @@
/* only fastcgi will get here */
requests++;
if (max_requests  (requests == max_requests)) {
-   fcgi_finish_request(request);
+   fcgi_finish_request(request, 1);
if (bindpath) {
free(bindpath);
}
http://cvs.php.net/viewvc.cgi/php-src/sapi/cgi/fastcgi.c?r1=1.4.2.13.2.28.2.5r2=1.4.2.13.2.28.2.6diff_format=u
Index: php-src/sapi/cgi/fastcgi.c
diff -u php-src/sapi/cgi/fastcgi.c:1.4.2.13.2.28.2.5 php-src/sapi/ 
cgi/fastcgi.c:1.4.2.13.2.28.2.6
--- php-src/sapi/cgi/fastcgi.c:1.4.2.13.2.28.2.5	Mon Aug 18  
10:49:35 2008

+++ php-src/sapi/cgi/fastcgi.c  Tue Aug 26 09:56:08 2008
@@ -16,7 +16,7 @@

+ 
--+

*/
-/* $Id: fastcgi.c,v 1.4.2.13.2.28.2.5 2008/08/18 10:49:35 dmitry  
Exp $ */
+/* $Id: fastcgi.c,v 1.4.2.13.2.28.2.6 2008/08/26 09:56:08 dmitry  
Exp $ */

 #include php.h
#include fastcgi.h
@@ -662,6 +662,7 @@
unsigned char buf[FCGI_MAX_LENGTH+8];
req-keep = 0;
+   req-closed = 0;
req-in_len = 0;
req-out_hdr = NULL;
req-out_pos = req-out_buf;
@@ -886,7 +887,6 @@
HANDLE pipe;
OVERLAPPED ov;
#endif
-   fcgi_finish_request(req);
while (1) {
if (req-fd  0) {
@@ -1177,13 +1177,16 @@
return len;
}
-int fcgi_finish_request(fcgi_request *req)
+int fcgi_finish_request(fcgi_request *req, int force_close)
{
int ret = 1;
if (req-fd = 0) {
-   ret = fcgi_flush(req, 1);
-   fcgi_close(req, 0, 1);
+   if (!req-closed) {
+   ret = fcgi_flush(req, 1);
+   req-closed = 1;
+   }
+   fcgi_close(req, force_close, 1);
}
return ret;
}
http://cvs.php.net/viewvc.cgi/php-src/sapi/cgi/fastcgi.h?r1=1.2.2.4.2.5.2.2r2=1.2.2.4.2.5.2.3diff_format=u
Index: php-src/sapi/cgi/fastcgi.h
diff -u php-src/sapi/cgi/fastcgi.h:1.2.2.4.2.5.2.2 php-src/sapi/cgi/ 
fastcgi.h:1.2.2.4.2.5.2.3
--- php-src/sapi/cgi/fastcgi.h:1.2.2.4.2.5.2.2	Mon Aug 18 10:49:35  
2008

  1   2   >