Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
On Wed, Jun 3, 2009 at 03:19, Kalle Sommer Nielsen ka...@php.net wrote: kalle Wed Jun 3 01:19:33 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/bcmath/libbcmath/src bcmath.h Log: MFH: config.h is in this directory, not in ext/bcmath root, fixes re-compilation for me Please read the commit history. This will probably break other stuff. -Hannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
Kalle Sommer Nielsen kirjoitti: 2009/6/3 Hannes Magnusson hannes.magnus...@gmail.com: On Wed, Jun 3, 2009 at 03:19, Kalle Sommer Nielsen ka...@php.net wrote: kalle Wed Jun 3 01:19:33 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/bcmath/libbcmath/src bcmath.h Log: MFH: config.h is in this directory, not in ext/bcmath root, fixes re-compilation for me Please read the commit history. This will probably break other stuff. Its broken for me, if its an issue for others then we need to isolate it, if i do a fresh nmake and then make a buildconf configure nmake (after i have made a change), it breaks the build because config.h isn't in ext/bcmath, but ext/bcmath/libbcmath/src/ Did you try on real OSes? Please keep in mind that Windows comes 2nd, if you fix something and it breaks on other OSes, that fix will be reverted. --Jani -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
On Wed, Jun 3, 2009 at 2:06 PM, Jani Taskinen jani.taski...@sci.fi wrote: Its broken for me, if its an issue for others then we need to isolate it, if i do a fresh nmake and then make a buildconf configure nmake (after i have made a change), it breaks the build because config.h isn't in ext/bcmath, but ext/bcmath/libbcmath/src/ Did you try on real OSes? Please keep in mind that Windows comes 2nd, if you fix something and it breaks on other OSes, that fix will be reverted. All supported OSes have the same priority. I asked Kalle to double check again that this change does not affect any other platform and revert it if yes (it works on win already, only not in some weird configuration). Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
2009/6/3 Jani Taskinen jani.taski...@sci.fi: Kalle Sommer Nielsen kirjoitti: 2009/6/3 Hannes Magnusson hannes.magnus...@gmail.com: On Wed, Jun 3, 2009 at 03:19, Kalle Sommer Nielsen ka...@php.net wrote: kalle Wed Jun 3 01:19:33 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/bcmath/libbcmath/src bcmath.h Log: MFH: config.h is in this directory, not in ext/bcmath root, fixes re-compilation for me Please read the commit history. This will probably break other stuff. Its broken for me, if its an issue for others then we need to isolate it, if i do a fresh nmake and then make a buildconf configure nmake (after i have made a change), it breaks the build because config.h isn't in ext/bcmath, but ext/bcmath/libbcmath/src/ Did you try on real OSes? Please keep in mind that Windows comes 2nd, if you fix something and it breaks on other OSes, that fix will be reverted. So real OSes about everything thats not produced by Microsoft? I don't see why we treat Windows as second class really, its just as a good OS as any of the other (*awaiting stupid comment*). Windows isn't lacking that much behind anymore, especially not with 5.3. Alternatively until the problem have been solved, then we could just directly include the config.h which is abit ugly and we're all happy: #include ext/bcmath/libbcmath/src/config.h --Jani -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- regrads, Kalle Sommer Nielsen ka...@php.net -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
Can you count to 2 ?? It's easy: 1, 2. Now, count how many levels it's to where the config.h would be if you do a phpize build: ext/bcmath/libbcmath/src/bcmath.h Revert or I will and fix the correct bug. --Jani Pierre-Alain Joye [EMAIL PROTECTED] kirjoitti: pajoye Fri Aug 15 15:39:18 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/bcmath/libbcmath/src bcmath.h Log: - MFH: no config.h in ext/ http://cvs.php.net/viewvc.cgi/php-src/ext/bcmath/libbcmath/src/bcmath.h?r1=1.9.6.2r2=1.9.6.2.2.1diff_format=u Index: php-src/ext/bcmath/libbcmath/src/bcmath.h diff -u php-src/ext/bcmath/libbcmath/src/bcmath.h:1.9.6.2 php-src/ext/bcmath/libbcmath/src/bcmath.h:1.9.6.2.2.1 --- php-src/ext/bcmath/libbcmath/src/bcmath.h:1.9.6.2 Tue Sep 11 11:25:20 2007 +++ php-src/ext/bcmath/libbcmath/src/bcmath.h Fri Aug 15 15:39:17 2008 @@ -53,7 +53,7 @@ } bc_struct; #ifdef HAVE_CONFIG_H -#include ../../config.h +#include config.h #endif #include php.h -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
On Fri, Aug 15, 2008 at 6:00 PM, Jani Taskinen [EMAIL PROTECTED] wrote: Can you count to 2 ?? It's easy: 1, 2. Now, count how many levels it's to where the config.h would be if you do a phpize build: Sorry, I can't count to 2 :) Should it not be in path anyway? ext/bcmath/libbcmath/src/bcmath.h Revert or I will and fix the correct bug. It is fixed with this commit, my comment may be wrong about ext/. -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
Pierre Joye [EMAIL PROTECTED] kirjoitti: On Fri, Aug 15, 2008 at 6:00 PM, Jani Taskinen [EMAIL PROTECTED] wrote: Can you count to 2 ?? It's easy: 1, 2. Now, count how many levels it's to where the config.h would be if you do a phpize build: Sorry, I can't count to 2 :) Should it not be in path anyway? It was correct as it was. ext/bcmath/libbcmath/src/bcmath.h Revert or I will and fix the correct bug. It is fixed with this commit, my comment may be wrong about ext/. WHAT was fixed? It worked fine before you started messing around, what EXACTLY did you fix with this change? --Jani -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
On Fri, Aug 15, 2008 at 6:30 PM, Jani Taskinen [EMAIL PROTECTED] wrote: Pierre Joye [EMAIL PROTECTED] kirjoitti: On Fri, Aug 15, 2008 at 6:00 PM, Jani Taskinen [EMAIL PROTECTED] wrote: Can you count to 2 ?? It's easy: 1, 2. Now, count how many levels it's to where the config.h would be if you do a phpize build: Sorry, I can't count to 2 :) Should it not be in path anyway? It was correct as it was. ext/bcmath/libbcmath/src/bcmath.h Revert or I will and fix the correct bug. It is fixed with this commit, my comment may be wrong about ext/. WHAT was fixed? It worked fine before you started messing around, what EXACTLY did you fix with this change? config.h not found, what else can be fixed? :) -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
Not enough info - bogus. FYI: Just tested to be sure. Doing phpize build now fails. Works when reverted. (reverted btw..) I say again: Fix the REAL bugs, not symptoms of the real bugs.. --Jani Pierre Joye [EMAIL PROTECTED] kirjoitti: On Fri, Aug 15, 2008 at 6:30 PM, Jani Taskinen [EMAIL PROTECTED] wrote: Pierre Joye [EMAIL PROTECTED] kirjoitti: On Fri, Aug 15, 2008 at 6:00 PM, Jani Taskinen [EMAIL PROTECTED] wrote: Can you count to 2 ?? It's easy: 1, 2. Now, count how many levels it's to where the config.h would be if you do a phpize build: Sorry, I can't count to 2 :) Should it not be in path anyway? It was correct as it was. ext/bcmath/libbcmath/src/bcmath.h Revert or I will and fix the correct bug. It is fixed with this commit, my comment may be wrong about ext/. WHAT was fixed? It worked fine before you started messing around, what EXACTLY did you fix with this change? config.h not found, what else can be fixed? :) -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
On Fri, Aug 15, 2008 at 6:37 PM, Jani Taskinen [EMAIL PROTECTED] wrote: Not enough info - bogus. FYI: Just tested to be sure. Doing phpize build now fails. Works when reverted. (reverted btw..) I say again: Fix the REAL bugs, not symptoms of the real bugs.. Wait, you revert a fix because a phpize build fails now for an extension being released only in php core? -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
Hello Jani, the real fix actually is to drop all #include config.h, because php needs to have php_config.h and not config.h as first file. marcus Friday, August 15, 2008, 6:37:24 PM, you wrote: Not enough info - bogus. FYI: Just tested to be sure. Doing phpize build now fails. Works when reverted. (reverted btw..) I say again: Fix the REAL bugs, not symptoms of the real bugs.. --Jani Pierre Joye [EMAIL PROTECTED] kirjoitti: On Fri, Aug 15, 2008 at 6:30 PM, Jani Taskinen [EMAIL PROTECTED] wrote: Pierre Joye [EMAIL PROTECTED] kirjoitti: On Fri, Aug 15, 2008 at 6:00 PM, Jani Taskinen [EMAIL PROTECTED] wrote: Can you count to 2 ?? It's easy: 1, 2. Now, count how many levels it's to where the config.h would be if you do a phpize build: Sorry, I can't count to 2 :) Should it not be in path anyway? It was correct as it was. ext/bcmath/libbcmath/src/bcmath.h Revert or I will and fix the correct bug. It is fixed with this commit, my comment may be wrong about ext/. WHAT was fixed? It worked fine before you started messing around, what EXACTLY did you fix with this change? config.h not found, what else can be fixed? :) -- Pierre http://blog.thepimp.net | http://www.libgd.org Best regards, Marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
No, I revert bad fixes that break something that worked before and are inherently totally bogus to begin with. --Jani Pierre Joye [EMAIL PROTECTED] kirjoitti: On Fri, Aug 15, 2008 at 6:37 PM, Jani Taskinen [EMAIL PROTECTED] wrote: Not enough info - bogus. FYI: Just tested to be sure. Doing phpize build now fails. Works when reverted. (reverted btw..) I say again: Fix the REAL bugs, not symptoms of the real bugs.. Wait, you revert a fix because a phpize build fails now for an extension being released only in php core? -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
You don't really need to comment about everything, do you? Please get your facts correct first. --Jani Marcus Boerger [EMAIL PROTECTED] kirjoitti: Hello Jani, the real fix actually is to drop all #include config.h, because php needs to have php_config.h and not config.h as first file. marcus Friday, August 15, 2008, 6:37:24 PM, you wrote: Not enough info - bogus. FYI: Just tested to be sure. Doing phpize build now fails. Works when reverted. (reverted btw..) I say again: Fix the REAL bugs, not symptoms of the real bugs.. --Jani Pierre Joye [EMAIL PROTECTED] kirjoitti: On Fri, Aug 15, 2008 at 6:30 PM, Jani Taskinen [EMAIL PROTECTED] wrote: Pierre Joye [EMAIL PROTECTED] kirjoitti: On Fri, Aug 15, 2008 at 6:00 PM, Jani Taskinen [EMAIL PROTECTED] wrote: Can you count to 2 ?? It's easy: 1, 2. Now, count how many levels it's to where the config.h would be if you do a phpize build: Sorry, I can't count to 2 :) Should it not be in path anyway? It was correct as it was. ext/bcmath/libbcmath/src/bcmath.h Revert or I will and fix the correct bug. It is fixed with this commit, my comment may be wrong about ext/. WHAT was fixed? It worked fine before you started messing around, what EXACTLY did you fix with this change? config.h not found, what else can be fixed? :) -- Pierre http://blog.thepimp.net | http://www.libgd.org Best regards, Marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h
Hello Jani, hu? First there was the clean and the fix would have been to clean the correct file. Though the fix you did was fine as well. All I did was reminding about the clean section. Second, and that was the only other thing I commented on, was this one. And, well, ignore my ignorance, but because we have a bunch of bundled libs and because we have a ton of wrong include statements, including config.h is not alwas the correct one. I hate to say it but we either need to drop them and only include php.n or the php_config.h or fix the build system to generate correct includes and prevent from it from pulling in the wrong config.h or we could not do anything and ignore that there is a problem. Anyway, in case you feel personally aussaulted, sorry. marcus Friday, August 15, 2008, 6:49:08 PM, you wrote: You don't really need to comment about everything, do you? Please get your facts correct first. --Jani Marcus Boerger [EMAIL PROTECTED] kirjoitti: Hello Jani, the real fix actually is to drop all #include config.h, because php needs to have php_config.h and not config.h as first file. marcus Friday, August 15, 2008, 6:37:24 PM, you wrote: Not enough info - bogus. FYI: Just tested to be sure. Doing phpize build now fails. Works when reverted. (reverted btw..) I say again: Fix the REAL bugs, not symptoms of the real bugs.. --Jani Pierre Joye [EMAIL PROTECTED] kirjoitti: On Fri, Aug 15, 2008 at 6:30 PM, Jani Taskinen [EMAIL PROTECTED] wrote: Pierre Joye [EMAIL PROTECTED] kirjoitti: On Fri, Aug 15, 2008 at 6:00 PM, Jani Taskinen [EMAIL PROTECTED] wrote: Can you count to 2 ?? It's easy: 1, 2. Now, count how many levels it's to where the config.h would be if you do a phpize build: Sorry, I can't count to 2 :) Should it not be in path anyway? It was correct as it was. ext/bcmath/libbcmath/src/bcmath.h Revert or I will and fix the correct bug. It is fixed with this commit, my comment may be wrong about ext/. WHAT was fixed? It worked fine before you started messing around, what EXACTLY did you fix with this change? config.h not found, what else can be fixed? :) -- Pierre http://blog.thepimp.net | http://www.libgd.org Best regards, Marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php Best regards, Marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
