Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c
hi, This change sounds wrong. The obj pointer is being used without being initialized: ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning C4700: uninitialized local variable 'obj' used Cheers, On Mon, Jun 8, 2009 at 7:31 PM, Lukas Kahwe Smithm...@pooteeweet.org wrote: On 08.06.2009, at 12:20, Andrey Hristov wrote: andrey Mon Jun 8 10:20:27 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c Log: Merge with HEAD. Someone committed changes to HEAD and did not merge back to the branch. Also switch off the zval cache, for now. puh .. you are aware that we want to do a commit freeze tonight? and release RC3, which should hopefully become the stable release for 5.3? since 2-3 weeks there is a constant stream of patches that seem to do pretty fundamental changes and design choices. regards, Lukas Kahwe Smith m...@pooteeweet.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c
Hi Pierre, Pierre Joye wrote: hi, This change sounds wrong. The obj pointer is being used without being initialized: ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning C4700: uninitialized local variable 'obj' used Cheers, Check with your eyes, the compiler is wrong. obj is touched only if allocated is FALSE but it is never FALSE if the zval cache has been switched off. Andrey On Mon, Jun 8, 2009 at 7:31 PM, Lukas Kahwe Smithm...@pooteeweet.org wrote: On 08.06.2009, at 12:20, Andrey Hristov wrote: andrey Mon Jun 8 10:20:27 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c Log: Merge with HEAD. Someone committed changes to HEAD and did not merge back to the branch. Also switch off the zval cache, for now. puh .. you are aware that we want to do a commit freeze tonight? and release RC3, which should hopefully become the stable release for 5.3? since 2-3 weeks there is a constant stream of patches that seem to do pretty fundamental changes and design choices. regards, Lukas Kahwe Smith m...@pooteeweet.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- Andrey Hristov, Connectors Software Developer, Database Group Sun Microsystems GmbH, Sonnenallee 1, 85551 Kirchheim-Heimstetten Amtsgericht Muenchen: HRB161028 Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin Haering -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c
Hi Lukas, On Mon, Jun 8, 2009 at 7:31 PM, Lukas Kahwe Smithm...@pooteeweet.org wrote: On 08.06.2009, at 12:20, Andrey Hristov wrote: andrey Mon Jun 8 10:20:27 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c Log: Merge with HEAD. Someone committed changes to HEAD and did not merge back to the branch. Also switch off the zval cache, for now. puh .. you are aware that we want to do a commit freeze tonight? and release RC3, which should hopefully become the stable release for 5.3? since 2-3 weeks there is a constant stream of patches that seem to do pretty fundamental changes and design choices. regards, Lukas Kahwe Smith m...@pooteeweet.org The zval cache is a feature which has been switched off. Why do you think I switch off a feature? Because there was a bug report which was few months old affecting all 5_3 versions including RC1 and RC2. The problem was manifesting itself on Windows only under load. I switched the feature and the problem is gone, according to the user. Andrey -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c
hi Andrey, On Thu, Jun 11, 2009 at 7:25 PM, Andrey Hristovandrey.hris...@sun.com wrote: Hi Pierre, Pierre Joye wrote: hi, This change sounds wrong. The obj pointer is being used without being initialized: ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning C4700: uninitialized local variable 'obj' used Cheers, Check with your eyes, the compiler is wrong. obj is touched only if allocated is FALSE but it is never FALSE if the zval cache has been switched off. Please read http://www.thefreedictionary.com/seems Now that the meaning of this word has been cleared :), can you add a ifdef around that code then? thanks for the quick reply, Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c
On Thu, Jun 11, 2009 at 7:42 PM, Andrey Hristovp...@hristov.com wrote: no :) Why not? it is clearly pointless when ZVAL_CACHE is not set. But you can send the case to your colleagues at the compiler team so they can analyze why the compiler failed to recognize it :) already sent :) I like the MS compiler, it gives more warnings than gcc, Yeah, me too :) I would like to run some more analyzes tools as well, one of these days :) but in this case was wrong :( I am curious why it does complain about one line although there are few places where obj is used and guarded by that allocated variable. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c
Hi Pierre, Pierre Joye wrote: hi Andrey, On Thu, Jun 11, 2009 at 7:25 PM, Andrey Hristovandrey.hris...@sun.com wrote: Hi Pierre, Pierre Joye wrote: hi, This change sounds wrong. The obj pointer is being used without being initialized: ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning C4700: uninitialized local variable 'obj' used Cheers, Check with your eyes, the compiler is wrong. obj is touched only if allocated is FALSE but it is never FALSE if the zval cache has been switched off. Please read http://www.thefreedictionary.com/seems Now that the meaning of this word has been cleared :), can you add a ifdef around that code then? thanks for the quick reply, no :) But you can send the case to your colleagues at the compiler team so they can analyze why the compiler failed to recognize it :) I like the MS compiler, it gives more warnings than gcc, but in this case was wrong :( I am curious why it does complain about one line although there are few places where obj is used and guarded by that allocated variable. Best, Andrey -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c
On 08.06.2009, at 12:20, Andrey Hristov wrote: andrey Mon Jun 8 10:20:27 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c Log: Merge with HEAD. Someone committed changes to HEAD and did not merge back to the branch. Also switch off the zval cache, for now. puh .. you are aware that we want to do a commit freeze tonight? and release RC3, which should hopefully become the stable release for 5.3? since 2-3 weeks there is a constant stream of patches that seem to do pretty fundamental changes and design choices. regards, Lukas Kahwe Smith m...@pooteeweet.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
