Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/odbc php_odbc.c php_odbc.h php_odbc_includes.h

2008-09-02 Thread Jani Taskinen 

Patrick van Kleef wrote:
I have merged these fixes to HEAD, PHP5_3 and PHP5_2 branch as per your 
request.


Jani: Please move the NEWS item fixes to PHP5_2 so i can see how you 
want this committed for future reference.


Done.

I will start looking at the registered ODBC bugs in the system to see 
what problems there are and how they can be fixed. However this will not 
all happen today ;)


You should watch your coding style and whitespace pollution.
f.e. whitespace: we only use tabs. And control structures, use { } 
generously, shortening stuff like 'if (foo) bar;' is not the way to go..

(not saying you did that, just FYI :)

And "splitting" lines: If you have to do that: Get a bigger screen!
(short: don't do it)

--Jani


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/odbc php_odbc.c php_odbc.h php_odbc_includes.h

2008-08-30 Thread Jani Taskinen 

Bug fixes should also go to PHP_5_2 branch. And don't forget to update NEWS.

--Jani


Patrick van Kleef kirjoitti:

iodbc   Fri Aug 29 16:44:29 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src/ext/odbc	php_odbc.c php_odbc.h php_odbc_includes.h 
  Log:

  - MFH: Fixed code to use ODBC 3.52 datatypes for 64bit systems (bug #43666)
  
  




--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php