I've commited a little fix to *printf() functions, so that they won't read
past the specified length.
Nuno
- Original Message -
It does not really read past it, but internally it does a strlen() on the
%s argument, which is where the valgrind shows the message. Technically
that
Modified files: (Branch: PHP_5_3)
/php-src/ext/pdo pdo_stmt.c
Log:
Fixed a possible corruption inside PDOStatement::debugDumpParams()
http://cvs.php.net/viewvc.cgi/php-src/ext/pdo/pdo_stmt.c?r1=1.118.2.38.2.24.2.39r2=1.118.2.38.2.24.2.40diff_format=u
Index:
The patch was already n 5.2, the issue is that the str (key) is not
guaranteed to be NULL terminated (nor does it need to be), so when
strlen() is attempted on top of it you could end up reading more data
then necessary.
On 11-Dec-08, at 10:43 AM, Nuno Lopes wrote:
Modified files:
Weird.. Isn't that a bug in php_stream_printf() then? I would say it
shouldn't read past the specified length.. otherwise the same bug may appear
in other places.
What do you think?
Nuno
- Original Message -
The patch was already n 5.2, the issue is that the str (key) is not
It does not really read past it, but internally it does a strlen() on
the %s argument, which is where the valgrind shows the message.
Technically that code needs to be reviewed, but just from general use
case I think its safer not to pass non-terminated char pointers around.
On 11-Dec-08,
Hello Marcus,
2008/10/11 Marcus Boerger [EMAIL PROTECTED]:
Hello Felipe,
why did we not put that 'static' into the macro?
marcus
Friday, October 10, 2008, 9:35:34 PM, you wrote:
felipe Fri Oct 10 19:35:34 2008 UTC
Modified files: (Branch: PHP_5_3)
Hello Felipe,
why did we not put that 'static' into the macro?
marcus
Friday, October 10, 2008, 9:35:34 PM, you wrote:
felipe Fri Oct 10 19:35:34 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/pdopdo_stmt.c
Log:
- MFH: Static'fication
Hello Marcus,
Em Sáb, 2008-10-11 às 20:48 +0200, Marcus Boerger escreveu:
Hello Felipe,
why did we not put that 'static' into the macro?
I think that would be nice. But will requires massive changes, as there
is tons of code like that. Though it isn't an impediment. :)
--
Regards,
2008/8/12 Felipe Pena [EMAIL PROTECTED]:
felipe Tue Aug 12 17:20:26 2008 UTC
Modified files: (Branch: PHP_5_3)
/ZendEngine2zend.c zend.h zend_API.c zend_API.h zend_compile.c
zend_compile.h zend_constants.c zend_constants.h
Em Qua, 2008-08-13 às 17:58 +0200, Pierre Joye escreveu:
2008/8/12 Felipe Pena [EMAIL PROTECTED]:
felipe Tue Aug 12 17:20:26 2008 UTC
Modified files: (Branch: PHP_5_3)
/ZendEngine2zend.c zend.h zend_API.c zend_API.h zend_compile.c
Hi Ilia,
After this fix 39 PDO rleated test are failed for me :(
SIGSEGV
#0 0x083430e9 in _zend_is_inconsistent (ht=0x0,
file=0x849721c /home/dmitry/php/php5.3/Zend/zend_hash.c, line=1015)
at /home/dmitry/php/php5.3/Zend/zend_hash.c:53
#1 0x08345d73 in zend_hash_num_elements (ht=0x0)
On 21.11.2007 00:14, Dmitry Stogov wrote:
Hi Ilia,
After this fix 39 PDO rleated test are failed for me :(
Confirmed.
Pay attention to `ht` value here:
(gdb) bt
#0 0x008c0e87 in _zend_is_inconsistent (ht=0x0, file=0xc22098
/local/qa/5_3/Zend/zend_hash.c, line=1015) at
I am looking into it now.
On 20-Nov-07, at 4:21 PM, Antony Dovgal wrote:
On 21.11.2007 00:14, Dmitry Stogov wrote:
Hi Ilia,
After this fix 39 PDO rleated test are failed for me :(
Confirmed.
Pay attention to `ht` value here:
(gdb) bt
#0 0x008c0e87 in _zend_is_inconsistent
13 matches
Mail list logo
