Hi Greg,

OK so I'm behind the times, but this commit is problematic. The request simulation broke the build under VC6 because zend_init_rsrc_list() and zend_destroy_rsrc_list() aren't actually part of the Zend API. The latter is simply a wrapper for a call to zend_hash_graceful_reverse_destroy(), which _is_ part of the Zend API, so that could easily be fixed. However it's virtually impossible to emulate zend_init_rsrc_list() in an extension, which makes me wonder if it's even safe to mess with the global regular_list?

Could you please investigate?

I'm about to commit some minor bits and pieces to kill the MSVC warnings that appeared in the debug build over the last week, but I can't actually build ext/phar here at present due to the linking problems caused by the above.

Cheers,

- Steph


----- Original Message ----- From: "Greg Beaver" <[EMAIL PROTECTED]>
To: <php-cvs@lists.php.net>; <[EMAIL PROTECTED]>
Sent: Thursday, June 12, 2008 7:56 PM
Subject: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar.phar phar_internal.h tar.c zip.c /ext/phar/tests phpinfo_001.phpt phpinfo_002.phpt phpinfo_003.phpt phpinfo_004.phpt


cellog Thu Jun 12 18:56:23 2008 UTC

 Modified files:              (Branch: PHP_5_3)
   /php-src/ext/phar phar.c phar.phar phar_internal.h tar.c zip.c
   /php-src/ext/phar/tests phpinfo_001.phpt phpinfo_002.phpt
                          phpinfo_003.phpt phpinfo_004.phpt
 Log:
[DOC] add phar.cache_list, a PATH_SEPARATOR-separated list of full paths to phar archives to cache at startup. This caches the manifest, so that on first access to a phar archive, no file manifest parsing occurs.

This could use further tweaking. For instance, the full copy of the manifest into the current process may be unnecessary if refcounting could be external to the manifest. This would be another significant gain. With APC, I measure a slight perf increase to 19 req/sec up from 16 req/sec, without it approaches regular PHP at 3.8 req/sec (regular is 4 req/sec). This is benching phpMyAdmin



--------------------------------------------------------------------------------


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to