Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/session session.c
Dmitry, Do we need this in 5.2? I think we do, looks low-risk to me. Nope; this commit fixed a bug with my patch to 5.3/HEAD. It wasn't backported to 5.2 in the first place. Ah, my bad, I thought it was in 5.2 too :) -- Stanislav Malyshev, Zend Software Architect [EMAIL PROTECTED] http://www.zend.com/ (408)253-8829 MSN: [EMAIL PROTECTED] -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/session session.c
On Mar 11, 2008, at 3:50 PM, Stanislav Malyshev wrote: Dmitry, Do we need this in 5.2? I think we do, looks low-risk to me. Nope; this commit fixed a bug with my patch to 5.3/HEAD. It wasn't backported to 5.2 in the first place. -- Gwynne, Daughter of the Code "This whole world is an asylum for the incurable." -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/session session.c
Dmitry, Do we need this in 5.2? I think we do, looks low-risk to me. -- Stanislav Malyshev, Zend Software Architect [EMAIL PROTECTED] http://www.zend.com/ (408)253-8829 MSN: [EMAIL PROTECTED] -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/session session.c
Dmitry,
Do we need this in 5.2?
On 11-Mar-08, at 5:36 AM, Dmitry Stogov wrote:
dmitry Tue Mar 11 09:36:41 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/session session.c
Log:
Fixed memory corruption because of double free()
http://cvs.php.net/viewvc.cgi/php-src/ext/session/session.c?r1=1.417.2.8.2.40.2.5&r2=1.417.2.8.2.40.2.6&diff_format=u
Index: php-src/ext/session/session.c
diff -u php-src/ext/session/session.c:1.417.2.8.2.40.2.5 php-src/ext/
session/session.c:1.417.2.8.2.40.2.6
--- php-src/ext/session/session.c:1.417.2.8.2.40.2.5 Mon Mar 10
22:12:35 2008
+++ php-src/ext/session/session.c Tue Mar 11 09:36:41 2008
@@ -17,7 +17,7 @@
+
--+
*/
-/* $Id: session.c,v 1.417.2.8.2.40.2.5 2008/03/10 22:12:35 felipe
Exp $ */
+/* $Id: session.c,v 1.417.2.8.2.40.2.6 2008/03/11 09:36:41 dmitry
Exp $ */
#ifdef HAVE_CONFIG_H
#include "config.h"
@@ -1943,6 +1943,7 @@
for (i = 0; i < 6; i++) {
if (PS(mod_user_names).names[i] != NULL) {
zval_ptr_dtor(&PS(mod_user_names).names[i]);
+ PS(mod_user_names).names[i] = NULL;
}
}
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Ilia Alshanetsky
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
