Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Ilia Alshanetsky
Why the increase? On 21-Mar-08, at 1:13 PM, Marcus Boerger wrote: helly Fri Mar 21 17:13:08 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/main/streamsmmap.c Log: - MFH Increase max mmap size to 8 MB Ilia Alshanetsky -- PHP CVS Mailing List

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Marcus Boerger
Hello Derick, good point, I Dropped the number in gthe comment marcus Friday, March 21, 2008, 6:16:29 PM, you wrote: On Fri, 21 Mar 2008, Marcus Boerger wrote: /* For now, we impose an arbitrary 2MB limit to avoid * runaway swapping when large files are passed thru. */ -

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Marcus Boerger
Hello Ilia, mmapping of larger phars, like the pear installer :-) marcus Friday, March 21, 2008, 6:39:10 PM, you wrote: Why the increase? On 21-Mar-08, at 1:13 PM, Marcus Boerger wrote: helly Fri Mar 21 17:13:08 2008 UTC Modified files: (Branch: PHP_5_3)

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Ilia Alshanetsky
The reason a 2 meg limit was imposed originally was partially due to memory_limit value set in PHP, which at the time was 8 megs. By bumping it to a much higher value, you are quite easily exceeding the memory limit. I am not opposed to increasing the value, but 8megs seems a bit high...

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Marcus Boerger
Hello Ilia, Friday, March 21, 2008, 7:28:36 PM, you wrote: The reason a 2 meg limit was imposed originally was partially due to memory_limit value set in PHP, which at the time was 8 megs. By bumping it to a much higher value, you are quite easily exceeding the memory limit. I am not

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main/streams mmap.c

2008-03-21 Thread Ilia Alshanetsky
I think 4mb would be a better value. On 21-Mar-08, at 2:44 PM, Marcus Boerger wrote: Hello Ilia, Friday, March 21, 2008, 7:28:36 PM, you wrote: The reason a 2 meg limit was imposed originally was partially due to memory_limit value set in PHP, which at the time was 8 megs. By bumping it to