Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main output.c

2008-07-15 Thread Hannes Magnusson
On Tue, Jul 15, 2008 at 11:09, Lars Strojny [EMAIL PROTECTED] wrote:
 lstrojnyTue Jul 15 09:09:09 2008 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src/main   output.c
  Log:
  Return null on when param parsing errors occur

Why?
I see no point in breaking bc just to break it.
Admittedly its not a major issue, but it is still completely pointless.

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main output.c

2008-07-15 Thread Lars Strojny
Hi Hannes,

Am Dienstag, den 15.07.2008, 15:07 +0200 schrieb Hannes Magnusson:
 I see no point in breaking bc just to break it.

that's how it is done elsewhere too. The issue is, there are no tests to
tell us how the behaviour was before the parameter handling was changed
to the new API, so we can only guess. And return null is the better
guess from MPOV.
cu, Lars


signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil


Re: [PHP-CVS] cvs: php-src(PHP_5_3) /main output.c

2008-07-15 Thread Hannes Magnusson
On Tue, Jul 15, 2008 at 15:18, Lars Strojny [EMAIL PROTECTED] wrote:
 Hi Hannes,

 Am Dienstag, den 15.07.2008, 15:07 +0200 schrieb Hannes Magnusson:
 I see no point in breaking bc just to break it.

 that's how it is done elsewhere too. The issue is, there are no tests to
 tell us how the behaviour was before the parameter handling was changed

Which is why it is good practice to write the tests before changing anything.

 to the new API, so we can only guess. And return null is the better
 guess from MPOV.

Some of those functions have been using that API for years...
Why would you need to guess anything anyway?

-Hannes

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php