Re: [PHP-CVS] cvs: php-src / configure.in /ext/fileinfo/libmagic print.c /main snprintf.c snprintf.h

2008-11-27 Thread Ilia Alshanetsky
Is there a reason you do not want to use PHP wrappers  allocation  
protection?



On 27-Nov-08, at 2:45 PM, Scott MacVicar wrote:


scottmacThu Nov 27 19:45:16 2008 UTC

 Modified files:
   /php-src configure.in
   /php-src/ext/fileinfo/libmagic   print.c
   /php-src/mainsnprintf.c snprintf.h
 Log:
 Add asprintf, use regular system malloc and free and add checks in  
configure.in for the functions


Ilia Alshanetsky





--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src / configure.in /ext/fileinfo/libmagic print.c /main snprintf.c snprintf.h

2008-11-27 Thread Scott MacVicar

On 27 Nov 2008, at 20:33, Ilia Alshanetsky wrote:

Is there a reason you do not want to use PHP wrappers  allocation  
protection?



On 27-Nov-08, at 2:45 PM, Scott MacVicar wrote:


scottmacThu Nov 27 19:45:16 2008 UTC

Modified files:
  /php-src  configure.in
  /php-src/ext/fileinfo/libmagicprint.c
  /php-src/main snprintf.c snprintf.h
Log:
Add asprintf, use regular system malloc and free and add checks in  
configure.in for the functions


Ilia Alshanetsky



If you didn't realise you were using a PHP version and used a free()  
as you'd expect to work then you'd get the memory manager complaining  
later on.


Scott

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src / configure.in /ext/fileinfo/libmagic print.c /main snprintf.c snprintf.h

2008-11-27 Thread Ilia Alshanetsky
Do we have other extensions using libmagic other then fileinfo?  
Otherwise, could we not solve it with define flags for fileinfo  
extension?



On 27-Nov-08, at 3:40 PM, Scott MacVicar wrote:


On 27 Nov 2008, at 20:33, Ilia Alshanetsky wrote:

Is there a reason you do not want to use PHP wrappers  allocation  
protection?



On 27-Nov-08, at 2:45 PM, Scott MacVicar wrote:


scottmacThu Nov 27 19:45:16 2008 UTC

Modified files:
 /php-src   configure.in
 /php-src/ext/fileinfo/libmagic print.c
 /php-src/main  snprintf.c snprintf.h
Log:
Add asprintf, use regular system malloc and free and add checks in  
configure.in for the functions


Ilia Alshanetsky



If you didn't realise you were using a PHP version and used a free()  
as you'd expect to work then you'd get the memory manager  
complaining later on.


Scott


Ilia Alshanetsky





--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src / configure.in /ext/fileinfo/libmagic print.c /main snprintf.c snprintf.h

2008-11-27 Thread Scott MacVicar
None at the moment, but this is mainly for Windows. Most of the other  
platforms have these functions already.


Derick mentioend XDebug is already implementing this within its own  
extension code and perhaps there are more that want to use sprintf but  
don't know the size of the output to allocate.


Scott

On 27 Nov 2008, at 21:10, Ilia Alshanetsky wrote:

Do we have other extensions using libmagic other then fileinfo?  
Otherwise, could we not solve it with define flags for fileinfo  
extension?



On 27-Nov-08, at 3:40 PM, Scott MacVicar wrote:


On 27 Nov 2008, at 20:33, Ilia Alshanetsky wrote:

Is there a reason you do not want to use PHP wrappers  allocation  
protection?



On 27-Nov-08, at 2:45 PM, Scott MacVicar wrote:


scottmacThu Nov 27 19:45:16 2008 UTC

Modified files:
/php-srcconfigure.in
/php-src/ext/fileinfo/libmagic  print.c
/php-src/main   snprintf.c snprintf.h
Log:
Add asprintf, use regular system malloc and free and add checks  
in configure.in for the functions


Ilia Alshanetsky



If you didn't realise you were using a PHP version and used a  
free() as you'd expect to work then you'd get the memory manager  
complaining later on.


Scott


Ilia Alshanetsky



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php