Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c

2009-05-09 Thread zoe
Johannes Schlüter wrote: On Sat, 2009-05-09 at 19:37 +, Scott MacVicar wrote: scottmacSat May 9 19:37:34 2009 UTC Modified files: /php-src/ext/spl spl_iterators.c Log: Fix bug #48206 - Iterating over an invalid data structure leads to a segfault

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c

2009-05-09 Thread Scott MacVicar
On 9 May 2009, at 21:42, Johannes Schlüter wrote: On Sat, 2009-05-09 at 19:37 +, Scott MacVicar wrote: scottmacSat May 9 19:37:34 2009 UTC Modified files: /php-src/ext/spl spl_iterators.c Log: Fix bug #48206 - Iterating over an invalid data structure leads to

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c

2009-05-09 Thread Johannes Schlüter
On Sat, 2009-05-09 at 19:37 +, Scott MacVicar wrote: > scottmac Sat May 9 19:37:34 2009 UTC > > Modified files: > /php-src/ext/spl spl_iterators.c > Log: > Fix bug #48206 - Iterating over an invalid data structure leads to a > segfault is there a test

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c

2008-07-19 Thread Marcus Boerger
Hello Derick, Etienne, hmmm. And I though I had that on. marcus Saturday, July 19, 2008, 9:45:25 PM, you wrote: > colder Sat Jul 19 19:45:25 2008 UTC > Modified files: > /php-src/ext/splspl_iterators.c > Log: > Complete the ZTS build fix > > http://cv

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c /ext/spl/tests array_004.phpt array_006.phpt array_008.phpt

2005-12-25 Thread Jani Taskinen
Easy: #undef inline #define inline On Sun, 25 Dec 2005, Marcus Boerger wrote: Hello Jani, though what you said is also true, i can nolonger easily get rid of those inline definitions for debugging purpose. marcus Sunday, December 25, 2005, 5:15:35 PM, you wrote: It was wrong

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c /ext/spl/tests array_004.phpt array_006.phpt array_008.phpt

2005-12-25 Thread Marcus Boerger
Hello Jani, though what you said is also true, i can nolonger easily get rid of those inline definitions for debugging purpose. marcus Sunday, December 25, 2005, 5:15:35 PM, you wrote: > It was wrong since you can safely use inline anywhere. > It's checked elsewhere and re-defined f

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c /ext/spl/tests array_004.phpt array_006.phpt array_008.phpt

2005-12-25 Thread Jani Taskinen
It was wrong since you can safely use inline anywhere. It's checked elsewhere and re-defined for each OS/compiler properly. You're not supposed to create such macros yourself. --Jani On Sun, 25 Dec 2005, Marcus Boerger wrote: Hello Jani, a, jani there was no wrong inli

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c /ext/spl/tests array_004.phpt array_006.phpt array_008.phpt

2005-12-25 Thread Marcus Boerger
Hello Jani, a, jani there was no wrong inline usage, just stupid compilers ignoring the specs, and the way to fix it is to find the places where an inline function is used as a non inline function and prodive a non inline wrapper for it. Which is probably only one single instance. regards m

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c

2005-10-28 Thread Marcus Boerger
Hello Dmitry, Friday, October 28, 2005, 10:07:20 AM, you wrote: > dmitry Fri Oct 28 04:07:20 2005 EDT > Modified files: > /php-src/ext/splspl_iterators.c > Log: > Unicode support > > > http://cvs.php.net/diff.php/php-src/ext/spl/spl_iterators.c?r1=1.92

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c /ext/spl/internal recursiveiteratoriterator.inc

2005-08-01 Thread Andi Gutmans
It's really irrelevant. The fact that something isn't supported doesn't mean you should commit stuff which doesn't fit coding standards. At 04:22 AM 8/2/2005 +0200, Marcus Boerger wrote: Hello Andi, in the end we want class constants but right now we didn't commit that patch. marcus Tuesda

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c /ext/spl/internal recursiveiteratoriterator.inc

2005-08-01 Thread Marcus Boerger
Hello Andi, in the end we want class constants but right now we didn't commit that patch. marcus Tuesday, August 2, 2005, 3:28:39 AM, you wrote: > Aren't these RIT constants against our coding standards? Might be too late > now if it's in 5.0.x but we should stick to plan. Something like > R

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c /ext/spl/internal recursiveiteratoriterator.inc

2005-08-01 Thread Andi Gutmans
Aren't these RIT constants against our coding standards? Might be too late now if it's in 5.0.x but we should stick to plan. Something like RECURSIVE_ITERATOR_SELF_FIRST Andi At 10:19 PM 7/27/2005 +, Marcus Boerger wrote: helly Wed Jul 27 18:19:02 2005 EDT Modified files:

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c

2004-05-31 Thread Marcus Boerger
Hello Zeev, thanks for the fixes here an in ext/ming marcus Sunday, May 30, 2004, 7:32:32 PM, you wrote: > zeev Sun May 30 13:32:32 2004 EDT > Modified files: > /php-src/ext/spl spl_iterators.c > Log: > Fix prototype > http://cvs.php.net/diff.php/php-sr