Re: [PHP-CVS] cvs: php-src /ext/standard exec.c

[Ilia Alshanetsky]

I'll try it tomorrow evening. It seems to work fine for me in 5.2 and  
5.3



Ilia Alshanetsky




On 19-Apr-09, at 5:37 PM, Antony Dovgal wrote:


On 20.04.2009 01:36, Ilia Alshanetsky wrote:

ZTS build?


Yup.
HEAD with ZTS enabled.

--
Wbr,
Antony Dovgal



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/standard exec.c

[Antony Dovgal]

On 20.04.2009 01:36, Ilia Alshanetsky wrote:
> ZTS build?

Yup.
HEAD with ZTS enabled.

-- 
Wbr, 
Antony Dovgal

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/standard exec.c

[Ilia Alshanetsky]

ZTS build?

Ilia Alshanetsky




On 19-Apr-09, at 5:33 PM, Antony Dovgal wrote:


On 19.04.2009 19:00, Ilia Alshanetsky wrote:

if (type == 1) {
PHPWRITE(buf, bufl);
-   sapi_flush(TSRMLS_C);
+   if (OG(ob_nesting_level) < 1) {
+   sapi_flush(TSRMLS_C);
+   }


ext/standard/exec.c: In function 'php_exec':
ext/standard/exec.c:115: error: 'output_globals_id' undeclared  
(first use in this function)
ext/standard/exec.c:115: error: (Each undeclared identifier is  
reported only once

ext/standard/exec.c:115: error: for each function it appears in.)

--
Wbr,
Antony Dovgal

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php




--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/standard exec.c

[Antony Dovgal]

On 19.04.2009 19:00, Ilia Alshanetsky wrote:
>   if (type == 1) {
>   PHPWRITE(buf, bufl);
> - sapi_flush(TSRMLS_C);
> + if (OG(ob_nesting_level) < 1) {
> + sapi_flush(TSRMLS_C);
> + }

ext/standard/exec.c: In function 'php_exec':
ext/standard/exec.c:115: error: 'output_globals_id' undeclared (first use in 
this function)
ext/standard/exec.c:115: error: (Each undeclared identifier is reported only 
once
ext/standard/exec.c:115: error: for each function it appears in.)

-- 
Wbr, 
Antony Dovgal

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/standard exec.c

[Felipe Pena]

Hi Alexey,

Em Qui, 2008-10-16 às 12:21 +, Alexey Zakhlestin escreveu:
> indeyets  Thu Oct 16 12:21:27 2008 UTC
> 
>   Modified files:  
> /php-src/ext/standard exec.c 
>   Log:
>   MFB: Fixed compilation warnings: tsrm_ls is not used here (anymore?)
>   

It is used in somes cases. The php_escape_shell_arg and
php_escape_shell_cmd uses php_mblen():

#ifndef HAVE_MBLEN
# define php_mblen(ptr, len) 1
#else
# if defined(_REENTRANT) && defined(HAVE_MBRLEN) &&
defined(HAVE_MBSTATE_T)
#  define php_mblen(ptr, len) ((ptr) == NULL ?
mbsinit(&BG(mblen_state)): (int)mbrlen(ptr, len, &BG(mblen_state)))
# else
#  define php_mblen(ptr, len) mblen(ptr, len)
# endif
#endif



> http://cvs.php.net/viewvc.cgi/php-src/ext/standard/exec.c?r1=1.136&r2=1.137&diff_format=u
> Index: php-src/ext/standard/exec.c
> diff -u php-src/ext/standard/exec.c:1.136 php-src/ext/standard/exec.c:1.137
> --- php-src/ext/standard/exec.c:1.136 Sun Aug 17 15:23:22 2008
> +++ php-src/ext/standard/exec.c   Thu Oct 16 12:21:27 2008
> @@ -16,7 +16,7 @@
> | Ilia Alshanetsky <[EMAIL PROTECTED]>
>  |
> +--+
>   */
> -/* $Id: exec.c,v 1.136 2008/08/17 15:23:22 pajoye Exp $ */
> +/* $Id: exec.c,v 1.137 2008/10/16 12:21:27 indeyets Exp $ */
>  
>  #include 
>  #include "php.h"
> @@ -253,8 +253,6 @@
>   char *cmd;
>   char *p = NULL;
>   size_t estimate = (2 * l) + 1;
> - 
> - TSRMLS_FETCH();
>  
>   cmd = safe_emalloc(2, l, 1);
>  
> @@ -343,7 +341,6 @@
>   int x, y = 0, l = strlen(str);
>   char *cmd;
>   size_t estimate = (4 * l) + 3;
> - TSRMLS_FETCH();
>  
>   cmd = safe_emalloc(4, l, 3); /* worst case */
>  
> 
> 
> 
-- 
Regards,
Felipe Pena


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php