Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-05 Thread Andi Gutmans 
At 08:52 PM 4/4/2003 +0300, Jani Taskinen wrote:
On Fri, 4 Apr 2003, Rasmus Lerdorf wrote:

Jani, it is not just me.  I think there is pretty much universal agreement
that this error_docref stuff is crap.  We already decided to disable it by
default in 4.3.2.  We haven't discussed it yet, but completely removing it
is probably a good idea.  If there isn't agreement that it is crap, then I
have yet to hear a solid reason for it not being crap.  I initially
thought it was benign and didn't really care either way until we started
seeing all the misguided emails and lawsuit threats.
Oh..it was this issue. Totally forgot about that. :I
(that backfired nicely on my face :)
I'm +100 on removing the docref crap altogether.
Me three.

Andi

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-04 Thread Jani Taskinen 
On Fri, 4 Apr 2003, Sascha Schumann wrote:

On Thu, 3 Apr 2003, Derick Rethans wrote:

 On Thu, 3 Apr 2003, Sascha Schumann wrote:

   Can we please stick to using php_error_docref and try to keep the
   descriptions in the same format (ie. with a capital and a point)?
 
  I don't think php_error_docref adds value to PHP.

 So because *you* dont think so we should do it all different? Come on...

So because *you* think so we should all simply comply? You
must be joking.

Rasmus also already voiced his opposition to this issue.
 
   ROFLMAO..so when Rasmus tells you to jump, you just ask How high, sir? :)
   
   --Jani
   


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-04 Thread Sascha Schumann 
ROFLMAO..so when Rasmus tells you to jump, you just ask How high, sir? :)

*sigh*

Jani, I sincerely hope that you will be able to acquire
some reading comprehension skills within your lifetime, so
that on one fortunate day you will understand the meaning of
the email you replied to.

Good luck from a friend,
- Sascha

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-04 Thread Rasmus Lerdorf 
Jani, it is not just me.  I think there is pretty much universal agreement 
that this error_docref stuff is crap.  We already decided to disable it by 
default in 4.3.2.  We haven't discussed it yet, but completely removing it 
is probably a good idea.  If there isn't agreement that it is crap, then I 
have yet to hear a solid reason for it not being crap.  I initially 
thought it was benign and didn't really care either way until we started 
seeing all the misguided emails and lawsuit threats.

-Rasmus

On Fri, 4 Apr 2003, Jani Taskinen wrote:

 On Fri, 4 Apr 2003, Sascha Schumann wrote:
 
 On Thu, 3 Apr 2003, Derick Rethans wrote:
 
  On Thu, 3 Apr 2003, Sascha Schumann wrote:
 
Can we please stick to using php_error_docref and try to keep the
descriptions in the same format (ie. with a capital and a point)?
  
   I don't think php_error_docref adds value to PHP.
 
  So because *you* dont think so we should do it all different? Come on...
 
 So because *you* think so we should all simply comply? You
 must be joking.
 
 Rasmus also already voiced his opposition to this issue.
  
ROFLMAO..so when Rasmus tells you to jump, you just ask How high, sir? :)

--Jani

 
 
 


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-04 Thread Jani Taskinen 
On Fri, 4 Apr 2003, Rasmus Lerdorf wrote:

Jani, it is not just me.  I think there is pretty much universal agreement 
that this error_docref stuff is crap.  We already decided to disable it by 
default in 4.3.2.  We haven't discussed it yet, but completely removing it 
is probably a good idea.  If there isn't agreement that it is crap, then I 
have yet to hear a solid reason for it not being crap.  I initially 
thought it was benign and didn't really care either way until we started 
seeing all the misguided emails and lawsuit threats.

Oh..it was this issue. Totally forgot about that. :I
(that backfired nicely on my face :)

I'm +100 on removing the docref crap altogether. 

--Jani



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-04 Thread Wez Furlong 
Rather than remove it, lets just disable the URL stuff.
IMO, it is still useful, for debugging purposes, to see in which
function an error was caused.

--Wez.

On Fri, 4 Apr 2003, Jani Taskinen wrote:

 On Fri, 4 Apr 2003, Rasmus Lerdorf wrote:

 Jani, it is not just me.  I think there is pretty much universal agreement
 that this error_docref stuff is crap.  We already decided to disable it by
 default in 4.3.2.  We haven't discussed it yet, but completely removing it
 is probably a good idea.  If there isn't agreement that it is crap, then I
 have yet to hear a solid reason for it not being crap.  I initially
 thought it was benign and didn't really care either way until we started
 seeing all the misguided emails and lawsuit threats.

 Oh..it was this issue. Totally forgot about that. :I
 (that backfired nicely on my face :)

 I'm +100 on removing the docref crap altogether.

 --Jani

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-03 Thread Derick Rethans 
On Thu, 3 Apr 2003, Sascha Schumann wrote:

 sas   Thu Apr  3 14:18:58 2003 EDT
 
   Modified files:  
 /php4/ext/gd  gd.c 
   Log:
   Fix segfaults in imagecreate/imagecreatetruecolor

Can we please stick to using php_error_docref and try to keep the 
descriptions in the same format (ie. with a capital and a point)?

 + if (Z_LVAL_PP(x_size) = 0
 + || Z_LVAL_PP(y_size) = 0) {
 + php_error(E_WARNING, invalid image dimensions);
 + RETURN_FALSE;
 + }
 + 


Derick

-- 
my other box is your windows PC
-
 Derick Rethans http://derickrethans.nl/ 
 PHP Magazine - PHP Magazine for Professionals   http://php-mag.net/
-

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-03 Thread Sascha Schumann 
 Can we please stick to using php_error_docref and try to keep the
 descriptions in the same format (ie. with a capital and a point)?

I don't think php_error_docref adds value to PHP.

- Sascha

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-03 Thread Derick Rethans 
On Thu, 3 Apr 2003, Sascha Schumann wrote:

  Can we please stick to using php_error_docref and try to keep the
  descriptions in the same format (ie. with a capital and a point)?
 
 I don't think php_error_docref adds value to PHP.

So because *you* dont think so we should do it all different? Come on...

Derick

-- 
my other box is your windows PC
-
 Derick Rethans http://derickrethans.nl/ 
 PHP Magazine - PHP Magazine for Professionals   http://php-mag.net/
-

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-03 Thread Marcus Börger 

+   if (dstW  0 || dstH  0 || srcW  0 || srcH  0) {
Why is that not =

marcus

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-03 Thread Ilia A. 
On April 3, 2003 07:35 pm, Marcus Börger wrote:
 +   if (dstW  0 || dstH  0 || srcW  0 || srcH  0) {

 Why is that not =

Why not indeed...

I'll make the change.

Ilia


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-03 Thread Sascha Schumann 
On Thu, 3 Apr 2003, Derick Rethans wrote:

 On Thu, 3 Apr 2003, Sascha Schumann wrote:

   Can we please stick to using php_error_docref and try to keep the
   descriptions in the same format (ie. with a capital and a point)?
 
  I don't think php_error_docref adds value to PHP.

 So because *you* dont think so we should do it all different? Come on...

So because *you* think so we should all simply comply? You
must be joking.

Rasmus also already voiced his opposition to this issue.

- Sascha

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-02-26 Thread Pierre-Alain Joye 
On Wed, 26 Feb 2003 23:22:09 -
Pierre-Alain Joye [EMAIL PROTECTED] wrote:

 pajoyeWed Feb 26 18:22:09 2003 EDT
 
   Modified files:  
 /php4/ext/gd  gd.c 
   Log:
   add imagesavealpha wrapper (Jukka Holappa
   [EMAIL PROTECTED], 
 2 Pierre-Alain Joye)

:/ something has gone wrong with the editor. Sorry

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-02-03 Thread Marcus Börger 
At 12:25 03.02.2003, Jani Taskinen wrote:


Isn't XPM support available with anything but our
bundled GD lib??

--Jani



Current code says it is only available with bundled version
so i added a notice on that. The second reason i did it was
that many people will look at the info and think: Well it is
not mentioned so it is not available.

marcus


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-02-03 Thread Jani Taskinen 
On Mon, 3 Feb 2003, Marcus Börger wrote:

At 19:26 03.02.2003, Jani Taskinen wrote:
I hope you're not mixing Xpm with XBM ?
 Since Xpm funcs ARE available in the GD lib from
 Boutell too..


I hope so, too. I had a look into the source and it has a #ifdef
around teh call which results in XPM only being available in
bundled library. Maybe someone has to check if the reasons

Yeah, as you just added those?

for doing so are meanwhile fixed by boutell. Apart from that
i just enabled/fixed XBM during the weekend.

Or what #ifdeds do you mean?

--Jani



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-02-03 Thread Marcus Börger 
At 19:43 03.02.2003, Jani Taskinen wrote:

On Mon, 3 Feb 2003, Marcus Börger wrote:

At 19:26 03.02.2003, Jani Taskinen wrote:
I hope you're not mixing Xpm with XBM ?
 Since Xpm funcs ARE available in the GD lib from
 Boutell too..


I hope so, too. I had a look into the source and it has a #ifdef
around teh call which results in XPM only being available in
bundled library. Maybe someone has to check if the reasons

Yeah, as you just added those?

for doing so are meanwhile fixed by boutell. Apart from that
i just enabled/fixed XBM during the weekend.

Or what #ifdeds do you mean?

--Jani



I just added #ifdefs for the info output. The function call was already
guarded by those #ifdefs.


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c /ext/gd/libgd gd.c gd.hgd_gd2.c gd_jpeg.c

2003-01-17 Thread Pierre-Alain Joye 
On Fri, 17 Jan 2003 18:34:07 -
Ilia Alshanetsky [EMAIL PROTECTED] wrote:

 iliaa Fri Jan 17 13:34:07 2003 EDT
 
   Modified files:  
 /php4/ext/gd  gd.c 
 /php4/ext/gd/libgdgd.c gd.h gd_gd2.c gd_jpeg.c 
   Log:
   Syncronize bundled GD library with latest GD (2.0.11).
   
   

MFH'ing this commit should be a good thing.

pierre

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c php_gd.h

2002-12-11 Thread Adam Maccabee Trachtenberg 
This patch, or at least this part:

-#ifdef HAVE_GD_XPM
+#if defined(HAVE_GD_XPM)  defined(HAVE_GD_BUNDLED)

Needs to be merged into the 4.3.0. Something in the build broke my GD
support between RC2 and RC3. This fixes it.

-adam

On Wed, 11 Dec 2002, Ilia Alshanetsky wrote:

 iliaa Wed Dec 11 17:25:24 2002 EDT
 
   Modified files:  
 /php4/ext/gd  gd.c php_gd.h 
   Log:
   Fixed build with non-bundled GD. Hidden the anti-alias functions when 
   non-bundled GD is used and made imagecreatefromxpm() unavailable because 
   of a bug in the external GD library.
   
   
 Index: php4/ext/gd/gd.c
 diff -u php4/ext/gd/gd.c:1.238 php4/ext/gd/gd.c:1.239
 --- php4/ext/gd/gd.c:1.238Wed Dec 11 15:44:44 2002
 +++ php4/ext/gd/gd.c  Wed Dec 11 17:25:22 2002
 @@ -18,7 +18,7 @@
 +--+
   */
  
 -/* $Id: gd.c,v 1.238 2002/12/11 20:44:44 pajoye Exp $ */
 +/* $Id: gd.c,v 1.239 2002/12/11 22:25:22 iliaa Exp $ */
  
  /* gd 1.2 is copyright 1994, 1995, Quest Protein Database Center, 
 Cold Spring Harbor Labs. */
 @@ -224,7 +224,7 @@
  #ifdef HAVE_GD_XBM
   PHP_FE(imagecreatefromxbm,  NULL)
  #endif
 -#ifdef HAVE_GD_XPM
 +#if defined(HAVE_GD_XPM)  defined(HAVE_GD_BUNDLED)
   PHP_FE(imagecreatefromxpm,  NULL)
  #endif
   PHP_FE(imagecreatefromgd,   NULL)
 @@ -1441,7 +1441,7 @@
   case PHP_GDIMG_TYPE_GD2PART:
   im = (*func_p)(fp, Z_LVAL_PP(srcx), Z_LVAL_PP(srcy), 
Z_LVAL_PP(width), Z_LVAL_PP(height));
   break;
 -#ifdef HAVE_GD_XPM
 +#if defined(HAVE_GD_XPM)  defined(HAVE_GD_BUNDLED)
   case PHP_GDIMG_TYPE_XPM:
   im = gdImageCreateFromXpm(fn);
   break;
 @@ -1508,7 +1508,7 @@
  /* }}} */
  #endif /* HAVE_GD_XBM */
  
 -#ifdef HAVE_GD_XPM
 +#if defined(HAVE_GD_XPM)  defined(HAVE_GD_BUNDLED)
  /* {{{ proto int imagecreatefromxpm(string filename)
 Create a new image from XPM file or URL */
  PHP_FUNCTION(imagecreatefromxpm)
 @@ -2130,7 +2130,6 @@
  {
   zval **IM, **x1, **y1, **x2, **y2, **col;
   gdImagePtr im;
 - int antialias=0;
  
   if (ZEND_NUM_ARGS() != 6 || zend_get_parameters_ex(6, IM, x1, y1, x2, y2, 
col) == FAILURE) {
   ZEND_WRONG_PARAM_COUNT();
 @@ -2145,14 +2144,11 @@
   convert_to_long_ex(col);
  
  #ifdef HAVE_GD_BUNDLED
 - antialias = im-antialias;
 -#endif
 - if (antialias) {
 + if (im-antialias)
   gdImageAALine(im, Z_LVAL_PP(x1), Z_LVAL_PP(y1), Z_LVAL_PP(x2), 
Z_LVAL_PP(y2), Z_LVAL_PP(col));
 - } else {
 + else 
 +#endif   
   gdImageLine(im, Z_LVAL_PP(x1), Z_LVAL_PP(y1), Z_LVAL_PP(x2), 
Z_LVAL_PP(y2), Z_LVAL_PP(col));
 - }
 -  
   
   gdImageLine(im, Z_LVAL_PP(x1), Z_LVAL_PP(y1), Z_LVAL_PP(x2), Z_LVAL_PP(y2), 
Z_LVAL_PP(col));
   RETURN_TRUE;
 @@ -4074,7 +4070,7 @@
   }
  }
  /* }}} */
 -#endif
 +/* End section: Filters */
  
  /* {{{ proto imagesetantialias(int im, bool on)
  Should antialiased functions used or not*/
 @@ -4092,8 +4088,7 @@
   RETURN_TRUE;
  }
  /* }}} */
 -

 -/* End section: Filters */
 +#endif
  
  /*
   * Local variables:
 Index: php4/ext/gd/php_gd.h
 diff -u php4/ext/gd/php_gd.h:1.48 php4/ext/gd/php_gd.h:1.49
 --- php4/ext/gd/php_gd.h:1.48 Wed Dec 11 15:45:47 2002
 +++ php4/ext/gd/php_gd.h  Wed Dec 11 17:25:23 2002
 @@ -17,7 +17,7 @@
 +--+
  */
  
 -/* $Id: php_gd.h,v 1.48 2002/12/11 20:45:47 pajoye Exp $ */
 +/* $Id: php_gd.h,v 1.49 2002/12/11 22:25:23 iliaa Exp $ */
  
  #ifndef PHP_GD_H
  #define PHP_GD_H
 @@ -112,12 +112,14 @@
  PHP_FUNCTION(imagecreatefromgif);
  PHP_FUNCTION(imagecreatefromjpeg);
  PHP_FUNCTION(imagecreatefromxbm);
 -PHP_FUNCTION(imagecreatefromxpm);
  PHP_FUNCTION(imagecreatefrompng);
  PHP_FUNCTION(imagecreatefromwbmp);
  PHP_FUNCTION(imagecreatefromgd);
  PHP_FUNCTION(imagecreatefromgd2);
  PHP_FUNCTION(imagecreatefromgd2part);
 +#if defined(HAVE_GD_XPM)  defined(HAVE_GD_BUNDLED)
 +PHP_FUNCTION(imagecreatefromxpm);
 +#endif
  
  PHP_FUNCTION(imagegammacorrect);
  PHP_FUNCTION(imagedestroy);
 
 
 
 


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-12-03 Thread Derick Rethans 
On Wed, 4 Dec 2002, Pierre-Alain Joye wrote:

 pajoyeTue Dec  3 21:48:23 2002 EDT
 
   Modified files:  
 /php4/ext/gd  gd.c 
   Log:
   Fix imagegd stdoutput
   Typo 256 colors
   
   
   }
   (*func_p)(im, q, tmp);
   break;
 +case PHP_GDIMG_TYPE_GD:
 +if(im-trueColor){
 + gdImageTrueColorToPalette(im,1,256);
 + }
 +(*func_p)(im, tmp);
 +break;
   default:
   (*func_p)(im, tmp);
   break;

Can you please watch your whitespace here?

Derick

-- 

-
 Derick Rethans http://derickrethans.nl/ 
 PHP Magazine - PHP Magazine for Professionals   http://php-mag.net/
-


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-11-14 Thread Marcus Börger 
Plase make sure you are using a TSRM build while developing.

[marcuszaphod PHP_4_3_0]$ ./configure --help|grep tsrm
  --with-tsrm-pth[=pth-config]Use GNU Pth.
  --with-tsrm-st
  --with-tsrm-pthreadsUse POSIX threads (default)

marcus

At 16:09 14.11.2002, Marcus Boerger wrote:

helly   Thu Nov 14 10:09:53 2002 EDT

  Modified files:
/php4/ext/gdgd.c
  Log:
  Fix TSRM build


Index: php4/ext/gd/gd.c
diff -u php4/ext/gd/gd.c:1.222 php4/ext/gd/gd.c:1.223
--- php4/ext/gd/gd.c:1.222  Wed Nov 13 15:02:58 2002
+++ php4/ext/gd/gd.cThu Nov 14 10:09:53 2002
 -18,7 +18,7 
+--+
  */

-/* $Id: gd.c,v 1.222 2002/11/13 20:02:58 iliaa Exp $ */
+/* $Id: gd.c,v 1.223 2002/11/14 15:09:53 helly Exp $ */

 /* gd 1.2 is copyright 1994, 1995, Quest Protein Database Center,
Cold Spring Harbor Labs. */
 -3806,7 +3806,7 
gdImagePtr im_src;
long brightness, tmp;

-   if (ZEND_NUM_ARGS()!=3 || zend_parse_parameters(3, zll, SIM, 
tmp, brightness) == FAILURE) {
+   if (ZEND_NUM_ARGS()!=3 || zend_parse_parameters(3 TSRMLS_CC, 
zll, SIM, tmp, brightness) == FAILURE) {
ZEND_WRONG_PARAM_COUNT();
}

 -3826,7 +3826,7 
gdImagePtr im_src;
long contrast, tmp;

-   if (ZEND_NUM_ARGS()!=3 || zend_parse_parameters(3, rll, SIM, 
tmp, contrast) == FAILURE) {
+   if (ZEND_NUM_ARGS()!=3 || zend_parse_parameters(3 TSRMLS_CC, 
rll, SIM, tmp, contrast) == FAILURE) {
ZEND_WRONG_PARAM_COUNT();
}

 -3846,7 +3846,7 
gdImagePtr im_src;
long r,g,b,tmp;

-   if (ZEND_NUM_ARGS()!=5 || zend_parse_parameters(5, r, SIM, 
tmp, r, g, b) == FAILURE) {
+   if (ZEND_NUM_ARGS()!=5 || zend_parse_parameters(5 TSRMLS_CC, 
r, SIM, tmp, r, g, b) == FAILURE) {
ZEND_WRONG_PARAM_COUNT();
}

 -3962,7 +3962,7 
gdImagePtr im_src;
double weight;

-   if (ZEND_NUM_ARGS()!=3 || zend_parse_parameters(3, rld, SIM, 
tmp, weight) == FAILURE) {
+   if (ZEND_NUM_ARGS()!=3 || zend_parse_parameters(3 TSRMLS_CC, 
rld, SIM, tmp, weight) == FAILURE) {
ZEND_WRONG_PARAM_COUNT();
}

 -3999,7 +3999,7 
php_image_filter_smooth
};

-   if (ZEND_NUM_ARGS()2 || ZEND_NUM_ARGS()5 || 
zend_parse_parameters(2, rl, tmp, filtertype) == FAILURE) {
+   if (ZEND_NUM_ARGS()2 || ZEND_NUM_ARGS()5 || 
zend_parse_parameters(2 TSRMLS_CC, rl, tmp, filtertype) == FAILURE) {
ZEND_WRONG_PARAM_COUNT();
}




--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-11-14 Thread Derick Rethans 
On Thu, 14 Nov 2002, Marcus Börger wrote:

 Plase make sure you are using a TSRM build while developing.
 
 [marcuszaphod PHP_4_3_0]$ ./configure --help|grep tsrm
--with-tsrm-pth[=pth-config]Use GNU Pth.
--with-tsrm-st
--with-tsrm-pthreadsUse POSIX threads (default)

You meant this switch I think, as those switches only select the 
threading library:

--enable-experimental-zts

Derick

-- 

---
 Derick Rethans   http://derickrethans.nl/ 
 JDI Media Solutions
--[ if you hold a unix shell to your ear, do you hear the c? ]-


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-11-14 Thread Marcus Börger 
Ups - Sorry - i missed that one of cause...thanks

At 16:25 14.11.2002, Derick Rethans wrote:

On Thu, 14 Nov 2002, Marcus Börger wrote:

 Plase make sure you are using a TSRM build while developing.

 [marcuszaphod PHP_4_3_0]$ ./configure --help|grep tsrm
--with-tsrm-pth[=pth-config]Use GNU Pth.
--with-tsrm-st
--with-tsrm-pthreadsUse POSIX threads (default)

You meant this switch I think, as those switches only select the
threading library:

--enable-experimental-zts

Derick

--

---
 Derick Rethans   http://derickrethans.nl/
 JDI Media Solutions
--[ if you hold a unix shell to your ear, do you hear the c? ]-


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-10-11 Thread Andi Gutmans 

I don't think this is a good idea. I'd definitely change the name to 
GD_something but it still doesn't make so much sense to me. When would 
people use this and not function_exists()?

Andi

At 09:49 AM 10/11/2002 +, Derick Rethans wrote:
derick  Fri Oct 11 05:49:38 2002 EDT

   Modified files:
 /php4/ext/gdgd.c
   Log:
   - Add indetified for bundled GD


Index: php4/ext/gd/gd.c
diff -u php4/ext/gd/gd.c:1.214 php4/ext/gd/gd.c:1.215
--- php4/ext/gd/gd.c:1.214  Thu Sep 19 21:25:55 2002
+++ php4/ext/gd/gd.cFri Oct 11 05:49:38 2002
 -18,7 +18,7 
 +--+
   */

-/* $Id: gd.c,v 1.214 2002/09/20 01:25:55 iliaa Exp $ */
+/* $Id: gd.c,v 1.215 2002/10/11 09:49:38 derick Exp $ */

  /* gd 1.2 is copyright 1994, 1995, Quest Protein Database Center,
 Cold Spring Harbor Labs. */
 -346,6 +346,9 
 REGISTER_LONG_CONSTANT(IMG_EFFECT_ALPHABLEND, 
 gdEffectAlphaBlend, CONST_CS | CONST_PERSISTENT);
 REGISTER_LONG_CONSTANT(IMG_EFFECT_NORMAL, gdEffectNormal, 
 CONST_CS | CONST_PERSISTENT);
 REGISTER_LONG_CONSTANT(IMG_EFFECT_OVERLAY, gdEffectOverlay, 
 CONST_CS | CONST_PERSISTENT);
+   REGISTER_LONG_CONSTANT(HAVE_BUNDLED_GD, 1, CONST_CS | 
CONST_PERSISTENT);
+#else
+   REGISTER_LONG_CONSTANT(HAVE_BUNDLED_GD, 0, CONST_CS | 
CONST_PERSISTENT);
  #endif
 return SUCCESS;
  }



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-10-11 Thread Rasmus Lerdorf 

On Fri, 11 Oct 2002, Pierre-Alain Joye wrote:

 On Fri, 11 Oct 2002 05:53:18 -0700 (PDT)
 Rasmus Lerdorf [EMAIL PROTECTED] wrote:

  I don't think we can do that.  Like someone said, they have to use GIF
  in order to generate images for a mobile device.  That means they
  either need to use GD-1.3 or a hacked up later version.

 Is only the compression system licenced ? Anyway, that is not too
 difficult to add GIF support to the bundled (maybe not in the upcoming
 release), regardless to the licence, which I did not take about it as
 far as I do not use gif anymore.

I see very little point in adding non-compressed GIF write support.  The
people who need it are going to need compressed GIF.  You are not going to
want to use uncompressed GIF images on a small mobile device, for example.

I'll put compressed GIF write in the next version as the LZW patent should
be expired by then.

-Rasmus


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-10-11 Thread Pierre-Alain Joye 

On Fri, 11 Oct 2002 05:53:18 -0700 (PDT)
Rasmus Lerdorf [EMAIL PROTECTED] wrote:

 I don't think we can do that.  Like someone said, they have to use GIF
 in order to generate images for a mobile device.  That means they
 either need to use GD-1.3 or a hacked up later version.

Is only the compression system licenced ? Anyway, that is not too
difficult to add GIF support to the bundled (maybe not in the upcoming
release), regardless to the licence, which I did not take about it as
far as I do not use gif anymore.

pa

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-10-11 Thread Andi Gutmans 

At 02:50 PM 10/11/2002 +0200, Derick Rethans wrote:
On Fri, 11 Oct 2002, Andi Gutmans wrote:

  I don't think this is a good idea. I'd definitely change the name to
  GD_something but it still doesn't make so much sense to me. When would
  people use this and not function_exists()?

Because some functions behave different in the bundled and non-bundled
versions of GD. This will only become more of a problem as we're fixing
more in the bundled library.

In that case we should maybe consider to only allow the bundled one.
Anyway, although I am -1 for this constant if it is decided to keep it it 
should be GD_*.

Andi


Derick

  At 09:49 AM 10/11/2002 +, Derick Rethans wrote:
  derick  Fri Oct 11 05:49:38 2002 EDT
  
 Modified files:
   /php4/ext/gdgd.c
 Log:
 - Add indetified for bundled GD
  
  
  Index: php4/ext/gd/gd.c
  diff -u php4/ext/gd/gd.c:1.214 php4/ext/gd/gd.c:1.215
  --- php4/ext/gd/gd.c:1.214  Thu Sep 19 21:25:55 2002
  +++ php4/ext/gd/gd.cFri Oct 11 05:49:38 2002
   -18,7 +18,7 
   
 +--+
 */
  
  -/* $Id: gd.c,v 1.214 2002/09/20 01:25:55 iliaa Exp $ */
  +/* $Id: gd.c,v 1.215 2002/10/11 09:49:38 derick Exp $ */
  
/* gd 1.2 is copyright 1994, 1995, Quest Protein Database Center,
   Cold Spring Harbor Labs. */
   -346,6 +346,9 
   REGISTER_LONG_CONSTANT(IMG_EFFECT_ALPHABLEND,
   gdEffectAlphaBlend, CONST_CS | CONST_PERSISTENT);
   REGISTER_LONG_CONSTANT(IMG_EFFECT_NORMAL, gdEffectNormal,
   CONST_CS | CONST_PERSISTENT);
   REGISTER_LONG_CONSTANT(IMG_EFFECT_OVERLAY, gdEffectOverlay,
   CONST_CS | CONST_PERSISTENT);
  +   REGISTER_LONG_CONSTANT(HAVE_BUNDLED_GD, 1, CONST_CS |
  CONST_PERSISTENT);
  +#else
  +   REGISTER_LONG_CONSTANT(HAVE_BUNDLED_GD, 0, CONST_CS |
  CONST_PERSISTENT);
#endif
   return SUCCESS;
}
  
  
  
  --
  PHP CVS Mailing List (http://www.php.net/)
  To unsubscribe, visit: http://www.php.net/unsub.php
 

--

---
  Derick Rethans   http://derickrethans.nl/
  JDI Media Solutions
--[ if you hold a unix shell to your ear, do you hear the c? ]-


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-10-11 Thread Derick Rethans 

On Fri, 11 Oct 2002, Andi Gutmans wrote:

 I don't think this is a good idea. I'd definitely change the name to 
 GD_something but it still doesn't make so much sense to me. When would 
 people use this and not function_exists()?

Because some functions behave different in the bundled and non-bundled 
versions of GD. This will only become more of a problem as we're fixing 
more in the bundled library.

Derick

 At 09:49 AM 10/11/2002 +, Derick Rethans wrote:
 derick  Fri Oct 11 05:49:38 2002 EDT
 
Modified files:
  /php4/ext/gdgd.c
Log:
- Add indetified for bundled GD
 
 
 Index: php4/ext/gd/gd.c
 diff -u php4/ext/gd/gd.c:1.214 php4/ext/gd/gd.c:1.215
 --- php4/ext/gd/gd.c:1.214  Thu Sep 19 21:25:55 2002
 +++ php4/ext/gd/gd.cFri Oct 11 05:49:38 2002
  -18,7 +18,7 
  +--+
*/
 
 -/* $Id: gd.c,v 1.214 2002/09/20 01:25:55 iliaa Exp $ */
 +/* $Id: gd.c,v 1.215 2002/10/11 09:49:38 derick Exp $ */
 
   /* gd 1.2 is copyright 1994, 1995, Quest Protein Database Center,
  Cold Spring Harbor Labs. */
  -346,6 +346,9 
  REGISTER_LONG_CONSTANT(IMG_EFFECT_ALPHABLEND, 
  gdEffectAlphaBlend, CONST_CS | CONST_PERSISTENT);
  REGISTER_LONG_CONSTANT(IMG_EFFECT_NORMAL, gdEffectNormal, 
  CONST_CS | CONST_PERSISTENT);
  REGISTER_LONG_CONSTANT(IMG_EFFECT_OVERLAY, gdEffectOverlay, 
  CONST_CS | CONST_PERSISTENT);
 +   REGISTER_LONG_CONSTANT(HAVE_BUNDLED_GD, 1, CONST_CS | 
 CONST_PERSISTENT);
 +#else
 +   REGISTER_LONG_CONSTANT(HAVE_BUNDLED_GD, 0, CONST_CS | 
 CONST_PERSISTENT);
   #endif
  return SUCCESS;
   }
 
 
 
 --
 PHP CVS Mailing List (http://www.php.net/)
 To unsubscribe, visit: http://www.php.net/unsub.php
 

--

---
 Derick Rethans   http://derickrethans.nl/ 
 JDI Media Solutions
--[ if you hold a unix shell to your ear, do you hear the c? ]-


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php