Re: [PHP-CVS] cvs: phpruntests /phpt-tests hw.phpsample_expectheaders.phpt sample_fileexternal.phpt

2009-04-23 Thread zoe

Greg Beaver wrote:

Johannes Schlüter wrote:
  

On Wed, 2009-04-22 at 17:37 -0500, Greg Beaver wrote:
  


Johannes Schlüter wrote:

  

Hi,

On Wed, 2009-04-22 at 16:14 +, Zoe Slattery wrote:

  


--EXPECTHEADERS--
Status: 404 Not Found
X-Powered-By: PHP/5.3.0RC2-dev
Content-type: text/html

--EXPECT--

  

shouldn't that support %s modifiers? I'm quite sure the X-Powered-By
header will change quite often and it will be painful to change them all
the time :-)
  


Probably better is to remove the X-Powered-By in this test, since its
point is only to verify that EXPECTHEADERS is working?

  

Wasn't sure whether it means expecting all of them or just at least
them (in a random order?)


it means all of these headers must be present, but others may be as well
  
I'll remove the X-Powered-By. As Greg says, all I'm doing at this stage 
is to define the most simple possible sample test for each of the CGI 
sections. As I'm not familiar with the cgi sapi at all I grateful for 
any advice :-)


Thanks, Z


Greg


  



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: phpruntests /phpt-tests hw.phpsample_expectheaders.phpt sample_fileexternal.phpt

2009-04-22 Thread Greg Beaver
Johannes Schlüter wrote:
 Hi,
 
 On Wed, 2009-04-22 at 16:14 +, Zoe Slattery wrote:
 
 --EXPECTHEADERS--
 Status: 404 Not Found
 X-Powered-By: PHP/5.3.0RC2-dev
 Content-type: text/html

 --EXPECT--
 
 shouldn't that support %s modifiers? I'm quite sure the X-Powered-By
 header will change quite often and it will be painful to change them all
 the time :-)

Probably better is to remove the X-Powered-By in this test, since its
point is only to verify that EXPECTHEADERS is working?

Greg

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: phpruntests /phpt-tests hw.phpsample_expectheaders.phpt sample_fileexternal.phpt

2009-04-22 Thread Johannes Schlüter
On Wed, 2009-04-22 at 17:37 -0500, Greg Beaver wrote:
 Johannes Schlüter wrote:
  Hi,
  
  On Wed, 2009-04-22 at 16:14 +, Zoe Slattery wrote:
  
  --EXPECTHEADERS--
  Status: 404 Not Found
  X-Powered-By: PHP/5.3.0RC2-dev
  Content-type: text/html
 
  --EXPECT--
  
  shouldn't that support %s modifiers? I'm quite sure the X-Powered-By
  header will change quite often and it will be painful to change them all
  the time :-)
 
 Probably better is to remove the X-Powered-By in this test, since its
 point is only to verify that EXPECTHEADERS is working?

Wasn't sure whether it means expecting all of them or just at least
them (in a random order?)

johannes



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: phpruntests /phpt-tests hw.phpsample_expectheaders.phpt sample_fileexternal.phpt

2009-04-22 Thread Greg Beaver
Johannes Schlüter wrote:
 On Wed, 2009-04-22 at 17:37 -0500, Greg Beaver wrote:
   
 Johannes Schlüter wrote:
 
 Hi,

 On Wed, 2009-04-22 at 16:14 +, Zoe Slattery wrote:

   
 --EXPECTHEADERS--
 Status: 404 Not Found
 X-Powered-By: PHP/5.3.0RC2-dev
 Content-type: text/html

 --EXPECT--
 
 shouldn't that support %s modifiers? I'm quite sure the X-Powered-By
 header will change quite often and it will be painful to change them all
 the time :-)
   
 Probably better is to remove the X-Powered-By in this test, since its
 point is only to verify that EXPECTHEADERS is working?
 

 Wasn't sure whether it means expecting all of them or just at least
 them (in a random order?)
it means all of these headers must be present, but others may be as well

Greg


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php