Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/main/php_ini.c trunk/main/php_ini.c

[Antony Dovgal]

On 08.06.2010 17:04, Johannes Schlüter wrote:
> Hi,
> 
> On Tue, 2010-06-08 at 12:54 +, Antony Dovgal wrote:
>> Modified: php/php-src/branches/PHP_5_3/main/php_ini.c
>> ===
>> --- php/php-src/branches/PHP_5_3/main/php_ini.c  2010-06-08 12:51:02 UTC 
>> (rev 300271)
>> +++ php/php-src/branches/PHP_5_3/main/php_ini.c  2010-06-08 12:54:11 UTC 
>> (rev 300272)
>> @@ -346,7 +346,9 @@
>>   */
>>  static void php_load_php_extension_cb(void *arg TSRMLS_DC)
>>  {
>> +#ifdef HAVE_LIBDL
>>  php_load_extension(*((char **) arg), MODULE_PERSISTENT, 0 TSRMLS_CC);
>> +#endif
>>  }
> 
> Won't an error message in an #else block make sense?

No, I don't think so.
Also zend_load_extension() doesn't output any errors in this case.

-- 
Wbr,
Antony Dovgal
---
http://pinba.org - realtime statistics for PHP

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/main/php_ini.c trunk/main/php_ini.c

[Johannes Schlüter]

Hi,

On Tue, 2010-06-08 at 12:54 +, Antony Dovgal wrote:
> Modified: php/php-src/branches/PHP_5_3/main/php_ini.c
> ===
> --- php/php-src/branches/PHP_5_3/main/php_ini.c   2010-06-08 12:51:02 UTC 
> (rev 300271)
> +++ php/php-src/branches/PHP_5_3/main/php_ini.c   2010-06-08 12:54:11 UTC 
> (rev 300272)
> @@ -346,7 +346,9 @@
>   */
>  static void php_load_php_extension_cb(void *arg TSRMLS_DC)
>  {
> +#ifdef HAVE_LIBDL
>   php_load_extension(*((char **) arg), MODULE_PERSISTENT, 0 TSRMLS_CC);
> +#endif
>  }

Won't an error message in an #else block make sense?

johannes



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php