Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/sysvshm/tests/001.phpt branches/PHP_5_4/ext/sysvshm/tests/001.phpt trunk/ext/sysvshm/tests/001.phpt
Hi 2011/9/6 Hannes Magnusson : > Can you post the diff? > I don't see any reason why it should fail.. Windows for one does not implement a native ftok() function, and the general use with ftok() was together with sysvshm(). If we have such an implementation, it would make sense to enable sysvshm on Windows too. But back to subject, I agree that we should move both the function and tests if there is no other valuable uses for ftok() outside of that extension. -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/sysvshm/tests/001.phpt branches/PHP_5_4/ext/sysvshm/tests/001.phpt trunk/ext/sysvshm/tests/001.phpt
Can you post the diff? I don't see any reason why it should fail.. -Hannes On Tue, Sep 6, 2011 at 11:29, Pierre Joye wrote: > no idea but this test is in there and fails when the ext is not > loadead, so I simply skip if the ext is not available. Feel free to > move this test if its location is wrong. > > On Tue, Sep 6, 2011 at 11:27 AM, Hannes Magnusson > wrote: >> On Tue, Sep 6, 2011 at 09:49, Pierre Joye wrote: >>> pajoye Tue, 06 Sep 2011 07:49:31 + >>> >>> Revision: http://svn.php.net/viewvc?view=revision&revision=316230 >>> >>> Log: >>> - add skipif >>> >>> Changed paths: >>> U php/php-src/branches/PHP_5_3/ext/sysvshm/tests/001.phpt >>> U php/php-src/branches/PHP_5_4/ext/sysvshm/tests/001.phpt >>> U php/php-src/trunk/ext/sysvshm/tests/001.phpt >>> >>> Modified: php/php-src/branches/PHP_5_3/ext/sysvshm/tests/001.phpt >>> === >>> --- php/php-src/branches/PHP_5_3/ext/sysvshm/tests/001.phpt 2011-09-06 >>> 07:47:20 UTC (rev 316229) >>> +++ php/php-src/branches/PHP_5_3/ext/sysvshm/tests/001.phpt 2011-09-06 >>> 07:49:31 UTC (rev 316230) >>> @@ -1,5 +1,7 @@ >>> --TEST-- >>> ftok() tests >>> +--SKIPIF-- >>> + >> >> >> ftok() is actually not part of syssvhm, its defined in the standard >> ext (ext/standard/ftok.c). >> >> >> -Hannes >> >> -- >> PHP CVS Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > > > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org > -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/sysvshm/tests/001.phpt branches/PHP_5_4/ext/sysvshm/tests/001.phpt trunk/ext/sysvshm/tests/001.phpt
no idea but this test is in there and fails when the ext is not loadead, so I simply skip if the ext is not available. Feel free to move this test if its location is wrong. On Tue, Sep 6, 2011 at 11:27 AM, Hannes Magnusson wrote: > On Tue, Sep 6, 2011 at 09:49, Pierre Joye wrote: >> pajoye Tue, 06 Sep 2011 07:49:31 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=316230 >> >> Log: >> - add skipif >> >> Changed paths: >> U php/php-src/branches/PHP_5_3/ext/sysvshm/tests/001.phpt >> U php/php-src/branches/PHP_5_4/ext/sysvshm/tests/001.phpt >> U php/php-src/trunk/ext/sysvshm/tests/001.phpt >> >> Modified: php/php-src/branches/PHP_5_3/ext/sysvshm/tests/001.phpt >> === >> --- php/php-src/branches/PHP_5_3/ext/sysvshm/tests/001.phpt 2011-09-06 >> 07:47:20 UTC (rev 316229) >> +++ php/php-src/branches/PHP_5_3/ext/sysvshm/tests/001.phpt 2011-09-06 >> 07:49:31 UTC (rev 316230) >> @@ -1,5 +1,7 @@ >> --TEST-- >> ftok() tests >> +--SKIPIF-- >> + > > > ftok() is actually not part of syssvhm, its defined in the standard > ext (ext/standard/ftok.c). > > > -Hannes > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/sysvshm/tests/001.phpt branches/PHP_5_4/ext/sysvshm/tests/001.phpt trunk/ext/sysvshm/tests/001.phpt
On Tue, Sep 6, 2011 at 09:49, Pierre Joye wrote: > pajoye Tue, 06 Sep 2011 07:49:31 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=316230 > > Log: > - add skipif > > Changed paths: > U php/php-src/branches/PHP_5_3/ext/sysvshm/tests/001.phpt > U php/php-src/branches/PHP_5_4/ext/sysvshm/tests/001.phpt > U php/php-src/trunk/ext/sysvshm/tests/001.phpt > > Modified: php/php-src/branches/PHP_5_3/ext/sysvshm/tests/001.phpt > === > --- php/php-src/branches/PHP_5_3/ext/sysvshm/tests/001.phpt 2011-09-06 > 07:47:20 UTC (rev 316229) > +++ php/php-src/branches/PHP_5_3/ext/sysvshm/tests/001.phpt 2011-09-06 > 07:49:31 UTC (rev 316230) > @@ -1,5 +1,7 @@ > --TEST-- > ftok() tests > +--SKIPIF-- > + ftok() is actually not part of syssvhm, its defined in the standard ext (ext/standard/ftok.c). -Hannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
