Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/oci8/tests/null_byte_1.phpt trunk/ext/oci8/tests/null_byte_1.phpt

2011-06-07 Thread Kalle Sommer Nielsen 
Hi Chris

2011/6/7 Christopher Jones s...@php.net:
 -Warning: OCI-Lob::savefile(): Filename cannot contain null bytes in 
 %snull_byte_1.php on line %d
 -bool(false)
 +Warning: OCI-Lob::savefile() expects parameter 1 to be valid path, string 
 given in %snull_byte_1.php on line %d
 +NULL

Just a note here unrelated to this patch but the change; wouldn't we
want the error message to say to be A valid path to be more
grammatically correct?

-- 
regards,

Kalle Sommer Nielsen
ka...@php.net

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/oci8/tests/null_byte_1.phpt trunk/ext/oci8/tests/null_byte_1.phpt

2011-06-07 Thread Christopher Jones 




On 06/07/2011 02:26 PM, Kalle Sommer Nielsen wrote:

Hi Chris

2011/6/7 Christopher Joness...@php.net:

-Warning: OCI-Lob::savefile(): Filename cannot contain null bytes in 
%snull_byte_1.php on line %d
-bool(false)
+Warning: OCI-Lob::savefile() expects parameter 1 to be valid path, string 
given in %snull_byte_1.php on line %d
+NULL


Just a note here unrelated to this patch but the change; wouldn't we
want the error message to say to be A valid path to be more
grammatically correct?



Hi Kalle,

Yes, I noticed that issue. I decided to sync the logs with Felipe's
code change first and then bring up the message text at an appropriate
time.

Chris

--
Email: christopher.jo...@oracle.com
Tel:  +1 650 506 8630
Blog:  http://blogs.oracle.com/opal/

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php