Hi: arpad, plz review this change, and btw, most mod_use_class phpt test failed in my environ due to %x, like:
003+ Read 2dv964ea5joi1pah2nad6e3pm5 004+ string(26) "2dv964ea5joi1pah2nad6e3pm5" 003- Read %x 004- string(32) "%x" thanks 2011/9/14 Xinchen Hui <larue...@php.net>: > laruence Wed, 14 Sep 2011 04:10:45 +0000 > > Revision: http://svn.php.net/viewvc?view=revision&revision=316711 > > Log: > Fix bug #55688 (Crash when calling SessionHandler::gc()) > Need arpad to review this change > > Bug: https://bugs.php.net/55688 (Open) Crash when calling SessionHandler::gc() > > Changed paths: > U php/php-src/branches/PHP_5_4/ext/session/mod_user_class.c > U php/php-src/trunk/ext/session/mod_user_class.c > > Modified: php/php-src/branches/PHP_5_4/ext/session/mod_user_class.c > =================================================================== > --- php/php-src/branches/PHP_5_4/ext/session/mod_user_class.c 2011-09-14 > 04:06:32 UTC (rev 316710) > +++ php/php-src/branches/PHP_5_4/ext/session/mod_user_class.c 2011-09-14 > 04:10:45 UTC (rev 316711) > @@ -133,7 +133,7 @@ > long maxlifetime; > int nrdels; > > - PS_SANITY_CHECK; > + PS_SANITY_CHECK_IS_OPEN; > > if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "l", > &maxlifetime) == FAILURE) { > return; > > Modified: php/php-src/trunk/ext/session/mod_user_class.c > =================================================================== > --- php/php-src/trunk/ext/session/mod_user_class.c 2011-09-14 04:06:32 > UTC (rev 316710) > +++ php/php-src/trunk/ext/session/mod_user_class.c 2011-09-14 04:10:45 > UTC (rev 316711) > @@ -133,7 +133,7 @@ > long maxlifetime; > int nrdels; > > - PS_SANITY_CHECK; > + PS_SANITY_CHECK_IS_OPEN; > > if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "l", > &maxlifetime) == FAILURE) { > return; > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > -- Laruence Xinchen Hui http://www.laruence.com/ -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
