Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_2/ext/iconv/tests/ iconv_stream_filter_delimiter.phpt
Huh? I guess this was added to 5.2 as well, and I don't think it got reverted at some point. Moriyoshi On Tue, Jul 28, 2009 at 8:08 AM, Rasmus Lerdorfras...@php.net wrote: rasmus Mon, 27 Jul 2009 23:08:23 + Revision: http://svn.php.net/viewvc?view=revisionrevision=286431 Log: We don't support . as a delimiter here in PHP 5.2. Support was added in 5.3 Changed paths: U php/php-src/branches/PHP_5_2/ext/iconv/tests/iconv_stream_filter_delimiter.phpt Modified: php/php-src/branches/PHP_5_2/ext/iconv/tests/iconv_stream_filter_delimiter.phpt === --- php/php-src/branches/PHP_5_2/ext/iconv/tests/iconv_stream_filter_delimiter.phpt 2009-07-27 22:12:35 UTC (rev 286430) +++ php/php-src/branches/PHP_5_2/ext/iconv/tests/iconv_stream_filter_delimiter.phpt 2009-07-27 23:08:23 UTC (rev 286431) @@ -40,10 +40,12 @@ string(20) a4b3a4f3a4cba4c1a4cf string(10) 69636f6e76 string(2) 0a -string(20) a4b3a4f3a4cba4c1a4cf -string(10) 69636f6e76 -string(2) 0a +Warning: stream_filter_append(): unable to create or locate filter convert.iconv.ISO-2022-JP.EUC-JP in %s/iconv_stream_filter_delimiter.php on line %d +string(20) 1b244224332473244b24 +string(10) 41244f1b28 +string(2) 42 + Warning: stream_filter_append(): unable to create or locate filter convert.iconv.ISO-2022-JP\0EUC-JP in %s/iconv_stream_filter_delimiter.php on line %d string(20) 1b244224332473244b24 string(10) 41244f1b28 -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_2/ext/iconv/tests/ iconv_stream_filter_delimiter.phpt
I don't see the code in 5.2.
Look at the php_iconv_stream_filter_factory_create() function in iconv.c
On line 2787 in 5.2 it says:
if ((to_charset = strchr(from_charset, '/')) == NULL) {
In the same function in 5.3 it says:
if ((to_charset = strpbrk(from_charset, /.)) == NULL) {
Unless I am completely reading the code wrong, '.' is not supporrted in
5.2, and since the test case is failing on the . separator the test
seems to agree.
-Rasmus
Moriyoshi Koizumi wrote:
Huh? I guess this was added to 5.2 as well, and I don't think it got
reverted at some point.
Moriyoshi
On Tue, Jul 28, 2009 at 8:08 AM, Rasmus Lerdorfras...@php.net wrote:
rasmus Mon, 27 Jul 2009 23:08:23 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=286431
Log:
We don't support . as a delimiter here in PHP 5.2. Support was added in 5.3
Changed paths:
U
php/php-src/branches/PHP_5_2/ext/iconv/tests/iconv_stream_filter_delimiter.phpt
Modified:
php/php-src/branches/PHP_5_2/ext/iconv/tests/iconv_stream_filter_delimiter.phpt
===
---
php/php-src/branches/PHP_5_2/ext/iconv/tests/iconv_stream_filter_delimiter.phpt
2009-07-27 22:12:35 UTC (rev 286430)
+++
php/php-src/branches/PHP_5_2/ext/iconv/tests/iconv_stream_filter_delimiter.phpt
2009-07-27 23:08:23 UTC (rev 286431)
@@ -40,10 +40,12 @@
string(20) a4b3a4f3a4cba4c1a4cf
string(10) 69636f6e76
string(2) 0a
-string(20) a4b3a4f3a4cba4c1a4cf
-string(10) 69636f6e76
-string(2) 0a
+Warning: stream_filter_append(): unable to create or locate filter
convert.iconv.ISO-2022-JP.EUC-JP in %s/iconv_stream_filter_delimiter.php
on line %d
+string(20) 1b244224332473244b24
+string(10) 41244f1b28
+string(2) 42
+
Warning: stream_filter_append(): unable to create or locate filter
convert.iconv.ISO-2022-JP\0EUC-JP in %s/iconv_stream_filter_delimiter.php
on line %d
string(20) 1b244224332473244b24
string(10) 41244f1b28
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_2/ext/iconv/tests/ iconv_stream_filter_delimiter.phpt
Hmm.. it should have been there. I'm gonna fix it then. Sorry for bothering you.
Moriyoshi
On Tue, Jul 28, 2009 at 5:40 PM, Rasmus Lerdorfras...@lerdorf.com wrote:
I don't see the code in 5.2.
Look at the php_iconv_stream_filter_factory_create() function in iconv.c
On line 2787 in 5.2 it says:
if ((to_charset = strchr(from_charset, '/')) == NULL) {
In the same function in 5.3 it says:
if ((to_charset = strpbrk(from_charset, /.)) == NULL) {
Unless I am completely reading the code wrong, '.' is not supporrted in
5.2, and since the test case is failing on the . separator the test
seems to agree.
-Rasmus
Moriyoshi Koizumi wrote:
Huh? I guess this was added to 5.2 as well, and I don't think it got
reverted at some point.
Moriyoshi
On Tue, Jul 28, 2009 at 8:08 AM, Rasmus Lerdorfras...@php.net wrote:
rasmus Mon, 27 Jul 2009 23:08:23 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=286431
Log:
We don't support . as a delimiter here in PHP 5.2. Support was added in 5.3
Changed paths:
U
php/php-src/branches/PHP_5_2/ext/iconv/tests/iconv_stream_filter_delimiter.phpt
Modified:
php/php-src/branches/PHP_5_2/ext/iconv/tests/iconv_stream_filter_delimiter.phpt
===
---
php/php-src/branches/PHP_5_2/ext/iconv/tests/iconv_stream_filter_delimiter.phpt
2009-07-27 22:12:35 UTC (rev 286430)
+++
php/php-src/branches/PHP_5_2/ext/iconv/tests/iconv_stream_filter_delimiter.phpt
2009-07-27 23:08:23 UTC (rev 286431)
@@ -40,10 +40,12 @@
string(20) a4b3a4f3a4cba4c1a4cf
string(10) 69636f6e76
string(2) 0a
-string(20) a4b3a4f3a4cba4c1a4cf
-string(10) 69636f6e76
-string(2) 0a
+Warning: stream_filter_append(): unable to create or locate filter
convert.iconv.ISO-2022-JP.EUC-JP in %s/iconv_stream_filter_delimiter.php
on line %d
+string(20) 1b244224332473244b24
+string(10) 41244f1b28
+string(2) 42
+
Warning: stream_filter_append(): unable to create or locate filter
convert.iconv.ISO-2022-JP\0EUC-JP in %s/iconv_stream_filter_delimiter.php
on line %d
string(20) 1b244224332473244b24
string(10) 41244f1b28
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
