Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/date/tests/ bug51819.phpt

2010-07-19 Thread Johannes Schlüter
Kai,

On Sat, 2010-07-17 at 23:20 +, Kai Schröder wrote:
 k.schroeder  Sat, 17 Jul 2010 23:20:24 +
 
 Revision: http://svn.php.net/viewvc?view=revisionrevision=301360
 
 Log:
 Test for #51819
 
 Bug: http://bugs.php.net/51819 (Assigned) Case discrepancy in timezone names 
 cause Uncaught exception and fatal error
   
 Changed paths:
 A   php/php-src/branches/PHP_5_3/ext/date/tests/bug51819.phpt

Thanks for the tests but please don't forget trunk ;-)

johannes


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/date/tests/ bug51819.phpt

2010-07-19 Thread Adam Harvey
On 19 July 2010 17:47, Johannes Schlüter johan...@php.net wrote:
 Thanks for the tests but please don't forget trunk ;-)

Furthermore, please don't commit tests for bugs that haven't actually
been fixed (or even triaged yet), such as #52359. They're not always
valid. :)

If you do write a test for an open, untriaged bug, it would be better
attached to the bug report, rather than being actually committed.

Thanks,

Adam

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php