Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ UPGRADING
Please document them as deprecated and mention that they always return false (obviously :) On Tue, Nov 22, 2011 at 2:29 PM, Peter Cowburn wrote: > Hi docs folks, > > What are your thoughts on how to treat the > get_magic_quotes_(gpc|runtime) functions, in the documentation. > Traditionally we mark functions as deprecated if they're deprecated in > the code (e.g. PHP_DEP_FE), but that's not the case for these two. > > Should we just say in the change log that they'll always return false, > or should the term "deprecated" be used? > > Peter > > On 22 November 2011 13:16, Pierre Joye wrote: >> they are, we only not raise notices or warnings anymore to keep the >> user experience at a good level. So please keep them in here :) >> >> On Tue, Nov 22, 2011 at 2:11 PM, Pierrick Charron wrote: >>> pierrick Tue, 22 Nov 2011 13:11:20 + >>> >>> Revision: http://svn.php.net/viewvc?view=revision&revision=319679 >>> >>> Log: >>> Those functions are not deprecated (r319249 #55371) >>> >>> Bug: https://bugs.php.net/55371 (Closed) get_magic_quotes_gpc() throws >>> deprecation warning >>> >>> Changed paths: >>> U php/php-src/branches/PHP_5_4/UPGRADING >>> >>> Modified: php/php-src/branches/PHP_5_4/UPGRADING >>> === >>> --- php/php-src/branches/PHP_5_4/UPGRADING 2011-11-22 12:47:49 UTC >>> (rev 319678) >>> +++ php/php-src/branches/PHP_5_4/UPGRADING 2011-11-22 13:11:20 UTC >>> (rev 319679) >>> @@ -258,8 +258,6 @@ >>> 7. Deprecated >>> = >>> >>> -- get_magic_quotes_gpc() >>> -- get_magic_quotes_runtime() >>> - mcrypt_generic_end() >>> - mysql_list_dbs() >>> >>> >>> >>> -- >>> PHP CVS Mailing List (http://www.php.net/) >>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >> >> >> >> -- >> Pierre >> >> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org >> >> -- >> PHP CVS Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] Re: [PHP-DOC] Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ UPGRADING
If we want to remove them in 5.5 (or whatever we end up after 5.4), then it should be documented as deprecated, even if we don't raise E_DEPRECATED for now. On Tue, Nov 22, 2011 at 2:44 PM, Pierrick Charron wrote: > I personally think that we should do both. As of 5.4 > get_magic_quotes_* are mark them as deprecated to discourage people > using it and will always return false. > > Thanks > Pierrick > > On 22 November 2011 08:29, Peter Cowburn wrote: > > Hi docs folks, > > > > What are your thoughts on how to treat the > > get_magic_quotes_(gpc|runtime) functions, in the documentation. > > Traditionally we mark functions as deprecated if they're deprecated in > > the code (e.g. PHP_DEP_FE), but that's not the case for these two. > > > > Should we just say in the change log that they'll always return false, > > or should the term "deprecated" be used? > > > > Peter > > > > On 22 November 2011 13:16, Pierre Joye wrote: > >> they are, we only not raise notices or warnings anymore to keep the > >> user experience at a good level. So please keep them in here :) > >> > >> On Tue, Nov 22, 2011 at 2:11 PM, Pierrick Charron > wrote: > >>> pierrick Tue, 22 Nov 2011 13:11:20 > + > >>> > >>> Revision: http://svn.php.net/viewvc?view=revision&revision=319679 > >>> > >>> Log: > >>> Those functions are not deprecated (r319249 #55371) > >>> > >>> Bug: https://bugs.php.net/55371 (Closed) get_magic_quotes_gpc() > throws deprecation warning > >>> > >>> Changed paths: > >>>U php/php-src/branches/PHP_5_4/UPGRADING > >>> > >>> Modified: php/php-src/branches/PHP_5_4/UPGRADING > >>> === > >>> --- php/php-src/branches/PHP_5_4/UPGRADING 2011-11-22 12:47:49 > UTC (rev 319678) > >>> +++ php/php-src/branches/PHP_5_4/UPGRADING 2011-11-22 13:11:20 > UTC (rev 319679) > >>> @@ -258,8 +258,6 @@ > >>> 7. Deprecated > >>> = > >>> > >>> -- get_magic_quotes_gpc() > >>> -- get_magic_quotes_runtime() > >>> - mcrypt_generic_end() > >>> - mysql_list_dbs() > >>> > >>> > >>> > >>> -- > >>> PHP CVS Mailing List (http://www.php.net/) > >>> To unsubscribe, visit: http://www.php.net/unsub.php > >>> > >> > >> > >> > >> -- > >> Pierre > >> > >> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org > >> > >> -- > >> PHP CVS Mailing List (http://www.php.net/) > >> To unsubscribe, visit: http://www.php.net/unsub.php > >> > >> > > > > -- > > PHP CVS Mailing List (http://www.php.net/) > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > -- Ferenc Kovács @Tyr43l - http://tyrael.hu
Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ UPGRADING
I personally think that we should do both. As of 5.4 get_magic_quotes_* are mark them as deprecated to discourage people using it and will always return false. Thanks Pierrick On 22 November 2011 08:29, Peter Cowburn wrote: > Hi docs folks, > > What are your thoughts on how to treat the > get_magic_quotes_(gpc|runtime) functions, in the documentation. > Traditionally we mark functions as deprecated if they're deprecated in > the code (e.g. PHP_DEP_FE), but that's not the case for these two. > > Should we just say in the change log that they'll always return false, > or should the term "deprecated" be used? > > Peter > > On 22 November 2011 13:16, Pierre Joye wrote: >> they are, we only not raise notices or warnings anymore to keep the >> user experience at a good level. So please keep them in here :) >> >> On Tue, Nov 22, 2011 at 2:11 PM, Pierrick Charron wrote: >>> pierrick Tue, 22 Nov 2011 13:11:20 + >>> >>> Revision: http://svn.php.net/viewvc?view=revision&revision=319679 >>> >>> Log: >>> Those functions are not deprecated (r319249 #55371) >>> >>> Bug: https://bugs.php.net/55371 (Closed) get_magic_quotes_gpc() throws >>> deprecation warning >>> >>> Changed paths: >>> U php/php-src/branches/PHP_5_4/UPGRADING >>> >>> Modified: php/php-src/branches/PHP_5_4/UPGRADING >>> === >>> --- php/php-src/branches/PHP_5_4/UPGRADING 2011-11-22 12:47:49 UTC >>> (rev 319678) >>> +++ php/php-src/branches/PHP_5_4/UPGRADING 2011-11-22 13:11:20 UTC >>> (rev 319679) >>> @@ -258,8 +258,6 @@ >>> 7. Deprecated >>> = >>> >>> -- get_magic_quotes_gpc() >>> -- get_magic_quotes_runtime() >>> - mcrypt_generic_end() >>> - mysql_list_dbs() >>> >>> >>> >>> -- >>> PHP CVS Mailing List (http://www.php.net/) >>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >> >> >> >> -- >> Pierre >> >> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org >> >> -- >> PHP CVS Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ UPGRADING
Hi docs folks, What are your thoughts on how to treat the get_magic_quotes_(gpc|runtime) functions, in the documentation. Traditionally we mark functions as deprecated if they're deprecated in the code (e.g. PHP_DEP_FE), but that's not the case for these two. Should we just say in the change log that they'll always return false, or should the term "deprecated" be used? Peter On 22 November 2011 13:16, Pierre Joye wrote: > they are, we only not raise notices or warnings anymore to keep the > user experience at a good level. So please keep them in here :) > > On Tue, Nov 22, 2011 at 2:11 PM, Pierrick Charron wrote: >> pierrick Tue, 22 Nov 2011 13:11:20 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=319679 >> >> Log: >> Those functions are not deprecated (r319249 #55371) >> >> Bug: https://bugs.php.net/55371 (Closed) get_magic_quotes_gpc() throws >> deprecation warning >> >> Changed paths: >> U php/php-src/branches/PHP_5_4/UPGRADING >> >> Modified: php/php-src/branches/PHP_5_4/UPGRADING >> === >> --- php/php-src/branches/PHP_5_4/UPGRADING 2011-11-22 12:47:49 UTC (rev >> 319678) >> +++ php/php-src/branches/PHP_5_4/UPGRADING 2011-11-22 13:11:20 UTC (rev >> 319679) >> @@ -258,8 +258,6 @@ >> 7. Deprecated >> = >> >> -- get_magic_quotes_gpc() >> -- get_magic_quotes_runtime() >> - mcrypt_generic_end() >> - mysql_list_dbs() >> >> >> >> -- >> PHP CVS Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ UPGRADING
Ok I just reverted the commit. It just look weird that they are deprecated in the UPGRADING but not in the code but I understand that it's better to tell people to avoid using them anyway :) On 22 November 2011 08:16, Pierre Joye wrote: > they are, we only not raise notices or warnings anymore to keep the > user experience at a good level. So please keep them in here :) > > On Tue, Nov 22, 2011 at 2:11 PM, Pierrick Charron wrote: >> pierrick Tue, 22 Nov 2011 13:11:20 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=319679 >> >> Log: >> Those functions are not deprecated (r319249 #55371) >> >> Bug: https://bugs.php.net/55371 (Closed) get_magic_quotes_gpc() throws >> deprecation warning >> >> Changed paths: >> U php/php-src/branches/PHP_5_4/UPGRADING >> >> Modified: php/php-src/branches/PHP_5_4/UPGRADING >> === >> --- php/php-src/branches/PHP_5_4/UPGRADING 2011-11-22 12:47:49 UTC (rev >> 319678) >> +++ php/php-src/branches/PHP_5_4/UPGRADING 2011-11-22 13:11:20 UTC (rev >> 319679) >> @@ -258,8 +258,6 @@ >> 7. Deprecated >> = >> >> -- get_magic_quotes_gpc() >> -- get_magic_quotes_runtime() >> - mcrypt_generic_end() >> - mysql_list_dbs() >> >> >> >> -- >> PHP CVS Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ UPGRADING
they are, we only not raise notices or warnings anymore to keep the user experience at a good level. So please keep them in here :) On Tue, Nov 22, 2011 at 2:11 PM, Pierrick Charron wrote: > pierrick Tue, 22 Nov 2011 13:11:20 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=319679 > > Log: > Those functions are not deprecated (r319249 #55371) > > Bug: https://bugs.php.net/55371 (Closed) get_magic_quotes_gpc() throws > deprecation warning > > Changed paths: > U php/php-src/branches/PHP_5_4/UPGRADING > > Modified: php/php-src/branches/PHP_5_4/UPGRADING > === > --- php/php-src/branches/PHP_5_4/UPGRADING 2011-11-22 12:47:49 UTC (rev > 319678) > +++ php/php-src/branches/PHP_5_4/UPGRADING 2011-11-22 13:11:20 UTC (rev > 319679) > @@ -258,8 +258,6 @@ > 7. Deprecated > = > > -- get_magic_quotes_gpc() > -- get_magic_quotes_runtime() > - mcrypt_generic_end() > - mysql_list_dbs() > > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/UPGRADING branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c
2011/9/12 Gustavo André dos Santos Lopes : > cataphract Mon, 12 Sep 2011 17:23:10 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=316562 > > Log: > - Fixed bug #55646: textual data is returned in UTF-8, but is input in > another encoding. 5.4 only as this implies a BC break. > > Bug: https://bugs.php.net/55646 (Open) decoding csr corrupts UTF8 characters > > Changed paths: > U php/php-src/branches/PHP_5_4/UPGRADING > U php/php-src/branches/PHP_5_4/ext/openssl/openssl.c > U php/php-src/trunk/ext/openssl/openssl.c I believe this change broke ext/openssl/tests/004.phpt -Hannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
