Re: [PHP-CVS] svn: /php/php-src/trunk/ UPGRADING ext/simplexml/simplexml.c ext/simplexml/tests/034.phpt ext/simplexml/tests/bug51615.phpt
Hi 2011/5/17 Andrew Curioso acuri...@php.net: acurioso Tue, 17 May 2011 13:50:48 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311138 Log: Use iterator when necessary to get the full properties hash - consistent with count (see test: ext/simplexml/tests/034.phpt) Shouldn't this be merged to PHP_5_4 aswell? -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ UPGRADING ext/simplexml/simplexml.c ext/simplexml/tests/034.phpt ext/simplexml/tests/bug51615.phpt
I didn't realize that branch was created. It should be in PHP_5_4, yes. I'm new to the team... so can you help me out? What is the standard way to do that? Using svn merge or just patch the code directly in the branch? Thanks in advance, - Andrew On Tue, May 17, 2011 at 10:26 AM, Kalle Sommer Nielsen ka...@php.netwrote: Hi 2011/5/17 Andrew Curioso acuri...@php.net: acurioso Tue, 17 May 2011 13:50:48 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311138 Log: Use iterator when necessary to get the full properties hash - consistent with count (see test: ext/simplexml/tests/034.phpt) Shouldn't this be merged to PHP_5_4 aswell? -- regards, Kalle Sommer Nielsen ka...@php.net
Re: [PHP-CVS] svn: /php/php-src/trunk/ UPGRADING ext/simplexml/simplexml.c ext/simplexml/tests/034.phpt ext/simplexml/tests/bug51615.phpt
hi, Whatever fits for you for this commit. For the next commits, please try to commit to all branches at once, see https://wiki.php.net/vcs/svnfaq about how to do a sparse checkout, then you can simply do a commit like: cd php-src svn commit branches/PHP_5_4 trunk/ Cheers, On Tue, May 17, 2011 at 4:43 PM, Andrew Curioso acuri...@php.net wrote: I didn't realize that branch was created. It should be in PHP_5_4, yes. I'm new to the team... so can you help me out? What is the standard way to do that? Using svn merge or just patch the code directly in the branch? Thanks in advance, - Andrew On Tue, May 17, 2011 at 10:26 AM, Kalle Sommer Nielsen ka...@php.netwrote: Hi 2011/5/17 Andrew Curioso acuri...@php.net: acurioso Tue, 17 May 2011 13:50:48 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311138 Log: Use iterator when necessary to get the full properties hash - consistent with count (see test: ext/simplexml/tests/034.phpt) Shouldn't this be merged to PHP_5_4 aswell? -- regards, Kalle Sommer Nielsen ka...@php.net -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ UPGRADING ext/simplexml/simplexml.c ext/simplexml/tests/034.phpt ext/simplexml/tests/bug51615.phpt
Thank you. I'll read through that sparse checkout documentation and also commit to the branch in a few hours. I'd do it now but unfortunately I have a meeting to run to. Thanks again, - Andrew On Tue, May 17, 2011 at 10:59 AM, Pierre Joye pierre@gmail.com wrote: hi, Whatever fits for you for this commit. For the next commits, please try to commit to all branches at once, see https://wiki.php.net/vcs/svnfaq about how to do a sparse checkout, then you can simply do a commit like: cd php-src svn commit branches/PHP_5_4 trunk/ Cheers, On Tue, May 17, 2011 at 4:43 PM, Andrew Curioso acuri...@php.net wrote: I didn't realize that branch was created. It should be in PHP_5_4, yes. I'm new to the team... so can you help me out? What is the standard way to do that? Using svn merge or just patch the code directly in the branch? Thanks in advance, - Andrew On Tue, May 17, 2011 at 10:26 AM, Kalle Sommer Nielsen ka...@php.net wrote: Hi 2011/5/17 Andrew Curioso acuri...@php.net: acurioso Tue, 17 May 2011 13:50:48 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311138 Log: Use iterator when necessary to get the full properties hash - consistent with count (see test: ext/simplexml/tests/034.phpt) Shouldn't this be merged to PHP_5_4 aswell? -- regards, Kalle Sommer Nielsen ka...@php.net -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php