Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-26 Thread Pierre Joye
btw, you can use valgrind as well with the tests suite. That should help you to catch other possible leaks or bad memory access. On Sat, Feb 26, 2011 at 8:08 PM, Boris Lytochkin lytbo...@php.net wrote: lytboris                                 Sat, 26 Feb 2011 19:08:55 + Revision:

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-26 Thread Lytochkin Boris
Just to indicate that this is not php function return and some other processing (in caller function) follows. On Sat, Feb 26, 2011 at 11:30 PM, Antony Dovgal t...@daylessday.org wrote: -                       RETURN_FALSE; +                       RETVAL_FALSE; +                       return;

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-26 Thread Antony Dovgal
- RETURN_FALSE; + RETVAL_FALSE; + return; What's the point? #define RETURN_FALSE{ RETVAL_FALSE; return; } On 02/26/2011 10:08 PM, Boris Lytochkin wrote: lytboris Sat, 26 Feb

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-26 Thread Pierre Joye
can you open a bug at bugs.php.net with the patch please? Thanks! On Sat, Feb 26, 2011 at 9:31 PM, Lytochkin Boris lytbo...@gmail.com wrote: It is a pain to run it on FreeBSD, there is a bug in run-tests.php: === --- run-tests.php       (revision 308673) +++ run-tests.php      

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-26 Thread Lytochkin Boris
Sure, #54108 On Sat, Feb 26, 2011 at 11:33 PM, Pierre Joye pierre@gmail.com wrote: can you open a bug at bugs.php.net with the patch please? -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- Boris Lytochkin -- PHP CVS Mailing List (http://www.php.net/) To

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-01 Thread Pierre Joye
hi, I wonder why you need that as we don't release snmp outside php. I would suggest to either drop these backward compatible checks (cleaner code) or consider to do release through pecl as well and then these checks make sense. Cheers, On Tue, Feb 1, 2011 at 9:20 AM, Boris Lytochkin

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-01 Thread Lytochkin Boris
Hi. I use this module in my production Cacti environment, which uses 5.2 branch. As I use FreeBSD, I'm able to build snmp extension separately from base php as .so module and I use this possibility :) As long as Cacti would need 5.2 to run I will mantain those ugly checks (I believe this legacy

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-01 Thread Pierre Joye
yes, but this branch is trunk and is not supposed to be 5.2 compatible. If you want to get it out with previous versions support, then go through pecl as well. But without such external releases it will just clutter the codes. Cheers, On Tue, Feb 1, 2011 at 9:51 AM, Lytochkin Boris