Andi Gutmans wrote:
I just reviewed the patch quickly. Are you sure that using MALLOC() for the
SG(request_info) variables is OK?
I think so. php4_execute() contains
nsapi_request_ctor(NSLS_C SLS_CC);
retval = nsapi_module_main(NSLS_C SLS_CC);
Someone said they'd commit the following patch to sapi/nsapi/nsapi.c in
CVS for me, but there's been no action from him so I'm posting it here in
the hope that someone else will oblige. Hope it's not too late for the
4.0.5 release. I've tested 4.0.4pl1 with this patch under both NES 3.6
and
Lars Torben Wilson wrote:
Jeff Lacy writes:
It is a 'good' coding practice (with many people) to indent everything (that
should be indented, like if's). You can't do a doc quoting inside of an if
and still maintain 'good' coding practices. That is a bug, in my opinion,
because you
I've been working on sapi/nsapi/nsapi.c to get it to work properly under
the iPlanet 4.1 server (there are several problems with the version
shipped with PHP 4.0.4pl1). What should I do with my patch file (~300
lines long) to get these changes incorporated?
- Andrew
--
Every great idea appears
