Sigh...I suck.
Foobared yet another patch.
Attached again.
Daniel
--- php-4.1.2/ext/oci8/oci8.c.orig Wed Mar 13 14:51:19 2002
+++ php-4.1.2/ext/oci8/oci8.c Thu Mar 14 10:02:48 2002
@@ -4090,16 +4090,35 @@
zval **arg;
oci_statement *statement;
oci_connection *con
I should have taken the time to make 100% sure these patches were
relatively bug free. I missed some obvious bugs in previous patches.
Hopfully these will test well.
I've not been able to compile the PHP binary in the latest CVS, so that
patch is untested, but it _seems_ ok, since the compile
a connection or any kind of global error?My concernc are what happens if sqltext remains a NULLpointer?On Wed, Mar 13, 2002 at 11:32:03AM -0800, Daniel Ceregatti wrote :
This patch simply adds the original query text as the "sqltext" element and the error offset as the &q
eate my own wrapperfunction call to OCIError, just so I can highlight the broken portion ofthe query.my $0.02WaltOn Tue, 2002-03-12 at 15:08, Daniel Ceregatti wrote:
Yes. An example of what would be in the array returned by OCIError would be:// Given the code below...$conn = OCILogon
of
>> > showing this type of info, without having to create my own wrapper
>> > function call to OCIError, just so I can highlight the broken
>> portion of
>> > the query.
>> >
>> > my $0.02
>> > Walt
>> >
>> > On Tu
the greatest felxibility, IMHO.
Daniel
Markus Fischer wrote:
On Tue, Mar 12, 2002 at 02:26:24PM -0800, Daniel Ceregatti wrote :
How about doing what sqlplus does and simply add an asterisk at that point? I'm ok with rolling my own inside of the script by using the offset element. I
ar 12, 2002 at 02:02:30PM -0800, Daniel Ceregatti wrote :
Hi,Andi, thanks for the feedback. I've changed the patch to include emallocand efree.I actually use PHP from the command line a lot and I've noticed thatwarnings always get wrapped in , so I figured it was ok to do H
using
>
>emalloc().
>
>Andi
>
>At 12:59 12/03/2002 -0800, Walter A. Boring IV wrote:
>
>>Ahh. very kewl patch Dan.
>>
>>Walt
>>
>>On Tue, 2002-03-12 at 12:48, Daniel Ceregatti wrote:
>>
>>>Hi,
>>>
>>>I wrote a small
plus adds an asterisk under an error.
I find this very useful, and I'm hoping you will too. I've attached the
patch.
Thanks,
Daniel Ceregatti
--- php-4.1.2/ext/oci8/oci8.c.orig Tue Mar 12 11:56:17 2002
+++ php-4.1.2/ext/oci8/oci8.c Tue Mar 12 12:23:35 2002
@@ -4090,10