Re: [PHP-DEV] [PATCH] Apache 2.0 Handler module

2003-02-11 Thread Rasmus Lerdorf
You guys have CVS access, and thus you make the call on what gets accepted or not. There is no higher power here, you guys know the Apache2 stuff better than most. You only start getting pushback if you start changing existing code that might break stuff. -Rasmus On Tue, 11 Feb 2003, Ian Hol

Re: [PHP-DEV] [PATCH] Apache 2.0 Handler module

2003-02-11 Thread Ian Holsman
On Mon, 10 Feb 2003 22:37:44 -0800, Justin Erenkrantz wrote: > FWIW, I think I had a minor bug in how it called ap_sub_req_lookup_uri in > my copy of php_functions.c. I posted an updated copy of that file on my > apache.org space. And, I tested virtual('test.html') and it does work > fine. > >

Re: [PHP-DEV] [PATCH] Apache 2.0 Handler module

2003-02-10 Thread Justin Erenkrantz
On Mon, Feb 10, 2003 at 09:10:44PM -0800, Ian Holsman wrote: > On Mon, 10 Feb 2003 15:44:22 -0500, Ilia A. wrote: > > > The patch appears to work correctly with only one 'interesting' bug. When > > the virtual() function is used to include a php file or php files are > > included via the use of mo

Re: [PHP-DEV] [PATCH] Apache 2.0 Handler module

2003-02-10 Thread Sebastian Bergmann
Justin Erenkrantz wrote: > Until Zend can cleanly support streamy input, PHP should probably just > use this method. I was under the impression it could, at least someone told me so (Zeev, IIRC, at a Conference last year). If not, this would surely be a nice feature for the Zend Engine 2.

Re: [PHP-DEV] [PATCH] Apache 2.0 Handler module

2003-02-10 Thread Ian Holsman
On Mon, 10 Feb 2003 15:44:22 -0500, Ilia A. wrote: > The patch appears to work correctly with only one 'interesting' bug. When > the virtual() function is used to include a php file or php files are > included via the use of mod_include, random binary data is dumped on > screen. This is particular

Re: [PHP-DEV] [PATCH] Apache 2.0 Handler module

2003-02-10 Thread Justin Erenkrantz
--On Monday, February 10, 2003 3:44 PM -0500 "Ilia A." <[EMAIL PROTECTED]> wrote: The patch appears to work correctly with only one 'interesting' bug. When the virtual() function is used to include a php file or php files are included via the use of mod_include, random binary data is dumped on

Re: [PHP-DEV] [PATCH] Apache 2.0 Handler module

2003-02-10 Thread Ilia A.
The patch appears to work correctly with only one 'interesting' bug. When the virtual() function is used to include a php file or php files are included via the use of mod_include, random binary data is dumped on screen. This is particular to PHP files, as virtual() function can successfully inc

Re: [PHP-DEV] [PATCH] Apache 2.0 Handler module

2003-02-10 Thread Sascha Schumann
On Mon, 10 Feb 2003, Justin Erenkrantz wrote: > In the spirit of code rather than discussions that lead nowhere, here is > a contribution that removes the filter code from PHP's sapi layer for > Apache httpd-2.0. Until Zend can cleanly support streamy input, PHP > should probably just use this me

[PHP-DEV] [PATCH] Apache 2.0 Handler module

2003-02-10 Thread Justin Erenkrantz
In the spirit of code rather than discussions that lead nowhere, here is a contribution that removes the filter code from PHP's sapi layer for Apache httpd-2.0. Until Zend can cleanly support streamy input, PHP should probably just use this method. Of course, this will not solve the threadsafety