Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) /sapi/cgi cgi_main.c

2002-12-02 Thread Zeev Suraski
How does this patch possibly fix something in this magnitude? It doesn't appear to do anything crucial at all, or do these variables have some far-reaching indirect effect? Zeev At 07:45 02/12/2002, Shane Caraveo wrote: It's not a matter of php cgi just having a couple bugs, it was completely

[PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) /sapi/cgi cgi_main.c

2002-12-02 Thread Andi Gutmans
I still haven't understood from your answer if this is a problem which was in 4.2.x. Andi At 09:45 PM 12/1/2002 -0800, Shane Caraveo wrote: It's not a matter of php cgi just having a couple bugs, it was completely broken. If we don't put it in 4.3, pull the cgi module out entirely because

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) /sapi/cgi cgi_main.c

2002-12-02 Thread Sascha Schumann
On Mon, 2 Dec 2002, Andi Gutmans wrote: I still haven't understood from your answer if this is a problem which was in 4.2.x. This problem has existed for a long time. There is not much which can break, because it has not been working since well before 4.2.x. - Sascha -- PHP

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) /sapi/cgi cgi_main.c

2002-12-02 Thread Andi Gutmans
At 06:59 PM 12/2/2002 +0100, Sascha Schumann wrote: On Mon, 2 Dec 2002, Andi Gutmans wrote: I still haven't understood from your answer if this is a problem which was in 4.2.x. This problem has existed for a long time. There is not much which can break, because it has not been

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) /sapi/cgi cgi_main.c

2002-12-02 Thread Shane Caraveo
Zeev Suraski wrote: How does this patch possibly fix something in this magnitude? It doesn't appear to do anything crucial at all, or do these variables have some far-reaching indirect effect? Zeev Well, the one patch refered to in this thread was only a minor fix over the previous patches

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) /sapi/cgi cgi_main.c

2002-12-02 Thread Jani Taskinen
On Mon, 2 Dec 2002, Shane Caraveo wrote: There are bugs in the bug database that this fixes also, one example: http://bugs.php.net/bug.php?id=19378 There are also bugs marked as bogus that probably were not, one example: http://bugs.php.net/bug.php?id=10075. (CGI and PATH_INFO aparently is

[PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) /sapi/cgi cgi_main.c

2002-12-01 Thread Andi Gutmans
Are you sure we should have this stuff in the branch of 4.3? Are these bugs which didn't exist in 4.2.3? If they did exist I'm -1. If they didn't exist then that's life and the patch should stay in but people familiar with CGI should review it carefully. Andi At 02:21 AM 12/2/2002 +, Shane

[PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) /sapi/cgi cgi_main.c

2002-12-01 Thread Shane Caraveo
It's not a matter of php cgi just having a couple bugs, it was completely broken. If we don't put it in 4.3, pull the cgi module out entirely because it's useless. Yet another point of view also, since no one has seriously complained about it's brokeness, it can't realy effect many people