Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/apache mod_php4.c

2002-06-13 Thread Jani Taskinen
On Thu, 13 Jun 2002, Rasmus Lerdorf wrote: >> >I don't know offhand which versions are broken. I'd have to do some >> >research. Hence my suggestion that more research is needed before blindly >> >uncommenting something like this. >> >> It's also good practice to add comments to the code >>

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/apache mod_php4.c

2002-06-13 Thread Rasmus Lerdorf
> >I don't know offhand which versions are broken. I'd have to do some > >research. Hence my suggestion that more research is needed before blindly > >uncommenting something like this. > > It's also good practice to add comments to the code > about things like this so that people shouldn

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/apache mod_php4.c

2002-06-13 Thread Jani Taskinen
On Thu, 13 Jun 2002, Rasmus Lerdorf wrote: >> Ah..nice to get that information now. Why didn't you reply to >> my question about this when I asked it on this list? > >I don't recall seeing the question. http://marc.theaimsgroup.com/?l=php-dev&m=101952354225480&w=2 >> And I reall

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/apache mod_php4.c

2002-06-13 Thread Rasmus Lerdorf
> Ah..nice to get that information now. Why didn't you reply to > my question about this when I asked it on this list? I don't recall seeing the question. > And I really didn't commit it without testing, it works fine > with Apache 1.3.24, so what might that apache version be wit

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/apache mod_php4.c

2002-06-13 Thread Jani Taskinen
On Thu, 13 Jun 2002, Rasmus Lerdorf wrote: >It is actually my code and the uncommenting had to do with a bug in >Apache. The deep meaning being that leaving this code in there will make >all authentication break for some versions of Apache. Ah..nice to get that information now. Why didn't y

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/apache mod_php4.c

2002-06-13 Thread Rasmus Lerdorf
It is actually my code and the uncommenting had to do with a bug in Apache. The deep meaning being that leaving this code in there will make all authentication break for some versions of Apache. -Rasmus On Fri, 14 Jun 2002, Jani Taskinen wrote: > > Yes, I did ask Stig who's code it is and

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/apache mod_php4.c

2002-06-13 Thread Jani Taskinen
Yes, I did ask Stig who's code it is and he said it was propably left commented by accident. And I asked about this on php-dev a while ago..without anybody bothering to reply. So, what is the deep meaning for that to be different from what our manual say

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/apache mod_php4.c

2002-06-13 Thread Rasmus Lerdorf
Uh Jani, how much research did you do on this one? Don't you think there is a reason that this code is commented out? On Thu, 13 Jun 2002, Jani Taskinen wrote: > sniperThu Jun 13 18:13:58 2002 EDT > > Modified files: > /php4/sapi/apache mod_php4.c > Log: > @- Fixed bug