RE: [PHP-DEV] error handler callback gets silenced errors

2002-04-09 Thread Marten Gustafsson
31, 2002 12:15 PM > To: Stig S. Bakken > Cc: [EMAIL PROTECTED] > Subject: Re: [PHP-DEV] error handler callback gets silenced errors > > > Don't you think it's better to allow the user to decide inside > the handler > whether he wants to silence this er

Re: [PHP-DEV] error handler callback gets silenced errors

2002-03-31 Thread Stig S. Bakken
For now I do "if (error_reporting() == 0) return;" in my handler. We could just leave it like it is and properly document the fact that _all_ errors will be passed to the handler, with an example of how to detect and ignore silenced errors. - Stig On Sun, 2002-03-31 at 12:14, Zeev Suraski wrot

Re: [PHP-DEV] error handler callback gets silenced errors

2002-03-30 Thread Zeev Suraski
Don't you think it's better to allow the user to decide inside the handler whether he wants to silence this error? It makes custom error loggers more powerful, even if error_reporting is set to 0 in the php.ini file. I think that if we are to pay attention to EG(error_reporting) before we call

[PHP-DEV] error handler callback gets silenced errors

2002-03-30 Thread Stig S. Bakken
Hi, When using set_error_handler, my error handler function is called even when I silence errors. IMHO that's just silly. Proposing the following patch: Index: zend.c === RCS file: /repository/Zend/zend.c,v retrieving revision 1.1