Re: [PHP-DEV] tsrm patch

2001-07-09 Thread Joey Smith
Shane: I just want to say it's good to hear from you again! :) On Sun, 8 Jul 2001, Shane Caraveo wrote the following to Andi Gutmans : Hi Andi, Here is yet another patch to tsrm. The popen implementation was broken. You could not write to a process because pclose did not wait

Re: [PHP-DEV] tsrm patch

2001-07-08 Thread Shane Caraveo
Hi Andi, Here is yet another patch to tsrm. The popen implementation was broken. You could not write to a process because pclose did not wait for a process to end, and the executed process could hang, because both sides of the pipe were inheritable. Index: tsrm_win32.c

Re: [PHP-DEV] tsrm patch

2001-07-08 Thread Andi Gutmans
Shane, Can you please also have Daniel Beulshausen [EMAIL PROTECTED] take a look at it as he did the original patch. Also please try and send unified diffs (cvs diff -u). Thanks, Andi At 03:12 PM 7/8/2001 -0700, Shane Caraveo wrote: Hi Andi, Here is yet another patch to tsrm. The popen

[PHP-DEV] tsrm patch

2001-07-07 Thread Shane Caraveo
Hello, Sending this little fix to the dev group, since I don't beleive I have write access into TSRM. Can someone get this submitted? In tsrm_win32.c, line 138, change the +4 to +5 to allow for the trailing null character: - cmd = (char*)malloc(strlen(command)+strlen(TWG(comspec))+4); + cmd

Re: [PHP-DEV] tsrm patch

2001-07-07 Thread Andi Gutmans
Hi, I commited a patch. Andi At 12:59 PM 7/7/2001 -0700, Shane Caraveo wrote: Hello, Sending this little fix to the dev group, since I don't beleive I have write access into TSRM. Can someone get this submitted? In tsrm_win32.c, line 138, change the +4 to +5 to allow for the trailing null