RE: [PHP-DEV] RE: [PHP-CVS] cvs: php4 /ext/xml xml.c

2002-09-06 Thread James Cox
Marcus pretty much got it.. sorry, php.net mail is broken again. but if you look over your php-cvs mail, Derick has pointed out a number of issues. -- james > -Original Message- > From: Ananth Kesari [mailto:[EMAIL PROTECTED]] > Sent: Friday, September 06, 2002 2:23 PM > To: [EMAIL P

Re: [PHP-DEV] RE: [PHP-CVS] cvs: php4 /ext/xml xml.c

2002-09-06 Thread Marcus Börger
You changed some ifdef statments by adding NETWARE for example: -#ifndef PHP_WIN32 +/*#ifndef PHP_WIN32*/ +#if !defined(PHP_WIN32) && !defined(NETWARE) Here as allways in your commits you commented out the old ifdef stament and added the new one. That is not a good idea. Simply change the ifdef s