RE: [PHP-DEV] Re: #19259 [Csd-Ctl]: sort-functions don't work

2002-11-16 Thread Sebastian Nohn
-Original Message- From: Michael Mauch [mailto:[EMAIL PROTECTED]] Sent: Saturday, November 16, 2002 4:29 PM To: [EMAIL PROTECTED] Subject: [PHP-DEV] Re: #19259 [Csd-Ctl]: sort-functions don't work I wrote: These test results scared me as well, but it looks like this array

Re: [PHP-DEV] Re: #19259 [Csd-Ctl]: sort-functions don't work

2002-11-16 Thread Marcus Börger
Thanks it looks good - applied. marcus At 16:29 16.11.2002, Michael Mauch wrote: I wrote: These test results scared me as well, but it looks like this array test itsself is flawed: it relies on the fact that integers automatically wrap around to negative values at INT_MAX (=2147483647 on 32

Re: [PHP-DEV] Re: #19259 [Csd-Ctl]: sort-functions don't work

2002-11-16 Thread Michael Mauch
Marcus Börger [EMAIL PROTECTED] wrote: Thanks it looks good - applied. Thanks, great. While we're at it, there's another test which fails on 64 bit machines and can easily be fixed: var_dump float test [ext/standard/tests/general_functions/008.phpt] This test fails because 123456789012 and

Re: [PHP-DEV] Re: #19259 [Csd-Ctl]: sort-functions don't work

2002-11-16 Thread Marcus Börger
Could you try the following patch instead? cvs -z3 -q diff 008.phpt (in directory S:\php4-HEAD\ext\standard\tests\general_functions) Index: 008.phpt === RCS file: /repository/php4/ext/standard/tests/general_functions/008.phpt,v

Re: [PHP-DEV] Re: #19259 [Csd-Ctl]: sort-functions don't work

2002-11-16 Thread Marcus Börger
Ups one missing: cvs -z3 -q diff 008.phpt (in directory S:\php4-HEAD\ext\standard\tests\general_functions\) Index: 008.phpt === RCS file: /repository/php4/ext/standard/tests/general_functions/008.phpt,v retrieving revision 1.1 diff