Re: [PHP-DEV] libgd patch for alpha-channel mixing

2002-08-21 Thread Rasmus Lerdorf
> Wouldn't it be preferable for the function to be there and report the reason > it doesn't work, ie "this function only works when using the bundled GD > library"? No, because then people can't write portable code that checks using function_exists() -Rasmus -- PHP Development Mailing List

Re: [PHP-DEV] libgd patch for alpha-channel mixing

2002-08-21 Thread Tim Toohey
On Thu, 22 Aug 2002 08:28, [EMAIL PROTECTED] wrote: > On Wed, 21 Aug 2002, Tim Toohey wrote: > > Any thoughts? Should I go ahead and commit this? I've never committed to > > PHP before so go easy on me :-). I've been using essentially the same > > code on a PHP-4.1.0 installation for a while now a

Re: [PHP-DEV] libgd patch for alpha-channel mixing

2002-08-21 Thread Rasmus Lerdorf
I've looked at these before and they look ok to me. That was the point of bringing libgd inhouse. Of course, we will have to carefully document the fact that some GD functions are only available with the bundled version of libgd. I can live with that hassle in exchange for bug fixes and added f

Re: [PHP-DEV] libgd patch for alpha-channel mixing

2002-08-21 Thread derick
On Wed, 21 Aug 2002, Tim Toohey wrote: > Any thoughts? Should I go ahead and commit this? I've never committed to PHP > before so go easy on me :-). I've been using essentially the same code on a > PHP-4.1.0 installation for a while now and I believe it works OK. Looking at your patch I see: