Re: [PHP-DEV] PEAR_INSTALLDIR breakage
[Sascha Schumann [EMAIL PROTECTED]]
Is there a reason the $'s were escape, or can I commit my fix?
If EXTENSION_DIR/INCLUDE_PATH are used outside makefiles,
your patch should be applied.
They are used outside makefiles, but they should be as separate
variables that are expanded. I've committed a fix for it.
Jon, the reason for the ${foo} syntax is that this is the only way to
reference a variable that works in both "make", "sh" and PHP. In the
makefiles we want to defer expansion as long as possible, to give the
user bigger flexibility for redefining individual variables from the
"make" command line.
- Stig
--
Stig Sther Bakken [EMAIL PROTECTED]
Fast Search Transfer ASA, Trondheim, Norway
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] PEAR_INSTALLDIR breakage
Is there a reason the $'s were escape, or can I commit my fix? If EXTENSION_DIR/INCLUDE_PATH are used outside makefiles, your patch should be applied. - Sascha Experience IRCG http://schumann.cx/http://schumann.cx/ircg -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
[PHP-DEV] PEAR_INSTALLDIR breakage
Revision 1.228 of configure.in breaks the expansion of the
PEAR_INSTALLDIR variable. I don't know why the $'s were escaped in
revision 1.228, but the following patch brings back what I think is
the intended behavior.
Is there a reason the $'s were escape, or can I commit my fix?
Index: configure.in
===
RCS file: /repository/php4/configure.in,v
retrieving revision 1.229
diff -u -r1.229 configure.in
--- configure.in2001/04/04 20:52:43 1.229
+++ configure.in2001/04/06 02:51:23
@@ -717,9 +717,9 @@
PEAR_INSTALLDIR="$prefix/lib/php"
fi
-EXTENSION_DIR="\${PEAR_INSTALLDIR}/extensions/$PART1-$PART2-$ZEND_MODULE_API_NO"
+EXTENSION_DIR="${PEAR_INSTALLDIR}/extensions/$PART1-$PART2-$ZEND_MODULE_API_NO"
-INCLUDE_PATH=".:\${PEAR_INSTALLDIR}"
+INCLUDE_PATH=".:${PEAR_INSTALLDIR}"
PHP_BUILD_RPATH
--
Jon Parise ([EMAIL PROTECTED]) . Rochester Inst. of Technology
http://www.csh.rit.edu/~jon/ : Computer Science House Member
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
