Re: [PHP-DEV] RE: mysql_pconnect still broken (was: RE: What does this mean ?)

2001-01-17 Thread Andi Gutmans

Looks like this was my bad :)
Sorry,
Andi

At 01:47 AM 1/17/2001 +0200, Zeev Suraski wrote:
Yep, you're right.  Fixed.

Thanks,

Zeev

At 23:24 16/1/2001, Steven Roussey wrote:
  OK. Look at a quick report. I've just installed php4-200101152345. It runs
  with mysql-3.23.27-beta. Apache 1.3.12, Solaris 2.6 (local host) and 2.4
  (remote connection).
 
  What I can see is: the offending messages didn't vanish at all (both hosts
  are involved):
  So, I think it's not fixed yet. Steven, you wrote about 99,8. I suppose
  every Apache process here makes this error while ending. I just see it.

:)

Andi, I hope you are reading this.

I looked at the CVS, and my patch was not properly applied. Andi has it
looking through the non-persistant destructors, rather than the persistent
ones (meaning that plist_entry_destructor is identical to
list_entry_destructor).

In file zend_list.c replace the plist_entry_destructor definition with:

void plist_entry_destructor(void *ptr)
{
 zend_rsrc_list_entry *le = (zend_rsrc_list_entry *) ptr;
 zend_rsrc_list_dtors_entry *ld;

 if (zend_hash_index_find(list_destructors, le-type,(void **)
ld)==SUCCESS) {
 switch (ld-type) {
 case ZEND_RESOURCE_LIST_TYPE_STD:
 if (ld-plist_dtor) {
 (ld-plist_dtor)(le-ptr);
 }
 break;
 case ZEND_RESOURCE_LIST_TYPE_EX:
 if (ld-plist_dtor_ex) {
 ld-plist_dtor_ex(le);
 }
 break;
 EMPTY_SWITCH_DEFAULT_CASE()
 }
 } else {
 zend_error(E_WARNING,"Unknown persistent list entry type in
module shutdown (%d)",le-type);
 }
}




Sincerely,

Steven Roussey
Network54.com
http://network54.com/?pp=e


--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

--
Zeev Suraski [EMAIL PROTECTED]
CTO   co-founder, Zend Technologies Ltd. http://www.zend.com/


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




RE: [PHP-DEV] RE: mysql_pconnect still broken (was: RE: What does this mean ?)

2001-01-17 Thread Maciek Uhlig

I think you might be interested in some feedback after the newest PHP
snapshot with a fix was installed here.

The "Aborted connection ... (Got an error reading communication packets)"
messages disappeared. This may seem as expected behaviour. However there is
one additional point worth mentioning:

In order to get rid of these annoying messages it is _not_ sufficient to
install lastly fixed PHP. In order to get rid of them I had to compile the
newest PHP snapshot with MySQL 3.23 (3.23.27-beta or 3.23.28-gamma) client
library instead 3.22 (3.22.25) one which was used before till today
(releases between them, as well as PHP bundled client, were not tested :-)).
I thought it may be interesting for some - and for the record.

Thank you, Steven and Zeev :-)

Maciek

 -Original Message-
 From: Zeev Suraski [mailto:[EMAIL PROTECTED]]
 Sent: Wednesday, January 17, 2001 12:48 AM
 To: Steven Roussey
 Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; Mysql
 Subject: Re: [PHP-DEV] RE: mysql_pconnect still broken (was: RE:
 What does this mean ?)


 Yep, you're right.  Fixed.

 Thanks,

 Zeev

 At 23:24 16/1/2001, Steven Roussey wrote:
   OK. Look at a quick report. I've just installed
 php4-200101152345. It runs
   with mysql-3.23.27-beta. Apache 1.3.12, Solaris 2.6 (local
 host) and 2.4
   (remote connection).
  
   What I can see is: the offending messages didn't vanish at
 all (both hosts
   are involved):

[stuff deleted]


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: [PHP-DEV] RE: mysql_pconnect still broken (was: RE: What does this mean ?)

2001-01-16 Thread Zeev Suraski

Yep, you're right.  Fixed.

Thanks,

Zeev

At 23:24 16/1/2001, Steven Roussey wrote:
  OK. Look at a quick report. I've just installed php4-200101152345. It runs
  with mysql-3.23.27-beta. Apache 1.3.12, Solaris 2.6 (local host) and 2.4
  (remote connection).
 
  What I can see is: the offending messages didn't vanish at all (both hosts
  are involved):
  So, I think it's not fixed yet. Steven, you wrote about 99,8. I suppose
  every Apache process here makes this error while ending. I just see it.

:)

Andi, I hope you are reading this.

I looked at the CVS, and my patch was not properly applied. Andi has it
looking through the non-persistant destructors, rather than the persistent
ones (meaning that plist_entry_destructor is identical to
list_entry_destructor).

In file zend_list.c replace the plist_entry_destructor definition with:

void plist_entry_destructor(void *ptr)
{
 zend_rsrc_list_entry *le = (zend_rsrc_list_entry *) ptr;
 zend_rsrc_list_dtors_entry *ld;

 if (zend_hash_index_find(list_destructors, le-type,(void **)
ld)==SUCCESS) {
 switch (ld-type) {
 case ZEND_RESOURCE_LIST_TYPE_STD:
 if (ld-plist_dtor) {
 (ld-plist_dtor)(le-ptr);
 }
 break;
 case ZEND_RESOURCE_LIST_TYPE_EX:
 if (ld-plist_dtor_ex) {
 ld-plist_dtor_ex(le);
 }
 break;
 EMPTY_SWITCH_DEFAULT_CASE()
 }
 } else {
 zend_error(E_WARNING,"Unknown persistent list entry type in
module shutdown (%d)",le-type);
 }
}




Sincerely,

Steven Roussey
Network54.com
http://network54.com/?pp=e


--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

--
Zeev Suraski [EMAIL PROTECTED]
CTO   co-founder, Zend Technologies Ltd. http://www.zend.com/


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]