Re: [PHP-DEV] [Patch] LDAP Error reporting for 4.2.1

2002-06-30 Thread derick
Hello, On 29 Jun 2002, Kris Karas wrote: On Thu, 2002-06-27 at 02:26, [EMAIL PROTECTED] wrote: Here is the patch: http://cvs.php.net/diff.php/php4/ext/ldap/ldap.c?r1=1.121r2=1.123ty=u (And I just fixed that \n thing :) Super. Tested over the past 36 hours or so, no problems

Re: [PHP-DEV] [Patch] LDAP Error reporting for 4.2.1

2002-06-27 Thread derick
On 26 Jun 2002, Kristofer T. Karas wrote: On Wed, 2002-06-26 at 15:47, [EMAIL PROTECTED] wrote: I think I caught that one... can you make sure? BTW.. I did a few other extensions too :) My pleasure! :-) But I'm not using CVS, so if you wouldn't mind, send it hither in email and I'll

Re: [PHP-DEV] [Patch] LDAP Error reporting for 4.2.1

2002-06-26 Thread Stig Venaas
On Tue, Jun 25, 2002 at 08:13:29PM -0400, Kristofer T. Karas wrote: I'm using OpenLDAP 1.x in PHP 4.2.1, and was dismayed that $x = ldap_add(...); dumps verbiage to stderr if the add fails, despite the . Figured it'd be faster to fix it than to whine and complain. In fixing, I found

Re: [PHP-DEV] [Patch] LDAP Error reporting for 4.2.1

2002-06-26 Thread derick
On Wed, 26 Jun 2002, Stig Venaas wrote: On Tue, Jun 25, 2002 at 08:13:29PM -0400, Kristofer T. Karas wrote: I'm using OpenLDAP 1.x in PHP 4.2.1, and was dismayed that $x = @ldap_add(...); dumps verbiage to stderr if the add fails, despite the @. Figured it'd be faster to fix it

Re: [PHP-DEV] [Patch] LDAP Error reporting for 4.2.1

2002-06-26 Thread Kristofer T. Karas
On Wed, 2002-06-26 at 02:40, [EMAIL PROTECTED] wrote: On Wed, 26 Jun 2002, Stig Venaas wrote: Thanks, I'll review your patch more carefully before I apply it Stig, I just patched it... and made it even more conformant to the rest of the PHP extensions. I am currently testing. Super.

Re: [PHP-DEV] [Patch] LDAP Error reporting for 4.2.1

2002-06-26 Thread derick
On 26 Jun 2002, Kristofer T. Karas wrote: On Wed, 2002-06-26 at 02:40, [EMAIL PROTECTED] wrote: On Wed, 26 Jun 2002, Stig Venaas wrote: Thanks, I'll review your patch more carefully before I apply it Stig, I just patched it... and made it even more conformant to the rest of the PHP