Re: [PHP-DEV] [patch] solaris getcwd() brokeness

2003-03-11 Thread Andi Gutmans
I think the patch is OK. I'm not extremely happy with it because I don't think it's very beautiful but I didn't have time to think of a better way of fixing it. I think he can go ahead and commit it but I'd like there to be comments in the source code to explain why those checks on

Re: [PHP-DEV] [patch] solaris getcwd() brokeness

2003-03-10 Thread Jani Taskinen
Andi, what's the status with this? --Jani On Sun, 23 Feb 2003, Wez Furlong wrote: Hi Andi (and James) Andi: I'd appreciate your comments on this patch, specifically if there are any concerns about it doing the right thing. Most people here:

Re: [PHP-DEV] [patch] solaris getcwd() brokeness

2003-02-23 Thread Wez Furlong
Hi Andi (and James) Andi: I'd appreciate your comments on this patch, specifically if there are any concerns about it doing the right thing. Most people here: http://bugs.php.net/bug.php?id=21310edit=1 report that it fixes their problems with solaris. I've held off from looking at this, as I

Re: [PHP-DEV] [patch] solaris getcwd() brokeness

2003-02-23 Thread James E. Flemer
Oh good, it hasn't been forgotten. I just want to point out that if committed the open() statement should probably use O_RDONLY. [main.c @ ~1542] I used 0 because I didn't have time to figure out where to add the correct #include to get O_RDONLY into main.c. -James On Sun, 23 Feb 2003, Wez

Re: [PHP-DEV] [patch] solaris getcwd() brokeness

2003-02-16 Thread James E. Flemer
When getcwd() fails in certain places, we end up passing a zero length cwd_state to virtual_file_ex(). This causes virtual_file_ex() to assume the path to be /, thus: include(foo.php); ends up trying to open, /foo.php, which is wrong. If you want to play with this problem, its very easy to

Re: [PHP-DEV] [patch] solaris getcwd() brokeness

2003-02-16 Thread Andi Gutmans
At 03:41 PM 2/13/2003 -0500, James E. Flemer wrote: RCS file: /repository/TSRM/tsrm_virtual_cwd.c,v retrieving revision 1.41 diff -u -b -r1.41 tsrm_virtual_cwd.c --- TSRM/tsrm_virtual_cwd.c 6 Nov 2002 18:07:22 - 1.41 +++ TSRM/tsrm_virtual_cwd.c 13 Feb 2003 20:40:07 - @@

Re: [PHP-DEV] [patch] solaris getcwd() brokeness

2003-02-16 Thread James E. Flemer
On Sun, 16 Feb 2003, Andi Gutmans wrote: At 03:41 PM 2/13/2003 -0500, James E. Flemer wrote: RCS file: /repository/TSRM/tsrm_virtual_cwd.c,v retrieving revision 1.41 diff -u -b -r1.41 tsrm_virtual_cwd.c --- TSRM/tsrm_virtual_cwd.c 6 Nov 2002 18:07:22 - 1.41 +++

Re: [PHP-DEV] [patch] solaris getcwd() brokeness

2003-02-15 Thread Andi Gutmans
Hey, The fchdir() part of the patch looks fine but I didn't quite understand the rest. PHP only uses realpath() if it doesn't fail, so what is the exact problem? What does that other code do? Andi At 03:29 PM 2/12/2003 -0500, James E. Flemer wrote: Well all the fancy new streams code in 4.3.0

Re: [PHP-DEV] [patch] solaris getcwd() brokeness

2003-02-13 Thread James E. Flemer
Here's that same patch, but without leaking a file descriptor. Any comments yet? Any objections to committing it? -James On Wed, 12 Feb 2003, James E. Flemer wrote: Well all the fancy new streams code in 4.3.0 seems to tickle a Solaris issue with getcwd(). It seems that under certain cases

[PHP-DEV] [patch] solaris getcwd() brokeness

2003-02-12 Thread James E. Flemer
Well all the fancy new streams code in 4.3.0 seems to tickle a Solaris issue with getcwd(). It seems that under certain cases solaris' getcwd() fails when other os' work. Consequently 4.3.0 causes a huge ammount of breakage for some sites running solaris. Below is a patch that seems to work