Re: [PHP-DEV] Apache2 SAPI - etag support?

2003-03-10 Thread Ian Holsman


Hi Ilia

I was wondering if you thing we should have etag support as well as the 
last-modified header you added.
if so .. we need to add ap_set_etag(r) just after the 
ap_set_last_modified(r) call.

what do you guys think?
Ilia
--Ian

--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php


Re: [PHP-DEV] Apache2 SAPI

2003-03-08 Thread Jean-Michel Dault
Le ven 07/03/2003 à 20:29, Ian Holsman a écrit :
 I think it would be in everyone's best interest if apache2handler was 
 introduced in 4.3.X series  probably replace the current apache2filter all 
 together.
 I'm big +1 on this as it can be considered as a FIX..
 Let's just replace the other one with this new one.
  Just one thing before we make the move: what about the thing with
  virtual and php re-entrancy? Is that fixed?

 I belive justin fixed that by using the same method the 1.3 handler 
 used (called zend_xyz instead of php_xyz .. i don't have the code in 
 front of me)

Derick, the issue was that virtual() didn't work with apache2handler. Of
course, you could always use file_get_contents, but it creates a couple
of problems (problems when using self-signed ssl certificates, extra log
entries in webserver, only compatible with php 4.3, etc). 

Ian, I just looked at the CVS, it has been fixed two weeks ago, now uses
zend_execute_script instead of php_execute_script, and content-type is
set properly now.

I'll give it a try in the following weeks, I'll let you know of any bugs
or success.

In the meantime, I would not object to put in the 4.3.x series, and even
put it as default, as long as you leave apache2filter as well, so we can
switch from one to the other just by altering the makefile. 

Jean-Michel


--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Apache2 SAPI

2003-03-07 Thread Jean-Michel Dault
Le ven 07/03/2003 à 02:56, Derick Rethans a écrit :
  I think it would be in everyone's best interest if apache2handler was 
  introduced in 4.3.X series  probably replace the current apache2filter all 
  together.
  I'm big +1 on this as it can be considered as a FIX..
  Let's just replace the other one with this new one.
 Ok, I'm convinced now too :)

Just one thing before we make the move: what about the thing with
virtual and php re-entrancy? Is that fixed?

Jean-Michel

--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Apache2 SAPI

2003-03-07 Thread Derick Rethans
On Fri, 7 Mar 2003, Jean-Michel Dault wrote:

 Le ven 07/03/2003 à 02:56, Derick Rethans a écrit :
   I think it would be in everyone's best interest if apache2handler was 
   introduced in 4.3.X series  probably replace the current apache2filter all 
   together.
   I'm big +1 on this as it can be considered as a FIX..
   Let's just replace the other one with this new one.
  Ok, I'm convinced now too :)
 
 Just one thing before we make the move: what about the thing with
 virtual and php re-entrancy? Is that fixed?

I've no idea what you're talking about, care to elaborate?

Derick

-- 
my other box is your windows PC
-
 Derick Rethans http://derickrethans.nl/ 
 PHP Magazine - PHP Magazine for Professionals   http://php-mag.net/
-

--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Apache2 SAPI

2003-03-07 Thread Ian Holsman
Jean-Michel Dault wrote:
Le ven 07/03/2003 à 02:56, Derick Rethans a écrit :

I think it would be in everyone's best interest if apache2handler was 
introduced in 4.3.X series  probably replace the current apache2filter all 
together.
   I'm big +1 on this as it can be considered as a FIX..
   Let's just replace the other one with this new one.
Ok, I'm convinced now too :)


Just one thing before we make the move: what about the thing with
virtual and php re-entrancy? Is that fixed?
Jean-Michel

I belive justin fixed that by using the same method the 1.3 handler 
used (called zend_xyz instead of php_xyz .. i don't have the code in 
front of me)

--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php


[PHP-DEV] Apache2 SAPI

2003-03-06 Thread Ian Holsman
I've been using the apache2handler on two low/medium-traffic sites for a 
while and it appears ok to me.

now.. I'm new to this list, and really don't know how it works, so 
excuse me if this is a FAQ or something.

I'd like to see this code in 4.3.2/4.3.3?, and if it doesn't blow up,
replace the 'apache2filter' as the default apache2 SAPI in a month or two.
so..
Can I check this into PHP_4  PHP_4_3 ?
Thanks
Ian.
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php


Re: [PHP-DEV] Apache2 SAPI

2003-03-06 Thread Derick Rethans
On Thu, 6 Mar 2003, Ian Holsman wrote:

 I've been using the apache2handler on two low/medium-traffic sites for a 
 while and it appears ok to me.
 
 now.. I'm new to this list, and really don't know how it works, so 
 excuse me if this is a FAQ or something.

 I'd like to see this code in 4.3.2/4.3.3?, and if it doesn't blow up,
 replace the 'apache2filter' as the default apache2 SAPI in a month or two.

Our policy is not to merge new things to stable branches (which is 
PHP_4_3 now).

 Can I check this into PHP_4  PHP_4_3 ?

Nope :)

Derick

-- 
Stop mad cowboy disease!
-
 Derick Rethans http://derickrethans.nl/ 
 PHP Magazine - PHP Magazine for Professionals   http://php-mag.net/
-

-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Apache2 SAPI

2003-03-06 Thread Ian Holsman
Derick Rethans wrote:
On Thu, 6 Mar 2003, Ian Holsman wrote:


I've been using the apache2handler on two low/medium-traffic sites for a 
while and it appears ok to me.

now.. I'm new to this list, and really don't know how it works, so 
excuse me if this is a FAQ or something.

I'd like to see this code in 4.3.2/4.3.3?, and if it doesn't blow up,
replace the 'apache2filter' as the default apache2 SAPI in a month or two.


Our policy is not to merge new things to stable branches (which is 
PHP_4_3 now).


Can I check this into PHP_4  PHP_4_3 ?


Nope :)

Derick

maybe I should have just patched the apache2filter code instead of 
creating a new directory ;-)

the handler is much simpler  IMHO more stable, but I'm not going to 
bitch and moan about it anymore

--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php


Re: [PHP-DEV] Apache2 SAPI

2003-03-06 Thread Sascha Schumann
  Can I check this into PHP_4  PHP_4_3 ?

 Nope :)

PHP_4 is ok.

- Sascha


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Apache2 SAPI

2003-03-06 Thread Derick Rethans
On Thu, 6 Mar 2003, Sascha Schumann wrote:

   Can I check this into PHP_4  PHP_4_3 ?
 
  Nope :)
 
 PHP_4 is ok.

Sure, but there is no point in doing that... as there won't be released 
from that branch anyway.

Derick

-- 
Stop mad cowboy disease!
-
 Derick Rethans http://derickrethans.nl/ 
 PHP Magazine - PHP Magazine for Professionals   http://php-mag.net/
-

-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Apache2 SAPI

2003-03-06 Thread Sascha Schumann
 Sure, but there is no point in doing that... as there won't be released
 from that branch anyway.

Well, that depends on the needs of our users.

Regardless, testing new SAPIs/extensions is quite a burden in the
PHP 5 context, because you have two moving targets then -- the
engine and your own code.  It's often preferrable to have a
stable environment for your own testing needs and that is
where PHP_4 comes in.

- Sascha


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Apache2 SAPI

2003-03-06 Thread Jani Taskinen

I think it would be okay to just replace the apache2filter
with apache2handler altogether..since the former does not
work as well anyway. 

Are there any differences how it is setup in http.conf btw?

--Jani



On Thu, 6 Mar 2003, Derick Rethans wrote:

On Thu, 6 Mar 2003, Ian Holsman wrote:

 I've been using the apache2handler on two low/medium-traffic sites for a 
 while and it appears ok to me.
 
 now.. I'm new to this list, and really don't know how it works, so 
 excuse me if this is a FAQ or something.

 I'd like to see this code in 4.3.2/4.3.3?, and if it doesn't blow up,
 replace the 'apache2filter' as the default apache2 SAPI in a month or two.

Our policy is not to merge new things to stable branches (which is 
PHP_4_3 now).

 Can I check this into PHP_4  PHP_4_3 ?

Nope :)

Derick



-- 
- For Sale! -


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Apache2 SAPI

2003-03-06 Thread Ian Holsman
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Jani Taskinen wrote:
| I think it would be okay to just replace the apache2filter
| with apache2handler altogether..since the former does not
| work as well anyway.
|
| Are there any differences how it is setup in http.conf btw?
no.. not now
but in previous versions of the setup, it was using
SetOutputFilter PHP
SetInputFilter PHP
which won't work.
the current implementation doesn't use this method..
|
| --Jani
|
|
|
| On Thu, 6 Mar 2003, Derick Rethans wrote:
|
|
|On Thu, 6 Mar 2003, Ian Holsman wrote:
|
|
|I've been using the apache2handler on two low/medium-traffic sites for a
|while and it appears ok to me.
|
|now.. I'm new to this list, and really don't know how it works, so
|excuse me if this is a FAQ or something.
|
|I'd like to see this code in 4.3.2/4.3.3?, and if it doesn't blow up,
|replace the 'apache2filter' as the default apache2 SAPI in a month or
two.
|
|Our policy is not to merge new things to stable branches (which is
|PHP_4_3 now).
|
|
|Can I check this into PHP_4  PHP_4_3 ?
|
|Nope :)
|
|Derick
|
|
|
|
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.1 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQE+Z4sOq3pgvCz4ZCcRArKkAJ4kZqsuKC3smPNe7MaR3fbu3SZjsACfbfFe
fIxhq1Tu5C2LJMESNDKGdUc=
=RTsX
-END PGP SIGNATURE-
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php


Re: [PHP-DEV] Apache2 SAPI

2003-03-06 Thread Jani Taskinen
On Thu, 6 Mar 2003, Ian Holsman wrote:

Jani Taskinen wrote:
| I think it would be okay to just replace the apache2filter
| with apache2handler altogether..since the former does not
| work as well anyway.
|
| Are there any differences how it is setup in http.conf btw?

no.. not now
but in previous versions of the setup, it was using
SetOutputFilter PHP
SetInputFilter PHP
which won't work.
the current implementation doesn't use this method..

So currently, there's no difference how you setup
apache2filter or apache2handler in httpd.conf ??

If so, then IMO, we should just replace the apache2filter
with apache2handler altogether. Also in 4.3.x branch.

And make the configure option --with-apxs2.. :)

--Jani



-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Apache2 SAPI

2003-03-06 Thread Peter Neuman
Hi,

Jani Taskinen [EMAIL PROTECTED] wrote:
 And make the configure option --with-apxs2.. :)

Do you have an idea when --with-apache2 comes?
thus which one can install the Apache2 also without DSO/CGI support?
As with the Apache1 (--with-apache)... 

Thanks
Peter Neuman

-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Apache2 SAPI

2003-03-06 Thread Ilia A.
On March 6, 2003 11:19 am, Derick Rethans wrote:
 Our policy is not to merge new things to stable branches (which is
 PHP_4_3 now).

True, however the apache2handler works much better then the existing 
apache2filter and as far as I can tell fixes at least 1 crash bug. There 
maybe more things it fixes, but I have not had the chance to test those yet.
The only things on my wishlist is some CS cleanup  better Apache info (akin 
to the one offered by Apache 1) and I hope to have a patch for those shortly.
The only possible issue that I see with apache2handler, is that is requires 
the very latest Apache 2, 2.0.44.

I think it would be in everyone's best interest if apache2handler was 
introduced in 4.3.X series  probably replace the current apache2filter all 
together.

Ilia

-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Apache2 SAPI

2003-03-06 Thread Jani Taskinen
On Thu, 6 Mar 2003, Ilia A. wrote:

On March 6, 2003 11:19 am, Derick Rethans wrote:
 Our policy is not to merge new things to stable branches (which is
 PHP_4_3 now).

True, however the apache2handler works much better then the existing 
apache2filter and as far as I can tell fixes at least 1 crash bug. There 
maybe more things it fixes, but I have not had the chance to test those yet.
The only things on my wishlist is some CS cleanup  better Apache info (akin 
to the one offered by Apache 1) and I hope to have a patch for those shortly.
The only possible issue that I see with apache2handler, is that is requires 
the very latest Apache 2, 2.0.44.

I don't think that's an issue. Everyone should be using 2.0.44 anyway,
as it fixes several security related bugs.

  http://www.apache.org/dist/httpd/Announcement2.html
 
(on windows, but still..)

I think it would be in everyone's best interest if apache2handler was 
introduced in 4.3.X series  probably replace the current apache2filter all 
together.

I'm big +1 on this as it can be considered as a FIX..
Let's just replace the other one with this new one.

--Jani



-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Apache2 SAPI

2003-03-06 Thread Derick Rethans
On Fri, 7 Mar 2003, Jani Taskinen wrote:

 I think it would be in everyone's best interest if apache2handler was 
 introduced in 4.3.X series  probably replace the current apache2filter all 
 together.
 
 I'm big +1 on this as it can be considered as a FIX..
 Let's just replace the other one with this new one.

Ok, I'm convinced now too :)

Derick

-- 
Stop mad cowboy disease!
-
 Derick Rethans http://derickrethans.nl/ 
 PHP Magazine - PHP Magazine for Professionals   http://php-mag.net/
-

-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php