The browscap extension is trying to load stuff into the object_store before
it gets initialized, so this'll fix it. Entries from the browscap.ini file
are now stored in straight hashes rather than objects, but the return value
is still an object. 

Additionally, this patch adds an optional parameter (a bool) that determines
whether the return value should be an object or an array. Object is the
default for BC.

This doesn't seem entirely, 100% BC, as I'm getting results now that are
slightly different from <= 4.3.x. However, the matches seem a bit better
after doing a few tests. For instance, the browser_name_pattern string no
longer escapes peroids and such, and it seems slightly more accurate. (In
older versions, my platform was reported as "unix"; now it's reporting
"linux", which is more precise.)

I figured I had better post the patch for comments before committing since
there is that ever-so-slight difference in browser_name_pattern and the
platform being reported.

Attached is the patch and a couple of tests so you can see the difference.
If there's no objections, I'll commit later on this week. This doesn't
really need to be merged into PHP_4, as it doesn't have the segfault bug.

J

Attachment: browscap.tar.gz
Description: GNU Zip compressed data

-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to