[PHP-DEV] Patch for #21330 - socket_select()

2003-01-02 Thread nicos 
This is the patch that fix the issue of socket_select that doesn't wait if
value for timeval is 0.

Tell me what you think.

Regards.
M.CHAILLAN Nicolas
[EMAIL PROTECTED]
www.WorldAKT.com Hébergement de sites internets.



-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Patch for #21330 - socket_select()

2003-01-02 Thread Derick Rethans 
On Thu, 2 Jan 2003 [EMAIL PROTECTED] wrote:

 This is the patch that fix the issue of socket_select that doesn't wait if
 value for timeval is 0.
 
 Tell me what you think.

There is no patch

Derick

-- 

-
 Derick Rethans http://derickrethans.nl/ 
 PHP Magazine - PHP Magazine for Professionals   http://php-mag.net/
-


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Patch for #21330 - socket_select()

2003-01-02 Thread nicos 
Well it was attached it looks the mailing list is dening them.

It put it online: http://nicos.worldakt.com/socket_select.patch

Regards.
M.CHAILLAN Nicolas
[EMAIL PROTECTED]
www.WorldAKT.com Hébergement de sites internets.

- Original Message -
From: Derick Rethans [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Cc: Wez Furlong [EMAIL PROTECTED]; [EMAIL PROTECTED]
Sent: Thursday, January 02, 2003 1:21 PM
Subject: Re: [PHP-DEV] Patch for #21330 - socket_select()


 On Thu, 2 Jan 2003 [EMAIL PROTECTED] wrote:

  This is the patch that fix the issue of socket_select that doesn't wait
if
  value for timeval is 0.
 
  Tell me what you think.

 There is no patch

 Derick

 --

 -
  Derick Rethans http://derickrethans.nl/
  PHP Magazine - PHP Magazine for Professionals   http://php-mag.net/
 -



-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Patch for #21330 - socket_select()

2003-01-02 Thread Daniel Lorch 
hi,

 Well it was attached it looks the mailing list is dening them.

The mailinglist will only let you get through text/plain Attachements.

-daniel

-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Patch for #21330 - socket_select()

2003-01-02 Thread nicos 
Feel free to take a look at the URL then.

--
Regards.
M.CHAILLAN Nicolas
[EMAIL PROTECTED]
www.WorldAKT.com Hébergement de sites internets.

Daniel Lorch [EMAIL PROTECTED] a écrit dans le message de news:
[EMAIL PROTECTED]
 hi,

  Well it was attached it looks the mailing list is dening them.

 The mailinglist will only let you get through text/plain Attachements.

 -daniel



-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Patch for #21330 - socket_select()

2003-01-02 Thread Tularis 
[EMAIL PROTECTED] wrote:

Well it was attached it looks the mailing list is dening them.

It put it online: http://nicos.worldakt.com/socket_select.patch

Regards.
M.CHAILLAN Nicolas
[EMAIL PROTECTED]
www.WorldAKT.com Hébergement de sites internets.


I know this doesn't really belong here, but,
I always like to keep my code as small as possible, do I think you 
should change:

 if (sec != NULL || sec != 0) {
 convert_to_long_ex(sec);
 tv.tv_sec = Z_LVAL_P(sec);
 tv.tv_usec = usec;
 tv_p = tv;
 }
 else {
 tv.tv_sec = 0;
 tv.tv_usec = 0;
 tv_p = tv;
 }

to:

if (sec != NULL || sec != 0) {
   convert_to_long_ex(sec);
   tv.tv_sec = Z_LVAL_P(sec);
   tv.tv_usec = usec;
} else {
   tv.tv_sec = 0;
   tv.tv_usec = 0;
}
tv_p = tv;

But, as I said it's just a fashion statement, and nothing important... 
let stand that it will make *any* difference ;)


--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Patch for #21330 - socket_select()

2003-01-02 Thread Wez Furlong 
It's also broken as it will not allow for a null value to give an
infinite wait period.

--Wez.

On Thu, 2 Jan 2003, Tularis wrote:


 if (sec != NULL || sec != 0) {
 convert_to_long_ex(sec);
 tv.tv_sec = Z_LVAL_P(sec);
 tv.tv_usec = usec;
 } else {
 tv.tv_sec = 0;
 tv.tv_usec = 0;
 }
 tv_p = tv;

 But, as I said it's just a fashion statement, and nothing important...
 let stand that it will make *any* difference ;)


 --
 PHP Development Mailing List http://www.php.net/
 To unsubscribe, visit: http://www.php.net/unsub.php





-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php