Re: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-03 Thread Michael Mauch
Melvyn Sopacua <[EMAIL PROTECTED]> wrote: > At 19:02 1-11-2002, John Coggeshall wrote: > >>I haven't looked at the patch in great detail, can someone forward me >>The commitlog? > > It hasn't been committed yet, as we agreed that only persons in 'Authors' > should do that and agree, otherwise it'

Re: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread Shane Caraveo
This would make a simpler test, which would not need to rely on more advanced features like OO, which may change in their functionality once ZE2 comes around, as Marcus had pointed out. Since at this point we could have people running both ZE1 and ZE2 use the test, I think relying on OO is dang

RE: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread Derick Rethans
On Fri, 1 Nov 2002, John Coggeshall wrote: > > The only thing I see wrong, is perhaps that Shane and I are working on a > new run-tests script (see run-tests2.php) > > Since the script (at least the CLI class) basically works just as well > as the current run-tests.php (as far as I've seen t

Re: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread Derick Rethans
On Fri, 1 Nov 2002, Melvyn Sopacua wrote: > At 15:37 1-11-2002, Derick Rethans wrote: > > > > Any objections? > > > >We can't object if there is no attachment :) > > #*!$%', mt_rand(1,6), 1); $i++; } ?> Looks fine to me. Derick --

Re: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread Ilia A.
On November 1, 2002 01:08 pm, John Coggeshall wrote: > |What made you decide to go for the OO model of the run-tests > |script, there > |does not seem to be any advantage in adding this overhead (imho)? > > There is most definitely an advantage. Using the OO model, we > essentially created > A "tes

Re: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread Shane Caraveo
Ok - so unless Shane disagrees and gets physical, /me jumps around screaming after hiking up a large mountain carrying 2 40lb. boulders...physical enough? :) run-tests.php should be in 4.3 and will have a totally different code-base than the version for php 4.4/5.0. I don't expect we'll b

RE: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread Melvyn Sopacua
At 19:02 1-11-2002, John Coggeshall wrote: I haven't looked at the patch in great detail, can someone forward me The commitlog? It hasn't been committed yet, as we agreed that only persons in 'Authors' should do that and agree, otherwise it'll be a mess. |Yep. |So the real question is: how ca

RE: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread John Coggeshall
|What made you decide to go for the OO model of the run-tests |script, there |does not seem to be any advantage in adding this overhead (imho)? There is most definitely an advantage. Using the OO model, we essentially created A "test engine" which had some default output code (direct to stdout)

RE: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread John Coggeshall
|Ok - so unless Shane disagrees and gets physical, |run-tests.php should be in 4.3 and will have a totally |different code-base than the version for php 4.4/5.0. Exactly. |The features addressed in the patch, are IMO important though. I haven't looked at the patch in great detail, can someo

Re: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread Marcus Boerger
At 18:44 01.11.2002, Ilia A. wrote: On November 1, 2002 12:23 pm, John Coggeshall wrote: > Wait wait wait.. > > I think I've been misunderstood... I'm not talking about the version 4.3 > release, and yes we are working on the web edition of the test script.. > However, Shane (rightly so, IMHO) re-

Re: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread Ilia A.
On November 1, 2002 12:23 pm, John Coggeshall wrote: > Wait wait wait.. > > I think I've been misunderstood... I'm not talking about the version 4.3 > release, and yes we are working on the web edition of the test script.. > However, Shane (rightly so, IMHO) re-wrote run-tests (now run-tests2) > an

RE: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread Melvyn Sopacua
At 18:23 1-11-2002, John Coggeshall wrote: Wait wait wait.. sleep(3); I think I've been misunderstood... I'm not talking about the version 4.3 release, and yes we are working on the web edition of the test script.. However, Shane (rightly so, IMHO) re-wrote run-tests (now run-tests2) and made

RE: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread John Coggeshall
Original Message- |From: Melvyn Sopacua [mailto:msopacua@;php.net] |Sent: Friday, November 01, 2002 12:14 PM |To: [EMAIL PROTECTED] |Cc: 'Php Dev List' |Subject: RE: [PHP-DEV] Re: [PATCH] run-tests.php | | |Ouch, | |I really thought you we're working on 'run-tests2.php - the

RE: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread Melvyn Sopacua
oerger; Sander Roobol |Subject: [PHP-DEV] Re: [PATCH] run-tests.php | | |At 15:37 1-11-2002, Derick Rethans wrote: | |> > Any objections? |> |>We can't object if there is no attachment :) | |#*!$%', mt_rand(1,6), 1); |$i++; } ?> | | |With kind regards, | |Melvyn Sopac

[PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread Ilia A.
On November 1, 2002 10:05 am, Melvyn Sopacua wrote: > At 15:37 1-11-2002, Derick Rethans wrote: > > > Any objections? > > > >We can't object if there is no attachment :) > > #*!$%', mt_rand(1,6), 1); $i++; } ?> > > > With kind regards, > > Melvyn Sopacua > Looks fine to me, +1. Ilia -- PHP Dev

RE: [PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread John Coggeshall
h will end up disappearing :( All IMHO of course. John |-Original Message- |From: Melvyn Sopacua [mailto:msopacua@;php.net] |Sent: Friday, November 01, 2002 10:05 AM |To: Derick Rethans |Cc: Php Dev List; Ilia Alshanetsky; Preston L.Bannister; |Marcus Boerger; Sander Roobol |Subject: [P

[PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread Melvyn Sopacua
At 15:37 1-11-2002, Derick Rethans wrote: > Any objections? We can't object if there is no attachment :) #*!$%', mt_rand(1,6), 1); $i++; } ?> With kind regards, Melvyn Sopacua Index: run-tests.php === RCS file: /repository/php

[PHP-DEV] Re: [PATCH] run-tests.php

2002-11-01 Thread Derick Rethans
On Fri, 1 Nov 2002, Melvyn Sopacua wrote: > Hi, > > attached a patch: > 1) To get the right compiler version (see php-qa thread on this) > 2) Add option to save results, by Michael Mauch <[EMAIL PROTECTED]> > > Any objections? We can't object if there is no attachment :) Derick -- -